7481 Commits

Author SHA1 Message Date
Tor Lillqvist
9d29d3dad4 BOOST_SPIRIT_SINGLE_GRAMMAR_INSTANCE has been defined forever in these files
Change-Id: I0afa1b404192f44540aa318e748452e0328fac6b
2017-02-14 21:21:29 +02:00
Julien Nabet
8aff36d87f Various typos about property
Change-Id: I7585a1346fb19a886240db8dd393554efee862cc
Reviewed-on: https://gerrit.libreoffice.org/34174
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-12 16:06:46 +00:00
Stephan Bergmann
8646ab97dc Remove MinGW support
In OOo times, there'd originally been efforts to allow building on Windows with
MinGW.  Later, in LO times, this has been shifted to an attempt of cross-
compiling for Windows on Linux.  That attempt can be considered abandoned, and
the relevant code rotting.

Due to this heritage, there are now three kinds of MinGW-specific code in LO:

* Code from the original OOo native Windows effort that is no longer relevant
  for the LO cross-compilation effort, but has never been removed properly.

* Code from the original OOo native Windows effort that is re-purposed for the
  LO cross-compilation effort.

* Code that has been added specifially for the LO cross-compilation effort.

All three kinds of code are removed.

(An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing
--with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.)

Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568
Reviewed-on: https://gerrit.libreoffice.org/34127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-10 18:01:27 +00:00
Noel Grandin
7cf66202f2 convert SearchParam::SearchType to scoped enum
and drop unused SRCH_LEVDIST enumerator

Change-Id: Ic5118757060656562e04dd7da24a3f143abec3fb
Reviewed-on: https://gerrit.libreoffice.org/34065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-10 06:05:09 +00:00
Stephan Bergmann
3783df2027 rtl_str_shortenedCompare_WithLength -> OString::startsWith
Change-Id: I3eabdeba10d8d1064f00b817b04f03aad8a6b352
2017-02-08 10:14:20 +01:00
Takeshi Abe
f31d07b546 connectivity: Remove leftover OEvaluateSet
Change-Id: Ia8ecabb426c969a02174b399a479dfb337b36a79
Reviewed-on: https://gerrit.libreoffice.org/33983
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-07 08:47:11 +00:00
Stephan Bergmann
6dce9c6757 Add missing #includes
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06 17:21:16 +01:00
Noel Grandin
c9c3cb5446 loplugin:unusedenumconstants in connectivity..cui
Convert ExpressionFunct to scoped enum and drop FUNC_CONST value.
Convert MQueryExpressionBase::node_type to scoped enum and drop Unknown
value.
Dop PageType::Color value

Change-Id: Icb1f5503c230fb91329acc7d9e1da665fa28d95e
Reviewed-on: https://gerrit.libreoffice.org/33948
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 09:13:25 +00:00
Stephan Bergmann
916061041e Too dumb to sort
Change-Id: I0ba613bff040d07554dc41783aea332d0a597b3c
2017-02-02 19:44:32 +01:00
Noel Grandin
c0f9bdd3e6 unnecessary use of OUStringBuffer in throwing exceptions
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f
Reviewed-on: https://gerrit.libreoffice.org/33788
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02 07:48:21 +00:00
Stephan Bergmann
ebe83479b4 Missing includes
Change-Id: I287f166291a905c9f4d166bf07c09de93184bf87
2017-02-01 17:19:06 +01:00
Stephan Bergmann
3667820d94 loplugin:useuniqueptr
Change-Id: Iffab8e3d8ecaad835d5f0cce68ede4eaea1547a4
2017-02-01 16:33:02 +01:00
Stephan Bergmann
87087bab94 loplugin:stringconstant
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
2017-02-01 16:00:41 +01:00
Stephan Bergmann
49c8235944 loplugin:unnecessaryoverride
Change-Id: I53699ef386dad99b38559defe985057492a5df76
2017-02-01 15:59:34 +01:00
Jochen Nitschke
8bf9bb1290 -Wunused-macros
Change-Id: I2d3b6f22deee0f2b9ec39592b89e0e4742659593
Reviewed-on: https://gerrit.libreoffice.org/33782
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jenkins <ci@libreoffice.org>
2017-02-01 12:03:36 +00:00
Noel Grandin
1c3e84d819 teach lolugin:stringconstant about calling constructors
so we can remove unnecessary calls to the OUString(literal) constructor
when calling constructors like this:
   Foo(OUString("xxx"), 1)

Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36
Reviewed-on: https://gerrit.libreoffice.org/33698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31 08:56:20 +00:00
Caolán McNamara
b87df03423 ditch fixed length buffer
Change-Id: I06bbe4ee92ebeb7d1bc305d5a7da9ee9a4fa0cb8
Reviewed-on: https://gerrit.libreoffice.org/33706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-30 16:45:42 +00:00
Tamás Bunth
4a193d39fb tdf#105101 check scale to determine subtype
For computed decimal/numeric values firebird's subtype remains 0. In
this case we check for the scale of column. If it is not 0 (negative),
than imply numeric.

Change-Id: Ie5a023d165852fe402b3b4cac817b0bbef58e7cd
Reviewed-on: https://gerrit.libreoffice.org/33660
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-01-30 14:57:40 +00:00
Tamás Bunth
1db4233388 tdf#105142 set default charset to UTF8
Change-Id: I47dd18a141949f94903297f6e011e7956587b400
Reviewed-on: https://gerrit.libreoffice.org/33663
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-30 14:50:32 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Takeshi Abe
6d898945d5 Fix typo in comments: relativ -> relative
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09
Reviewed-on: https://gerrit.libreoffice.org/33488
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-25 06:05:54 +00:00
Noel Grandin
a90a4810ae loplugin: unnecessary destructor: comphelper..desktop
Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e
Reviewed-on: https://gerrit.libreoffice.org/33453
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23 16:59:48 +00:00
Stephan Bergmann
7e5c140dd9 loplugin:useuniqueptr
Change-Id: Ia0c8c3bb8319b5719bf63a3408d404d9adc681cc
2017-01-23 11:39:49 +01:00
Noel Grandin
b395d9fd82 use rtl::Reference in OResultSet
instead of manual acquire/release

Change-Id: I8baa2e7ac64445ea69d4b62566a89b6e42307e51
2017-01-23 07:56:34 +02:00
Stephan Bergmann
0494fc3f91 loplugin:dynexcspec (macOS), connectivity
Change-Id: Ic8cd364cd27f7f7669ac8d5553fc3974b5f8c992
2017-01-20 13:00:06 +01:00
Stephan Bergmann
c6f6d0b721 loplugin:dynexcspec (clang-cl), connectivity
Change-Id: Ia49a11d4f707764640ea497d877d1699183ca56e
2017-01-20 11:53:28 +01:00
Stephan Bergmann
5b2b75ac26 New loplugin:dynexcspec: Add @throws documentation, connectivity
Change-Id: Id8711eaeac65efaa228b60d5786169016bfb61a3
2017-01-19 18:03:24 +01:00
Caolán McNamara
6abcf8b289 no special support for MACOSX PPC in master for a while now
Change-Id: I8d5dc878f41939e55ef8995d1da74548faa4711f
2017-01-17 16:19:11 +00:00
Noel Grandin
d9884a62a2 new loplugin: useuniqueptr: connectivity
Change-Id: I016f6a62814f1e93373dc70f59893fa38361464b
Reviewed-on: https://gerrit.libreoffice.org/33149
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17 06:34:31 +00:00
Caolán McNamara
fffb674c1e coverity#1371289 avoid the need for an assignment
Change-Id: I7f9b8d21652c79642f9a2f916ad0609c8abd430b
2017-01-14 20:27:33 +00:00
Stephan Bergmann
1c3385fa27 loplugin:refcounting
Change-Id: Ied9ecabb3cb6b5d629ec72db164df452d8ca114a
2017-01-14 16:19:14 +01:00
Tamás Bunth
882db8709f tdf#70433 tdf#104734 implement sdbc XClob
And use it in getClob, so LO can display clob values like the return
value of the built-in List function.

Change-Id: I395016e945dbeb2c6bb3737b6345d40ff9f48089
Reviewed-on: https://gerrit.libreoffice.org/32938
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-01-14 12:13:32 +00:00
Caolán McNamara
6bd96eda06 coverity#1371289 avoid the need for an assignment
Change-Id: Ia0efc427d9996eb8414821d07f7e760fb1b35246
2017-01-13 13:46:12 +00:00
Lionel Elie Mamane
afe64b6f0a jdbc clob character stream: return 1 when returning a single odd byte
if at that point nBytesToRead is 0, it may be that it was 1, but we
have read one byte from the buffer (m_buf). So in this case, return 1,
not 0 (which would signal EOF).

Change-Id: I229e53f1c38c80f709df244a3509caccd69c8ecf
Reviewed-on: https://gerrit.libreoffice.org/33029
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-13 10:12:13 +00:00
Tamás Bunth
38ce989b4f XBlob::getBytes expects 1-indexed position
There was also a wrong relation. Now blob resets its position.

Change-Id: I41caf7cdfa261cafa5b9e66c9523c7f15225bfd8
Reviewed-on: https://gerrit.libreoffice.org/32937
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-11 17:48:01 +00:00
Stephan Bergmann
f50fa59583 loplugin:externvar (clang-cl)
Change-Id: Ibbcb8b6dfaf1c979db2e7930c4f6c8475d693ac8
2017-01-11 13:42:39 +01:00
Stephan Bergmann
f28939b9f9 Some loplugin:conststringvar/stringconstant improvements: connectivity
Change-Id: I8b026b61b8744e21584bc64d80a957aca08aae2b
2017-01-11 11:27:22 +01:00
Jochen Nitschke
48c100d730 remove unused typedefs
Change-Id: I99c44caabca3d799c783d57cd2c3a1692c899191
Reviewed-on: https://gerrit.libreoffice.org/32911
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10 08:52:14 +00:00
Stephan Bergmann
4e1d035731 New loplugin:conststringvar: connectivity
Change-Id: I2c38bc842ee07d27a5a2ff084e8a608a858f4faa
2017-01-10 08:12:16 +01:00
Stephan Bergmann
3a639ccf74 New loplugin:externvar: connectivity
Change-Id: I7e62a92ee4b019163de797fd4448170a741879dc
2017-01-09 15:44:10 +01:00
Caolán McNamara
9a30cb2161 hack to silence -Wunused-function
Change-Id: I585839c05ca3b0336ffbe2c60a2f58c34b0aae78
2017-01-09 11:21:12 +00:00
Stephan Bergmann
b397c4b8cb bSilent is unused
...ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import"

Change-Id: Iccee867aa9722ced2f66d4d8b8911c5e191502c2
2017-01-06 12:34:15 +01:00
Stephan Bergmann
c38aa3b734 loplugin:salbool
Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
2017-01-06 11:19:42 +01:00
Stephan Bergmann
c2b24cd6fb Use string literals directly
Change-Id: Ia4ae5c01ae7eb976a0e9638f8bc8fe7ebab8e2cb
2017-01-06 10:53:34 +01:00
Stephan Bergmann
21033d04fd Clean up a usage of OUStringBuffer
Change-Id: I8435865f1a67a3a6d889c1b8a3d30e632ffc61fd
2017-01-05 14:24:28 +01:00
Stephan Bergmann
c03d803a72 Replace side-effect--only uses of makeStringAndClear() with setLength(0)
Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
2017-01-05 13:52:17 +01:00
Stephan Bergmann
9389f7bc1c Fix loplugin warnings in sqlflex.l
(Normally hidden by T_LEXFLAGS containing -L in connectivity/Library_dbtools.mk
suppressing #line directives; some loplugin:literaltoboolconversion warning
would remain in a flex-provided occurrence of ECHO that is apparently not
properly prefixed by #line at least with flex 2.6.0.)

Change-Id: Id5693d6bd9e5b565dd9820e3cbea8e88e7967dd5
2017-01-04 16:26:46 +01:00
Stephan Bergmann
30dd4ac3a8 Fix loplugin warnings in sqlbison.y
(Normally hidden by T_YACCFLAGS containing -l in connectivity/Library_dbtools.mk
suppressing #line directives; some loplugin:cstylecast would remain in bison-
provided expansions of $1 etc. variables.)

Change-Id: Ic93bea0b2fe0ec5f741c4bc41f25cc72fec0498f
2017-01-04 16:18:13 +01:00
Jochen Nitschke
a29bd2dabb cleanup tailing backslashes
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2
Reviewed-on: https://gerrit.libreoffice.org/32491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-30 18:48:24 +00:00
Damjan Jovanovic
1307212b87 Fix some comment typos.
Patch by: me

(cherry picked from commit 7ac035b2ddf9275085c30d1048bec7da160158f0)

Change-Id: Ic5fa1abe69fbf5f656e79fcd5e17ea5f84208ae6
2016-12-24 15:37:19 +00:00