mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
403,714 Commits 1 Branch 0 Tags
Commit Graph

7481 Commits

Author SHA1 Message Date
Julien Nabet
dbc3cfb011 tdf#104858: fix typo 
Thank you to himajin100000@gmail.com for having noticed this.

Change-Id: I81da0d4fc91faf95f4f5257d5834a9fdfd2618f7
Reviewed-on: https://gerrit.libreoffice.org/32378
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2016-12-23 10:15:44 +00:00
Wastack
ef1aee0f80 tdf#70506 implement getColumnLabel function 
which is responsible for aliasnames defined with the SQL 'AS' keyword.

Change-Id: I6aaf1ba6969e2bd738941e41492338382168bc89
Reviewed-on: https://gerrit.libreoffice.org/32042
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2016-12-20 18:18:03 +00:00
Stephan Bergmann
83d2c5180d Adapt to no-longer explicit OUStringLiteral ctor 
...from previous commit

Change-Id: I062b7cd212c17e7eb5274476e6859228d0477c7f
Reviewed-on: https://gerrit.libreoffice.org/32098
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-12-17 16:12:02 +00:00
Noel Grandin
d15b4e2045 teach sallogareas plugin to catch inconsistencies 
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-15 06:45:14 +00:00
Stephan Bergmann
de7922ad57 -Werror,-Wunused-macros 
Change-Id: Idc81dd30502a1968f2f65386575cac1e029f8c64
 2016-12-13 11:06:02 +01:00
Stephan Bergmann
cb92af91da loplugin:sallogareas 
Change-Id: I25f793d88a87d94925026fc3de97d02086a0c855
 2016-12-13 09:17:42 +01:00
Noel Grandin
c3586b684c OSL_TRACE->SAL in chart2..oox 
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-13 06:12:00 +00:00
Stephan Bergmann
385f624027 Prevent use of ORowSetValue with sal_Bool as TINYINT 
sal_Bool and sal_uInt8 are typedefs for the same underlying type, so any use of
ORowSetValue with sal_Bool instead of bool, apparently intending to treat the
value as a boolean, actually treated it as a TINYINT.  (See e.g. recent
7b0c57b2faec875c790051d233d1e9abaed2a3bc "some compilers don't like implicit
bool-to-ORowSetValue conversion".)

Now that there's no way to create a sal_uInt8 ORowSetValue, getUInt8 and the
m_uInt8 union member can probably go away, too.

Change-Id: Ia27554f76e7e9edce6410284b578064573e54fd3
Reviewed-on: https://gerrit.libreoffice.org/31909
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-12-12 18:02:57 +00:00
Lionel Elie Mamane
7b0c57b2fa some compilers don't like implicit bool-to-ORowSetValue conversion 
Change-Id: Ic4463db8aeca6ae9a86f7b890f95eb73724c6a1b
 2016-12-12 07:49:46 +01:00
Wastack
1d0f3649ba tdf#103074 Implement Boolean Type for FB driver 
Change-Id: Ibed5435e23730dc901155e79152e9becd3e70566
Reviewed-on: https://gerrit.libreoffice.org/31262
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
 2016-12-11 10:43:22 +00:00
Wastack
ea61a62323 tdf#104227 query boolean like infos correctly 
Change-Id: Ic862bb1ce3efa61d6a01fc56fb9e84cf98bb7cd0
Reviewed-on: https://gerrit.libreoffice.org/31355
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
 2016-12-11 10:40:57 +00:00
Jochen Nitschke
0c6c37cb01 cleanup unused includes (related to tdf#88206) 
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx

compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only
implbase*.hxx stuff is used.

Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995
Reviewed-on: https://gerrit.libreoffice.org/31686
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-06 18:17:06 +00:00
Noel Grandin
50151db9f7 convert FSysStyle to o3tl::typed_flags 
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
 2016-12-05 12:49:02 +02:00
Noel Grandin
bfde4866e0 convert DecodeMechanism to scoped enum 
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
 2016-12-05 12:49:02 +02:00
Noel Grandin
803215142e convert INetURLObject::EncodeMechanism to scoped enum 
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
 2016-12-05 12:49:02 +02:00
Julien Nabet
8d2f58a992 tdf#104227: fix subtypes DECIMAL/NUMERIC in resultset 
bt here:
https://bug-attachments.documentfoundation.org/attachment.cgi?id=129298

See also https://bugs.documentfoundation.org/show_bug.cgi?id=104227#c13 for more details

Change-Id: Ied497cfff2f71e67161d541b90fe48bb3e2456b9
Reviewed-on: https://gerrit.libreoffice.org/31593
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-12-04 18:22:24 +00:00
Noel Grandin
036603d72f convert nowParsing_ constants to scoped enum 
Change-Id: I8df9ca0e9317a4d969f492699be926044415f68c
Reviewed-on: https://gerrit.libreoffice.org/31483
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-12-01 21:51:41 +00:00
Stephan Bergmann
7222ffb79c Rewrite some (trivial) assignments inside if/while conditions: connectivity 
Change-Id: I67d4bb92db04b5103b98a2855ae6069a054f171b
 2016-11-29 17:21:33 +01:00
Stephan Bergmann
507f1a34a7 loplugin:unnecessaryoverride (dtors) in connectivity 
Change-Id: Icba385b3b7f6991f4dab7b2fd57beab5ac184df0
 2016-11-28 14:14:35 +01:00
Jan-Marek Glogowski
c3da6e3844 KAB loplugin:datamembershadow 
Change-Id: I1962ab1d131cf714f8bd540b589e793c4389cfb2
 2016-11-25 16:27:07 +01:00
Caolán McNamara
e190825b73 coverity#1371267 Missing move assignment operator 
Change-Id: Iefcfd20ac17f24f4fc3faec72b15de6bfb42eeac
 2016-11-24 12:01:57 +00:00
Caolán McNamara
8ceb8b2d14 Related: coverity#1371267 copy ctor broken, nPagePos not copied 
initially operator= was removed by

commit a0a919d2b541c415ad9b81d2ee91895bf106e9bb
Date:   Fri Oct 3 10:39:28 2014 +0200

    remove SvRefBase::QueryDelete

and then operator= was restored by

commit faa6455995966e41653204779d055b885b27fc4c
Date:   Fri Oct 10 12:02:32 2014 +0200

    add copy constructor for ONDXPagePtr class

    which I forgot in commit a0a919d2b541c415ad9b81d2ee91895bf106e9bb
    "remove SvRefBase::QueryDelete"

but nPagePos was missed

Change-Id: I6497934d4a199f5ea94cf2da840c164910e7a826
 2016-11-24 11:51:55 +00:00
Stephan Bergmann
f70ae430a0 OPreparedStatement::m_aTypeInfo is unused 
Change-Id: I89a43b06a9983e2fac374298db2fef17f3671ab5
 2016-11-22 17:40:18 +01:00
Stephan Bergmann
3ec6de78f6 loplugin:datamembershadow 
Change-Id: I773bb19ae33709421fde01426716dcf52065402f
 2016-11-21 22:15:49 +01:00
Stephan Bergmann
8442bda2ca loplugin:datamembershadow 
shadowed OCatalog::m_xMetaData can be used here directly

Change-Id: I1041272b98139fda2413442e4621507655ab67ca
 2016-11-21 22:14:25 +01:00
Wastack
3ec084d61e get table name from resultset simply 
There is a much simpler way to access table name in ResultSetMetadata
in Firebird sdbc which I didn't notice before.

Change-Id: Ib306c04acf38ec86475d8d1a22a67012fe48539e
Reviewed-on: https://gerrit.libreoffice.org/30931
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
 2016-11-21 17:10:52 +00:00
Wastack
a2686cc717 tdf#74172 ensure prepared while setting numeric 
Change-Id: I727a0af5c3aa1b2e1f6c251b2dcb32feb46041d6
Reviewed-on: https://gerrit.libreoffice.org/30933
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
 2016-11-21 16:54:25 +00:00
Michael Stahl
e2f08f9def connectivity, sc: add missing #include <osl/endian.h> 
These files use the macro OSL_BIGENDIAN but did not include the header
that defines it.

Found via:

git grep -l OSL_.*ENDIAN | grep -v -E '\.h(xx)?$' | while read f; do case $f in *cxx) grep -L endian\\.h workdir/Dep/CxxObject/${f%.cxx}.d ;; *) grep -L endian\\.h workdir/Dep/CObject/${f%.c}.d ;; esac ; done

Change-Id: Iaf589a8235dbc8062840d2716ab843e64b5cb7a2
 2016-11-21 12:47:51 +01:00
Stephan Bergmann
d015317f36 loplugin:datamembershadow 
shadowed OCatalog::m_xMetaData can be used here directly

Change-Id: I5d4436e1aa6f8f74ef6f9af816625044492cbf58
 2016-11-21 09:34:40 +01:00
Noel Grandin
b495eb4dba loplugin:datamembershadow 
Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9
Reviewed-on: https://gerrit.libreoffice.org/30948
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-18 12:11:33 +00:00
Caolán McNamara
97e61ba58c sync ONDXPagePtr impl with current SvRef impl 
Change-Id: I85e62a8c634a681e2e53745e3bed52731e8740e0
 2016-11-18 11:49:15 +00:00
Caolán McNamara
c5c8790122 this is copied from SvRefBase, so copy the clang opt fix here too 
Change-Id: Ia3a2f086d66b5e15ddd4e7dcc600271d19e5d052
 2016-11-18 11:12:50 +00:00
Noel Grandin
0a840edcc1 includes should be at the top of the file 
not randomly scattered through the code

found with something like:
   git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include"

Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351
Reviewed-on: https://gerrit.libreoffice.org/30952
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-18 09:25:06 +00:00
Noel Grandin
7cca2c7fb3 new loplugin finalprotected 
look for final classes, and make sure they don't have protected members

Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4
Reviewed-on: https://gerrit.libreoffice.org/30895
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-16 09:10:16 +00:00
Caolán McNamara
21005d0ded fix build of kde3 addressbook 
Change-Id: I109f6ff9ca35792d3337bac2a6612ba12d2272fd
 2016-11-15 16:34:51 +00:00
Noel Grandin
7ab84fab53 fix build 
after commit 0d051730156f633150fa9e3107fe97cf7be6d8f9
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Tue Nov 15 09:13:33 2016 +0200
    loplugin:constantparam

Change-Id: Ia3e761168043e5a8d22793689e9f224a85a6b7ca
 2016-11-15 15:41:23 +02:00
Noel Grandin
0d05173015 loplugin:constantparam 
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0
Reviewed-on: https://gerrit.libreoffice.org/30858
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-15 12:56:26 +00:00
Stephan Bergmann
1e70553585 Make ~OCode an anchor again for vtable and RTTI emission 
...had been lost with dd5fa4cea7b0c6912754e6887a678a050d4a7610 "declare default
dtor as virtual"

Change-Id: I30acd02c293a5ecc99f5bf4f6b1f6358ae392e93
 2016-11-14 15:29:12 +01:00
Caolán McNamara
6b35488c72 coverity#1371279 Missing move assignment operator 
Change-Id: Ic1c1017184bff54360b0ea3b6f57e53d61cbe1d5
 2016-11-14 08:53:11 +00:00
Caolán McNamara
1ef8ab3ed7 coverity#1394295 Unchecked return value 
Change-Id: Ie4edbe91ab4f9b9910fc895e47ea8b9fdfc00b7e
 2016-11-12 12:23:08 +00:00
Caolán McNamara
c0081fe0f4 coverity#1371239 Missing move assignment operator 
but if _MSC_VER need >= 2015

Change-Id: I730319702ddc589c4fc1d72b20fd200eacfa53e4
Reviewed-on: https://gerrit.libreoffice.org/30785
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-11-12 12:15:27 +00:00
Julien Nabet
a2c6112a47 Related tdf#70433: Use subtype to distinguish BLOB/CLOB for Firebird 
See http://www.firebirdfaq.org/faq48/

Change-Id: If233919daeb02b67d0b3bc42547fbd3030864c37
Reviewed-on: https://gerrit.libreoffice.org/30789
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2016-11-12 09:15:49 +00:00
Julien Nabet
ba8a41bac3 tdf#71251: VARCHAR max length is 32765 for Firebird 
At least for Firebird 2.5 (see http://www.firebirdsql.org/en/firebird-technical-specifications/)
Let's put the same for CHAR

Change-Id: I4ab232689093b0418a7c1a9751685f41f2dabbf7
Reviewed-on: https://gerrit.libreoffice.org/30783
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2016-11-11 21:54:50 +00:00
Caolán McNamara
fe7671f144 Revert "coverity#1371239 Missing move assignment operator" 
This reverts commit 8909cbeb315e257fbe06dad6caee5db18879b916.
 2016-11-11 20:44:14 +00:00
Caolán McNamara
8909cbeb31 coverity#1371239 Missing move assignment operator 
Change-Id: Ie5cddac8b4b0c8eefee82a14c845982600df0455
 2016-11-11 17:03:11 +00:00
Stephan Bergmann
25edea0637 loplugin:staticmethods 
Change-Id: Id7d7bb572466bcc803ac424cd8ddb64205a1c273
 2016-11-10 11:50:02 +01:00
Stephan Bergmann
be8d620464 loplugin:stringconstant 
Change-Id: I0eb2b9986840b1bd5bc892da23c56205047bc120
 2016-11-10 11:48:04 +01:00
Stephan Bergmann
14544da21e loplugin:cstylecast 
Change-Id: I6ec274c6c546f60c23fe639002d751f0a9f11d33
 2016-11-10 11:38:27 +01:00
Wastack
21cc1826c7 WiP tdf#74172 use DECIMAL and NUMERIC data types 
Change-Id: I917cdf6e8d3ebfa7c9e4a52ca61adc5b8707ecfc
Reviewed-on: https://gerrit.libreoffice.org/30447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
 2016-11-10 09:37:12 +00:00
Noel Grandin
5c2c2d8dc4 loplugin:expandablemethods in comphelper..cppuhelper 
Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d
Reviewed-on: https://gerrit.libreoffice.org/30717
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-10 06:51:53 +00:00