3868 Commits

Author SHA1 Message Date
Khaled Hosny
930a3d462b tdf#33278: Enable UI for vertical left-to-right
Used mainly for traditional Mongolian. This has been disable since 2010
(shortly after the code was merged):

commit faf68cc7565cb2662d4ed5b5902ec52975d99865
Author: Mathias Bauer <mba@openoffice.org>
Date:   Fri Jun 25 11:10:43 2010 +0200

    CWS mongolianlayout: disable new direction until problems are fixed

No idea what the problems are, but lets enable it and see what happens
(the actual layout code have been enabled all the time and one can
always manually craft ODT files that use it anyway).

Change-Id: Id38d1735013d451f9fe116876483df3484dec051
Reviewed-on: https://gerrit.libreoffice.org/30364
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-29 13:18:57 +00:00
Justin Luth
c0baab9aa8 reset border should clear all borders
If no borders were originally defined, the reset button was failing
to clear the last-selected border line.

Eg. page border, click on two of the borders, then hit reset. One border
remains defined, and didn't reset to the starting value of non-visible.
Because one border was still "selected", it became visible again as
SelStyleHdl_Impl reinitialized.

Change-Id: I2d20ae1e02816d5b30fe126572b54e7083114fc3
Reviewed-on: https://gerrit.libreoffice.org/30365
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-10-28 18:58:49 +00:00
Caolán McNamara
117fc49c97 ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivatives
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2
Reviewed-on: https://gerrit.libreoffice.org/30344
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-28 09:08:50 +00:00
Noel Grandin
09cb920969 convert std::unique_ptr<VclAbstractDialog> to VclPtr
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-28 09:12:27 +02:00
Maxim Monastirsky
89c23b4aae Sub menus no longer need manual disposing
after:

commit ee79a2dd7ea60e902cab3a9203e307b8a78fee23
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Fri Jul 29 14:33:22 2016 +0100

    Resolves: tdf#101169 crash using column menu in base

Change-Id: I7c6e54dd5574c61cffd5884d1cf1b63075073001
Reviewed-on: https://gerrit.libreoffice.org/30343
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-27 22:11:07 +00:00
Muhammet Kara
0c2272786b tdf#103464 Don't allow empty names in SvxNameDialog
Menus, context menus, toolbars, toolbar items...
could be created with empty names, and could be
renamed to have empty names before this patch.

Change-Id: Ic383f16955746002aa3ad69406bac855cdd58d2d
Reviewed-on: https://gerrit.libreoffice.org/30286
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-27 09:25:59 +00:00
Noel Grandin
eca5ea9f79 make the AbstractDialog stuff extend from VclReferenceBase
Because some stuff wants to multiple-inherit from VclAbstractDialog and
OutputDevice-subclasses, and we'd prefer to keep all the lifetime
management through a single smart pointer class (VclPtr)

The change in msgbox.cxx and window.cxx is to workaround a bug in
VS2013 to do with virtual inheritance and delegating constructors.

Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773
Reviewed-on: https://gerrit.libreoffice.org/29140
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27 06:08:30 +00:00
Muhammet Kara
cd7b306e61 tdf#103160 Add 'Add Submenu' button in Customize dialog
And remove the 'Add Submenu' entry from Modify split button
in Customize dialog

Change-Id: I6ac940f5f1f41ac1f962f66f458c7e14d702b2be
Reviewed-on: https://gerrit.libreoffice.org/30230
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2016-10-25 13:15:16 +00:00
Katarina Behrens
fab262f115 screenshot annotation: More readable markup
this should placate clang too

Change-Id: Ida2cceebd5870b5896fb125e51e4cb67ad253d92
2016-10-25 11:26:49 +02:00
Katarina Behrens
ae3fb69ebc screenshot annotation: put back removed fields
I hate you loplugin !!!

Change-Id: I01067b04005a59b7ecb10a5a72ab6090b7f040a8
2016-10-25 11:26:49 +02:00
Katarina Behrens
dbecfbdde5 screenshot annotation: Make this a default button
Change-Id: I1a1db338696cf56062306a54a43c746a21a3431d
2016-10-25 11:26:48 +02:00
Katarina Behrens
dcbfb99fc5 screenshot annotation: insert markup for annotated widgets
Change-Id: I82b8c541239271e3acfa6d8ad45b752fa1554931
2016-10-25 11:26:48 +02:00
Katarina Behrens
3298e8b8ec screenshot annotation: Display markup for embedding the image
Change-Id: I06fd744fabd66ee02123790718a899d9e0dcb6b7
2016-10-25 11:26:48 +02:00
Katarina Behrens
b43888e73c screenshot annotation: tweak dialog a bit
Add some descriptive labels
Remove OK button (redundant in this context, Save Screenshot... does
the job)

Change-Id: I36e32986f777675f297390b691f2cd1681a0eaa2
2016-10-25 11:26:47 +02:00
Yousuf Philips
ac374ebf05 tdf#103223 custom palette label and a11y improvements
In the color section of the Area fill tab, i've added a custom palette
label above the add and delete buttons, moved the palette label and
control on the same line and improved the accessibility of various
controls by adding tooltips and associating labels.

Change-Id: I4a8c9963fd23312190ba343dbb1a0db587b13d1e
Reviewed-on: https://gerrit.libreoffice.org/29894
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-21 10:28:24 +00:00
Samuel Mehrbrodt
f0006e79c4 Handle link click directly in FixedHyperlink
Change-Id: I5b5f0648b6e6432b0928351a17d285df8c9da811
2016-10-20 12:48:43 +02:00
Noel Grandin
dcb1fbef20 loplugin:expandablemethodds in cui
Change-Id: I7b2321d45171f9b73965efea32832a3789f0dee7
Reviewed-on: https://gerrit.libreoffice.org/30011
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19 06:26:00 +00:00
Caolán McNamara
0a7d06cfc3 make area tab page of paragraph properties not crash
cause the parent dialog isn't a SvxAreaTabDialog

Change-Id: I1a1311ca4b414c797d4b3e72208e64bffea863ca
2016-10-18 18:57:33 +01:00
Samuel Mehrbrodt
d1f4b84faa Drop 'Human' icon theme
Was used in Ubuntu formerly, but they now switched to breeze.

Human is mostly similiar to Tango, with some Ubuntu colors.
So it should be enough to keep Tango.

Change-Id: Ib44cbefb2953406c95dbb269ada663bce2503234
Reviewed-on: https://gerrit.libreoffice.org/29537
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-18 12:52:05 +00:00
Jacek Fraczek
398d641664 tdf#89307: Removed T* SvRef::opeartor &()
Usage has been replaced with SvRef::get() or removed where applicable.

Change-Id: I49f108910b668466134c40940b53fc3ab2acd816
Reviewed-on: https://gerrit.libreoffice.org/29780
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-18 09:27:56 +00:00
Noel Grandin
292560a957 loplugin:unusedmethods
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4
Reviewed-on: https://gerrit.libreoffice.org/29968
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18 06:15:55 +00:00
Yousuf Philips
c33f0e0c85 tdf#103223 Arrange buttons, add spacing and separator to Area tab
Change-Id: I6aa6c1a43ac3f3ab468c28dbc298d60646c7dadb
Reviewed-on: https://gerrit.libreoffice.org/29892
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-15 02:21:59 +00:00
Caolán McNamara
797bb29eac coverity#1373664 Uninitialized scalar field
Change-Id: I011810bb7f40b27f940dafaf4454f9e3ab4fd804
2016-10-14 09:00:26 +01:00
Caolán McNamara
6db89521e2 flaten array of stringarrays by a level
Change-Id: I44dfe258f2220c5063b1177b67dbef71608ecef8
2016-10-13 10:36:01 +01:00
Noel Grandin
8fce16fb57 convert SvxPageUsage to scoped enum
and expand out the bit-tricks some of the code was playing to make it
more obvious what is going on

Change-Id: I9c98334393b939b1d900425f6133556ce88247ae
Reviewed-on: https://gerrit.libreoffice.org/29734
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13 06:54:23 +00:00
Katarina Behrens
2ee2757f15 Avoid one more crash on switching to pattern tab
this one happens when selecting Format > Area with no shape selection
or in Draw's page properties dialog

Change-Id: I20c94d4ac0c0ad20a4ac3f28275d1ca7f9ccdeb9
Reviewed-on: https://gerrit.libreoffice.org/29726
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12 14:29:23 +00:00
Katarina Behrens
6b44a8186d Enlarge tabpage size so that even colour tab fits in
Change-Id: Ic768000d6710b14d117a3480a13c39efe9e330ea
Reviewed-on: https://gerrit.libreoffice.org/29725
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12 10:25:38 +00:00
Federico Bassini
a4df89e0fa tdf#101442 "hyperlink" to "link" - other words change
Changes to be committed:
	modified:   cui/uiconfig/ui/securityoptionsdialog.ui
	modified:   sw/uiconfig/swriter/ui/tocentriespage.ui

Change-Id: Ie46281b4c15dad634bab870fbe50c749165a001d
Reviewed-on: https://gerrit.libreoffice.org/29727
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-12 09:17:36 +00:00
Stephan Bergmann
7034589b10 -Werror,-Wunused-private-field, again
Change-Id: I1f1ab1e3fd1360111a48d68effd254277e220843
2016-10-12 11:13:59 +02:00
Katarina Behrens
0d93900801 Avoid crash on switching to pattern tab
Change-Id: I8edeb1a92c20c88160109a904cdcec355a5ef998
Reviewed-on: https://gerrit.libreoffice.org/29599
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12 08:41:14 +00:00
Rishabh Kumar
d19ec9a9bd [GSoC] Remove fill style tabs from area fill dialog
Change-Id: I7409118cbbab1350dda169d5bdfef51b7354de9f
Reviewed-on: https://gerrit.libreoffice.org/27864
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12 08:38:42 +00:00
Rishabh Kumar
686349476e [GSoC] Move all fill style tabs inside area tab
Change-Id: I89e84b7b3c7075ad4107e7bc444ea5c07bc90795
Reviewed-on: https://gerrit.libreoffice.org/27866
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12 08:36:13 +00:00
Noel Grandin
a9717054dc loplugin:unnecessaryoverride in connectivity/cui
Change-Id: I5ec4eb2f74036e42851333e3d669dbea58c2490a
Reviewed-on: https://gerrit.libreoffice.org/29687
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12 06:31:56 +00:00
Noel Grandin
5c84f40ea2 loplugin:constantfunction
update the plugin similarly to
    commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970
    Author: Stephan Bergmann <sbergman@redhat.com>
    Date:   Fri Oct 7 12:05:49 2016 +0200
    loplugin:staticmethods: Don't be fooled by decls starting with macros

Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510
Reviewed-on: https://gerrit.libreoffice.org/29665
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11 06:15:21 +00:00
Federico Bassini
06dec56d96 tdf#101442 Change "hyperlink" to "link" for a modern vocabulary
Change-Id: Ib1c067b6d45e959d6cd0fbf00cab167939554203
Reviewed-on: https://gerrit.libreoffice.org/29572
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-10 08:38:04 +00:00
Caolán McNamara
6e57881e99 I can't see any evidence of any remaining magenta mask using image resources
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-06 15:09:22 +01:00
Caolán McNamara
04ba40c749 ImageList just reads and discards the MaskColor, so drop it
Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
2016-10-06 13:29:39 +01:00
Caolán McNamara
ae13786616 these other IMAGE_STDBTN_COLOR defines do nothing
Change-Id: If35bd52f973dc89b05afd283a4a89998c491b862
2016-10-06 09:06:20 +01:00
Caolán McNamara
306add13e1 convert the last two lonely FixedInfos to FixedText
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05 16:02:59 +01:00
Noel Grandin
954f752cf1 convert MapUnit to scoped enum
I left a prefix on the names "Map" so that I would not have to re-arrange
each name too much, since I can't start identifiers with digits like "100thMM"

And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore.

Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224
Reviewed-on: https://gerrit.libreoffice.org/29096
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05 06:51:20 +00:00
Stephan Bergmann
106ea87205 Remove _TYPED suffix from tools/link.hxx macros
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-05 07:56:12 +02:00
Noel Grandin
f6a258948a remove bogus include checks
Change-Id: Ia76f000ed10852dadc4ca0270b925efd6d8cd0b7
Reviewed-on: https://gerrit.libreoffice.org/29518
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-04 10:41:20 +00:00
Caolán McNamara
d2e69a61a3 Resolves: tdf#101953 controls become wider/smaller switching to/from graphics
Change-Id: I20a82d1ff2f3a11b0f327eecc90a2bb30bd4df3d
2016-10-03 21:24:22 +01:00
Andrea Gelmini
943919692e Fix typos
Change-Id: I8374d6d08f4eb4ae2821e213371c615b92d7e9ab
Reviewed-on: https://gerrit.libreoffice.org/29432
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01 19:02:02 +00:00
Adolfo Jayme Barrientos
89a3f82555 tdf#102235 Tweak terms to avoid misunderstandings
Change-Id: I8dc57d894c00090d04b2baef986a64813affb954
2016-09-29 18:18:12 -05:00
Laurent Balland-Poirier
80942ca029 tdf#102235 Replace Hindi with Indic and add some sample digits
Tools > Options > Language settings > Complex Text Layout > Numerals:
Choosing "Hindi" (eastern arabic) numerals is quite confusing
for Hindi language which use Devanagari numerals.
I propose to recall it "Indic"
See https://en.wikipedia.org/wiki/Eastern_Arabic_numerals
and add some sample digits

Change-Id: I97e50d6e5c4715eb3aed9701457164269d5d75da
Reviewed-on: https://gerrit.libreoffice.org/29000
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-09-28 20:59:02 +00:00
Muhammet Kara
652c97b821 tdf#101549: Remove tooltip_markup from glade .ui files
where there is also an identical tooltip_text.
And convert the remaining tooltip_markup properties
to tooltip_text.

Change-Id: Id9995217468fb7046a2822dcef9a99072a7269ee
Reviewed-on: https://gerrit.libreoffice.org/29367
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-09-28 20:57:21 +00:00
Caolán McNamara
219aae1cea Resolves: tdf#96748 'Default Language' show current ui lang not new default
i.e. if you select it, then the General::UILocale is unset and a new
default generated based on the L10N::UILocale and what langpacks are installed
but what the entry string claims is "Default - Current Language", rather than
"Default - The Language That Will Be Used", so split out the language selection
code into a reusable bit and use that to get the name of the language which will
be selected if this entry is used

Change-Id: I13d901c9a47ef213aea86417501114d4231efae5
2016-09-28 11:39:00 +01:00
Caolán McNamara
b466bd9292 Resolves: tdf#101475 adjacent cells text is still too wide
this still isn't brilliant I guess

Change-Id: I18b6647133329afa85826a8014f839986a9b68de
2016-09-27 21:30:37 +01:00
Noel Grandin
0e740b9b07 convert ITEMCONN_ constants to scoped enum
Remove unused enum values.

Which means that these methods simplify to constant values:
   ItemConnectionBase::GetEnableState() -> TRISTATE_INDET
   ItemConnectionBase::IsActive() -> true
so inline those values.

Which means that ControlWrapperBase::ModifyControl is always called with
a first parameter of TRISTATE_INDET, so drop that first parameter.

Change-Id: I6d63b63b2f15faad2336665f60e7239e35b74e47
2016-09-26 08:29:38 +02:00