...which makes it more flexible, can now also be used on non-const arguments.
The drawback of the argument no longer being a compile-time constant is remedied
by making the ctor constexpr.
Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
...(ever since c5bcf0e5e7a467b41c955a5f13affbccd23004eb "convert sw pos/size
page to .ui"), leading to out-of-bounds reads, but which should be harmless, as
all they could do is add bad StringIds inot aFrames, but the only use of those
IDs in SvxSwFramePosString::GetString (svx/source/dialog/swframeposstrings.cxx)
guards against bad IDs.
Change-Id: I7a50230c12bcf8a197f787201442c503fe5974e7
Edge-rounding and linewidth for selection/cursor, default
filename for save dialog. Code cosmetics.
Change-Id: I8a76d68f4f3070458ec4ba51a81bb046057218ab
Moved code to cui, added abstraction for AbstractDialog,
adapted rendering, changed selection, added better selection
visualization, added save ressources and dialog, creating
pure screenshot with annotation display
Change-Id: I533d9f559ee17cd46105b934bcf4beef87b96168
Enable users to apply custom values without adding it to the preset list
Change-Id: Ida00c6eeb06e717a8aed30f4d230ab616c5b03dd
Reviewed-on: https://gerrit.libreoffice.org/28333
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
See https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/
And it makes the code simpler. Win-win.
It is just a single full name that is stored in ODF and OOXML anyway.
Take care of migrating separate given names, father's names and
surnames from older user profiles if modifying the data. Handle the
"Eastern" (as the code calls it) case, too.
Change-Id: Iebf59f224995f722669f844d03053a55c088bc6e
Added 'delete' button for contents of Menus, Context Menus,
and Toolbars pages of the 'Customize' dialog. And removed
the 'delete' item from the 'Modify' menu in those pages.
Change-Id: Ie59a32e0b92116f8058fe8efe288bfb215b522b0
Reviewed-on: https://gerrit.libreoffice.org/28323
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
GetAddress_Impl() and SetAddress_Impl() handled more than just
addresses. So somewhat boringly, s/Address/Data.
Change-Id: I56c4e5ff7a4983a7fbb04d056c64333a016164c5
Don't call copy function if its argument is -1 because "firefox" isn't present in searchTerm
There's still at least 1 other case to deal (eg: ../en-US/ as indicated in bugreport)
Change-Id: Id78ec6c174abecd9cc101ac730f5e83b5acd167d
Reviewed-on: https://gerrit.libreoffice.org/28271
Reviewed-by: Susobhan Ghosh <susobhang70@gmail.com>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
and
coverity#705367 Mixing enum types
coverity#705371 Mixing enum types
coverity#982694 Mixing enum types
coverity#1027717 Mixing enum types
coverity#1371228 Mixing enum types
coverity#1371242 Mixing enum types
coverity#1371280 Mixing enum types
coverity#1371310 Mixing enum types
MapUnit and SfxMapUnit share the same values and
are freely cast from one to the other.
Now that
commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527
Date: Thu Aug 11 15:02:19 2016 +0200
loplugin:unusedenumconstants in package..svtools
removed the SfxMapUnit entries that were directly unused, they
don't match anymore and casting from one to the other is dangerous.
Why there was two of these anyway escapes me, get rid of SfxMapUnit
and just use MapUnit universally
Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e
Reviewed-on: https://gerrit.libreoffice.org/28234
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Added an OUString array to hold the original English strings
for search categories. The array is initialized in ctor by using
an initializer list of strings.
Also grouped the related strings of category names. So it can be
iterated easily without writing their names one by one.
Buttons in the UI will be displayed with localized strings,
but the search will take place with the original strings
coming from the array created in ctor.
Change-Id: Ieb72644203df1325e97693b14d5b3476020c6ff1
Reviewed-on: https://gerrit.libreoffice.org/28027
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Up to now the screenshot creation was added/dependent of
target slowcheck. Since quite some modules have added screenshot
creations now, I added an own target 'screenshot' to allow to keep
current slowcheck and screenshot creation separated
Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
