3868 Commits

Author SHA1 Message Date
Stephan Bergmann
0214be9338 -Werror,-Wunused-private-field
Change-Id: I7c1f1438be7226b9ea4692f1c4e39782288f6196
2016-08-17 10:36:12 +02:00
Rishabh Kumar
0e867bc4cb [GSoC] Add new Bitmap controls to bitmap tab
Change-Id: I0eb59e5082da1efa52dcb3b85f6e4129aad3e676
Reviewed-on: https://gerrit.libreoffice.org/26402
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-08-17 07:39:34 +00:00
Noel Grandin
48cb92cb16 convert XPropertyListType to scoped enum
Change-Id: I071c0d17c7c5982af47bccd92580bbac62bdf7b3
2016-08-17 08:45:15 +02:00
Noel Grandin
430b93f7f3 convert SvxEscapement to scoped enum
and fix a potential bug with footnotes and superscripts in writer in
ndtxt.cxx, where it was passing bad args to the SvxEscapementItem
constructor

Change-Id: I0d2de34c056e7824f3b456a86d502e10ac93a1c1
2016-08-17 08:45:15 +02:00
Noel Grandin
49561be0fd convert SvxTabAdjust to scoped enum
Change-Id: I29a33b8ea5daaa4b9059d024ffa4a99ca924f7ef
2016-08-17 08:45:15 +02:00
Noel Grandin
42ab2cfbd9 convert SvxLineSpace to scoped enum
and rename to be more explicit

Change-Id: Id06e6b68ef30e1d0d0daf19c37a390060e8bcb01
2016-08-17 08:45:15 +02:00
Noel Grandin
a49eeecd23 convert SvxInterLineSpaceRule to scoped enum
and rename it to be more explicit

Change-Id: I3f8bd7928495dba1e94b785cdda06d9819ee66bf
2016-08-17 08:45:15 +02:00
Noel Grandin
d5ad8f9619 convert SvxBreak to scoped enum
Change-Id: If8b79ed617e5662550bd73bd1506d047217f2313
2016-08-17 08:45:15 +02:00
Noel Grandin
fd0e67ce0d convert SvxCellJustifyMethod to scoped enum
Change-Id: Ifdb9192f6556477a28af05a74042f216d4e9e8fd
2016-08-17 08:45:15 +02:00
Laurent Balland-Poirier
6e44bb1b67 Fraction Number Format: add UI/Sidebar options
Enable modification of fraction number format through dialog UI:
- negative in red
- "Decimal places" is replaced with "Denominator places"
- leading zeros for integer part
- thousand separator for integer part

Update: options in Sidebar
Thousand separator works, also for ' ' as thousand separator

Change-Id: I0ed2952ed9cd8afb5444b44997526e5019a5858d
Reviewed-on: https://gerrit.libreoffice.org/27268
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2016-08-16 19:20:57 +00:00
Szymon Kłos
aa2aa4a6d2 GSoC notebookbar: icon size switching
+ added entry in the Options > View
+ changed sfxlo-SidebarToolBox to sfxlo-NotebookbarToolBox
  in the Notebookbar ui files

Change-Id: Id5719953be9830b650af96d54e63936c553cda74
Reviewed-on: https://gerrit.libreoffice.org/28169
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2016-08-16 14:42:12 +00:00
Stephan Bergmann
38ff65644f Remove unnecessary UcbStreamHelper::CreateStream overload
...with an explicit XInteractionHandler, but which was only ever called with a
null XInteractionHandler, so could just as well call the overload that doesn't
specify one (but internally uses a special SimpleFilaAccessInteraction handler
since f60eaab748add19683e66c7e4bc073c9ce7887f7 "Related: tdf#99312, add
specialized interaction handler", which is probably also what is wanted for
these two calls to UcbStreamHelper::CreateStream in cui and sd).

Change-Id: I2bf7bebd32f1c06b7414a4646631a19b689ee52f
2016-08-16 14:59:30 +02:00
Jochen Nitschke
aff3d8dbac remove casts
XPropertyList members take long for position

Change-Id: I39b064f0934f9d4b30f71065537983dd8bce3697
Reviewed-on: https://gerrit.libreoffice.org/28150
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-16 07:11:47 +00:00
Noel Grandin
127f70d66a new loplugin to check for static OUStrings
that are better declared as OUStringLiteral

Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567
Reviewed-on: https://gerrit.libreoffice.org/27377
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-16 06:30:09 +00:00
Jochen Nitschke
2b68e03348 tdf#100782 have XPropertyList hold unique_ptr
Change-Id: I928f297e1be76b965898d83cb3dd2e79b23b7974
Reviewed-on: https://gerrit.libreoffice.org/28095
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-15 07:49:37 +00:00
Julien Nabet
8180a8c33a cppcheck: redundant assignment tphatch.cxx
Change-Id: Idf9ebf5df0d95e045a5766c740e22b80e57f7848
Reviewed-on: https://gerrit.libreoffice.org/28109
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-14 05:38:56 +00:00
Noel Grandin
3716b14426 loplugin:constantparam
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886
Reviewed-on: https://gerrit.libreoffice.org/28016
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11 06:05:32 +00:00
Muhammet Kara
ecc43f06a9 Update api URL for mozilla personas
Currently, entering a search term or clicking on
the category buttons on the Firefox Theme selection
dialog of Personalization option doesn't work at all.

With this url, it returns some results of firefox personas
which are applicable to LibreOffice.

Change-Id: Ie4da58cd987a1834dee969c09367229d3b69a47a
Reviewed-on: https://gerrit.libreoffice.org/27986
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-08-10 07:31:22 +00:00
Arnold Dumas
f4d0818cd2 tdf#89329: use unique_ptr for pImpl in sdbcdriverenum
Change-Id: Ie0bdc9693d2bade872ee3ac8d4cf6fd5c469493d
Reviewed-on: https://gerrit.libreoffice.org/27891
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-07 06:37:35 +00:00
Noel Grandin
7fa183cb1a loplugin:countusersofdefaultparams in chart2..desktop
Change-Id: Iaca94acd6ef91f07ed0c0085390500c418099dee
Reviewed-on: https://gerrit.libreoffice.org/27896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05 10:28:25 +00:00
Rishabh Kumar
755a483805 Don't save the color list
Color list can't be modified, so no need to save the list

Change-Id: Idb11343f7812e1a30df9a5c0d26b6f22bd92c107
Reviewed-on: https://gerrit.libreoffice.org/27899
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-08-05 10:14:44 +00:00
nadith
bd4c80b856 tdf#100726: Improve readability of OUString concatenation
module cui and dbaccess fixed

Change-Id: Ief6fca46622fe4e0da804c9a874f7ec93a0fd7af
Reviewed-on: https://gerrit.libreoffice.org/27770
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04 09:34:11 +00:00
Arnold Dumas
6d9cf658ed tdf#89329: use unique_ptr for mpImpl in macroass
Change-Id: I6d3263cf35db3bef6963b2443cb8538343ca9a3a
Reviewed-on: https://gerrit.libreoffice.org/27812
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04 05:40:34 +00:00
Tor Lillqvist
e13aead8a1 Reduce ENABLE_OPENGL / ENABLE_HEADLESS confusion
ENABLE_OPENGL means whether to enable the OpenGL slideshow transition
code. It does not mean whether to enable use of OpenGL in general. So
rename it to ENABLE_OPENGL_TRANSITIONS while at it.

ENABLE_HEADLESS means whether to disable use of X11 and OpenGL on X11
(and Wayland) platforms, I think, meaning Linux and maybe Solaris and
the BSDs. Maybe it should be renamed to DISABLE_X11_AND_OPENGL.

Change-Id: Ibb30f51646b1bcc477fe691a3fa38c7a1e3944ae
2016-08-03 22:36:36 +03:00
Rishabh Kumar
571866eaba [GSoC] Rework of color tab
New Features -

1. Multiple Palettes in color tab.
2. Remember the selected palette.
3. Recent colors.
4. Custom colors.

Change-Id: I36a438a0c282059ddcbda35f934fcd90337fd451
Reviewed-on: https://gerrit.libreoffice.org/26868
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-08-03 14:19:51 +00:00
Caolán McNamara
4e8bc5462a Related: tdf#101196 prompt to restart after OpenGL config changes
Change-Id: If0ade12ed4cf360bdac8cfbec7bb09c9a640fc6d
2016-08-02 21:04:44 +01:00
Caolán McNamara
40c889105f Related: tdf#101196 shorten description, move info into tooltip
Change-Id: Id3e083dc45135c8af724c64530b6eb4e36c7f6d2
2016-08-02 20:53:57 +01:00
Caolán McNamara
1c33b3f5f6 Resolves: tdf#101196 line wrap very long checkbox content
Change-Id: Ie451b88240f755a0d64dd3db14d7981b8ed2a2a2
2016-08-02 20:49:49 +01:00
Rishabh Kumar
55859becb8 [GSoC] Add functionality to disable buttons in SvxMessDialog
Change-Id: Ib25b65a6d1fd760d2a8535c1a97cfbb889d7a824
Reviewed-on: https://gerrit.libreoffice.org/27715
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-08-01 09:26:37 +00:00
Caolán McNamara
b3b7669e7f Resolves: tdf#96677 effects page didn't link labels to what they labelled
Change-Id: I29503324f221c42208267f4f0d36922e89119fdd
2016-07-29 10:58:17 +01:00
Miklos Vajna
05676088e2 cui: fix Android build
Change-Id: I6396d7702de42ad2cec3843e919cca084e92c008
2016-07-28 10:33:53 +02:00
Rishabh Kumar
5e0b0de0af Bug fix: Fill bitmap item set only when bitmap tab is selected
Change-Id: I9bb7bdeecfcd51e8191f82c649585af8458f1001
Reviewed-on: https://gerrit.libreoffice.org/27578
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-27 14:00:39 +00:00
Rishabh Kumar
706b76d1d5 Align pattern preview correctly
Change-Id: I7513934e3195297bc6b68ff7149e9fd78922dcdc
Reviewed-on: https://gerrit.libreoffice.org/27562
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-27 09:17:44 +00:00
Noel Grandin
187044b5e8 loplugin:vclwidgets
Change-Id: Ie16efa4a66cc3ea1991878f20442f0c0bac79d10
2016-07-27 10:23:13 +02:00
Noel Grandin
702e26d656 loplugin:passstuffbyref
Change-Id: I37cc39974784e59aa793c2a2ca0dbc59d00e3cb4
2016-07-27 10:23:13 +02:00
Rishabh Kumar
7438bc1f0c [GSoC] Remove bitmap controls from area tab
Change-Id: Ie8d62b42c9b5ce9a4d087d809e7c395b8c71e667
Reviewed-on: https://gerrit.libreoffice.org/27024
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-26 19:31:28 +00:00
Rishabh Kumar
a44a0690da [GSoC] Add Bitmap tab to area dialog
Change-Id: I6549e7eb4efd24d035b0383a750698a4c3f16cf7
Reviewed-on: https://gerrit.libreoffice.org/27546
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-26 18:33:01 +00:00
Caolán McNamara
a860df25dd masses of MessBoxes not being disposed promptly
since...

commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f
Date:   Thu May 28 21:35:43 2015 +0100

    tdf#91702 - fix stack-based MessBox allocation.

There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X

Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-26 11:26:52 +01:00
Noel Grandin
938821fb08 new loplugin overrideparam
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25 06:09:17 +00:00
Caolán McNamara
c1bd3156cf Resolves: tdf#101054 crash on options->path with non-native file picker
regression from...

commit 3bbc0574d78d129359638b74612de2f93419eeb0
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Tue Jul 5 10:16:51 2016 +0100

    Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker

only clear the xFolderPicker immediately in the non-async case

Change-Id: Id6a411424d41262a9379ad3eb7976c8dd666a5cf
2016-07-21 21:45:29 +01:00
Rishabh Kumar
e543f5cfc3 Keep spacing between widgets consistent in gradient tab
Change-Id: Ida726439644c0b06d1562f82c8ba037dc7399e15
Reviewed-on: https://gerrit.libreoffice.org/27391
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-21 19:48:06 +00:00
Rishabh Kumar
63a7e84cfc Remove unnecessary container in hatch tab
Change-Id: I49f513a6c78a68403b4275ba480add0ca71c4244
Reviewed-on: https://gerrit.libreoffice.org/27390
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-21 19:46:50 +00:00
Rishabh Kumar
6f2b129a8e Minor UI changes for SvxPresetListBox
1. Reduced item icon size.
2. Add slider depending on the number of entries.

Change-Id: I1fad15861438952664c26666afe89fffa08051f6
Reviewed-on: https://gerrit.libreoffice.org/27389
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-21 19:46:22 +00:00
Noel Grandin
56823b52e5 compile fix
Change-Id: I1d1dc12b6c2ff3ea8d8ba4593bd94e02a87a9c35
2016-07-21 09:24:31 +02:00
Noel Grandin
2cdc10d66b loplugin:vclwidgets
Change-Id: I264644d1fb3582168879d47d0d538bef27902573
2016-07-21 09:22:24 +02:00
Rishabh Kumar
45e9ccb699 Remove PatternLB dead code
PatternLB is replaced by SvxPresetListBox in tppattern.cxx

Change-Id: Ie4ec100963b714e07807f8b600cca2e165fb4641
Reviewed-on: https://gerrit.libreoffice.org/27353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-21 06:20:44 +00:00
Rishabh Kumar
74aa685bf3 [GSoC] Redesign of Pattern tab
1. New Pattern Listbox for presets.
2. Context menu for Rename and Delete.
3. Rearrangement of controls.
4. Remove Save and Load buttons.

Change-Id: I7edaf2496837443967711a307c01cdba284270d0
Reviewed-on: https://gerrit.libreoffice.org/27352
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-20 20:26:04 +00:00
Caolán McNamara
b184c54a51 loplugin:vclwidgets
Change-Id: I0a762a0eaa6cc9dc2f3c41b456faf98b919181ba
2016-07-20 08:44:13 +01:00
Rishabh Kumar
ea96d97020 tdf#100907: Cannot set white background for hatching
Change-Id: Id10cb4d90a19717b44d02064eb69981c69a421de
Reviewed-on: https://gerrit.libreoffice.org/27258
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-19 18:32:47 +00:00
Rishabh Kumar
1d60208813 Fix regression : Automatic gradient steps in gradient tab
Adds a checkbox for enabling/disabling automatic gradient steps.

Change-Id: I223279ec0f23f20f3ff544072cc7fd8662946296
Reviewed-on: https://gerrit.libreoffice.org/27269
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-19 18:25:14 +00:00