6262 Commits

Author SHA1 Message Date
Eike Rathke
838fab822c Resolves: tdf#79250 add typed list to form control listbox
... so numeric and text data can be distinguished input.

Change-Id: I63280a93c272ccc6f5e7ca06a1a1fcbfb3db8455
2017-02-14 11:49:35 +01:00
Andrea Gelmini
417bc89880 Fix typos
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c
Reviewed-on: https://gerrit.libreoffice.org/34199
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-13 09:37:18 +00:00
Eike Rathke
d3293c7173 Revert "Resolves: tdf#79250 add typed list to form control listbox"
This reverts commit e387b69967aabc44d5da5aaad8d94191437dc57c.

It breaks toolkit.subsequentcheck with
propertyChangeListener wasn´t called for ´TypedItemList´

Back to the drawing board for the twisted property logic of forms and
toolkit uno control models.
2017-02-11 01:19:37 +01:00
Eike Rathke
e387b69967 Resolves: tdf#79250 add typed list to form control listbox
... so numeric and text data can be distinguished input.

Change-Id: I63280a93c272ccc6f5e7ca06a1a1fcbfb3db8455
2017-02-10 20:58:52 +01:00
Stephan Bergmann
8646ab97dc Remove MinGW support
In OOo times, there'd originally been efforts to allow building on Windows with
MinGW.  Later, in LO times, this has been shifted to an attempt of cross-
compiling for Windows on Linux.  That attempt can be considered abandoned, and
the relevant code rotting.

Due to this heritage, there are now three kinds of MinGW-specific code in LO:

* Code from the original OOo native Windows effort that is no longer relevant
  for the LO cross-compilation effort, but has never been removed properly.

* Code from the original OOo native Windows effort that is re-purposed for the
  LO cross-compilation effort.

* Code that has been added specifially for the LO cross-compilation effort.

All three kinds of code are removed.

(An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing
--with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.)

Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568
Reviewed-on: https://gerrit.libreoffice.org/34127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-10 18:01:27 +00:00
Yousuf Philips
8dc38dd9b1 tdf#105447 Move accelerator to first letters in Help menu
Change-Id: I14088435228a989cb388cb9e205dc7fcd3fbbfa9
Reviewed-on: https://gerrit.libreoffice.org/33646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-02-09 22:40:37 +00:00
Stephan Bergmann
3b53a4cdb5 Blind fix for apparently buggy GCC 4.8
cf. <http://ci.libreoffice.org/job/lo_tb_master_linux_dbg/10952/console>

Change-Id: If947e338be0ab17f41f74f8e70e6281f46a7f57c
2017-02-08 11:10:30 +01:00
Stephan Bergmann
ccc2b4ec0e Use OUStringLiteral
Change-Id: I15580bd0395145f9554cd3a155c4825ba95005b3
2017-02-08 10:14:20 +01:00
Stephan Bergmann
40035bbbbc Drop bogus check for escaped $
This apparently wanted to check whether the $ starting a potential pattern
occurrence was escaped by a preceding $.  However:

* The check itself was broken, erratically looking into sPattern instead of
  _inout_rFileURL for the $.

* The check was bogus, as it would have misinterpreted e.g. "$$$(loggername)".

* The resulting string is documented (in
  officecfg/registry/schema/org/openoffice/Office/Logging.xcs) to be passed
  through css.util.PathSubstitution.  However, neither the PathSubstitution
  service's documentation (in offapi/com/sun/star/util/PathSubstitution.idl) nor
  its implementation (SubstitutePathVariables::impl_substituteVariable in
  framework/source/services/substitutepathvars.cxx) appear to support esacping
  $ with a preceding $.  So it looks more reasonable to remove the check
  completely here.

Change-Id: I445493d444904cd54f166adcbf870a918d1f9982
2017-02-08 10:14:20 +01:00
Stephan Bergmann
fed3783e77 Add missing #includes
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code

Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-08 08:40:06 +01:00
Stephan Bergmann
6dce9c6757 Add missing #includes
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06 17:21:16 +01:00
Maxim Monastirsky
eb0b727b87 .uno:ScriptOrganizer should be menu:menuitem
... so it won't show as an empty submenu in the
customization dialog, and allow accidentally
overwriting it.

Change-Id: I9431e5240485a58f63a2333850a9052e475db63e
2017-02-05 22:08:43 +02:00
Noel Grandin
c0f9bdd3e6 unnecessary use of OUStringBuffer in throwing exceptions
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f
Reviewed-on: https://gerrit.libreoffice.org/33788
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02 07:48:21 +00:00
Noel Grandin
1c3e84d819 teach lolugin:stringconstant about calling constructors
so we can remove unnecessary calls to the OUString(literal) constructor
when calling constructors like this:
   Foo(OUString("xxx"), 1)

Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36
Reviewed-on: https://gerrit.libreoffice.org/33698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31 08:56:20 +00:00
Noel Grandin
f1d83ac45f loplugin:stringconstant check for unnecessary OUString constructor..
..calls when creating exceptions

Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe
Reviewed-on: https://gerrit.libreoffice.org/33617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28 09:22:55 +00:00
Noel Grandin
4511431fb6 improve "unnecessary user-declared destructor" check
to look for inline&empty destructors, where we can just let
the compiler do it's thing

Change-Id: Ibde8800bdfed6b77649c30ebc19921167c33dec3
Reviewed-on: https://gerrit.libreoffice.org/32999
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27 09:49:04 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Caolán McNamara
d92b12604b tdf#105467 new color widget doesn't support XStringListControl
so this threw and mangled the dialog. New color dialog doesn't need
to be told the name of colors, it figures that out itself.

Change-Id: I89382b6b26312fc90c967620c654ea611cbd9616
2017-01-24 15:49:49 +00:00
Jan-Marek Glogowski
bf110d40ef Change all Idle* LINKs to be Timer*
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles
Link in the Timer class. Now there are two possible solution:

  1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or
  2. split the inheritance of Idle from Timer again to maintain
     different Link<>s and move all common code into a TimerBase.

While the 1st is more correct, the 2nd has a better indicator for
Idles. This implements the first solution.

And while at it, this also converts all call sites of SetTimeoutHdl
and SetIdleHdl to SetInvokeHandler and gets rid of some local Link
objects, which are just passed to the SetInvokeHandler call.

It also introduces ClearInvokeHandler() and replaces the respective
call sites of SetInvokeHandler( Link<Timer *, void>() ).

Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23 20:49:05 +01:00
Noel Grandin
9c6bdac80b use rtl::Reference in SubmissionPropertyHandler
rather than manual acquire/release

Change-Id: I3276361153591a3af8c6b00b478365b2700dedf5
2017-01-23 07:56:34 +02:00
Noel Grandin
32f4f3b52a use rtl::Reference in bib::OComponentListener
rather than manual acquire/release

Change-Id: Ib4b52fb4a85223f974e9905bc3d02eb839150030
2017-01-23 07:56:34 +02:00
Noel Grandin
81253afdba use rtl::Reference in BibFrameCtrl_Impl
instead of storing both a raw pointer and a uno::Reference

Change-Id: I8caa56eade25561178aa6ffd144b00f452517974
2017-01-20 12:52:45 +02:00
Noel Grandin
3663edf465 use rtl::Reference in BibliographyLoader
instead of storing both a raw pointer and an uno::Reference

Change-Id: Ic46c5cda34c1df818cbe1ffa4b2d44d1519b4d6f
2017-01-20 08:51:08 +02:00
Noel Grandin
7d7a5666ae use rtl::Reference in FormControlContainer
instead of manual acquire/release

Change-Id: Ie0fed7db217adea68aaa09cf9de699d488bf84dd
2017-01-20 08:51:08 +02:00
Stephan Bergmann
8ee3f98698 New loplugin:dynexcspec: Add @throws documentation, extensions
Change-Id: Ia44f7b0a162d269bf38133575f986efd62eb6d52
2017-01-19 18:03:21 +01:00
Michael Stahl
0cee740c95 replace #ifdef SOLARIS with #ifdef __sun
Check for a macro that is defined by the compiler, we don't really need
one defined by the build system.

Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-17 16:38:33 +01:00
Jan-Marek Glogowski
fdc612619c Refactor Scheduler to add Task class
Moves all the "task-specific" stuff into a Task class and just
keeps the "real" static Scheduler functions in the original
Scheduler class.

Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17 16:08:47 +01:00
Caolán McNamara
0bb8bcf1f8 e*, f*: load BitmapEx resources instead of Image ones
Change-Id: I3383e222829042557a8fd9f575049c47aeddeb09
2017-01-16 14:30:43 +00:00
Noel Grandin
99e09b18b7 new loplugin: useuniqueptr: extensions
Change-Id: Iaafaf0117a339dbb435cec2bbf4dca55629ab8a2
Reviewed-on: https://gerrit.libreoffice.org/33154
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-16 11:43:03 +00:00
Stephan Bergmann
95bf4e560a -Werror,-Wunused-lambda-capture
Change-Id: I0ceabed1f89b6b641d5282fa1c32719bf3ead19c
2017-01-14 19:58:35 +01:00
Stephan Bergmann
6ec5717e06 loplugin:externvar (clang-cl)
Change-Id: I638199f1455bead71f0a03f15e4b6f418a0cd0e2
2017-01-11 13:42:40 +01:00
heiko tietze
0c9f0f3c17 tdf#105160: word wrap at wizard
Vertical spacing fill now

Change-Id: I1463df1a0b345a39c10ef83b2fa0c558bd135cdc
Reviewed-on: https://gerrit.libreoffice.org/32829
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-01-09 16:03:30 +00:00
Stephan Bergmann
71d8920b4d New loplugin:externvar: extensions
Change-Id: I596eecab083092cccbe67062ade2279e6e25baab
2017-01-09 15:43:38 +01:00
Stephan Bergmann
c38aa3b734 loplugin:salbool
Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
2017-01-06 11:19:42 +01:00
Caolán McNamara
5a6994870b fold ResourceIndexAccessBase into ResourceStringIndexAccess
Change-Id: Icef518dc65d5edf4e7893df460aaae179eecfb45
2017-01-01 20:32:29 +00:00
Caolán McNamara
705b435162 so ResourceStringListIndexAccess isn't needed
Change-Id: Ic25fc6f2f8f3e471a90e10c3f2319f40888520e6
2017-01-01 20:30:03 +00:00
Caolán McNamara
e777637ffc so we can drop StringList access from ResourceIndexAccess
Change-Id: Ie855a45f7994e9d58ddecc51b54c25424fc544d6
2017-01-01 20:28:47 +00:00
Noel Grandin
833e6ca9d2 use std::vector instead of naked array in SfxItemPool
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4
Reviewed-on: https://gerrit.libreoffice.org/32384
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-26 18:35:59 +00:00
Caolán McNamara
ab72a07f1a unwind RID_TOOLBAR_IMGLIST and RID_TOOLBAR_BIGIMGLIST ImageLists
Change-Id: Iae7ffce940f90e48dfb95b33abab35ca03a6b305
2016-12-24 15:28:42 +00:00
Caolán McNamara
4a780e9e03 RID_SVXBMP->RID_EXTBMP
Change-Id: I19e5c60ea8b42223322da2a1e343b7c4c1c59928
2016-12-22 15:59:01 +00:00
Stephan Bergmann
87d1657d6b loplugin:staticmethods
Change-Id: I04d3095c657deb72a20fa803964912cf6baf268b
2016-12-21 21:43:27 +01:00
Caolán McNamara
20bd8d0426 -Werror,-Wmacro-redefined
Change-Id: Ifd246b642979df0d8b1aa20a59f8c73dc9ddc1b2
2016-12-21 20:20:12 +00:00
Tor Lillqvist
59a5664ffb loplugin:staticmethods
Change-Id: I30456ec3a0440364b8b4c460d198588aed241034
2016-12-21 21:24:09 +02:00
Noel Grandin
6b8ee3c9ba convert VclButtonsType to scoped enum
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1
Reviewed-on: https://gerrit.libreoffice.org/32285
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-21 16:19:37 +00:00
Caolán McNamara
7c7e1fb0f2 unwind RID_IL_FORMEXPLORER imagelist
Change-Id: I4c86aa99aecf22e842183966721976a921bafe7b
2016-12-21 16:02:28 +00:00
Takeshi Abe
2e9c02feca extensions: Drop empty file
Change-Id: I4962d739af889595f026c250b8f10a917b1dfb17
Reviewed-on: https://gerrit.libreoffice.org/32130
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-20 00:18:05 +00:00
Noel Grandin
c3586b684c OSL_TRACE->SAL in chart2..oox
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13 06:12:00 +00:00
Noel Grandin
d6f2dd831a remove useless Mutex guards
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51
Reviewed-on: https://gerrit.libreoffice.org/31875
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12 09:16:09 +00:00
Noel Grandin
2d48f5fc0a convert VCLEVENT constants to scoped enum
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba
Reviewed-on: https://gerrit.libreoffice.org/31675
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07 07:10:39 +00:00
Noel Grandin
bfde4866e0 convert DecodeMechanism to scoped enum
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05 12:49:02 +02:00