6262 Commits

Author SHA1 Message Date
Noel Grandin
0112840eb0 convert ExtDateFieldFormat to scoped enum
Change-Id: I717e5e727ee0e2b6d732ecc6a432c70926654902
2016-09-05 08:21:46 +02:00
Noel Grandin
65ca57a447 convert LineStyle to scoped enum
Change-Id: I30cfa5a0649b806604c443f55683d1f2a430983d
2016-09-05 08:21:46 +02:00
Noel Grandin
a881fd7e66 convert RasterOp to scoped enum
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-09-05 08:21:46 +02:00
Noel Grandin
bdc4010565 tdf#101810 - Crash when selecting Bibliography from Tools
fallout from commit aa0d0536 "tdf#97527 - vcl: reference-count Menu"

Change-Id: I996a5b739f35d034b15fd5d0b4c94fd57688bf12
2016-08-31 15:12:24 +02:00
Markus Mohrhard
d54773ada2 remove unnecessary default constructor and operator=
They are equal to the default generated and therefore unnecessary.

Change-Id: I4c0c77c025443fc074308bfd3ce2637a7e1af8bf
Reviewed-on: https://gerrit.libreoffice.org/27946
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-26 13:11:29 +00:00
Gökhan Gurbetoğlu
674e0f0b43 tdf#100726 - Improve readability of OUString concatanations
Change-Id: I3099818283a9801976288d0efa67a8711106f376
Reviewed-on: https://gerrit.libreoffice.org/28360
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26 07:15:34 +00:00
Stephan Bergmann
d4aae1b104 -Werror,-Wnonportable-include-path (clang-cl)
Change-Id: Ia468adf0bea2f7fca9b370ef0ff8b05e34b3ac19
2016-08-25 17:39:19 +02:00
Arnold Dumas
e420085f6f tdf#89329: use unique_ptr for pImpl in datasourcehandling
Change-Id: Ib019d26a72d234245cc1a7322bfbfb11705f29d3
Reviewed-on: https://gerrit.libreoffice.org/28231
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-19 08:44:09 +00:00
Caolán McNamara
4630157e29 cppcheck: passedByValue
Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
2016-08-18 14:24:11 +01:00
Jochen Nitschke
2b68e03348 tdf#100782 have XPropertyList hold unique_ptr
Change-Id: I928f297e1be76b965898d83cb3dd2e79b23b7974
Reviewed-on: https://gerrit.libreoffice.org/28095
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-15 07:49:37 +00:00
Olivier Hallot
20469b5650 tdf#96015 (part) links to Askbot in the Help menu
Add the entry "~Get help online" to the modules
Help menu.

on click, the system browser opens
http://hub.libreoffice.org/forum/?&LOlang=<lang>

<lang> is obtained from .getLocale()

That in turn will redirect to e.g. askbot (but only few languages are
using it at the moment) or other nl-specific resources.
(nl-projects can request corresponding targets from infa, without the
need to change the code – cf rdm#1983)

The link can/should be extended to also include the version of LO and
the currently used module to allow finer grained redirects.

Change-Id: I56108dba4dd2684405623c4586103fc8ff9bea56
Reviewed-on: https://gerrit.libreoffice.org/27028
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-08-11 14:23:28 +00:00
Michael Stahl
49b06c2e83 loplugin:sallogareas
Change-Id: I3443ed8d481d7a0ac72c03c4d0fd0bcf100a09b6
2016-08-09 12:48:04 +02:00
Markus Mohrhard
8cb1976232 it is possible that Sources is empty
See e.g.
http://crashreport.libreoffice.org/stats/crash_details/570429b8-21e3-494e-9677-ea95fa8a5293

Change-Id: I8c05efd61fa5a91511c06c660c49a0c470a96c88
Reviewed-on: https://gerrit.libreoffice.org/27947
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-08-08 18:22:41 +00:00
Noel Grandin
b4e12269e8 loplugin:countusersofdefaultparams in editeng..fpicker
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68
Reviewed-on: https://gerrit.libreoffice.org/27897
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05 11:54:17 +00:00
Noel Grandin
508c95f1b6 improve passstuffbyref return analysis
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27 06:48:25 +00:00
Caolán McNamara
a860df25dd masses of MessBoxes not being disposed promptly
since...

commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f
Date:   Thu May 28 21:35:43 2015 +0100

    tdf#91702 - fix stack-based MessBox allocation.

There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X

Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-26 11:26:52 +01:00
Noel Grandin
6e72f0251b new loplugin unnecessary override
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15 14:05:41 +00:00
Stephan Bergmann
82dafd096a loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I9bc14b4df6bdda68bae44a1972e6b412fa6adccb
2016-07-07 18:59:55 +02:00
Caolán McNamara
3cecadbddd Related: tdf#92478 speculative win64 scanning fix
TWAIN-2.3-Spec.pdf says...

All TWAIN 2.x Sources must be prepared to work with either TWAINDSM.DLL or
TWAIN_32.DLL, which may still be used by older Applications.

The TWAIN DSM is a shared library named TWAINDSM.DLL.  There is a 32-bit and a
64-bit version of this file.

Change-Id: I047d872271573a5b2efc3ee2af4ecfc4e142a2b2
Reviewed-on: https://gerrit.libreoffice.org/26541
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-07 11:55:20 +00:00
Noel Grandin
64354e6479 merge BibTabPage with BibGeneralPage
Change-Id: I16a80e7e98fdd2be08b5a8ce586b709a3720e694
Reviewed-on: https://gerrit.libreoffice.org/26929
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05 09:44:26 +00:00
Noel Grandin
cd71034b26 comphelper::OBaseMutex -> cppu::BaseMutex
convert usage of deprecated class, and remove the old class

Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2
Reviewed-on: https://gerrit.libreoffice.org/26843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04 06:49:07 +00:00
Muhammet Kara
541fcc978d Move accessibility relations to .ui files, Part 12: tdf#87026
By removing unnecessary variables/strings/function calls,
and making proper changes in the related .ui files.

As of this commit, all accessible relations have been
moved to .ui files other than a few exceptions.

Change-Id: Ic9dffdde414d245c13f13ee08543f90884991222
Reviewed-on: https://gerrit.libreoffice.org/26707
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29 09:17:53 +00:00
Stephan Bergmann
e3e79246cb Simplify some PutProperties calls
Change-Id: Idf91592e6cf34b5591f221c3c5bdc937bbe46014
2016-06-28 14:50:49 +02:00
Michael Stahl
136a2fd6c0 compilerplugins: add OWeakObject::release() override check
Change-Id: I767857545d7c91615cf162790c04f0016de9fdf6
Reviewed-on: https://gerrit.libreoffice.org/26555
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-24 12:05:09 +00:00
Noel Grandin
aa0d0536a4 tdf#97527 - vcl: reference-count Menu
some places are marked with "dodgy"- need to check those to see
what is going on, because they are leaving dangling pointers behind
in the Menu class

Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b
Reviewed-on: https://gerrit.libreoffice.org/26516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23 06:28:00 +00:00
Caolán McNamara
2822d1891b valgrind: use after free
sal/osl/unx/conditn.cxx:90: pthread_cond_destroy failed: Device or resource busy
sal/osl/unx/conditn.cxx:92: pthread_mutex_destroy failed: Device or resource busy

"Desktop disposed before terminating it"

seen under valgrind with CppunitTest_sccomp_lpsolver

Change-Id: I643cf114b902c38a6a54487fd78c55d84ed78cfc
2016-06-22 11:33:58 +01:00
Caolán McNamara
0e2a656104 coverity#1362777 Explicit null dereferenced
Change-Id: I5db9cf469677b8509c19d6489472a4cf0babeca5
2016-06-19 17:14:43 +01:00
Muhammet Kara
093ebf2722 Fix simple typo in parameter name
Change-Id: I8c4a5e701c20c70c7df091a34efb38936ee59f9d
Reviewed-on: https://gerrit.libreoffice.org/26420
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-18 11:16:37 +00:00
Caolán McNamara
d6665da4ea Resolves: tdf#96251 address wizard crash when run from start center
Change-Id: I20de1fbdd3ca609a1818dfe8f81ba66b1cb15281
2016-06-17 09:16:58 +01:00
krishna keshav
46e372a601 tdf#43157 Clean up DBG_ASSERT
Change-Id: I2a7d5d507a875e555441a9d30d54e638e5dea026
Reviewed-on: https://gerrit.libreoffice.org/26099
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-13 11:57:03 +00:00
Noel Grandin
9f4e283fc8 loplugin:sallogareas
Change-Id: I6ce045db236b81aa8bc7bce2a0e20c4132c5931f
2016-06-13 10:25:40 +02:00
Caolán McNamara
7c98344565 Resolves: tdf#92478 avoid crash on using scanner on windows x64
which appears to correspond to backtrace
http://crashreport.libreoffice.org/stats/crash_details/ad46ef89-6b98-44f9-b060-ccb25015269d

Change-Id: Ic5a4b66028db6ba4aea08baf5bf4a672f71745a0
Reviewed-on: https://gerrit.libreoffice.org/26197
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-06-12 13:48:56 +00:00
Noel Grandin
ab10f9fc11 convert DBG_ASSERT(false, to SAL_WARN(
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c
Reviewed-on: https://gerrit.libreoffice.org/26187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12 09:04:15 +00:00
Stephan Bergmann
177afb1ec3 Clean up uses of Any::getValue() in extensions
Change-Id: I67b9127d8aa67a702086ef5bc61372ae54c2142e
2016-06-10 18:55:25 +02:00
Gleb Mishchenko
a97b392879 tdf#94698 cleanup Makefiles. Get rid of udkapi and offapi
This patch changes occurences in makefiles
from
$(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \
	udkapi \
	offapi \
))

to
$(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config))

(corrected instead of abandon, jani)

Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e
Reviewed-on: https://gerrit.libreoffice.org/23426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09 09:47:11 +00:00
David Tardon
0a5a20e929 merge cond. blocks to one
Change-Id: Iad5858955244e12a849336f84938a39b6f3219e0
2016-06-08 12:51:42 +02:00
Michael Stahl
62d270116b tools: rename SvStream::Read/Write to ReadBytes/WriteBytes
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a
Reviewed-on: https://gerrit.libreoffice.org/25972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06 18:09:11 +00:00
Noel Grandin
9f138ffe9d remove unused constants in HRC files
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1
Reviewed-on: https://gerrit.libreoffice.org/25817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06 07:01:43 +00:00
Noel Grandin
0323253a7c remove some manual ref-counting
triggered when I noticed a class doing acquire() in the
constructor and then release() in the destructor.

found mostly by
    git grep -n -B5 -e '->release()'

Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f
Reviewed-on: https://gerrit.libreoffice.org/25806
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06 07:01:34 +00:00
Caolán McNamara
ede8229983 DataAccess.xcs says xs:short not xs:int for this type
noticed when examing tdf#96251

Change-Id: Iec8748ad323bcb59e8e1f6b4135b4a3b313a6e44
2016-06-02 14:06:49 +01:00
Muhammet Kara
3498fd9fe9 Remove SetAccessibleRelationLabeledBy calls tdf#87026
And make proper changes in the related .ui files

Change-Id: Iea998b6de25831c08950a8afa725713288113bfa
Reviewed-on: https://gerrit.libreoffice.org/25807
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-02 10:36:59 +00:00
Noel Grandin
b860b73f2b Convert VCL_MESSAGE to scoped enum
Change-Id: I976536849fa5585c96cee23b660c56d3d0116933
Reviewed-on: https://gerrit.libreoffice.org/25720
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01 06:46:29 +00:00
Michael Stahl
1aff9299ab extensions: more README
Change-Id: I9cd902ce606c800e67cc142daf698962544b26bc
2016-06-01 00:11:11 +02:00
Michael Stahl
c11e60f11f tdf#99643 OLE automation bridge: fix 64-bit pointer conversions
XBridgeSupplier2::createBridge() is always called in-process and should
therefore expect and create Anys with native-sized encoded pointers,
so use sal_uIntPtr.

Change-Id: Ia757ff38568b07de8085a1a9d323d806bcca0f63
Note: Currently all calls in LO code are with source=UNO, target=OLE.
2016-06-01 00:11:10 +02:00
Noel Grandin
0b23eec200 teach refcounting clang plugin about uno::Reference
uno::Reference is only allowed to used with classes that have a
::static_type member.
So convert all those places to rtl::Reference.

Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and
uno::Reference to make this a little smoother?

Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3
Reviewed-on: https://gerrit.libreoffice.org/25516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31 06:25:45 +00:00
Stephan Bergmann
8fec9e7e4c Some clean up of uses of css::uno::Any::setValue
Change-Id: I04e8aef35a6083b61d775c8eb3f96757da2b31bd
2016-05-30 15:14:03 +02:00
Noel Grandin
c47b170c71 Convert SelectionMode to scoped enum
Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1
Reviewed-on: https://gerrit.libreoffice.org/25611
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30 06:41:28 +00:00
Noel Grandin
06cb2df4db Convert VclAlign to scoped enum
Change-Id: I03718cc63ec5c1260ebd599bddb1a787ca8f5788
Reviewed-on: https://gerrit.libreoffice.org/25603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30 06:36:21 +00:00
Noel Grandin
9eb2e683ab tdf#34465 remove calls to SfxItemSet::Put(const SfxPoolItem&, sal_uInt16)
and put an assert in SfxPoolItem::SetWhich() so nothing new
creeps in.

Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df
Reviewed-on: https://gerrit.libreoffice.org/24324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27 07:21:45 +00:00
Noel Grandin
74713b34a3 loplugin:unusedmethods
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda
Reviewed-on: https://gerrit.libreoffice.org/25431
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26 07:50:33 +00:00