Commit Graph

2710 Commits

Author SHA1 Message Date
Stefan Heinemann
c50eb68af3 Renamed wrongly prefixed boolean variables
Fixed tdf#94269

Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29 18:33:40 +00:00
Noel Grandin
34180700b2 loplugin:removeunusedmethods, remove unused stuff
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
Noel Grandin
146fe08382 convert Link<> to typed
Change-Id: Ica5093e29630d6d6974ccba034609129887ac85b
Reviewed-on: https://gerrit.libreoffice.org/18802
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-23 13:07:27 +00:00
Caolán McNamara
3a00aaef2a boost->std
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 07:59:14 +00:00
Noel Grandin
0535f42e5f convert Link<> to typed
Change-Id: Ic3ce7783614d90a34f9c4414bbc7df9774091805
2015-09-17 12:22:47 +02:00
Caolán McNamara
eaf2c27888 boost->std
Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
2015-09-17 11:00:51 +01:00
Noel Grandin
81bec2e553 convert Link<> to typed
Change-Id: I87d4697fe032e3095406becdda026447edd1d68a
2015-09-17 08:19:32 +02:00
Noel Grandin
69a06ca6bf convert Link<> to typed
Change-Id: I9ce05712af8300c8bcea6ea0f670b57cce1ca43d
2015-09-16 08:38:55 +02:00
Stephan Bergmann
82285ab5c9 Merge INetMessageIStream into INetMIMEMessageStream
Change-Id: Ic3d9cd117b3f911a7cb1317fc9d1d2e9d8f1ff42
2015-09-10 23:04:35 +02:00
Stephan Bergmann
8cb1f9ac1c A charset is not a content transfer encoding
...the code was in this odd shape ever since
bf4154eb53 "initial import"

Change-Id: Ic931b99267bb6501f15119636f13391f1d065ed4
2015-09-10 23:04:34 +02:00
Stephan Bergmann
e871b6a31a Reduce INetMIMEMessage::EnableAttachChild to its only use case
Change-Id: I67221408d6b9d2aee942ca8bd39ca51da0209551
2015-09-10 23:04:33 +02:00
Noel Grandin
4ea70f87f7 convert Link<> to typed
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4
Reviewed-on: https://gerrit.libreoffice.org/18306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-04 06:31:30 +00:00
Noel Grandin
7b096a6da1 make Link<> typed
Change-Id: I8949a92792df892b7f360e6b9979c8f61c702ce3
2015-08-31 09:50:10 +02:00
Stephan Bergmann
7144ce742a loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: If06eb179be6dd00a14d8920e303af37b53e22bdc
2015-08-31 08:03:28 +02:00
Noel Grandin
bd8b93fdff make PostUserEvent Link<> typed
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
Stephan Bergmann
fe6c124da7 Remove demonstrated-useless comphelper::compare
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-21 10:34:04 +02:00
Stephan Bergmann
d0f18382c5 comphelper::isA(Any... -> Any::has
Change-Id: I4fdc77c6fde93d9d1ee814f7614a1c4c81e18247
2015-08-19 14:48:27 +02:00
Stephan Bergmann
d21260cdb6 Remove two silly typedefs
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19 13:34:43 +02:00
Thorsten Behrens
ad1f0d1f1a o3tl: rename compat_functional header
After the cleanup, the stuff there really stands on its own (and the
remaining usage of select1st/2nd is more descriptive than lambdas).

Change-Id: I0aba131d5dc550189f8130d167dc94167e404540
Reviewed-on: https://gerrit.libreoffice.org/17806
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17 16:38:30 +00:00
Noel Grandin
8cf544cb3a convert Link<> to typed
Change-Id: Ib0bf56a0e642720ff5daafdfc2dc12809be87e43
2015-08-17 09:59:59 +02:00
Noel Grandin
fceee9237c loplugin: defaultparams
Change-Id: I4080aece6fec2778a2a8646ddedd280337303591
2015-08-14 11:09:40 +02:00
Daniel Robertson
87130a4e18 tdf#92459 Cleanup unclear lambdas
Replace lambdas used to select the first/second member of a pair with
the new simplified select1st/2nd from o3tl/compat_functional. There
should be no side effects due to this change.

Change-Id: I17f37796e0c4defe96a10aa491d192adb9eebb89
Reviewed-on: https://gerrit.libreoffice.org/17656
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-11 22:29:12 +00:00
Takeshi Abe
14bead7f42 forms: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: Ia4f56692c9beddda13ee948ab8bbc1ee95098fbf
Reviewed-on: https://gerrit.libreoffice.org/17648
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-11 13:30:17 +00:00
Noel Grandin
2886f830a9 idl,framework,forms: inline some use-once typedefs
Change-Id: Icb4908c274ec0778af7ed9fe2d935bf6723fedfb
2015-08-04 08:55:56 +02:00
Noel Grandin
4eeeec899f convert RGCHK constants to scoped enum
Change-Id: Iafeae0f85f751469900471cf8fccd5f763407890
2015-07-28 08:35:34 +02:00
Noel Grandin
38ecca9b30 inline a bunch of use-once macros
no point in having a macro unless it's actually going to reduce the
number of lines of code

Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
2015-07-27 08:18:16 +02:00
Noel Grandin
efac5fa06e remove some unused defines
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188
Reviewed-on: https://gerrit.libreoffice.org/17332
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-27 06:12:01 +00:00
Noel Grandin
771d9ef3f6 loplugin:unusedmethods forms
Change-Id: I6b7938e948fb1422f83e2175fee5fcabe0a0b83f
2015-07-17 11:07:13 +02:00
Stephan Bergmann
891c80e172 loplugin:simplifybool
Change-Id: I8b704401233fa865c8ec4d4663d720a3d7d8de69
2015-07-16 14:00:17 +02:00
danlrobertson
5a61d7f049 tdf#92459 replace unary_function in forms
Remove all instances of classes that are derived from the now
depreciated unary_function and binary_function with lambda expressions.

Change-Id: Iab662159b8b8554e10dfe6886ee803da78a937ed
Reviewed-on: https://gerrit.libreoffice.org/16631
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-15 23:50:50 +00:00
Noel Grandin
4c5498ec5e fix windows build
Change-Id: I505b7b0e6bf86093fbed1aa7e28b710e12116e6e
2015-07-14 12:37:32 +02:00
Zolnai Tamás
70f152983f tdf#47832: Pictures on buttons, created in forms, gone after reopening form
When image is set to a Button control the correspoding graphic object
lives only temporarily, after the graphic is copied from the graphic
object it's destroyed so save can't find it by graphic ID.
Use the same solution which works for ImageControls: use a graphic object
member for the control, so save can find it.

Change-Id: If99a3efc4727a07df9d2daaefbdacc9565920005
2015-07-14 10:36:17 +02:00
Stephan Bergmann
cbce40e965 Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...to avoid lots of loplugin:staticmethods warnings.  Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.

Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
Noel Grandin
89c77994d4 remove some unnecessary typedefs around uno::Reference
Not very useful these days, since we have the css:: prefix to reduce
verbosity.

Found with a search like:
   git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;'
       | grep -v 'std::'

Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd
Reviewed-on: https://gerrit.libreoffice.org/16730
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06 06:14:15 +00:00
Andrea Gelmini
465489d97a Fix typos
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03 09:43:46 +00:00
Andrea Gelmini
1a8915ef83 Fix typos
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-30 15:57:12 +00:00
Caolán McNamara
5d39063581 coverity#1308583 Uncaught exception
Change-Id: Ibc6a8e437d81769b9a77d0a52e98f71b1c7e7d51
2015-06-29 09:43:35 +01:00
Caolán McNamara
0a4e65219e coverity#1308582 Uncaught exception
Change-Id: Ibe15ebdbdd5c0eb719821043696ce22f76c5b232
2015-06-29 09:43:35 +01:00
Caolán McNamara
265ad0605c coverity#1308542 Uncaught exception
Change-Id: I083d3152c0bb51f72e9f61203a7b3d9c4421a072
2015-06-28 17:56:00 +01:00
Stephan Bergmann
6390d2c52b Get rid of comphelper::string::is*Ascii functions
Change-Id: I99912112e5b009d7a143f9816d757cdf6ebb1783
2015-06-24 15:27:28 +02:00
Stephan Bergmann
bd20422248 Disambiguate needlessly overloaded OGridControlModel::createColumn
Change-Id: Ie12370fbd0b1d5aaacd56d6e21de29b6134d9741
2015-06-19 11:04:15 +02:00
Andrea Gelmini
ae150c6a54 Fix typos
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18 11:44:56 +00:00
Stephan Bergmann
8e1ad96626 Some missing SolarMutexGuard around VclPtr acquire/release
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so
apparently rely on the SolarMutex being locked whenever they are called.  Fixed
those places that caused "make check" to fail for me when temporarily adding
DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release.  (A recurring pattern is
that a class fails to ensure the SolarMutex is locked around the destruction of
non-null VclPtr members.)

Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
2015-06-17 15:24:19 +02:00
Andrea Gelmini
3fa7b0b70f Fix typos
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e
Reviewed-on: https://gerrit.libreoffice.org/16310
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:25:13 +00:00
Andrea Gelmini
ca9de688c2 Fix typos
Change-Id: I549635318f46718042e50c8f89ce3c620cade990
Reviewed-on: https://gerrit.libreoffice.org/16281
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:10:51 +00:00
Andrea Gelmini
01532b1ab8 Fix typos
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072
Reviewed-on: https://gerrit.libreoffice.org/16297
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:05:58 +00:00
Noel Grandin
4729774b24 remove unnecessary check for null when calling delete
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
Caolán McNamara
8d8f264f57 cppcheck: passedByValue
Change-Id: I444c40340bcfd64f88dac34da6cc858f66996fe6
2015-06-15 11:11:43 +01:00
Stephan Bergmann
885bf7c68c loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I1d24939c085ee0751de00124d2a90de1270dbd22
2015-06-08 16:25:15 +02:00
Noel Grandin
d33c6cd785 fix Windows build
after my commit 55bc128636
"loplugin:loopvartoosmall"

Change-Id: I1d43447df24d7bf5c8737801389447980bb69d26
2015-06-01 10:19:15 +02:00