Commit Graph

2710 Commits

Author SHA1 Message Date
Matúš Kukan
39c4b2787e forms: Replace these macros
Change-Id: I656905cf6f0e3647824ff3836fcea93920251264
2015-03-28 11:52:41 +01:00
Matúš Kukan
a9535fe984 forms: More unused services related stuff
Change-Id: I3be9b1a57971286441d78e03130d0467ea2cc838
2015-03-28 11:52:40 +01:00
Stephan Bergmann
0b1d8eff97 const_cast: convert some C-style casts and remove some redundant ones
Change-Id: I4293d3e9244bb2ae3c6b8999c0d682e7f23138fb
2015-03-26 15:33:30 +01:00
Noel Grandin
9110d8724d convert EE_STAT constants to enum class
Change-Id: I2967cdbfd0303844892150bbff7aa5ce1a57054f
2015-03-25 09:47:29 +02:00
Noel Grandin
c7c0723dd9 convert EV_CNTRL constants to enum class
Change-Id: I0ffc0e222c978ce7c734228f712e88422d3a615f
2015-03-25 08:56:15 +02:00
Noel Grandin
abf60c4a0f convert EE_CNTRL constants to enum class
there were a couple of lines in SC and SW where the code was using a
EV_CNTRL constant. I switched it to used the same-valued constant from
EE_CNTRL

Change-Id: I027183cc3b6e700bf365d48833e37eddc9b50f04
2015-03-25 08:56:14 +02:00
Noel Grandin
d772b9bdc4 loplugin:constantfunction: forms
Change-Id: Icb1b4bb3fd73b54378b77fbaa6c41c3a0f03706a
2015-03-24 10:31:18 +02:00
Noel Grandin
fb14be5f8f create new 'enum class' SotClipboardFormatId to unify types
of which there are several.

There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
  Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
   numeric values to the underlying code, but perhaps further fixing is necessary?

Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-03-18 14:23:50 +02:00
Stephan Bergmann
3099c70b11 Fix various XServiceInfo implementations
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
Noel Grandin
82c3745348 SfxItemHandle is only used in one place, so inline it
Change-Id: Ie54e0699312b6c072d2b162a068cffdf960be4d0
2015-03-11 10:16:52 +02:00
Caolán McNamara
567f511924 V801: Decreased performance
Change-Id: I97c7977fdfea57b5d1c45ce0c5902b74cc719db9
2015-03-06 17:08:55 +00:00
Tobias Madl
8f9b0c8692 Idle: Changed to new enum name
Change-Id: Id3852abe9bc7bbe774331a7d691abd2a79ff59b4
2015-03-06 12:27:10 +00:00
Tobias Madl
2d95bc0510 Idle: Removed VCL_IDLE_PRIORITY_ prefix of enum
Change-Id: I12290bed7e4f298ab90393b8de6e2b6e7061e53f
2015-03-06 12:27:09 +00:00
Tobias Madl
826143684d Timer: Adapted all idle includes and enum uses
Change-Id: Id4ef36d6c80ad62306bdbaa7094c2cb0b8ff77da
2015-03-06 12:27:05 +00:00
Noel Grandin
a3646d5572 cppcheck: duplicate inherited member
Change-Id: Iee20ca4523739eb082ea1fa8c1145891c0caed29
2015-03-02 10:25:49 +02:00
Stephan Bergmann
fa6c09877e Fix OFormattedFieldWrapper[_ForcedFormatted] instance creation
broken with 5d05f7ed85 "forms: use constructor
feature for form modules" and follow-up misguided clean up

Change-Id: If9447740e6408472722b81d112cd85349020eabe
2015-02-27 13:25:42 +01:00
Caolán McNamara
186dbb6890 callcatcher: update unused code
Change-Id: If6e0cbf8544ca7a4668cdc67fcf390d8835b7017
2015-02-19 09:55:18 +00:00
Jan Holesovsky
e46549e955 forms: Fix copy'n'paste mistakes.
com_sun_star_form_ORadioButtonModel_get_implementation ->
  com_sun_star_form_ORadioButtonControl_get_implementation

com_sun_star_form_OGroupBoxModel_get_implementation ->
  com_sun_star_form_OGroupBoxControl_get_implementation

and a bit of further cleanup.

Change-Id: I2d03d69ac83c482257baed5a6b84a6bacae68889
2015-02-17 12:05:47 +01:00
Jan Holesovsky
5c3d918062 forms: Convert also com.sun.star.form.XForms.
Plus some associated cleanup.

Change-Id: I0a923198c23e2e4ecbc91e5b56cfac31b7f71256
2015-02-17 11:34:20 +01:00
Chris Sherlock
5d05f7ed85 forms: use constructor feature for form modules
Change-Id: I8f1588cbd338e2f8b5bc6047d84b17c697a7d2d3
2015-02-17 11:34:20 +01:00
Stephan Bergmann
c27ab70f26 GenerateHeader(false) -> SetHeaderGenerated()
Change-Id: I41f06c92589e6b1839e39d840a479f1a184b47dd
2015-02-11 17:09:09 +01:00
Miklos Vajna
a11c71f7f1 forms: use constructor feature for ODatabaseForm
Change-Id: I1f36b28c3d71b90e439c6ba86bba09cf55bc43ae
2015-02-09 08:09:25 +01:00
Miklos Vajna
73076f5e9a forms: use constructor feature for OFormsCollection
Change-Id: Ifdc031480617ec4d0a50ae5b6cd6a2c838ae076a
2015-02-09 08:09:25 +01:00
Stephan Bergmann
73e117d19a loplugin:deletedspecial
Change-Id: Ic3b744fe3eb3a07d7f5a7feeaf43cde2ec2b3241
2015-02-07 12:35:59 +01:00
Caolán McNamara
76e372ccd9 coverity#704645 Dereference after null check
Change-Id: Id6930c8e87f27051520e10e1277d769d0b380374
2015-01-30 21:15:31 +00:00
Caolán McNamara
05abd8b205 chisel off some more unused code
Change-Id: I62cafc8e10e9c9dab3fde1785b826ba8ff68569f
2015-01-30 12:44:36 +00:00
Noel Grandin
f61dbc3029 followup code removal after changing virtual methods to non-virtual
This cleanups up indentation and removes dead classes.

This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"

Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26 08:42:29 +02:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
Stephan Bergmann
3ad6e328a7 Some more loplugin:cstylecast: forms
Change-Id: I39325fccdadcc57df32fe5821eef0d8477018b59
2015-01-20 09:06:47 +01:00
Stephan Bergmann
4efa9604cf Revert "ListBox: refuse to give values before we are loaded"
This reverts commit 1cc29a04ad, as it caused
JunitTest_forms_unoapi trigger the

  assert( m_nConvertedBoundValuesType == getValueType())

at forms/source/component/ListBox.cxx:1189.
2015-01-14 08:35:33 +01:00
Noel Grandin
c32a5a3b8e simplify Date/Time/DateTime conversion code
add constructors to Date/DateTime/Time,
that take the css::util counterparts,
to simplify code converting between these type

Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7
Reviewed-on: https://gerrit.libreoffice.org/13855
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2015-01-13 15:24:04 +00:00
Stephan Bergmann
7ca657e5ee css.form.component.{CheckBox,RadioButton} DefaultState property values
...must be in the range 0--2; avoid setting bad values from generic qadevOOo
property set tests, and throw an IllegalArgumentException if bad values do
get set.

Change-Id: Ia4a97d0fac326b3ca2ce254946dc4d418e9dd5a7
2015-01-13 15:17:18 +01:00
Lionel Elie Mamane
0331fa6a90 ListBox with value list: consider first empty value as NULL
Change-Id: I15c040b481b7f03720d0227ba5d2fcd2ccc78386
2015-01-13 14:59:04 +01:00
Lionel Elie Mamane
1cc29a04ad ListBox: refuse to give values before we are loaded
If we are not loaded,
we don't know our field type,
so cannot give values with the right type

Change-Id: I372b77647ec8ff7428b67cca72fdd89e5e147a32
2015-01-13 14:59:03 +01:00
Lionel Elie Mamane
5cd4ab7f5c janitorial
Change-Id: If0fcad97538556ef7be5fe5f8405ca171696502d
2015-01-13 14:59:03 +01:00
Michael Stahl
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
Noel Grandin
45ec1d9b56 brute-force find-and-remove of unused #define constants.
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
Noel Grandin
7f8f277b94 fdo#84938: convert STREAM_ #defines to 'enum class'
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07 11:20:44 +02:00
Noel Grandin
54942f0d09 spelling: attachement -> attachment
Change-Id: I1bb1ad04adec864b594d96711f85b8fcdc1d1ef2
2015-01-05 12:57:18 +02:00
Caolán McNamara
fd1372ba8b boost::unordered_map->std::unordered_map
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
Stephan Bergmann
9e3ced1956 forms: Use appropriate OUString functions on string constants
Change-Id: I1bcd815663c29025da6b3ce50bdf767eef74fe94
2014-12-18 14:12:26 +01:00
Michael Weghorn
afb5143639 fdo#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: I1d037e87c69b1a7de019f1abf1f729bf7e28d762
Reviewed-on: https://gerrit.libreoffice.org/13494
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-17 07:31:17 +00:00
Stephan Bergmann
0c1b8516cb forms: Use appropriate OUString functions on string constants
Change-Id: I196e847e2f63d1bac6ed0f520cba67508aec1a5d
2014-12-15 10:12:09 +01:00
Tobias Madl
ea6399b837 changed timers to idles
Change-Id: Ic0d7730f7880dfe2e83c84e773b8cc420249b269
2014-12-09 12:34:57 +00:00
Tobias Madl
14596452e7 fdo#84938: replace EVENT_ constants with enum
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f
Reviewed-on: https://gerrit.libreoffice.org/13134
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-01 07:43:31 +00:00
Matúš Kukan
09186fceb0 unotools: Internalize ucblockbytes.hxx header
Change-Id: I1a9b795eda832673a83a426c8bf10d5bb9c28581
2014-11-24 23:14:54 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Caolán McNamara
275eb9c78e coverity#706540 Uncaught exception
Change-Id: I9dabd74824ec7cffe5371ed8be202ad27fecc80d
2014-11-14 12:02:47 +00:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14 09:20:38 +01:00