Caolán McNamara
117fc49c97
ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivatives
...
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2
Reviewed-on: https://gerrit.libreoffice.org/30344
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2016-10-28 09:08:50 +00:00
Stephan Bergmann
c0b3531919
Use SAL_DLLPRIVATE instead of extra TUBES_DLLPRIVATE
...
Change-Id: I188bf325e6eb6db0250a58d9354860733950e887
2016-10-28 08:52:47 +02:00
Stephan Bergmann
f479e6878e
Move internal include files from include/tubes/ to tubes/source/
...
Change-Id: I2fa9334721c203d4d977f0638a9030e8e74efc06
2016-10-28 08:52:46 +02:00
Stephan Bergmann
97c28ad74f
Various loplugin warnings in --enable-telepathy
...
Change-Id: I4c437491466c3029f2a9c93fb630c7b5a8d2ff21
2016-10-28 08:52:46 +02:00
Maxim Monastirsky
89c23b4aae
Sub menus no longer need manual disposing
...
after:
commit ee79a2dd7e
Author: Caolán McNamara <caolanm@redhat.com >
Date: Fri Jul 29 14:33:22 2016 +0100
Resolves: tdf#101169 crash using column menu in base
Change-Id: I7c6e54dd5574c61cffd5884d1cf1b63075073001
Reviewed-on: https://gerrit.libreoffice.org/30343
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com >
2016-10-27 22:11:07 +00:00
Stephan Bergmann
d4398c7767
Remove bogus comments about ~IPropertyArrayHelper not being virtual
...
...which isn't true at least ever since b525a3115f
"initial import", but got copy/pasted all over the place
Change-Id: I47d3d8a594aef3ac3736d7176ae964a118821014
2016-10-27 17:08:09 +02:00
Noel Grandin
337e19bf46
loplugin:expandablemethods in sfx2
...
Change-Id: I5dcc9e6e7fef210f85a01057ddf59f8de14b847d
Reviewed-on: https://gerrit.libreoffice.org/30320
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-27 12:43:46 +00:00
Noel Grandin
7da765dde1
loplugin:expandablemethods in svtools
...
Change-Id: I126cc87c890867c3e762f86969a20d64aef63108
Reviewed-on: https://gerrit.libreoffice.org/30314
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-27 10:23:35 +00:00
Noel Grandin
c19d2b276b
loplugin:expandablemethods in stoc..svl
...
Change-Id: I7dd701ef07a14f70589b87154bfeeda7530b628f
Reviewed-on: https://gerrit.libreoffice.org/30316
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-27 10:16:08 +00:00
Noel Grandin
883172375d
loplugin:expandablemethods in svx
...
Change-Id: I0d193ddf07cc0ddc89b6ce2df6eb71d44e49b631
Reviewed-on: https://gerrit.libreoffice.org/30295
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-27 06:09:29 +00:00
Noel Grandin
eca5ea9f79
make the AbstractDialog stuff extend from VclReferenceBase
...
Because some stuff wants to multiple-inherit from VclAbstractDialog and
OutputDevice-subclasses, and we'd prefer to keep all the lifetime
management through a single smart pointer class (VclPtr)
The change in msgbox.cxx and window.cxx is to workaround a bug in
VS2013 to do with virtual inheritance and delegating constructors.
Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773
Reviewed-on: https://gerrit.libreoffice.org/29140
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-27 06:08:30 +00:00
Caolán McNamara
0d3e45608a
SfxSlotInfo is unused
...
Change-Id: I8d5438ca338868c77dcf489609a4e007cfe925fd
Reviewed-on: https://gerrit.libreoffice.org/30290
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2016-10-26 12:44:31 +00:00
Miklos Vajna
36c4fd5c33
svl: the compiler can generate the same SfxGrabBagItem copy ctor itself
...
Change-Id: I54f94e8ec710ca117ecdf33ebe97a0e5f07c59ec
Reviewed-on: https://gerrit.libreoffice.org/30283
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Jenkins <ci@libreoffice.org >
2016-10-26 11:21:04 +00:00
Caolán McNamara
8efdf567de
drop now unused SfxStyleItem, etc.
...
Change-Id: I61227079c376299d17250970b19acb0c415034fb
2016-10-26 12:02:40 +01:00
Caolán McNamara
c14b9d036a
assemble SfxStyleFamilies from more generic resource components
...
Change-Id: I25aa0d8bca1f16f5fc27d3b299709479a1635ea3
2016-10-26 12:02:40 +01:00
Caolán McNamara
0b4be27b14
try and silence coverity#1374267 Out-of-bounds access
...
Change-Id: Ib7a8866dc4acdc243e7bfa975e760afde3bb43a6
2016-10-26 09:56:30 +01:00
Caolán McNamara
ae68c27457
coverity#1374269 Uncaught exception
...
Change-Id: Ib3a876ea6463396784062bd53bfedff177818498
2016-10-26 09:56:30 +01:00
Takeshi Abe
c498c97f74
The default std::less<sal_uInt16> is fine
...
Change-Id: I29cd62ef0b687613ed9bda5170511dcae2fc6e7e
Reviewed-on: https://gerrit.libreoffice.org/30282
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp >
2016-10-26 08:39:09 +00:00
Jochen Nitschke
20f2a6b3f7
untangle .cxx include in itemset.cxx
...
Change-Id: I0102ad82d82c8f0e9f8939512bae83424613c54e
Reviewed-on: https://gerrit.libreoffice.org/30281
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-26 06:59:32 +00:00
Noel Grandin
e5c1e15eda
loplugin:expandablemethods in toolkit..tools
...
Change-Id: I7221bf131d28804ee93474b11973bbc066cc2764
Reviewed-on: https://gerrit.libreoffice.org/30268
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-26 06:50:03 +00:00
Noel Grandin
47317f0416
loplugin:expandablemethods in ucb..ucbhelper
...
Change-Id: I42d077d7ebcfb77447d011644f8d64e80eae69c2
Reviewed-on: https://gerrit.libreoffice.org/30266
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-26 06:49:46 +00:00
Noel Grandin
fe1f1247fa
loplugin:expandablemethods in vcl
...
Change-Id: I1876e203d3a3a5fa36d83a9b282ba49429c1da2a
Reviewed-on: https://gerrit.libreoffice.org/30261
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-26 06:49:31 +00:00
Caolán McNamara
45a646f2fa
split the creation of SfxStyleFamilies into a method
...
Change-Id: I2590180fc30d75c89e758c72246a8294b5c4b9a2
2016-10-25 15:39:47 +01:00
Caolán McNamara
e83d0d9b3b
we don't need to update the style icons anymore
...
once this was a dialog but now its a panel and the case of a the document under
the dialog changing type isn't an issue anymore
Change-Id: I4680cf238675161c533852d843508a19c74a9073
2016-10-25 14:06:12 +01:00
Noel Grandin
c5498c310f
loplugin:expandablemethods in UnoControls..vbahelper
...
Change-Id: I7e607df2a1f6d4eb207ee0d3eb30f41fac44a0c6
Reviewed-on: https://gerrit.libreoffice.org/30262
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-25 11:16:02 +00:00
Caolán McNamara
cdd3963a3a
no RSWND anymore
...
Change-Id: I5547a0d19ae60ea06dd666c77deaf0de910975d0
2016-10-25 11:41:23 +01:00
Caolán McNamara
00c4595646
no WindowResHeader, no RscWindowFlags
...
Change-Id: Id41e9414237c849c211785151e9170c71a449238
2016-10-25 11:41:23 +01:00
Caolán McNamara
2b6abbaa24
can drop RSC_WINDOW now
...
Change-Id: Ic60b35eb78ebd3e934cbf45c2184edf59c971a53
2016-10-25 11:41:23 +01:00
Caolán McNamara
f615d6195a
can drop RSC_CONTROL now
...
Change-Id: I651b9d2ead019507b8e48c4e19797bf8f8b9a438
2016-10-25 11:41:23 +01:00
Caolán McNamara
d1bea6be4f
no Control loaded from .src now
...
Change-Id: I25af1187f7888ad3f8d7078e3b59d3e4a09b8ab5
2016-10-25 11:41:23 +01:00
Caolán McNamara
3c0bfd4271
drop HID_CTRL_CUSTOMPROPS_YES_NO that does nowhere
...
Change-Id: Ibf64359936ea224dc7342585b99691f88630c6ca
2016-10-25 11:41:23 +01:00
Caolán McNamara
c445e1d678
no need for ResId here now
...
Change-Id: I2b9ec5e587724550ea8b78f023f18b6ec65d7f75
2016-10-25 11:41:23 +01:00
Caolán McNamara
56c71eb5bc
remove now unused ImplLoadRes methods
...
Change-Id: I8ff86fa847a74d48ccd06e8945beac9cf5653ab9
2016-10-25 11:41:23 +01:00
Caolán McNamara
c1448b4286
no raw Window is loaded from .src anymore
...
Change-Id: I81e4bb23f4a819f59115cdf58afe19097b4ce68f
2016-10-25 11:41:23 +01:00
Caolán McNamara
141a7aa1b3
SvTreeListBox cannot be loaded from .src now
...
Change-Id: I80090f4daf9b7f224392a76449a87ab6aa6b7d05
2016-10-25 11:41:23 +01:00
Caolán McNamara
3c4f6b7804
no FixedText loaded from .src now
...
Change-Id: Ic377c5238e1763a2defdce72bbe893e826aae5ac
2016-10-25 11:41:23 +01:00
Caolán McNamara
dcd099d335
nothing uses RSC_BUTTON anymore now
...
Change-Id: I016d1507fcadf5da1207241c6feec1a03188eef7
2016-10-25 11:41:23 +01:00
Caolán McNamara
cd6e8837c1
no PushButton loaded from .src now
...
Change-Id: Ib866107995ab0496cf4f37a5e780458031d2fc25
2016-10-25 11:41:23 +01:00
Caolán McNamara
f23297e111
no Edit controls loaded from .src now
...
Change-Id: I42c7377c101c642ea39028e05e4ffd58fc7435d7
2016-10-25 11:41:23 +01:00
Caolán McNamara
30a458d7e1
no ListBox loaded from .src now
...
Change-Id: I7d30c38777f6a36c991271a3617d3f75c83cd490
2016-10-25 11:41:23 +01:00
Tamás Zolnai
f7c61b08d5
tdf#103389: Resaving a DOCX document with two canvases leads to a broken file.
...
Make custom shape export more robust. In case of the test
document, WriteCustomGeometry is called, but this call
does not export anything, and so we get a shape without
any geometry in the DOCX file, which causes problem to MS Word.
Change-Id: Ie7a4e2b8a18bfddaeeb81425ae5f1de04140d43f
Reviewed-on: https://gerrit.libreoffice.org/30241
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com >
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com >
2016-10-25 00:37:25 +00:00
Caolán McNamara
eac3793d4d
no FixedImage is loaded from .src anymore
...
Change-Id: I7c5acd18b14822d6344af3709c6d8cfb343104ef
2016-10-24 15:06:41 +01:00
Caolán McNamara
602274c77f
no ImageButton loaded from .src now
...
Change-Id: If6f6718e1e6d756b99a499deafa4310c76a75ad3
2016-10-24 13:04:38 +01:00
Caolán McNamara
6f66029388
implement VclVPaned and decripple formula panel
...
Change-Id: If87e481a5cf0ef34b469ac0440643b0a0e8a296c
2016-10-24 13:04:38 +01:00
Noel Grandin
a41ecf9227
loplugin:expandablemethods in xmloff
...
Change-Id: I995a4167ac4df5ca35d963dcf68ae802a997e1e1
2016-10-24 13:35:36 +02:00
Yousuf Philips
967436ba7c
tdf#103259 Add java not found error for mac
...
Change-Id: Ia52316b8868c8124dcb322b44e9600a33a13df28
Reviewed-on: https://gerrit.libreoffice.org/29920
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com >
2016-10-24 08:41:58 +00:00
Tomaž Vajngerl
21e8ed8b5f
tdf#103395 opencl: don't initialize OpenCL when disabled
...
If SAL_DISABLE_OPENCL is set we don't want to do any kind of
OpenCL initialization. Put an extra guard in fillOpenCLInfo
(and similar methods in opencl package) to prevent that.
Put the check if OpenCL can be used into one place which checks
SAL_DISABLE_OPENCL and UseOpenCL in configuration.
Change-Id: Icc216d4299d3a7942843117ab9b9411de8075b11
Reviewed-on: https://gerrit.libreoffice.org/30025
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com >
2016-10-24 08:35:15 +00:00
Noel Grandin
6f428c38c5
remove unused SfxListener subclassing
...
where the Notify method is doing nothing
Change-Id: I834aa40a9bcb0dd8d7335a5688acc5da6f40b0a2
2016-10-24 08:21:28 +02:00
Andrea Gelmini
525311b0d6
Fix typos
...
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4
Reviewed-on: https://gerrit.libreoffice.org/30040
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: jan iversen <jani@documentfoundation.org >
Tested-by: jan iversen <jani@documentfoundation.org >
2016-10-23 17:17:01 +00:00
Noel Grandin
e4cb0742c8
loplugin:expandablemethodds in include/connectivity..drawinglayer
...
Change-Id: Ic58f86422ef8f1e2bb655157850e214fc3a1a9b4
Reviewed-on: https://gerrit.libreoffice.org/30136
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-23 12:09:33 +00:00