Commit Graph

10315 Commits

Author SHA1 Message Date
Marco Cecchetti
6c9337866d LOK: Calc: missing invalidate when ending larger-than-cell edit text
- reason: when text content goes further than the cell border the
output area of the edit view is grown (extended to an adjacent cell),
on the contrary the output area of edit views used only for
invalidating windows of other view shells is never updated, so, in
other views, only the tile where the edit cell is placed is
invalidated;

- solution: instead of adding fake edit views for invalidation porpuse
(and having to updated the output area of each of them when required),
the new solution provides each new edit view, created on cell editing,
with a set of `foreign` windows related to other views, they are added
and removed to this collection owned by an edit view still using the
ScExtraEditViewManager, which has been in turn simplified; when
EdiEngine::UpdateViews is invoked not only the window where the edit
view lives is invalidated but also all `foreign` windows in the owned
set;

- note: ScTiledRenderingTest::testTextEditViewInvalidations unit test
has been enhanced in order to test correct invalidation when text
content goes out of the starting tile.

Change-Id: Id223fb1a032d3b18d2cf70df31f704abd245b3ac
Reviewed-on: https://gerrit.libreoffice.org/29625
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/29658
2016-10-14 15:01:36 +00:00
Noel Grandin
11570275c6 convert LOCK_UI constants to scoped enum
Change-Id: Ie8a8702124ba86feda17c4371e66c3997ba3557c
2016-10-14 12:53:01 +02:00
Armin Le Grand
a1b7231a33 profilesafe: Adapted to UI
Adaptions to UI, added more modes what the user
can do in SafeMode. Adapted locations to write
pack information and added places where to enter
SafeMode. Implemented basically all five
possible user choices

Change-Id: Ic5324a8f77ab434309e840949c3803e65a75c538
Reviewed-on: https://gerrit.libreoffice.org/29785
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-14 10:37:30 +00:00
Noel Grandin
0927bdaf6e loplugin:mergeclasses merge SvxListBoxControl with SvxUndoRedoControl
Change-Id: I5ba9c9d970246d80bb60e27e3b703ec03376c35c
2016-10-14 08:17:50 +02:00
Samuel Mehrbrodt
0cd2250b7c Add IsExperimental method to CommandInfoProvider
Change-Id: I827ae6db25a1df9f25b58ca122e39dc9cb4b0652
2016-10-13 21:53:06 +02:00
Armin Le Grand
5f55b7d00a profilesafe: extended to three modes
Saving configuration is now extended to three
basic modes, from just saving registrymodifiications
to adding user-defined config stuff to saving all
information in the user profile, additionally
configuration information for Extensions is saved.
Added configuration entries for this and tested
saving/restoring.

Change-Id: I79b09c37617803bf656826f76a7e3db79cda49ac
Reviewed-on: https://gerrit.libreoffice.org/29770
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-13 14:43:37 +00:00
Noel Grandin
a7e395f397 loplugin:mergeclasses ImplEESdrWriter with ImplEscherExSdr
Change-Id: Iea2241d9fc44b92e18101b3f367a643f03729183
2016-10-13 13:31:28 +02:00
Noel Grandin
17ec3b96de pass params to Outliner LINK callbacks on stack
instead of yuck..cough... on itself, which is horribly vulnerable to re-
entrancy

Change-Id: I8f3d6d39ee50fd36b56b431978cf6c2499c375a6
Reviewed-on: https://gerrit.libreoffice.org/29756
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13 11:16:13 +00:00
Caolán McNamara
06609e714f drop unused SID_UNKNOWN resource
Change-Id: Ib12078ec72a61b44339799053cc43a53ba82bba3
2016-10-13 10:36:01 +01:00
Caolán McNamara
15f5fdef97 move this monstrosity to the last place its used
Change-Id: I4691f20143406249afc8da1a6dfa901224f4a62d
2016-10-13 09:36:51 +01:00
Maxim Monastirsky
9125a4f3f6 Use FeatureStateEvent directly for status updates
... for SfxPopupWindow and SvxColorToolBoxControl (the
latter shares BorderColorStatus with SvxColorWindow_Impl,
so it was easier to convert it too).

Change-Id: Ifcb23fe5809e467322d1cf4d790420886ac79b47
2016-10-13 11:12:27 +03:00
Maxim Monastirsky
a7a048f9a2 SvxColorToolBoxControl: Some cleanup
Change-Id: Iaf908b0c2456a239e343d0fcb89a2ba163b74010
2016-10-13 11:12:27 +03:00
Maxim Monastirsky
670dc75150 SvxColorToolBoxControl: Unify members prefix
and rename bSidebarType to something more sensible.

Change-Id: Ia41afe4ecc3068394cb41cc4c3caddce59905103
2016-10-13 11:12:27 +03:00
Noel Grandin
8fce16fb57 convert SvxPageUsage to scoped enum
and expand out the bit-tricks some of the code was playing to make it
more obvious what is going on

Change-Id: I9c98334393b939b1d900425f6133556ce88247ae
Reviewed-on: https://gerrit.libreoffice.org/29734
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13 06:54:23 +00:00
Noel Grandin
62223f9a8a loplugin:unnecessaryoverride
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae
Reviewed-on: https://gerrit.libreoffice.org/29656
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13 06:47:44 +00:00
Caolán McNamara
7f5d27a7a7 no Browse is loaded from .src anymore
Change-Id: I72e87433fef1a27c6bcac2746d9d366335797800
2016-10-12 16:25:12 +01:00
Caolán McNamara
f9a0f120a0 no EditBrowseBox is loaded from .src anymore
Change-Id: I70c4cfa85a4a4379ee80e73066193676ca83b5b0
2016-10-12 16:16:19 +01:00
Miklos Vajna
53bba96ac0 xmlsecurity: add initial Executable_pdfverify
We have code to verify ODF and OOXML signatures, this adds initial
support for verifying a PDF signature.

Initially this is a standalone executable, need to turn this into a unit
test + hook it into sfx2 in follow-up commits.

Change-Id: Ideb5ec63f761c74fd4527cf1766b0aa739e275ee
2016-10-12 16:50:31 +02:00
Caolán McNamara
d1a6aea1da de-src empty panel placeholder widgetry
Change-Id: I99a292cd76f40159f12cb98b362559e4109121c3
2016-10-12 15:23:37 +01:00
Armin Le Grand
5f1a338d54 profilesafe: Multiple adaptions
Added own directory in User config to where the
saved content is written and taken from, adapted
to also handle ExtensionConfiguration, changed
point for creating backups of configuration to
doShutdown, create no configuration when a restart
is triggered (untested configuration)

Change-Id: Id7a96195b765842c31cacf81cc08d2965a205281
Reviewed-on: https://gerrit.libreoffice.org/29729
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-12 14:08:55 +00:00
Stephan Bergmann
802f2a4208 Don't allow O[U]StringBuffer in string concatenation
...as

  OStringBuffer b("foo"); b = "bar" + b;

doesn't work as one might expect (see the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2016-October/075464.html>
"concat of OUStringBuffer".  That feature was LIBO_INTERNAL_ONLY, anyway.  And
of the affected places, MethodDescriptor::getSignature
(codemaker/source/javamaker/javatype.cxx) was the only one that would actually
have benefitted.

Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff
2016-10-12 16:05:32 +02:00
Caolán McNamara
ad067cb0c7 remove StringListResource in favour of ResStringArray...
and turn local resources used as lists of strings into
string array resources

Change-Id: I9d67a790659963bca87aacba1c052d7b244b4e21
2016-10-12 14:03:00 +01:00
Caolán McNamara
1606171e91 rearrange CustomPropertiesTypeBox
Change-Id: Ib30389f7ddf0a85d03b519b586bacf45b3c8adc7
2016-10-12 12:56:36 +01:00
Caolán McNamara
e6a05e9f32 annoyings inlines
Change-Id: I0823b29ac99b99b9e9cd8b402e4de71ac176d784
2016-10-12 12:56:36 +01:00
Caolán McNamara
637587fc8f drop unused argument
Change-Id: I54a86f98289877abc435e2c7397ff5fd6c516545
2016-10-12 11:38:00 +01:00
Caolán McNamara
3abc986877 GetAutoHelpId logically can only return an empty string now
Change-Id: Ie7368f083a5aa6bcfb249375fbae1f4cd92e02ba
2016-10-12 11:38:00 +01:00
Caolán McNamara
540b7d3ae4 drop RSC_DOCKINGWINDOW*
Change-Id: Ibcddc2def40e15f4a2f92fec13c1c3fd2f824d68
2016-10-12 11:38:00 +01:00
Caolán McNamara
7091666cb9 DockingWindow ResId code needed only by removed ToolBar src support
Change-Id: Ib0dff4b569ac1b95a59b618258036ecf3d2c4e73
2016-10-12 11:38:00 +01:00
Caolán McNamara
c3c008f360 drop unused defines and enums
Change-Id: Ifc81443047380221a7329be5b6b094ee8bc76451
2016-10-12 11:38:00 +01:00
Caolán McNamara
4cc4df51d9 no toolboxes are loaded from .src anymore
Change-Id: Ia2eabf157845b9b6b00b745332a558ffdd1e0ec7
2016-10-12 11:38:00 +01:00
Samuel Mehrbrodt
a1261b63f2 Safemode: Add doxygen documentation
Change-Id: Ic5a7f5dfcefe66c961c9b71e9dbdfefeb9f06825
2016-10-12 12:33:11 +02:00
Samuel Mehrbrodt
b3b9ae6c6f safemode: Add flag to indicate safemode
Change-Id: Ifdbb291715b033eaace159297eac5348530e9f36
2016-10-12 12:33:11 +02:00
Jochen Nitschke
41683b9a85 use more 'nullptr' in SvRef templates
Change-Id: Idfe140863b7ec51230110d942c5732e18f411192
Reviewed-on: https://gerrit.libreoffice.org/29701
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12 06:38:11 +00:00
Armin Le Grand
35ec8253ad profilesafe: Add values for SecureUserConfig
Added default values for SecureUserConfig values
to soffice.ini/rc which enable the mechanism,
enable by default and set a maximum of three backups
file in packed form. Added more handy flag for easy
decision to add compressed/uncompressed.

Change-Id: I5a624c09fec4e4278314e13fc5f693ac085d5e61
2016-10-11 13:56:22 +02:00
Armin Le Grand
7db23b6346 profilesafe: Collect copies in single *.pack file
Enhanced helper classes for BackupFileHelper to
allow writing a stack of rescued last valid
configuration files to a single file package.
Added configuration values for enabling this and
defining the number of entries, added max entry
limitation. Using FileSize and CRC32 now to dectect
if config file did change. To make this work I added
sorting to writing the configuration so that with no
change the same configuration file is written.
Use std::vector for better mem performance for sorting,
defined static const for buffer size of manipulation,
prepare inflate/deflate usages. Fixes to setPos, warnings

Change-Id: Ib286e2a3f25b0085a1e3ae4f50c9ff1ff3a5dcf5
2016-10-11 13:56:22 +02:00
Armin Le Grand
9fa4eff9be profilesafe: Enhancements to BackupFileHelper
Added helper class to allow easy creation/deployment
of backups of a file. It works like a 'stack' of backups,
supports easy add/remove/delete of last entry (LIFO).
Added some work top allow opening dialogs in DeInit
under linux.

Change-Id: Idacec97ec2f097af9bd22a8a67b410c7677d17f1
2016-10-11 13:56:22 +02:00
Armin Le Grand
ed646dc595 profilesafe: Initial creation of BackupFileHelper
Added helper class to allow easy creation/deployment
of backups of a file (here: registrymodifications). It
works like a 'stack' of backups, supports easy push/pop
of backed-up versions.

Change-Id: Ie19e1209534f23a3dbd6106a5ca13b24b8fefe4d
2016-10-11 13:56:22 +02:00
Noel Grandin
52dfb06b19 loplugin:unnecessaryoverride in sfx2
Change-Id: I9097a5cfb861e6659a5d9ae10f9c45f2edcae2ec
Reviewed-on: https://gerrit.libreoffice.org/29686
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11 08:42:49 +00:00
Stephan Bergmann
6cded5c853 Demonstrate that SvRef ==/!= are acceptable as member functions
Change-Id: I30771393bc16f2320cd89f018ff93c756913b70d
2016-10-11 08:52:41 +02:00
Noel Grandin
5c84f40ea2 loplugin:constantfunction
update the plugin similarly to
    commit 3ee3b36ae0
    Author: Stephan Bergmann <sbergman@redhat.com>
    Date:   Fri Oct 7 12:05:49 2016 +0200
    loplugin:staticmethods: Don't be fooled by decls starting with macros

Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510
Reviewed-on: https://gerrit.libreoffice.org/29665
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11 06:15:21 +00:00
Noel Grandin
90a0e59737 loplugin:unnnecessaryoverride in svtools
Change-Id: I49773d9054205c223744495768e1cb05dd7b087d
Reviewed-on: https://gerrit.libreoffice.org/29671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11 06:08:29 +00:00
Gulsah Kose
e2f6c7f0d0 tdf#101390 Add "Dimesion Line" command to the writer arrowsbox.
Change-Id: I238bc37871c029d547b21ce7c8ef3cb0c0ff95b8
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/29669
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-10 23:07:35 +00:00
Maxim Monastirsky
9079d599ba Merge SystemWindow and FloatingWindow setPosSizeOnContainee methods
This reverts commit 95942b16f4
("Resolves: tdf#90481 fix cropped buttons"), and changes the
code in a way that seems to not crop buttons anymore. Tested
under gtk3 with File > Digital Signatures... and the toolbar
underline dropdown.

Change-Id: Idcb680c82f594f630b1dd7c76c42912e6b5a093a
2016-10-11 00:07:12 +03:00
Samuel Mehrbrodt
ae94c223e2 safemode: Add uno command and menu entry
Change-Id: I1843767160b79041c42e506eff0cf39399c74f26
Reviewed-on: https://gerrit.libreoffice.org/29668
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-10 18:30:57 +00:00
Caolán McNamara
d1e02bd3c6 de-src another standalone PushButton
Change-Id: I5e38e8877d70efd3b6413a14c0c121a8babb44f8
2016-10-10 15:26:57 +01:00
Caolán McNamara
e8393d4d91 de-src standalong PushButton
Change-Id: I6f062e04377fc74ec2fea3ea4390943b715e06d1
2016-10-10 15:23:53 +01:00
Caolán McNamara
9f7f5b5f91 no numericfield, spinfield or spinbutton loaded from .src now
Change-Id: I90e4390d1fadcbb18036861dc9b9d39fa8a73551
2016-10-10 14:56:58 +01:00
Jacek Fraczek
f004aa9951 tdf#89307: Removed SvRef::operator T*()
Conditional statements are using SvRef::Is() method.
Changed static_cast<T*>(svRef<T>) occurances to svRef.get().
Added operator == and != to SvRef.

SbxObject::Execute is using SbxVariableRef internally.
SbxObject::FindQualified is using SbxVariableRef internally.

Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395
Reviewed-on: https://gerrit.libreoffice.org/29621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-10 08:48:30 +00:00
Noel Grandin
044260331d loplugin:unnecessaryoverride in vcl
Change-Id: I8a49316dccdc142389d2f7121ff7c8cbbad55638
Reviewed-on: https://gerrit.libreoffice.org/29655
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10 08:39:13 +00:00
Caolán McNamara
a1c77e9d3a drop some unused forward declarations and includes
Change-Id: Ibf5b915798f1a9554d06c705d454cbfb998ea277
2016-10-10 09:17:20 +01:00