10315 Commits

Author SHA1 Message Date
Maxim Monastirsky
215953f981 There is no SfxToolbox class
Change-Id: I30dd797921420a4009455841052f5c5436f4a93b
2017-01-08 16:07:27 +02:00
Caolán McNamara
87f9e8945f default copy ctor and assignment operator are good enough
and block default move equivalents

Change-Id: Ib8a1050803446c2e099f66602fae0465bd8165cf
2017-01-07 21:57:03 +00:00
Julien Nabet
d911663f0f Typo: Acess->Access
Found thanks to Buovjaga

Change-Id: I73e36f50a1fd393859ba775ab084a488047864a3
Reviewed-on: https://gerrit.libreoffice.org/32810
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-07 10:08:48 +00:00
Henry Castro
0ad4b2570f lok: refill font list if empty
After preinit stage the font list is empty
when creating documents.

Reviewed-on: https://gerrit.libreoffice.org/32108
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Conflicts:
	sd/source/ui/docshell/docshel4.cxx
	svtools/source/control/ctrltool.cxx

Change-Id: Ia6938d521626f4b4022f0f993e77c017e4932415
Reviewed-on: https://gerrit.libreoffice.org/32796
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-01-07 00:20:59 +00:00
Caolán McNamara
9e7ff6a7e4 coverity#1398371 Useless call
Change-Id: I3614bb162cec889ee102e0284b6a3a33a98df470
2017-01-07 00:04:51 +00:00
Eike Rathke
6b89bcf85a check "#ERRxxx!" constants for accepted error values, tdf#105024 follow-up
Change-Id: I9a11695710baa2f4e022c8e07f01b962cfabe2e7
2017-01-05 18:23:45 +01:00
Caolán McNamara
ab3fe69ffb finish moving ImageList to framework
Change-Id: I9d9f292066321174af8b0bcd96c58de5fc7566b8
2017-01-05 15:54:29 +00:00
Caolán McNamara
3cd39b91f8 move ImageList to framework
this can probably be replaced by a std::*map<Image>

Change-Id: Ic36c5f406f5ea51cb9ff135858e319e0877179c7
2017-01-05 15:00:54 +00:00
Caolán McNamara
4f5cd607e3 move CommandImageResolver out of vcl and beside its only user
Change-Id: I2bd70d87bb12d5750d8427b8a8fe786cfce8961b
2017-01-05 15:00:54 +00:00
Caolán McNamara
57990e4b8e move ImageType enum out of CommandImageResolver.hxx
Change-Id: I0b4da9a4edff8d0f9016fbd79cb205bdf2b35268
2017-01-05 15:00:54 +00:00
Michael Stahl
b07fac2f7a oox: rename misleadingly prefixed m_pShapeStyle
Change-Id: I07fdc4fff2dd05b57d1a0635d0bed8d1afd6dc58
2017-01-05 15:51:31 +01:00
Stephan Bergmann
cdff2caffa No need for heap-allocated OUStringBuffer
Change-Id: Id2dbe3ecce9eba2eefab90f43b9a2a6894839cfb
2017-01-05 15:41:59 +01:00
Caolán McNamara
fbf10700c5 ImageList doesn't need to be a friend of Image
Change-Id: I3bfe3b6fcd033f1cab503934cf4442adb0143939
2017-01-05 13:50:29 +00:00
Stephan Bergmann
21033d04fd Clean up a usage of OUStringBuffer
Change-Id: I8435865f1a67a3a6d889c1b8a3d30e632ffc61fd
2017-01-05 14:24:28 +01:00
Caolán McNamara
9253dae361 drop newly unused InsertFromHorizontalBitmap
Change-Id: Ia0b0032bf261712be30ac23c8e5ce993011b2e5c
2017-01-05 13:24:09 +00:00
Caolán McNamara
619456ed85 unwind RID_SVXBMP_FRMSEL_ARROWS imagelist
Change-Id: Id74ebd81b3688383271b581b69734fecfe3eb079
2017-01-05 13:24:09 +00:00
Caolán McNamara
1016cd7856 flatten and simplify this resource hierarchy
Change-Id: I622dae5f36b44c08e597d94fe8184ad92504d038
2017-01-05 13:24:09 +00:00
Stephan Bergmann
c03d803a72 Replace side-effect--only uses of makeStringAndClear() with setLength(0)
Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
2017-01-05 13:52:17 +01:00
Szymon Kłos
9152f16b79 tdf#102059 NotebookBar accessible using F6 key
Change-Id: I873c49d8c0557eb3702de921fb5d2281acfed526
Reviewed-on: https://gerrit.libreoffice.org/32459
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-05 09:36:54 +00:00
Stephan Bergmann
ad9cfbcf02 Don't exclude a var from loplugin:salbool merely because of use in >>=
Change-Id: I1b8a3dfa1dc6b351ab0903a74eae19dfa6d0888d
2017-01-05 09:17:47 +01:00
Maxim Monastirsky
9ae8e4d356 Base SvxLineEndWindow on ToolbarPopup
Fixes size and position issues under gtk3/wayland

Change-Id: I357a5935e2b44fd3d5effde8cf7d3499e26384db
2017-01-05 00:11:29 +02:00
Maxim Monastirsky
835556b51a Prefix SvxLineEndWindow members
Change-Id: I0cfe88c65cc75757938a9f8004c219fbe39f88dd
2017-01-05 00:11:29 +02:00
Maxim Monastirsky
9e4ae869f4 Get rid of SvxLineEndWindow resizing
Change-Id: I0135f084f64b9709688f0f9205940baf193c5d83
2017-01-05 00:11:29 +02:00
Maxim Monastirsky
a487e548a0 Use command labels for the color popup title
Change-Id: I2f61e25ef4451775320f8fa1761a951ab94af7d5
2017-01-05 00:11:28 +02:00
Caolán McNamara
59ad262ab9 last bitmaps that pMaskColor arg was used on converted to true transparency
Change-Id: I99bb32355bc53e2c870f84e60fc1e35b9dfe8270
2017-01-04 20:34:55 +00:00
Caolán McNamara
4d1cbb7e89 drop unused SplitWindow::ImplDrawButtonRect
Change-Id: I0ccb4adfec39f8717d5921e04809af65be066d0a
2017-01-04 20:34:55 +00:00
Caolán McNamara
8077cc31a0 all users of InsertFromHorizontalBitmap use all args
Change-Id: I458036b084645af509d64a78f5389415dfc4115a
2017-01-04 20:34:55 +00:00
Caolán McNamara
9e7b0ef950 follow up remove unused autohide leftovers
Change-Id: Ic7281e915075519c300a330557399111838d7d34
2017-01-04 16:50:44 +00:00
Caolán McNamara
b4a31534b9 drop AutoHide code
only used from reportdesign and that appears to be overlooked from an earlier
eradication program

Change-Id: I196fd7ccbc909c935daf534d55e6b39de8510f23
2017-01-04 16:50:44 +00:00
Miklos Vajna
4ad249af88 tdf#105093 sd PDF export: handle embedded videos
In practie embedded files always have a temp file URL, so from the PDF
export's point of view they are still URLs, just at the end the contents
of the URL is embedded to the PDF, not just the URL itself.

So add a SetScreenStream() that's similar to SetScreenURL(), but it's
for embedded, not linked videos.

Change-Id: Ifcc60357ef0f5fed0bdec02e0c84cb16ee147781
Reviewed-on: https://gerrit.libreoffice.org/32727
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04 16:27:44 +00:00
Huzaifa Iftikhar
da7b100184 tdf#97228 Moved class ControlCacheKey in a seperate include file.
class ControlCacheKey defined in include/vcl/salnativewidgets.hxx is used
only by vcl therefore it is moved to a seperate include file named
ControlCacheKey.hxx which is inside vcl/inc/ControlCacheKey.hxx.

This header file contains the definition of the the class ControlCacheKey.

Since this class uses an object of another class named Size which is
defined in gen.hxx therefore this is included in ControlCacheKey.hxx.

All the files that references the class ControlCacheKey includes
ControlCacheKey.hxx with the syntax: #include "ControlCacheKey.hxx"

Change-Id: I7d7b3e1cf6950a953e6bbed670c1914826b2bacd
Reviewed-on: https://gerrit.libreoffice.org/32422
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-04 16:02:26 +00:00
Miklos Vajna
0e71075bb7 Related: tdf#104841 sw PDF export: handle linked videos on non-first pages
Be explicit about the page number, this way a video on the second page
doesn't end up as an annotation for the first page. (In the Impress case
each slide is exported separately, so there this wasn't a problem.)

Change-Id: I83ba9cb4a3b2a6734bd88a138654e391199651c6
Reviewed-on: https://gerrit.libreoffice.org/32696
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04 08:15:51 +00:00
kerem
909164e474 tdf#39674: translated German to English in svdtrans.cxx
Change-Id: Ic46e747a9dbec99e6037c6b35e175ce5b1efdd82
Reviewed-on: https://gerrit.libreoffice.org/32594
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-03 14:55:11 +00:00
Caolán McNamara
1b5e144b4e SetPin and IsPinned are in an always-false circular isolated relationship
Change-Id: I4fb3aaa8a5e8c62091fbc542deae6af3a113a608
2017-01-03 14:12:25 +00:00
Caolán McNamara
19ce5fa563 WB_PINABLE isn't set anywhere
Change-Id: I6acc4b9dc87dd6023b5ad7013bc27180d6e0db6c
2017-01-03 14:12:25 +00:00
Stephan Bergmann
803f474337 Mark [Scoped]VclPtrInstance as SAL_WARN_UNUSED
Stack-allocated instances of the non-Instance [Scoped]VclPtr variants are
occasionally used merely for the side-effect of holding objects alive (like
css::uno::Reference and rtl::Reference, which are also not SAL_WARN_UNUSED for
that reason).

Change-Id: I37ebfaf028a646cb2777c0baf0d99992057a22bd
2017-01-03 14:35:38 +01:00
Stephan Bergmann
f82cd9c786 Hold SfxInfoBarWindow by VclPtr
In SfxInfoBarContainerWindow::removeInfoBar, disposeAndClear is already called
on the removed member (once found), so the ScopedVclPtr (also calling
disposeAndClear when going out of scope) should not be necessary.

Change-Id: Ibf4d19ebd5f1a6217e1d18ef0458c9b865667898
2017-01-03 14:32:24 +01:00
Caolán McNamara
e4a84c625f default copy ctor and assignment operator are good enough
and block default move equivalents

Change-Id: I360860512d2c88f8688685f4e751ded6335549da
Reviewed-on: https://gerrit.libreoffice.org/32656
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-03 09:58:27 +00:00
Tor Lillqvist
0621795c54 Move documentation for parameter of SfxObjectShell::GetTitle() to include file
A re-design of this API would be a good idea.

Is this function ever called with some specific max length that would
not be one of the magic values? Probably the sanest would be to turn
the magic value constants into a normal (scoped) enum, and have two
separate functions: One that takes no parameter and returns the whole
title (and then let the caller take care of truncating as necessary),
and one that takes such an enum and returns a correspondingly mangled
title. The less magic and defaulted parameters the better.

Change-Id: I9e3aa95fae981c5ed48300b753556fa9074c1166
2017-01-03 10:24:47 +02:00
Caolán McNamara
f97cd16ea4 coverity#1371220 Missing move assignment operator
Change-Id: Ie2947ea621da7ffc6c9530f007e1acdd4efb50cb
Reviewed-on: https://gerrit.libreoffice.org/32650
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-02 18:23:50 +00:00
Miklos Vajna
9d6a749bc6 tdf#104841 sd PDF export: handle linked videos
Use the screen annotation markup for this purpose.

Change-Id: I129111cbe08c19c2f3b3ae046408ff9b2a28520c
Reviewed-on: https://gerrit.libreoffice.org/32654
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-02 17:42:02 +00:00
Caolán McNamara
d09888b835 use std::unique_ptr
Change-Id: I1c4f81e0ba0529b9e365c6ddb3d77a8a6a6d5741
Reviewed-on: https://gerrit.libreoffice.org/32649
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-02 16:35:58 +00:00
Muhammet Kara
136f5a209e Prefer prefix ++/-- operators for non-primitive types.
Change-Id: I9be657cd0b5ed964db8db2ca28fd2874ae5406aa
cppcheck: performance
Reviewed-on: https://gerrit.libreoffice.org/32431
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-02 10:36:33 +00:00
Caolán McNamara
970edf67d2 noone cares about the return from WriteGraphic either
Change-Id: Ia91a8b4ae7768bd1623b8e2b545fcc9beff1fbc7
2017-01-01 21:03:49 +00:00
Caolán McNamara
0a599225bc noone cares about the return from ReadGraphic
Change-Id: Ifd86dee6f2657155faaa31a229feb16178d89f34
2017-01-01 21:02:44 +00:00
Caolán McNamara
a3eaeff2db don't need to forward declare ImageList here
Change-Id: Id0477b52a004a9a24e4733aa4916cd1b011c6fdd
2017-01-01 20:48:47 +00:00
kerem
9bbc168c29 fdo#39674: translated German to English in svdmodel.cxx
Change-Id: I48992d2738de40060239b4c25c4adbe64c97b4be
Reviewed-on: https://gerrit.libreoffice.org/32537
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-01 19:38:12 +00:00
Jochen Nitschke
a29bd2dabb cleanup tailing backslashes
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2
Reviewed-on: https://gerrit.libreoffice.org/32491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-30 18:48:24 +00:00
Caolán McNamara
394f65f212 RSC_ACCEL isn't in use anymore
Change-Id: I581d55adfbae078c154eaf41cf98c2be0f5dfd5d
2016-12-30 16:43:13 +00:00
Caolán McNamara
1fec83409c no use of RSC_KEYCODE appears to remain
Change-Id: I968093ef9a9a5647f410432918a60dbc2331192a
2016-12-30 16:40:29 +00:00