10315 Commits

Author SHA1 Message Date
Caolán McNamara
73545e2efa RscImageListFlags is newly unused
Change-Id: Ic6ed613496ce1903f752ae3b6258121870f99558
2016-12-30 16:33:32 +00:00
Caolán McNamara
21f934a7c5 ImageLists no longer loaded from resource files
Change-Id: I5bf1c75dce7bc9af6aaa92447fab7239dff4b676
2016-12-30 16:33:32 +00:00
Caolán McNamara
b8e27d5da6 unwind this ImageList
after discovering one of the referenced images was missing

Change-Id: I25321ee436976415313fb004e798fad897673ee5
Reviewed-on: https://gerrit.libreoffice.org/32511
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-30 15:00:49 +00:00
Caolán McNamara
6f4d538ede this can be local
Change-Id: I8084e8c33a930f13cf7f1212a086a9f1ad1bdfb4
2016-12-27 16:31:58 +00:00
abdulwd
e61fe745d1 tdf#97228 Move include file include/vcl/BitmapProcessor.hxx to vcl/inc/
Adapt users, all in vcl, accordingly.

Change-Id: I4531840091da73fa8fc29175407fa8a737deac18
Reviewed-on: https://gerrit.libreoffice.org/32442
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2016-12-27 10:53:16 +00:00
Noel Grandin
833e6ca9d2 use std::vector instead of naked array in SfxItemPool
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4
Reviewed-on: https://gerrit.libreoffice.org/32384
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-26 18:35:59 +00:00
Markus Mohrhard
c61981c193 use the existing namespace map for the oox namespace export
Change-Id: I7909b08db556c6c65c1547303f2b899c30feaba4
Reviewed-on: https://gerrit.libreoffice.org/32425
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-26 02:04:39 +00:00
Caolán McNamara
2dc821572e HasImageAtPos takes an id not a pos
so rename it

Change-Id: Id83a11d31d1d51f414e6a98ebb71a227c7fe448f
2016-12-24 17:09:36 +00:00
Caolán McNamara
995dca0837 remove unused ImageList member
since

commit 284ca1a5840c5fcbf4f9d1eff02ae607cdc2c222
Author: Noel Grandin <noelgrandin@gmail.com>
Date:   Sat May 28 14:38:03 2016 +0200

    Convert RSC_TOOLBOX to scoped enum

    and drop unused (in .src files) constants

Change-Id: I0e05389e1bbd5f74ff3b3cd9f1f16cfd54b992c2
2016-12-23 20:58:21 +00:00
Caolán McNamara
7a339a03d2 unwind AVMEDIA_IMGLST/AVMEDIA_IMGLST_L ImageLists
Change-Id: Idf115c12c5da138141010673ed2bf0525aec6aaa
2016-12-23 20:40:22 +00:00
giacco
5f116966de tdf#87700 command to rotate 180 degrees
added command to rotate an image 180 degrees in Writer

Change-Id: I4a1e40f4c3475aceb24edd44691a74372f61b49a
Reviewed-on: https://gerrit.libreoffice.org/30074
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-23 18:29:37 +00:00
Noel Grandin
cfcbbfaeb4 remove unnecessary casting in BrowseBox::pDataWin member
Change-Id: I1187691c19808c53ff3839cfd8892ab06d36053e
Reviewed-on: https://gerrit.libreoffice.org/32381
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-23 11:56:20 +00:00
Noel Grandin
c4c23515d6 merge svx::sidebar::BulletsSettings with svx::sidebar::BulletsSettings_Impl
Change-Id: I7cf6bb4cf3aa532718753904c2100882b0df6775
Reviewed-on: https://gerrit.libreoffice.org/32373
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-23 11:43:10 +00:00
Noel Grandin
46d3163f77 loplugin:unusedmethods
Change-Id: Ife4c8d948ffa116f044d43903de9485e43cfcae5
Reviewed-on: https://gerrit.libreoffice.org/32336
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-23 04:46:35 +00:00
Caolán McNamara
cf6f3ad82b unwind RID_SVXIMGLIST_FMEXPL ImageList
Change-Id: If9d733c5242e2f2b9947b251cfe832d1c10bd4bd
Reviewed-on: https://gerrit.libreoffice.org/32350
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-22 18:30:05 +00:00
Noel Grandin
cc15806b52 convert BasePrimitive2D::get2DDecomposition to use a visitor
which lets us avoid constructing the decomposition when we are only
interesting in the bounding box, e.g. for hit testing

Change-Id: Icd8d430b75d207063f1db70e5a0822d5d82a7d00
Reviewed-on: https://gerrit.libreoffice.org/30835
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-22 06:44:08 +00:00
Noel Grandin
41f7878ccb convert BmpFilter to scoped enum
Change-Id: I22c5b49f108d4ce103dea5098a2a0dc9d6bc854c
Reviewed-on: https://gerrit.libreoffice.org/32292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-22 06:43:35 +00:00
Noel Grandin
7444355f1d convert VclButtonBoxStyle to scoped enum
Change-Id: If3d02c9be54a509f85214acbf4a1e6cfd8955dc4
Reviewed-on: https://gerrit.libreoffice.org/32291
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-22 06:43:22 +00:00
Noel Grandin
21907d647c convert VclSizeGroupMode to scoped enum
Change-Id: Id731fb3d5f9eb5ddaa3af41b010bff340f1077ce
Reviewed-on: https://gerrit.libreoffice.org/32290
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-22 06:43:06 +00:00
Noel Grandin
29fa61837f convert GetDefaultFontFlags to scoped enum
Change-Id: I048aa989f5a90a5e2fb51e33eb9c1dafda3fc7f6
Reviewed-on: https://gerrit.libreoffice.org/32284
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-22 06:42:53 +00:00
Caolán McNamara
a15bdfa3a5 unwind RID_SVXIMGLIST_XFORMS_TBX ImageList
Change-Id: Ib2e41e65dbc5079db12bf7ad63f857c8473cf0f3
2016-12-21 18:39:35 +00:00
Noel Grandin
6b8ee3c9ba convert VclButtonsType to scoped enum
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1
Reviewed-on: https://gerrit.libreoffice.org/32285
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-21 16:19:37 +00:00
Caolán McNamara
64a2dc962c unwind RID_SVXIL_FRAME ImageList
Change-Id: I18f567d3ff7f415c75e29043ef29a460be8a21c5
2016-12-21 16:02:29 +00:00
Stephan Bergmann
2d0e3d1cc6 ODR violation (base class must be the same across compilation units)
Change-Id: I7c8a773f652e4a0987a4232520b88b5dde9dfe67
2016-12-21 15:10:21 +01:00
Stephan Bergmann
9fcfd0bdac Useless namespace around a #define
Change-Id: I789a28305e7d874a7cc78af60fa7b2d60e140efb
2016-12-21 15:09:56 +01:00
Stephan Bergmann
4cae165f0b ODR violation (base class must be the same across compilation units)
Change-Id: I2aa5fefad978f50f5166d75bbcfb25d88780d03d
2016-12-21 15:09:10 +01:00
Noel Grandin
d235f64368 convert OutDevViewType to scoped enum
Change-Id: Id980f09c198ca976c88b11030f5db9d6f010add1
Reviewed-on: https://gerrit.libreoffice.org/32274
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21 11:42:53 +00:00
Caolán McNamara
331c66989f unwind RID_SVXIL_DATANAVI ImageList
Change-Id: I0aae6774ee0b42d32838b9010ddddaa33324c6c6
2016-12-21 11:07:22 +00:00
Caolán McNamara
2ebe42ff29 unwind RID_SVTOOLS_IMAGELIST_EDITBROWSEBOX ImageList
Change-Id: I4cf82ca8530f8b244be593e10976965be2ef2b60
2016-12-21 11:07:22 +00:00
Caolán McNamara
e3203ad42d remove newly unused SfxModule::GetImageList_Impl, etc
Change-Id: Ibb1430d2b6c7994b2425d686cf206d168530faef
2016-12-21 11:07:22 +00:00
Caolán McNamara
e0b71d8e5a remove newly unused SfxImageManager
Change-Id: If68637fe49b5d252ad4ec5d63d56261113be6a7c
2016-12-21 11:07:21 +00:00
Noel Grandin
735a002507 convert EnumContext::Context to scoped enum
Change-Id: I16ec63beb801073e5d604d852892c2fd6e8d8fc3
Reviewed-on: https://gerrit.libreoffice.org/32272
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21 10:34:13 +00:00
Takeshi Abe
b55c205460 [API CHANGE] Retire SAL_ABS
which had served since d441fa1f8cc0a17a2bc166bf2f2a44f76b83a773;
we now have polymorhpic std::abs.

Change-Id: Ibe48ac51508f7d9f5a44d712550237db7f553df3
Reviewed-on: https://gerrit.libreoffice.org/32225
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-21 07:54:51 +00:00
Noel Grandin
5ec1b04b9b convert EnumContext::Application to scoped enum
Change-Id: Ia289a7b63bf8797085315218785e2a2a4c45d232
Reviewed-on: https://gerrit.libreoffice.org/32230
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21 07:10:54 +00:00
Tibor Móger
86519381cd tdf#94576 handle esc keypress on templatemanagerdialog
SfxTemplateManagerDlg now overrides behaviour of ModalDialog on
EventNotify by checking if the pressed key was esc and
the searchFilter is not empty and it was focused. In this case
instead of letting ModalDialog close the modal
it clears the searchFilter

Change-Id: I90d91a3b152f68b6c8780963d1b95258d9ccf23a
Reviewed-on: https://gerrit.libreoffice.org/31736
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-20 20:22:39 +00:00
Jan-Marek Glogowski
41bbcc5b50 Drop ListBox include from ComboBox header
ComboBox just uses ListBox internally

Change-Id: Ieed279160db1c9918bd9f3e37102b59ea62f0581
2016-12-20 14:19:18 +01:00
Jan-Marek Glogowski
a4d1dea6c7 Unify drag handles for toolboxes
The custom shape popup toolbars used their own drawing code for
the drag handle. This was dropped in favour of the default toolbox
drag handle code.

This also drops the drag highlighting in favour of a move mouse
cursor as the drag indicator. The drag handle is currently always
drawn on the top, like a window title.

Change-Id: I08cbf715f1e240c2eb6d9a61fad2b705f9bd8014
2016-12-20 14:19:15 +01:00
Stephan Bergmann
8a71eacef7 Don't use 'this' in ctor
Change-Id: I405160743609aae92a37b2359bea5aa42ee66519
2016-12-20 14:13:13 +01:00
Takeshi Abe
4956fd64e1 tools: Kill empty enum LockType
It seems unused in the first place.

Change-Id: I556ae97b86498c63315f1f1bbe8d55fdbb10c1aa
Reviewed-on: https://gerrit.libreoffice.org/32218
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-20 12:40:42 +00:00
Stephan Bergmann
3ead3aef02 SfxFrameStatusListener::m_xFrame can apparently be const
Change-Id: I6c7b508eae23cf6046ba07fb00ae5e63d5efc57f
2016-12-20 11:47:30 +01:00
Stephan Bergmann
2017526bcc ODR violation
Change-Id: Ia56bd463c83c0aedcc7f4e9cf1b65c57104d78f2
2016-12-20 11:43:14 +01:00
Noel Grandin
ed2b8ca92a convert SFX_EVENT constants to scoped enum
SFX_EVENT_CLOSEAPP and SFX_EVENT_TOGGLEFULLSCREENMODE are never
generated,
so remove them and delete the code that receives them

Change-Id: I2d003ba73fff0b02120ba29ff58e1d2399dedf00
Reviewed-on: https://gerrit.libreoffice.org/32168
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-20 06:08:30 +00:00
Stephan Bergmann
2eb121bd15 MSVC 2015 apparently fails the sizeof(incomplete) SFINAE trick
...at least with --disable-pch it complained

> [build CXX] canvas/source/directx/dx_bitmapcanvashelper.cxx
> C:/lo/core/include\vcl/vclptr.hxx(98): error C2027: use of undefined type 'OutputDevice'
> c:\lo\core\canvas\source\directx\dx_devicehelper.hxx(33): note: see declaration of 'OutputDevice'
> c:\lo\core\canvas\source\directx\dx_devicehelper.hxx(109): note: see reference to class template instantiation 'VclPtr<OutputDevice>' being compiled

Change-Id: I3ba90acdb632fc209b8137818e30fb771ba0807c
2016-12-19 17:32:13 +01:00
Tomaž Vajngerl
bf5f6df9e4 vcl: separate ImplImageTree - ImageTree singleton and public iface
ImplImageTree was used outside of VCL which is not consistent with
the name and the header also contains a lot of implementation
detail. This separates the implementation to ImplImageTree and
the public interface and singleton to ImageTree only.

Change-Id: I3a26444f0f6971a6b1d83472e9cef19c93192d3e
Reviewed-on: https://gerrit.libreoffice.org/32134
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-12-19 07:26:24 +00:00
Noel Grandin
f9fd6390cd ScrollableWrapper -> ScrollableDialog
no point in having a template and a virtual base class when it's only
used for one type

Change-Id: Idb1a1a551064cc10896eff33652038eb5be0297e
Reviewed-on: https://gerrit.libreoffice.org/32041
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-19 06:04:33 +00:00
Stephan Bergmann
87707670c9 Make OUStringLiteral more useful
...by:

* making the OUStringLiteral ctor non-explicit (to be exploited in a follow-up
  commit)

* adding (LIBO_INTERNAL_ONLY) overloads to OUString/OUStringBuffer functions
  that can now take OUStringLiteral in addition to taking "real" string literals

(Keeping the number of overloads smaller by replacing the ConstCharArrayDetector
overloads with ones taking OUStringLiteral (for LIBO_INTERNAL_ONLY, at least)
and relying on the now-implicit conversion from "real" string literals to
OUStringLiteral unfortunately would not work:  Both OUString and OUStringLiteral
argubably need implicit conversions from "real" string literals, so any function
overloaded for OUString and OUStringLiteral would be ambinguous when called with
a "real" string literal.  And removing the OUString ctor taking a "real" string
literal and relying on an implicit conversion chain from "real" string literal
to OUStringLiteral to OUString doesn't work because it would involve two user-
provided conversions.)

Change-Id: I14433fc1605b048807f60b3a3e14f92221d3a226
Reviewed-on: https://gerrit.libreoffice.org/32097
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-17 16:11:10 +00:00
Miklos Vajna
0e1b831b93 CppunitTest_vcl_complextext: fix loplugin:cppunitassertequals warnings
Change-Id: I18b052cadb061535d7552f2ec1eac4b932489d22
2016-12-16 13:39:39 +01:00
Stephan Bergmann
0dc19268d2 Typo in meant-to-be-overloading function name
Change-Id: I65ab9176b39a436afce23e6bd4423ebf76219166
2016-12-16 12:57:53 +01:00
Stephan Bergmann
10bf49c18d loplugin:unnecessaryoverride
Change-Id: I24a0e495b64a1db8b7c45f3c68e06ad3301bd9c4
2016-12-16 10:37:26 +01:00
Takeshi Abe
6ee75be645 vcl: Kill unused RenderSettings
Change-Id: Ie74d4f3258ef553b4febcc544204080d8c6e0f40
Reviewed-on: https://gerrit.libreoffice.org/32046
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-16 08:23:34 +00:00