Eliminating 11 unused IDs that occupied empty elements in the string
table. Also moved STR_ERR_NAME_INVALID_CELL_REF to the proper position.
Change-Id: I2534476895edb438c7404d781781e6088adf0385
This reverts commit d69bc9c939, which isn't needed
any more now that 01aa52b5e9 "Work around
-Werror,-Wunknown-pragmas" makes the whole pragma block conditional on
__GNUC__ >= 7
(which Clang does not fulfill).
Moved LOKitThread back to LibreOfficeMainActivity, so that it could
use the context in the constructor. Once the Context became available
in LOKitThread, it was simply a matter of replacing static references
with the one passed in the constructor.
Also changed access levels of some methods in LOKitThread.
Change-Id: I0cc2c846c67b90907cbf3dce363666f9ab02d887
Reviewed-on: https://gerrit.libreoffice.org/33546
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Removed references to static context, replaced them with the context
object already available in the class, and changed access levels on
some methods in LOKitTileProvider.
Change-Id: Ib52d325650377b77ec166ddbfb760f74c19067ff
Reviewed-on: https://gerrit.libreoffice.org/33554
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
...can happen when 'unopkg add' is called before soffice had ever been run, so
UserInstallation isn't populated yet
Change-Id: I0c6b9444f196da5ad5a32cc90f2e1e2a5dbd0f58
this patch writes the .filters file, it creates 2 filters:
-headers: place, for each module, the header files contained in gbuilparser.modules[<module>][headers]
-sources: place, for each module, the cxx files contained in gbuildparser.modules[<module>][<target>]['CXXOBJECTS']
Change-Id: Iba98d788b72992624fb8aa09315a5647e275ffcc
Reviewed-on: https://gerrit.libreoffice.org/33721
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
seeing as we seek from previous position + bytecount on each loop
we can only be sure we go forward the min (+1/+2) for each iteration
Change-Id: I4f1a29d96c43ee8aa858c97405d196b89994669b
Regression from commit 9e7eb63989 (DOCX
import: parse <w:spacing>'s w:before/afterLines attribute, 2014-10-17),
the problem is that OOXML has 3 different attributes for the paragraph
bottom margin (and other 3 for the top one), while in Writer we just
have a top margin.
Now the import filter tries to work out which one of these should have
priority and ignore the rest, but this is way more complicated when
style inheritance has to be taken into account as well.
To avoid the regression just restrict w:before/afterLines handling for
the case when it's used as direct formatting, that's why this was
introduced after all.
Change-Id: Ie8642c7a9771596def6b8899e098b26c4f8be0b4
Reviewed-on: https://gerrit.libreoffice.org/33738
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
This is in !LIBO_INTERNAL_ONLY code, so cannot use SAL_FALLTHROUGH. And even on
current <https://github.com/boostorg/config> master, BOOST_FALLTHROUGH does not
yet support [[fallthrough]] for GCC 7.
Change-Id: I5306c3949b13c517fe8ef643cf98c2021147617e
Copied gbuild-to-ide.py from d575e3a14b
to gbuild-to-ideNS.py
Changed Makefile.in to use gbuild-to-ideNS.py for non-actively
supported platforms.
That way these platform are stable, and not affected of new features.
For now all platforms are still present in gbuild-to-ide and will
have a "does not break" test for all new features.
Change-Id: I8bb069d93c954a80de540a32b8a01889035c840d
Reviewed-on: https://gerrit.libreoffice.org/33710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
so we can remove unnecessary calls to the OUString(literal) constructor
when calling constructors like this:
Foo(OUString("xxx"), 1)
Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36
Reviewed-on: https://gerrit.libreoffice.org/33698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Project: help 57c058399077a50156e8f2d26f7b483f49fc3700
Fix ahelp for the Section tab page
Was set for the title instead of the description here
Change-Id: I108ea751c79f9dff0d8ab24205a7e06ca43a9ac3
Reviewed-on: https://gerrit.libreoffice.org/33727
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
Project: help 8ecc94f4f628fc151aabd6d4f3ba5dfe9ff72198
Fix ahelps for Wrap tab page and related UNO commands
These are on the Drawing Object Properties toolbar
and on the drawing objects Properties window - Wrap tab
also some simple drawing objects have an own Wrap window
Change-Id: I18471f402eb109af5936feacb3fdd8e1d1033087
Reviewed-on: https://gerrit.libreoffice.org/33729
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
Project: help 31cb3368f3f9412c359b58009a8ea0dc9ab75324
Fix ahelps for FlipVertical and FlipHorizontal UNO commands
These are on the Image toolbar
Change-Id: I9ed0262e9e6e346a8e42dc034c690eb88646a316
Reviewed-on: https://gerrit.libreoffice.org/33730
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
Project: help d427d899f1228bcb309f349c39c17eb96d80d980
Fix ahelp for InsertCaptionDialog UNO command
This is on the Drawing Object Properties toolbar
Change-Id: I2f50145a75d213914f1b699753f39a19cc4a3b71
Reviewed-on: https://gerrit.libreoffice.org/33728
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
Project: help ae83c2d740080cd66029a9cf58457f9711c95b66
Fix ahelp for Insert Section UNO command
This is on the Insert toolbar
Change-Id: I0690631f09fae8f3fca109e7b30b62f0411c4a5b
Reviewed-on: https://gerrit.libreoffice.org/33726
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
Project: help 8ff48d16dbea60ef20ca187f36214e020f73367f
Fix ahelp for line property related UNO commands
These appear on the Drawing Object Properties toolbar
Change-Id: I232f41a8fbde595a57fa6be705cb15ad330a124f
Reviewed-on: https://gerrit.libreoffice.org/33725
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
