Commit Graph

403714 Commits

Author SHA1 Message Date
Mike Kaganski
62c063de37 tdf#105536: PDF image should be v-flipped unconditionally
Unit test included

Change-Id: Id0d054a6b9922666daf4f36908f97ed6e65fb6c7
Reviewed-on: https://gerrit.libreoffice.org/33649
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-01-28 17:30:06 +00:00
Jochen Nitschke
d817456fb0 loplugin:stringconstant
Change-Id: I4e2e0aba2930d7c4ee60567d1d65e0e773a470bf
Reviewed-on: https://gerrit.libreoffice.org/33650
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-28 17:27:35 +00:00
Jochen Nitschke
681c329b7f loplugin:stringconstant
Change-Id: I7e90f4fecf7243c7551ec7ecbb29adfa92a86447
Reviewed-on: https://gerrit.libreoffice.org/33648
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-28 14:38:25 +00:00
jan Iversen
bcaba2ca36 gbuild-to-ide source code is relative to module
Last central change, before rewrapping xcode.

Change-Id: If9b3d668fa59fe32a7a89a17ea56a6852b260a2b
2017-01-28 13:33:00 +01:00
Caolán McNamara
ce2238a7bd coverity#1399595 Uninitialized scalar field
Change-Id: I6e6a1e114ee9abf8826dda19e0b7bc3b573e2edf
2017-01-28 12:29:02 +00:00
Caolán McNamara
a5233e5112 Resolves: coverity#1399594 Unchecked dynamic_cast
Change-Id: I6aae2d451db218a53931df1982a5412923dd42c1
2017-01-28 12:27:07 +00:00
Zdeněk Crhonek
bb759c4868 add SHEETS test case
Change-Id: I4e0aed457dd82ce2f16aa007000067a3e4438876
Reviewed-on: https://gerrit.libreoffice.org/33645
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-28 12:09:38 +00:00
Jochen Nitschke
b2e54bef53 loplugin:unnecessaryoverride
seen on tinderbox Linux-F19-x86_64_14-with-check

Change-Id: Ic494f75df7b2ca879e7bb312166b4c91263ee214
Reviewed-on: https://gerrit.libreoffice.org/33644
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-28 10:49:59 +00:00
Noel Grandin
f1d83ac45f loplugin:stringconstant check for unnecessary OUString constructor..
..calls when creating exceptions

Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe
Reviewed-on: https://gerrit.libreoffice.org/33617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28 09:22:55 +00:00
jan Iversen
53d3755972 gbuild-to-ide, add pr module sources
Additional to having sources pr target (needed
for generarition), each module also has a sources key
where all the module source files are sorted, this allows
to present the user with a sorted list of sources.

Change-Id: I8fd8249c88dc55f47199b7998faeb721d74f982f
2017-01-28 10:03:22 +01:00
jan Iversen
03bbd573ca gbuild-to-ide, centralized adding extension.
Instead of each generator handling extensions it is
not done centrally.

Change-Id: I2cf1a499269a26c1c402577b3e8e508d578f9c6e
2017-01-28 09:34:57 +01:00
Rohan Kumar
6e901f8651 tdf#51358 Support for SnakeWipe transition animation in SVG support
ported the class SnakeWipe.

Change-Id: Icb41072bbd276e0edf3ef2ecea6148c81110b53e
Reviewed-on: https://gerrit.libreoffice.org/23285
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-28 06:16:25 +00:00
Samuel Mehrbrodt
8a0416be44 Symstore: Also add .exe and .dlls to symstore
These are needed when analyzing the minidump.

Change-Id: Ife296c298e3b2f1ca8a47dcbaaf1947e6aefdc81
Reviewed-on: https://gerrit.libreoffice.org/33631
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-28 03:45:49 +00:00
Abhilash Singh
413232229c tdf#86214 User isn't warned entering a cell address not allowed
Refactored ScRangeData::IsNameValid

Change-Id: I74dd5830d13e48e8fe9a5180a819be4acdc9a1db
Reviewed-on: https://gerrit.libreoffice.org/33386
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-28 00:08:47 +00:00
Caolán McNamara
3084e8f5b1 add eps fuzzer
Change-Id: I7455a01076fc7c5fd16bbb90914ac93c236b2a3b
2017-01-27 20:48:22 +00:00
Caolán McNamara
f40aba6bf6 coverity#1371303 Missing move assignment operator
Change-Id: I0dec3e192f3da895398a8b011c0e7275aab59d73
2017-01-27 20:48:20 +00:00
Caolán McNamara
15a2a39ce6 everything ImplClear clears is managed by their dtors anyway
Change-Id: Icafd4a4915d2fb3159b50409e5fc443c58d43d57
2017-01-27 20:48:19 +00:00
Caolán McNamara
9aebc26c9b Animation dtor will be called anyway, so drop Clear
Change-Id: Ifa5a1cf6d782af0bb73ceff10f5a2a2daa4457d4
2017-01-27 20:48:19 +00:00
Caolán McNamara
00f0694c09 everything reset by ImplClear is going to be overwritten anyway
Change-Id: I94de8723a43d177fdf2caf0d8d3e529200d2e718
2017-01-27 20:48:19 +00:00
Caolán McNamara
a42e8baed4 we copy the flag for the context in the ctor, but not the context
which is worrying, copy the other missing maSwapInfo too which should be safe
to do.

in the assignment operator, we don't copy any of those three fields at all, which
is inconsistent

save and restore the context and context flags on the piece where we overwrite
ourself via *this = tempobj

Change-Id: I06a7d491f95dcb113a3c705ceeb41f576ab0a514
2017-01-27 20:48:19 +00:00
Caolán McNamara
9bf03203cd remove weirdness of ImpGraphic assignment operator
seems to me that this hackery is to avoid the swapfile
getting pulled out from underneath it during swapin

Change-Id: I6b58d7e31731db8edc4026460beabc667204dcae
Reviewed-on: https://gerrit.libreoffice.org/33620
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-27 20:46:11 +00:00
Kohei Yoshida
f2f6d11e35 tdf#102688: let's purge it here just in case...
In theory it would still leak without this if the map mode is set
multiple times.

Change-Id: Ie862f4d59e45b92ff75dffb787ef256337f47f84
Reviewed-on: https://gerrit.libreoffice.org/33602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-27 20:43:51 +00:00
giacco
ee7e34696e tdf#87700 command to rotate 180 degrees
same things, with less code

Change-Id: Ied67277f1a48b58aba094f3ca650c08133e95d68
Reviewed-on: https://gerrit.libreoffice.org/33619
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-27 17:09:50 +00:00
Stephan Bergmann
9ee0f108ca GCC 7 supports [[fallthrough]]
Change-Id: Ic6fb995a76a30b60b597005e714de03d43c36a7c
2017-01-27 18:04:53 +01:00
Michael Stahl
2fc5a65a18 sal: add SAL_NO_ASSERT_DIALOGS variable to redirect...
... the dialogs that pop up on assert() and abort() to stderr, which
should work better in CI builds.

Change-Id: I80ec95bae6cc21b8ac27f68ca93aa6c6cce707f4
2017-01-27 17:52:53 +01:00
Stephan Bergmann
71511385dd Just pass in OUString directly
Change-Id: Idf7d63672e8b330499e53c1395dedb92d25bb76a
2017-01-27 17:28:27 +01:00
Pranav Kant
464d9249d4 gtktiledviewer: Can reply, delete comments from sidebar
... and put the sidebar in a scrolled window

Change-Id: I57e982c849ed0c4dda4e8f5fdbcb0b85e46da36c
2017-01-27 21:57:01 +05:30
Pranav Kant
621e143c1c gtktiledviewer: factor out user prompt entry dialog
Change-Id: I282390f7319de2e24564e0122e8c0081235a0ef5
2017-01-27 21:57:01 +05:30
Pranav Kant
b3178e2fce lokdocview: 'comment' signal for comment callbacks
Change-Id: I82040893added83ff13395db3917b230ef6b01d5
2017-01-27 21:57:01 +05:30
Pranav Kant
8b3ea2ad62 gtktiledviewer: Comment dialog when tiled annotations are off
Change-Id: I6762baac6c387d968dc6ee94d3494907c817214c
2017-01-27 21:57:01 +05:30
Khaled Hosny
7c2e96a4e7 DisableGlyphInjection does nothing
Change-Id: Ie97eac46fde075bd74c7adb583b8be979f3af829
2017-01-27 18:25:23 +02:00
Pranav Kant
4f60b300d2 lok: Unit test for comments api
Change-Id: Ieedb50a4d376c1214ea23b56c8cab19c96c159d0
Reviewed-on: https://gerrit.libreoffice.org/33615
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 16:16:25 +00:00
Stephan Bergmann
8c78aa379f Just pass in OUString directly
Change-Id: Id9bd288080fdd5ed4dfaee77b697954ad7bc2458
2017-01-27 17:15:43 +01:00
Pranav Kant
3616f875b0 lokdocview: Separate gobject property for turning off comments
Pass --enable-tiled-annotations to gtktiledviewer on command line
to turn comments on again, by default they are turned off now.

Change-Id: I40e93ab683ec9538e088ae9aa83cda2eaaf9939e
Reviewed-on: https://gerrit.libreoffice.org/33622
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 16:13:04 +00:00
Pranav Kant
99a2a1f975 gtktiledviewer: Comments sidebar
Change-Id: Icf5bb78859668bfb5c43efc3e5fa9afce8458f41
Reviewed-on: https://gerrit.libreoffice.org/33621
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 16:12:26 +00:00
Stephan Bergmann
111d9033b6 Just pass in OUString directly
Change-Id: Iba5289abf96b15e833cb85e96d4e60b2285271be
2017-01-27 17:08:03 +01:00
Jochen Nitschke
70dee11c2e use a define for invalid SfxPoolItem
and use helper function IsInvalidItem() more

Change-Id: Ifd651a336a7bd4ef4f945219d765afb827465438
Reviewed-on: https://gerrit.libreoffice.org/33611
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-27 15:58:28 +00:00
Caolán McNamara
ac33904d05 move these into the member init list
Change-Id: I94a1ea4cb81e2b7383c3e7c56314d08eea754434
2017-01-27 15:33:08 +00:00
Caolán McNamara
011bae55cd Resolves: tdf#104153 lookup what listbox an entry is dragged from
so we can find where its been dragged from in order to remove it from that
source, rather than relying that it comes from the previously focused listbox

Change-Id: Ie6aa1a311b46e5e9ee96cab05e0705b794b5eb0b
Reviewed-on: https://gerrit.libreoffice.org/33575
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-01-27 15:32:42 +00:00
Stephan Bergmann
53eb2fae38 -Werror=int-in-bool-context (GCC 7)
Change-Id: Ide131a586d0d282993dfbf53a783f02d48860647
2017-01-27 16:23:52 +01:00
Pranav Kant
1eef075ad5 Fix android build
Change-Id: I3a39b7adc44a61f1bd4379c2a46e559ad12e7184
2017-01-27 20:44:22 +05:30
Caolán McNamara
1ddf5b0ecb ImplClear sets mbSwapOut false, so mbSwapOut is actually always false here
i.e. failure to swap in does not mean that mbSwapOut is true afterwards, and
mpSwapFile is discarded. It means the whole thing is thrown away.

Change-Id: I73704866d77078c73d053047a7d2ef6499a3e69d
2017-01-27 15:01:21 +00:00
Stephan Bergmann
4d092cba79 Remove dynamic exception specifications from some TDE-only code
Change-Id: I55cfacfd66ed31c8ec209d8deed7746ce917f8ba
2017-01-27 15:54:56 +01:00
Stephan Bergmann
c65d6e9e5d -Werror=int-in-bool-context (GCC 7)
Change-Id: I69f31a94f3e57b3488c576f8d8e0569f459a2117
2017-01-27 15:46:47 +01:00
Stephan Bergmann
85ccbb6f2e Don't worry, Kai, it's still in the git repo
57558f61e9 "#i108938# - commented out unused
member fuction."

Change-Id: I4972d0ff98f8fa21de4fa6506bc1bcbc7088f6d3
2017-01-27 15:41:22 +01:00
Caolán McNamara
3ae2158d43 getColorWindow calling itself, so undisposed windows lying around
Change-Id: I5902c7a677b8b0d3d2891a5f793e5f8e457f25fa
2017-01-27 14:34:24 +00:00
Stephan Bergmann
9c62e04bd5 Remove unused sw/source/ui/vba/vbacheckbox.cxx
...which was listed as explicitly not copiled with
24a129b9f5 "make it obvious some files are
intentionally not compiled ( temporarily )" but not removed completely with
09abd826a0 "remove uncompiled source files" (which
removed the other files from the first commit's list)

Change-Id: I232fa73680a2fbc64c6b57b85a626695b86d5f7a
2017-01-27 15:28:28 +01:00
Eike Rathke
9a283e44ca Resolves: tdf#105558 accept numeric BASIC return types as numeric
... not only SbxINTEGER, SbxLONG, SbxSINGLE and SbxDOUBLE.

Change-Id: I75d892f5ae60ef1b18bd86e64777dea746e35a1f
2017-01-27 14:58:38 +01:00
Stephan Bergmann
cb3c2eaba6 loplugin:unnecessaryoverride
Change-Id: I5bed51a3c03e2d55b9b7508d854cd486a35ea90e
2017-01-27 14:18:32 +01:00
Pranav Kant
d83deb9d50 lok: Allow to delete comment by post it id
Change-Id: I61971dfe3a2630ba33c029ce7865bd7077e235cc
Reviewed-on: https://gerrit.libreoffice.org/33613
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27 13:01:33 +00:00