Commit Graph

403714 Commits

Author SHA1 Message Date
Markus Mohrhard
6c98339f75 uitest: some pep8 fixes
Change-Id: Ib889604f1b6d11e874c27fb5d2757a792a687366
2017-01-25 00:35:56 +01:00
Markus Mohrhard
21248f909e uitest: document more UNO helper methods
Change-Id: I941f5ba20a7e3176e8d9f5f64c64ada6551d533a
2017-01-25 00:35:56 +01:00
Federico Bassini
c3580d08a6 gbuild-to-ide: replacement of the code
this patch do 2 things:
1a) create class testide, a duplicate of
VisualStudioIntegrationGeneration to work on it without touch the
real one
1b) place xcodeintegrationgenerator under testide, and under this
last one all of generators that work yet

Change-Id: Ib678134678ed19de9dcd9d1f47e8e7c16ae59f74
Reviewed-on: https://gerrit.libreoffice.org/33495
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2017-01-24 19:39:03 +00:00
Xisco Fauli
efbbf4a795 tdf#105466: Add uitest
Change-Id: I21ba4b716b3b7d2c1c23db816701331ba462b379
Reviewed-on: https://gerrit.libreoffice.org/33494
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-01-24 17:37:40 +00:00
Tor Lillqvist
31e12a9e63 Move two include files to oox/inc as they are used only in oox
Change-Id: Ie13614c1977f45aa8086f4db65ca86b7d9212735
2017-01-24 18:37:56 +02:00
Stephan Bergmann
09768d8ee4 Use proper check for FunctionProtoType
...as at least MSVC SAL_CALL-annotated functions have an AttributeType wrapped
around the FunctionProtoType.

Change-Id: Ic085e2e3649e6b2fc8ca380047133a8edbe20589
2017-01-24 17:30:51 +01:00
Caolán McNamara
e2eaaa8a57 Resolves: tdf#104552 table properties dialog drops previous border color
Change-Id: Ie39ea17fe56cc88efc65f6916aaeb1bd1b77c51f
2017-01-24 16:12:08 +00:00
Noel Grandin
c5df32e5cb loplugin: unnecessary destructor jvmfwk..lotuswordpro
Change-Id: Iaa4f9b178ab265342255066af7fff09f5b33ab37
Reviewed-on: https://gerrit.libreoffice.org/33496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-24 15:56:31 +00:00
Caolán McNamara
d92b12604b tdf#105467 new color widget doesn't support XStringListControl
so this threw and mangled the dialog. New color dialog doesn't need
to be told the name of colors, it figures that out itself.

Change-Id: I89382b6b26312fc90c967620c654ea611cbd9616
2017-01-24 15:49:49 +00:00
Caolán McNamara
e3bd10f8d5 adjust the hide of the zoom so its dynamic on docking/undocking navigators
Change-Id: I525d0abf5618ffc2f614857a29e530f7140c0de7
2017-01-24 15:12:32 +00:00
Caolán McNamara
b37ac48935 Resolves: tdf#105450 calc navigator gets 0 height on toggle off/on when docked
Change-Id: Icd346cdf0a208ccaeddd77e6803f4f906361324c
2017-01-24 15:12:32 +00:00
Caolán McNamara
25a10ae68e add psd fuzzer
Change-Id: I8969e9f5020a6c1957b7f326e5dcca52915ddd4f
2017-01-24 15:12:32 +00:00
Caolán McNamara
ecf852299b coverity#1242895 Untrusted value as argument
Change-Id: I1f0d8aee19d2723861aa70f31176db08299cd9b9
2017-01-24 15:12:32 +00:00
Caolán McNamara
84568fa10a coverity#1399021 Unchecked dynamic_cast
Change-Id: I3befc9be20f8d414ec786f1a94f1f85ce94fb44b
2017-01-24 15:12:32 +00:00
Tor Lillqvist
dda1c7b6fa Drop incorrect "artistic" prefix from some token names
Apparently copy/paste mistakes in the
642a252cf1 and
21d4cfe19e commits from 2014; most of
the picture effect type tokens added in that commit do have names that
start with "artistic" but not all.

Does not break any unit test. (Does not fix the bug I am investigating
either, though.)

Change-Id: I2c3bb7243e1feaa3fa949b58d3acf34825d6987b
2017-01-24 16:57:45 +02:00
Tor Lillqvist
c0ee5231c9 Probably makes more sense to return DONTKNOW if the element is DONTKNOW ...
... and not the namespace token without any element token ORed in.

DONTKNOW is what the two callers look for.

Does not break any unit test. (Does not fix the bug I am investigating
either, though.)

Change-Id: Ibd75ee06797d7b62476d4bf2302338b2bb3266d4
2017-01-24 16:57:03 +02:00
Takeshi Abe
d8aa450396 tdf#105382 Set URL-decoded default filename for minimized presentation
See mailing-list thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076702.html>
for a discussion on the original presentation file's URL.

Change-Id: I51ccd7672513118f39518c4ed21902de16b2298f
Reviewed-on: https://gerrit.libreoffice.org/33261
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-24 13:22:37 +00:00
Stephan Bergmann
80cec5faa5 AccStatisticsObject is apparently dead code
Change-Id: I4e04b13538d1242ea38d1400df0ced813171bc5e
2017-01-24 13:37:59 +01:00
Noel Grandin
26f6dadb4f manage SvRefBase-subclass by tools::SvRef in ScXMLTableRowCellContext
ScXMLTableRowCellContext

Change-Id: Ia624e971f31cc517f65b6ae15729476cea091d86
2017-01-24 13:35:19 +02:00
Caolán McNamara
a3fe4ca1b1 just build the hunspell lib, not the rest
might hack around link failures of the hunspell tools under arm

Change-Id: Ib5db702c2898e909e2bb91f4c4bc6b91bd08f47b
2017-01-24 11:22:03 +00:00
Noel Grandin
fe2164949b teach unusedvariablecheck plugin about SfxPoolItem subclasses
which can all be treated as SAL_WARN_UNUSED

The eehtml.cxx change probably fixes some CJK/CTL bug somewhere

Change-Id: I6852129540f316075aee907971ac19418d71dd9a
2017-01-24 13:19:39 +02:00
Noel Grandin
1d7c589d50 loplugin: unnecessary destructor cppcanvas..filter
Change-Id: I009cdd60869a67d210edf879ddb451663a7b8676
Reviewed-on: https://gerrit.libreoffice.org/33491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24 11:02:35 +00:00
Caolán McNamara
04e5d7a614 can use memcmp here, for hopefully a little import boost
Change-Id: I5084eff570a66cc2596b400cbb83d1eb24889f0b
2017-01-24 10:17:57 +00:00
Caolán McNamara
a8f67df121 return early
Change-Id: Ic95f968bcd7acdde170a1128a512f03f77e334cf
2017-01-24 09:56:12 +00:00
Stephan Bergmann
d63b767c69 loplugin:useuniqueptr
Change-Id: I502ebf4024cd9b0ee61d58d6b6a8e342c7ceac08
2017-01-24 10:38:23 +01:00
Caolán McNamara
f0b38738d8 Related: tdf#105426 upgrade to hunspell-1.6.0
Change-Id: I275222d1a7d78cbfb1ca046562fc8a3c314b0fae
Reviewed-on: https://gerrit.libreoffice.org/33454
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-24 09:34:16 +00:00
Miklos Vajna
44cb1d16f2 tdf#104334 DOC import: don't map STYLREF with switches to SwChapterField
Commit d635b35184 (tdf#99100 DOC import:
handle subset of STYLEREF natively, 2016-04-06) started to import the
STYLEREF field code as SwChapterField in case it had \[a-z] switches
after the field argument.

The bugdoc has a \s switch, which is not documented in ISO/IEC
29500-1:2012 17.16.5.59 "STYLEREF", nor is really clear what it would
do.

The original use-case was for the " STYLEREF 1 \* MERGEFORMAT " syntax,
so just keep using fieldmarks for the " STYLEREF <field argument> \[a-z]
" case.

Change-Id: Ibd094e72be4e179c779a79a75769b599d4d9bba8
Reviewed-on: https://gerrit.libreoffice.org/33489
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-24 09:12:06 +00:00
Caolán McNamara
06202a90d6 coverity#1399266 Uncaught exception
Change-Id: I1066fda2258e6acbbbad23256f815975564e5e61
2017-01-24 09:09:57 +00:00
Caolán McNamara
b13b78a906 coverity#1399552 Unintended sign extension
and

coverity#1399551 Unintended sign extension

Change-Id: Iedf7edf35f8b7985860fc254597776fbc1f561f5
2017-01-24 09:09:57 +00:00
Caolán McNamara
86895c6d30 coverity#1399550 Dereference after null check
Change-Id: I4a1ba212b64c7b561f0c1b1f7f75fe255c8d1415
2017-01-24 09:09:57 +00:00
Stephan Bergmann
635d4b0eb8 Clarify some INetURLObject::setExtension behavior
Change-Id: I1a9e7233b2861a3d09661a08c07d2043c9c0c3c1
2017-01-24 10:07:31 +01:00
Samuel Mehrbrodt
6ebf8368a5 Crashdump: Make crash directory configurable
Change-Id: I8106ec674080ede7072581dab2e6700040de5828
Reviewed-on: https://gerrit.libreoffice.org/33032
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-24 08:36:43 +00:00
Noel Grandin
a449e0d242 use rtl::Reference in FastParser
instead of storing both a raw pointer and a uno::Reference

Change-Id: I6b67a6098a3ccdce7e29ee8d601c743897032eaf
2017-01-24 10:26:23 +02:00
Noel Grandin
b1211e965a use rtl::Reference in XFSaxAttrList
instead of storing both a raw pointer and an uno::Reference

Change-Id: I227ac624b03a172e10840c4d1e2c4ca0362b33a4
2017-01-24 07:03:11 +02:00
Noel Grandin
bd281dc6e1 use rtl::Reference in AccessibleBase
instead of storing both a raw pointer and an uno::Reference

Change-Id: I583de7a25893baa65363aa6d3199564f63f4fa60
2017-01-24 07:03:11 +02:00
Noel Grandin
33319078e9 use rtl::Reference in ControllerCommandDispatch
rather than storing both a raw pointer and an uno::Reference

Change-Id: I46496da508689d82211940da765d53378f72fd7a
2017-01-24 07:03:11 +02:00
Noel Grandin
8d611dcc31 use rtl::Reference in ChartModel
instead of storing both a raw pointer and an uno::Reference

Change-Id: I86846c2c756255eb5627a4b1e5144c41865db895
2017-01-24 07:03:11 +02:00
Jochen Nitschke
12643f4161 use range based loops
Change-Id: I8144aa147883120cfbeacddaff0bcec486f84be2
Reviewed-on: https://gerrit.libreoffice.org/33449
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24 05:02:19 +00:00
Noel Grandin
5145f60cc9 loplugin: unnecessary destructor: basctl..codemaker
Change-Id: Iadcfa9bc4fe9efb8d24d6d6afaf2b9b3def0bc3c
Reviewed-on: https://gerrit.libreoffice.org/33452
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24 04:59:44 +00:00
Takeshi Abe
79497f4587 Fix typo in comments: absolut -> absolute
Change-Id: I8aab9004001a9a2ddd54b4c73857b6f9c5b51515
Reviewed-on: https://gerrit.libreoffice.org/33486
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-24 03:10:14 +00:00
Takeshi Abe
c2850bab4f starmath: Inline and remove SmRect::BuildRect()
because a ctor was its only client.

Change-Id: I31cce925231210930576bf93396f9d7aa44a5a71
Reviewed-on: https://gerrit.libreoffice.org/33414
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-24 03:09:37 +00:00
Caolán McNamara
4ef8740c98 Related: tdf#105466 add a freeze/thaw to avoid interim RecalcAlls
so when we are going to do one anyway, skip all the RecalcAlls
that are triggered by queue_resize due to widgets getting added/removed

Change-Id: I23104e27ce1331f660e90fdd3a28a38a4f778a94
2017-01-23 21:01:44 +00:00
Caolán McNamara
0b7c1dcd14 Resolves: tdf#105466 crash when changing conditional formatting condition
Change-Id: Id219a7935f83acf3924e60cb1bf02311dc5c4372
2017-01-23 20:45:44 +00:00
Caolán McNamara
21297dc605 signs match, so don't need to cast
Change-Id: Ic1a3d4816430478c77ed56b4768524147bbce174
Reviewed-on: https://gerrit.libreoffice.org/33284
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23 20:43:34 +00:00
Caolán McNamara
04fafa35fc drop one of the Image ctors
Change-Id: I51178fa30418136d4e5d266715d450f1c967167c
Reviewed-on: https://gerrit.libreoffice.org/33475
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23 20:38:27 +00:00
Jan-Marek Glogowski
bf110d40ef Change all Idle* LINKs to be Timer*
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles
Link in the Timer class. Now there are two possible solution:

  1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or
  2. split the inheritance of Idle from Timer again to maintain
     different Link<>s and move all common code into a TimerBase.

While the 1st is more correct, the 2nd has a better indicator for
Idles. This implements the first solution.

And while at it, this also converts all call sites of SetTimeoutHdl
and SetIdleHdl to SetInvokeHandler and gets rid of some local Link
objects, which are just passed to the SetInvokeHandler call.

It also introduces ClearInvokeHandler() and replaces the respective
call sites of SetInvokeHandler( Link<Timer *, void>() ).

Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23 20:49:05 +01:00
Pranav Kant
75d8b305bb lok: New feature flag to turn off tiled annotations
Change-Id: Ie418642242ada98d4a41f30bb6cefcd57f398ef0
Reviewed-on: https://gerrit.libreoffice.org/33472
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-01-23 19:32:03 +00:00
Szymon Kłos
6d031e4e3a tdf#102142 : disable paragraph spacing icons in the print preview mode
Change-Id: Ia75581ae6fe2942d8c28892f38abda2dd425f33b
Reviewed-on: https://gerrit.libreoffice.org/33474
Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
Tested-by: Szymon Kłos <eszkadev@gmail.com>
2017-01-23 19:26:18 +00:00
Miklos Vajna
a983ad7cf9 gbuild-to-ide: restore exec bit
Lost in commit 115797f070 (beginning of
support for CodeLite in gbuild-to-ide, 2017-01-19), probably
accidentally.

Change-Id: I641ba0b5e2960ff9b98403bd6379608f3e452c9c
2017-01-23 20:23:05 +01:00
Pranav Kant
18fe7c8687 gtktiledviewer: Make edit mode the default one
This is a testing tool, most of the time developers want to do
something with the document to test some functionality, lets keep
edit mode on by default and save them a second.

Change-Id: I61bbd2b85054b7ebdd14e69ca170674e260368e5
2017-01-23 23:18:33 +05:30