Commit Graph

403714 Commits

Author SHA1 Message Date
Noel Grandin
8777c3482d use rtl::Reference in SvUnoImageMap
instead of manual acquire/release

Change-Id: Ia17a1cca542ef0008fe32f2dbfcfce1ecd3161a2
2017-01-23 07:56:34 +02:00
Noel Grandin
71d9f5df23 use rtl::Reference in TransferableDataHelper_Impl
instead of manual acquire/release

Change-Id: I0d7d71a76c84f61f87399d7b7d93be0e50ccae16
2017-01-23 07:56:34 +02:00
Noel Grandin
6f1123d3dd use rtl::Reference in Ruler
instead of manual acquire/release

Change-Id: I7815a0a3c01fce57b4798ac1dbf501e20444c61d
2017-01-23 07:56:34 +02:00
Noel Grandin
bbd8c94967 use rtl::Reference in stoc
instead of manual acquire/release

Change-Id: I626ad9875528fa76d8f781b07cc86e149032ecb1
2017-01-23 07:56:34 +02:00
Noel Grandin
ca958f886c use rtl::Reference in SfxInPlaceClient
instead of manual acquire/release

Change-Id: I4ebbdbcbd619991c3dae0733b797f310903f96e6
2017-01-23 07:56:34 +02:00
Noel Grandin
9605f1cd13 use rtl::Reference in SfxAppData_Impl
instead of manual acquire/release

Change-Id: Id8c1b2dbb9acb0861f71f05a83842f357edfc1e8
2017-01-23 07:56:34 +02:00
Noel Grandin
87a8d05946 use rtl::Reference in CellShell_Impl
instead of manual acquire/release

Change-Id: I4fde1277c023101e5331e3dad4f0243bd8ac8e3f
2017-01-23 07:56:34 +02:00
Noel Grandin
a232712f39 use rtl::Reference in ScSelectionTransferObj
instead of manual acquire/release

Change-Id: I056fc3767f2e7b3ffacdd930e9a8e3b71c32620e
2017-01-23 07:56:34 +02:00
Noel Grandin
8abcd0c387 use tools::SvRef in ImpSdrObjTextLinkUserData
since the field is SvRefBase-derived

Change-Id: Ie84c48daf93e3805b2db240a497a8496779fe750
2017-01-23 07:56:34 +02:00
Noel Grandin
dc33775281 use rtl::Reference in ODatabaseForm
rather than manual acquire/release

Change-Id: Ic5f013b7e4cafc597c659c61fbf568adccfd806a
2017-01-23 07:56:34 +02:00
Noel Grandin
9c6bdac80b use rtl::Reference in SubmissionPropertyHandler
rather than manual acquire/release

Change-Id: I3276361153591a3af8c6b00b478365b2700dedf5
2017-01-23 07:56:34 +02:00
Noel Grandin
32f4f3b52a use rtl::Reference in bib::OComponentListener
rather than manual acquire/release

Change-Id: Ib4b52fb4a85223f974e9905bc3d02eb839150030
2017-01-23 07:56:34 +02:00
Noel Grandin
2bbf21aade use rtl::Reference in DocumentHolder
instead of manual acquire/release

Change-Id: Id795dca5ff9e392fa2649f4721a73ce3ffd6de2c
2017-01-23 07:56:34 +02:00
Noel Grandin
4f5b22b93a use rtl::Reference in OCommonEmbeddedObject
instead of manual acquire/release

Change-Id: Ie641f72687a05e1cd3cf697d551f9c6d21ac4487
2017-01-23 07:56:34 +02:00
Noel Grandin
db0f4ecd00 use rtl::Reference in SbaXGridControl
instead of manual acquire/release

Change-Id: Ie103377d89419648d5f1d786933030b6f6166515
2017-01-23 07:56:34 +02:00
Noel Grandin
b395d9fd82 use rtl::Reference in OResultSet
instead of manual acquire/release

Change-Id: I8baa2e7ac64445ea69d4b62566a89b6e42307e51
2017-01-23 07:56:34 +02:00
Noel Grandin
017911facd use rtl::Reference in OPropertyChangeListener
instead of manual acquire/release

Change-Id: Ie80253b5a59a3e3fcd52f98d9c26bcde42fe985a
2017-01-23 07:56:34 +02:00
Noel Grandin
45e591e237 use rtl:Reference in SmartContent
instead of storing both a raw pointer and an uno::Reference

Change-Id: Ia7a177ed9adcd9d413c86490b57036b0bd80f76d
2017-01-23 07:56:34 +02:00
Ashod Nakashian
f6c0e851ef Lok: unittest batch API
Change-Id: I33bc59756f46b51a69efd91b89813ba17eca6218
Reviewed-on: https://gerrit.libreoffice.org/33403
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-01-23 05:35:52 +00:00
Justin Luth
0c3f61fb61 tdf#104061 MSWordExportBase: tables shouldn't prevent sectionbreak
This also reverts temporary commit ba2c31da97
which was done to look for more pro or con proof documents.  None found.

This section of code has been essentially unmodified since the initial
import in 2000, so apparently the necessity for preventing the processing
of a section if the table item contains pageBreak info is no longer valid.

My guess is that tables were excluded to fudge round-tripping better. Recent
use of dummy paragraphs during import fixes many import problems, and thus
export of the section node no longer should be avoided.

Change-Id: I28bcf618f596a1676e2e7820de192ca63bffe68f
Reviewed-on: https://gerrit.libreoffice.org/32936
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-01-23 04:52:22 +00:00
Ashod Nakashian
1c27286b9d Lok: support for batch API calls
Mouse and keyboard operations typically
come in batches, and often each results in
tile invalidations and/or layout modifications.

Processing each input event on its own, then processing
the resulting output event is very costly and unecessary
when we know there is more of the same.

The new API adds support for batching such related
input events by disabling the output events generated
by Core until the batch is done. The client can
then process the resulting events, which will
be compressed and deduplicated.

Change-Id: Id381dab807186d010021a8778ee440074a739920
Reviewed-on: https://gerrit.libreoffice.org/33402
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-01-23 03:23:19 +00:00
Maxim Monastirsky
d9cfbabc7f bEncodedFilter is always false
Change-Id: I1b959ce8f46f45a789bb7d493c371677ba775f3b
2017-01-23 00:32:47 +02:00
Caolán McNamara
e59b69010c coverity#1399045 Untrusted value as argument
Change-Id: Icac88c7b439036434cbf2352ac50e954139db4ce
2017-01-22 21:57:38 +00:00
Caolán McNamara
f42a57528f wrong stream
Change-Id: I4e890ab80ed4ddb24b0fd41dae12264c99fb1477
2017-01-22 21:55:08 +00:00
Caolán McNamara
d608a304ec return early on not good
Change-Id: I4aca6cb1c3dae652595b93ff7507db713a668d5f
2017-01-22 21:46:47 +00:00
Caolán McNamara
35c602a5f4 move loop variables to loops
Change-Id: I914206bad88fb3c405a335c2926fb51e39b7857e
2017-01-22 21:42:58 +00:00
Caolán McNamara
e2e2775f3b align comment
Change-Id: I50a728e785589e3ec2d9128679f3e69451c5102a
2017-01-22 21:31:01 +00:00
Caolán McNamara
49889a296e coverity#1399029 silence Out-of-bounds read
Change-Id: I025e416a6a162316d82cfbde9fbfcb0a45e888d5
2017-01-22 21:26:45 +00:00
Andras Timar
f5cf7cfecd Updated core
Project: dictionaries  d759f48f50da7ecd05b045780079b54d339f36c6

tdf#105396 update German dictionaries

Change-Id: I74d65e945c3ad080d95d77d846e56b4fa493c3aa
Reviewed-on: https://gerrit.libreoffice.org/33395
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2017-01-22 19:03:16 +00:00
Jochen Nitschke
5301985417 cppcheck: memleak (false positive)
but manage ownership from start

Change-Id: I22d855d89bd93c56fbbcc1fb64e757fc950aa791
Reviewed-on: https://gerrit.libreoffice.org/33391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-22 13:54:22 +00:00
Jochen Nitschke
db2991d159 cppcheck: multiCondition
> Expression is always false becase 'else if' condition matches
> previous condition at line 1130.

Change-Id: Ic56379716ada435ad7e2a00252310bfa50868f04
Reviewed-on: https://gerrit.libreoffice.org/33388
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-22 13:06:07 +00:00
Jochen Nitschke
ab4a55632b cppcheck: useInitializationList
no need to initialise twice,
actually no need to explicit initialise unique_ptr to nullptr

Change-Id: Iff213722e22a0056d7e4c635e62437479c021f08
Reviewed-on: https://gerrit.libreoffice.org/33389
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-22 13:04:43 +00:00
Jochen Nitschke
ffafd5e4a0 cppcheck: useInitializationList
don't initialise the unique_ptr m_pFat twice

Change-Id: Ifa4d9b68756c89c76a1be5803e84526dcfa2c1e7
Reviewed-on: https://gerrit.libreoffice.org/33390
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-22 13:04:24 +00:00
Zdeněk Crhonek
63fd4c9711 add SKEWP test case
Change-Id: I4b1e9711d1d85670e7ec698d961eb63f3cb53e6e
Reviewed-on: https://gerrit.libreoffice.org/33382
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-22 09:29:55 +00:00
jan Iversen
ad98ba87cb gbuild-to-ide, final cleanup in parser.
Now the json file can be expanded with new keys, without
the need to touch parser.

Change-Id: I8182e8030e206e302258bd156d7392ff5c98f3d4
2017-01-22 08:56:18 +01:00
Jochen Nitschke
8be77aaea1 cppcheck: funcArgOrderDifferent
fixes
> Function 'Writer' argument order different:
> declaration 'nDocWidthInput, nDocHeightInput, nDocWidth,
>              nDocHeight, nJPEGcompressMode'
> definition 'nTWIPWidthOutput, nTWIPHeightOutput, nDocWidthInput,
>             nDocHeightInput, nJPEGcompressMode'

use arguments in initializer list

Change-Id: I746da5ef237b62a983df6745e1704342bcea5f9d
Reviewed-on: https://gerrit.libreoffice.org/33381
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-21 22:41:29 +00:00
Zdeněk Crhonek
77fef04a3d add HEX2BIN, HEX2DEC, HEX2OCT test case
Change-Id: I94232c713306f98816308840cc654b7ae1d3d6d3
Reviewed-on: https://gerrit.libreoffice.org/33357
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-21 22:18:37 +00:00
Caolán McNamara
efd58e2b72 coverity#1399435 Unused value
and

coverity#1399438 Unused value
coverity#1399439 Unused value

its all ok as it was, but doesn't hurt to skip the exception test
if the previous test failed anyway

Change-Id: I110ac062d72514c51d415944a2250c3095584531
2017-01-21 21:25:50 +00:00
Caolán McNamara
761af26838 coverity#1399156 split ImplCreateSwapInfo and ImplClearGraphics
Change-Id: Iab449967c70a55c03c3e6b95de8e7d973cb68089
2017-01-21 20:45:23 +00:00
Caolán McNamara
56af72b6fa coverity#1399443 UrF: Unread field
fix like...

commit b9d63d49be
Date:   Tue Jan 12 15:27:41 2016 +0200

    remove some unused Java code

    found by UCDetector

    Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df

Change-Id: I5ce651905edbba3f23ebb421ebc0acadd54f39cf
Reviewed-on: https://gerrit.libreoffice.org/33379
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21 20:38:14 +00:00
Caolán McNamara
5d7d2beba7 coverity#1399442 UPM: Private method is never called
since

commit 10cb59eb91
Date:   Mon Jan 16 16:41:53 2017 +0200

    remove some unused Java code

Change-Id: I00c0b1b22f29165fea73b39b4bf946af453186a3
Reviewed-on: https://gerrit.libreoffice.org/33378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21 20:37:26 +00:00
Caolán McNamara
711f203d1e coverity#1399444 UwF: Unwritten field
and

coverity#1399441 NP: Null pointer dereference

since

commit 10cb59eb91
Date:   Mon Jan 16 16:41:53 2017 +0200

    remove some unused Java code

Change-Id: Ieab0325c8685cdc89458570ac8e4d3292af84dff
Reviewed-on: https://gerrit.libreoffice.org/33377
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21 20:36:57 +00:00
Zdeněk Crhonek
63f3d68d7f add IMABS, IMAGINARY testcase
Change-Id: Icb4f4339318b88c4c2038cb4d1f16af7fc5057a2
Reviewed-on: https://gerrit.libreoffice.org/33361
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-21 20:13:03 +00:00
jan Iversen
9da87ef8d9 gbuild-to-ide clean replaced GbuildLinkTarget with dict
The class GbuildLinkTarget was removed and replaced by a dict.
This is first step in avoiding typing the json key names multiple times

Change-Id: I3a2006979929c5d21549693e51eb47df7233400d
2017-01-21 20:16:40 +01:00
Caolán McNamara
0a09da40dd this.cmdLine assigned twice
Change-Id: Icbc2393ac623d76c3ca5ae74525705f784b99c1c
2017-01-21 17:35:24 +00:00
Caolán McNamara
0dace9ec07 coverity#1399047 Untrusted loop bound
Change-Id: I1c4c4613349935c803d1cf7729c52a3a18ee5375
2017-01-21 17:31:33 +00:00
Caolán McNamara
f5c1909f04 coverity#1399043 Resource leak
Change-Id: I11c23a02241712bbbae62c4716d0ca48c0436107
2017-01-21 17:05:46 +00:00
Caolán McNamara
05e99b1c05 coverity#1399016 Logically dead code
Change-Id: Ib3f0ca4d07dffb568287bcd6a283ab4e529519ff
2017-01-21 17:05:43 +00:00
Caolán McNamara
9ad08b403b coverity#1399031 golden, Out-of-bounds read
There are 17 elements, so SAL_N_ELEMENTS(sppnPatterns) is 17 The largest valid
index is 16, not 17, so valid max index is out by one

Change-Id: Id20218a0e73cb9e502a631fa6bfbb3f0a22c4727
2017-01-21 17:05:43 +00:00
Caolán McNamara
c17b739bad coverity#704601 Dereference after null check
Change-Id: Icfef8f4ded311790a90b61b37c08254592d979ab
2017-01-21 17:05:43 +00:00