403714 Commits

Author SHA1 Message Date
Noel Grandin
21b5c88398 convert SectionSort to scoped enum
and drop read-only SORTSECT_NAME enumerator

Change-Id: Ibb192b0857161560a666e6ffdc2125bc6fc552c5
2017-02-13 08:17:42 +02:00
Noel Grandin
62232e60bf convert SplitTable_HeadlineOption to scoped enum
Change-Id: I5a9ea036b8827a84e646488b2b57012ebadd4d0a
2017-02-13 08:17:42 +02:00
Noel Grandin
d8499c45eb convert ShellModes to scoped enum
and drop read-only SHELL_MODE_DRAW_CTRL enumerator

Change-Id: I2ccaeb492912c876b89ff9b5dccaa99e28a268b7
2017-02-13 08:17:42 +02:00
Noel Grandin
4f52b3b052 drop read-only FileType::SW2 enumerator
Change-Id: Ic14fb46fea04c7b039bd0768108d89e759de4c86
2017-02-13 08:17:42 +02:00
Noel Grandin
f149f5abed convert eF_ResT to scoped enum
and drop read-only FLD_TAGTXT enumerator

Change-Id: I718529082ce540c0e3bca37d969917d3b3a67f5e
2017-02-13 08:17:42 +02:00
Noel Grandin
ba948e3827 convert AnchorState to scoped enum
and drop unused AS_START enumerator

Change-Id: I1ae8e75c6b99f0f923e5f3b020d66e57c81838f0
2017-02-13 08:17:42 +02:00
Noel Grandin
cdbe81f2ac convert SW_KeyState to scoped enum
and drop unused InsDel_* enumerators.
Also rename to SwKeyState to make it a little shorter and more
consistent with other naming.

Change-Id: I837ea8d64a0f26426567dcf78750939fc959a4a4
2017-02-13 08:17:42 +02:00
Tamás Zolnai
1d810b69a5 ChartDumpTest: Let's have a bigger delta
Change-Id: I2bbb2fb5470af3026441102980f026bc9ad753b0
2017-02-13 00:02:32 +01:00
Tomaž Vajngerl
608811c2cb chart2: simplify and/or clean-up and c++11 features
Change-Id: I4550d04ae4bf6e45f24e34dfb2babc0fdef8ba5a
Reviewed-on: https://gerrit.libreoffice.org/34006
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-12 23:00:59 +00:00
Tomaž Vajngerl
8cc8ffdb04 [API CHANGE] Add PopupRequest - a callback to open a pop-up win. in calc
Change-Id: Iea600e229deb69d1638a1a649008fc4738a5934a
Reviewed-on: https://gerrit.libreoffice.org/34005
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-12 22:22:06 +00:00
Tamás Zolnai
614f4b5a32 ChartDumpTest: Fix checking of transformations
Allow 1 point difference.

Change-Id: Ib7d6ca0db773872469f5fc5a0d0dadb4a101c7df
Reviewed-on: https://gerrit.libreoffice.org/34184
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-02-12 22:11:09 +00:00
Maxim Monastirsky
81d4fbc0da tdf#42029 Use a floating toolbar to show clipped items
Change-Id: I6b366f115258ef8497807163179d3e08ab3d5e6f
Reviewed-on: https://gerrit.libreoffice.org/34180
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-12 21:56:29 +00:00
Tamás Zolnai
e5aa7a5b57 Pivot table median function test
Change-Id: I0a31733644aa6d4566566d0324d39aaf6b59b04f
Reviewed-on: https://gerrit.libreoffice.org/34179
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-02-12 21:38:01 +00:00
Caolán McNamara
163435fa23 use alternative optimizations for buffer creation bottleneck
Change-Id: I9f29e8d3e5e97fe403a3e0d7d03c6ac01c7689c4
2017-02-12 21:16:59 +00:00
Tamás Zolnai
125194ff4b ChartDumpTest: Test chart wall
Change-Id: I16b7da66c6a6bab160212c47a75ce22951f85f87
Reviewed-on: https://gerrit.libreoffice.org/34181
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-02-12 21:12:54 +00:00
Caolán McNamara
804287e4ab Resolves: tdf#105426 helpful to actually let the compiler optimize hunspell
*facepalm*

Change-Id: I5f6d6cb94e1a80d2d7ae96900517aae3c8f39f08
Reviewed-on: https://gerrit.libreoffice.org/34176
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-12 21:12:26 +00:00
Tomaž Vajngerl
1425067797 chart2: layout buttons in charts when data is present
This commit layouts the buttons in the chart when there is data
present. Currently this never shows them as other infrastructure
needs to be present to get the PT data.

Change-Id: If33c726eb057b2b938ccb3c00f0d5b671416f355
Reviewed-on: https://gerrit.libreoffice.org/34004
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-12 20:10:55 +00:00
Tomaž Vajngerl
30efd7cfda chart2: simple button (view) to add to a chart
Change-Id: I2001efe1e7eb9e92edb8f5e78535cea0e78935ad
Reviewed-on: https://gerrit.libreoffice.org/34003
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-12 20:08:52 +00:00
Tamás Zolnai
934e2d83e2 ChartDumpTest: Make position and size check a bit more robust
Some of tinderboxes shows these values can be variable
among machines.

Change-Id: I867cc5d124e537d5de16e2b8275f8eb6fdfde447
Reviewed-on: https://gerrit.libreoffice.org/34178
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-02-12 19:41:55 +00:00
Julien Nabet
9732bf2d0d Typo: (trans)fomat->(trans)format
Change-Id: Id2e3024c149b14d40e58f8534946a514ededfcfc
Reviewed-on: https://gerrit.libreoffice.org/34158
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-12 17:09:43 +00:00
Arnaud Versini
b82a9f34ec VCL: Simplify WinSalInstance::CreateVirtualDevice
Change-Id: I26e9823faa53fdbb0ae468f03e40b0a4e5313b49
Reviewed-on: https://gerrit.libreoffice.org/34170
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-12 17:06:29 +00:00
Arnold Dumas
ff2927095e tdf#89329: Use unique_ptr for pImpl in optcomp
Change-Id: I0f6ec9c2bab27dc4c6fe5e94bd3c05319f246b35
Reviewed-on: https://gerrit.libreoffice.org/34171
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-12 17:05:49 +00:00
Tamás Zolnai
49d7bdea17 ChartDumpTest: A new chart test suite for a more sistematic testing
A hibrid of dumper tests (xmlDump) and simple CppUnit tests.
Advantages:
* Easy to add a new test case
** Add a new test file and generate the reference
** Similar to dumper tests
* Easy to find out the root of the problem when test fails
** Assertion is not coming somewhere from an XML file
** Assertion are placed in the code, so if you read and
understand that code, you can find out easier why the test fails.
** Similar to simple CppUnit tests.
* One test checks only one smaller part of the whole document
** e.g. legend, chart data, grid

Change-Id: I7bba5a37efcc62d6358c84acece91963243a914f
Reviewed-on: https://gerrit.libreoffice.org/34154
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-02-12 16:43:06 +00:00
Julien Nabet
8aff36d87f Various typos about property
Change-Id: I7585a1346fb19a886240db8dd393554efee862cc
Reviewed-on: https://gerrit.libreoffice.org/34174
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-12 16:06:46 +00:00
Stephan Bergmann
c26d6edbc1 LEAK_STATIC_DATA is always defined for WNT
cppu_no_leak and bndchk were remnants from pre-gbuild times

Change-Id: Ie9f325c20e39c100b4a7180a9925559f58bcca6b
Reviewed-on: https://gerrit.libreoffice.org/34153
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-12 14:03:53 +00:00
Tor Lillqvist
6d15d4a6f6 Get rid of "unicodes" in lower-case, too
Instead, use "code points" (if you mean full 21-bit Unicode code
points), or "code units" (if you mean the 16-bit units that make up
UTF-16). Hopefully I got it right which one was meant in each case
here.

Change-Id: I8ee7a98996f1cebcfb95cd7d18a56570e48fa390
2017-02-12 12:57:32 +02:00
aleksandar-stefanovic
ce1fec5f5d Changed description of setting entries
Changed to make more sense to non-tech-savvy users.
See https://material.io/guidelines/style/writing.html for
writing guidelines.

Changed grid default value from string to integer, since the value
is effectively an integer, and no point in being a string.

Change-Id: I6c1737927e7f9d20536756c3cb8b7059cf49500b
Reviewed-on: https://gerrit.libreoffice.org/34074
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-12 10:49:48 +00:00
Tor Lillqvist
20c43a23d1 "Unicode" is a proper noun and should not be used in plural
The 16-bit things that make up the UTF-16 encoding are called "code
units".

Change-Id: Iab2b83323783e518198c1a0553f7b053fc415985
2017-02-12 12:43:12 +02:00
Tomaž Vajngerl
d4c09a4e37 sc: simplify GetByName, FreeTable methods of DPCollection + test
Simplify DPCollection GetByName and FreeTable by using c++11
features. Change GetByName to return non-const ScDPObject as this
is more useful (as operator[] does that already anyway).

Change-Id: Ia502c615acc5cb7fdc51acea9b428d04e1c9a40f
Reviewed-on: https://gerrit.libreoffice.org/34002
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-02-12 09:13:19 +00:00
Zdeněk Crhonek
aa7e1415ab add CONVERT_OOO test case
Change-Id: I8804c97a0d9ae02789350cd49537be4262a85277
Reviewed-on: https://gerrit.libreoffice.org/34167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-12 09:02:28 +00:00
Julien Nabet
2b21ac16c2 Various typos on accessible
Change-Id: Id28a4a2cbbcec10a7cc9cb40ad208d575352039b
Reviewed-on: https://gerrit.libreoffice.org/34161
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-12 07:43:23 +00:00
Julien Nabet
d707687fe3 Typo: NUMBULET->NUMBULLET
Change-Id: Ib8d874d77e1a1bb9ef6630f3f2f62c8c8c92e82b
Reviewed-on: https://gerrit.libreoffice.org/34157
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-12 07:40:56 +00:00
Julien Nabet
7017c1bb49 Typo: (De)SelectMutipleChidren->(De)SelectMultipleChidren
Change-Id: Ia3a998e3629c5e002379e6a85b015b6546c59fb8
Reviewed-on: https://gerrit.libreoffice.org/34156
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-12 07:40:14 +00:00
Kohei Yoshida
2aea0d0148 Clarify what this method does. Also remove inaccuracies.
Change-Id: I2d6bda3dccb2040558bd7d4daa9d9b3b43b2d528
2017-02-11 17:02:57 -05:00
Kohei Yoshida
5fea81e4bf tdf#86470: add unit test for this.
Change-Id: Ib93703d10fe1fff0898bc935222df7a0cfe20486
Reviewed-on: https://gerrit.libreoffice.org/34160
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-02-11 22:02:08 +00:00
Kohei Yoshida
bcdde13996 tdf#86470: Let's not forget to move onto the next column.
Change-Id: I451f521723458b5d6fe9d9fa8b41855fe17def64
Reviewed-on: https://gerrit.libreoffice.org/34159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-02-11 22:01:34 +00:00
Stephan Bergmann
c0f241e80f SourceManager::getFilename returns StringRef
Change-Id: I77db8565efe2e0d366afc8470308d7801a2a7337
2017-02-11 20:31:37 +01:00
Stephan Bergmann
e1e261fef3 Remove dead #ifdef _UWINAPI_
...a macro originally introduced with 173db4f242e55172bef92ef78f9d28a4ffc7f204
"#91296# UWINAPI wrapper added", missed by
1f357a5f03401bbc0138eb73807534f59d647121 "Clean out cruft from systools and
especially uwinapi"

Change-Id: Ide3f83d6ea45f4821adb4043ae2a814762d4fafd
Reviewed-on: https://gerrit.libreoffice.org/34152
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-11 18:15:36 +00:00
Stephan Bergmann
61396df4f4 LEAK_STATIC_DATA is only ever defined for WNT
Change-Id: I1aa7b56b44e5efc8ad407c8d0fe09927f622b5e7
2017-02-11 18:32:05 +01:00
Khaled Hosny
72a311533a LigaturesEnabled flag is never set
Change-Id: Id4a4631ff7c69aa01deddd2b88626ff83fd5e7b1
Reviewed-on: https://gerrit.libreoffice.org/34151
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-02-11 17:12:20 +00:00
Arnold Dumas
71eab1c4b0 tdf#89329: Use unique_ptr for pImpl in stlfamily
Change-Id: I0c9df5809a906dbc761f9a51c3424cebb215d0bc
Reviewed-on: https://gerrit.libreoffice.org/34132
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-11 15:06:09 +00:00
Katarina Behrens
c639ae462b Translate some German comments in sc
Change-Id: Iea73c353f59bf0c93d7942e7fffb70e8d00182ba
2017-02-11 15:45:23 +01:00
Stephan Bergmann
99839ca138 Remove comment that is no longer accurate/relevant
...after e16fa715c43dcdf836ce8c400b6d54eae87b627d "Handle wchar_t as native
C++11 type on windows"

Change-Id: I8005a48a43f1baba3c04c11ff52d26d756f25204
2017-02-11 13:05:54 +01:00
Stephan Bergmann
bc9976be20 Misplaced #endif
...ever since 79d3bc479950127ecfd40f73978c0fc84c1e7908 "INTEGRATION: CWS
visibility03: #i45006# Moved from svtools/source/sbx/", at least

Change-Id: If39462e5907817d6a77c98b212d5031610716a7c
2017-02-11 13:01:23 +01:00
Tor Lillqvist
6c30119bbb Pdfium does not build for iOS
It uses Carbon, eek, which was marked as deprecated for OS X already
back in 2012, and never has been available for iOS.

Change-Id: Icfc57dff1ae01272a347a050303139f4f86e6fec
2017-02-11 13:55:19 +02:00
Stephan Bergmann
709709962d Upon failure, 'cd' itself already prints a message to stderr
Change-Id: Iabe3a6bb14ca3e83a0792d7fc131ae0ac74e578c
2017-02-11 12:54:24 +01:00
Takeshi Abe
ad849f4bda starmath: Make stricter assertion to prevent out of range
Change-Id: I3ce0712e5095ade35628bad026a91a11dc6b9967
Reviewed-on: https://gerrit.libreoffice.org/34146
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-11 11:14:59 +00:00
Zdeněk Crhonek
258f2f439b IMCOS test case update
Change-Id: Id415829b2361b530904211ae8a940648646a1250
Reviewed-on: https://gerrit.libreoffice.org/34107
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-11 09:09:11 +00:00
Kohei Yoshida
6d450aad0a tdf#95306: Be sure to specify the entire range.
Especially in presence of multiple disjointed selections.

Change-Id: I8e7779824109c30e69fd43a2448ae900beaf28d3
Reviewed-on: https://gerrit.libreoffice.org/34140
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-02-11 04:42:30 +00:00
Eike Rathke
d3293c7173 Revert "Resolves: tdf#79250 add typed list to form control listbox"
This reverts commit e387b69967aabc44d5da5aaad8d94191437dc57c.

It breaks toolkit.subsequentcheck with
propertyChangeListener wasn´t called for ´TypedItemList´

Back to the drawing board for the twisted property logic of forms and
toolkit uno control models.
2017-02-11 01:19:37 +01:00