403714 Commits

Author SHA1 Message Date
Michael Stahl
d22377ab55 tdf#98993 cui: Paragraph dialog: decimals in Line Spacing spinbox
For whatever reason, this also makes the +/- buttons increment by 1pt
instead of the previous 10pt, which is also an improvement.

(presumably regression from 324141f21bf2280d7613c4056ee8cd997ea345f9)

Change-Id: If47dd768b2faea760d9967a73453d3f714c65fe3
2017-02-09 23:07:40 +01:00
Zdeněk Crhonek
6d1b4c8592 add IMSINH, IMSQRT,IMSUB,IMSUM,IMTAN test case
Change-Id: I02e4517948a300f0c8753bbccb2f1980dcc3ae2c
Reviewed-on: https://gerrit.libreoffice.org/34102
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-02-09 21:42:03 +00:00
Michael Stahl
bd269f902b tdf#91596 sw: make Format All Comments persistent
Change-Id: I8f9a20084d2dc8abd7699f64307b81321699498c
2017-02-09 21:42:38 +01:00
Bjoern Michaelsen
1bc10ebd32 use proper message passing
Change-Id: Ic41c7acc73c2d275dfdb6b2ffcbb24fba5f8be72
Reviewed-on: https://gerrit.libreoffice.org/33980
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-09 20:23:02 +00:00
Jochen Nitschke
dca6eefc21 use std::unique_ptr
Change-Id: I6d80d47dcc40daf2749eeec58a7ca19d09c4b803
Reviewed-on: https://gerrit.libreoffice.org/34045
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 19:21:13 +00:00
Stephan Bergmann
1d2c7fd407 -Werror,-Wunused-macros
Change-Id: I06a6b6fa51fe437661610a4a678cd2d410bb1e4c
2017-02-09 19:54:58 +01:00
Stephan Bergmann
a218c5c639 Dummy implementations of backtrace/backtrace_symbols on Android, too
pt#2

Change-Id: I5cc280613879786bd723019d630edb5a920419b9
2017-02-09 19:51:36 +01:00
Stephan Bergmann
b4cb88dbbd loplugin:unnecessaryoverride
Change-Id: I5b344a92f4d762517529fb43fb68e849a7c0a619
2017-02-09 19:19:35 +01:00
Eike Rathke
1e02bf3ceb and more unit tests for tdf#103890
Change-Id: I342b11cb1442ff5ad4a51d8b8f2f7ed9f081bcaa
2017-02-09 18:54:53 +01:00
Eike Rathke
aeb465a458 yet more 3D flag to preserve cases, tdf#103890 follow-up
Change-Id: I8b8cdb01325d0cd54e436c1043c243eedfddbfb0
2017-02-09 18:54:20 +01:00
Eike Rathke
08a0850bfe add absolute sheet reference unit test for tdf#103890
Change-Id: Idb4a182a548efe00be66194ba38655baeb80069f
2017-02-09 17:43:54 +01:00
Caolán McNamara
5f8b616611 Resolves: tdf#101648 disable new/modify of table styles
cause there is no ui for it at the moment, so it crashes

Change-Id: I703449ff69f93b6385d3bf9225abe81682d3b893
2017-02-09 16:34:17 +00:00
Stephan Bergmann
c697ae306c Some clean up
No more need to call sal_detail_log_report from sal_detail_log, now that it is
called from SAL_DETAIL_LOG_STREAM since b3a11c8f4f307bbbb597c9c6e7e61ee93e794873
"tdf#91872: Make SAL_INFO and friends more efficient".

Change-Id: Idb6cf7a4814abe29d5ba68591f39b4279267bc9b
2017-02-09 17:05:22 +01:00
Eike Rathke
6e1efe7b6b preserve 3D flag if sheet reference is absolute, tdf#103890 follow-up
A reference like $Sheet1.A1 should have the 3D flag preserved when
moving around, otherwise the absolute flag is still there but invisible
when moving within or onto Sheet1.

Change-Id: I937091535bc37d0bdbffb786472d7eae2f931df0
2017-02-09 16:58:51 +01:00
Eike Rathke
12ecbe7962 space typo
it's an interface name..

Change-Id: Ie758f29864761a4e0c41326dac14d233c22e5f52
2017-02-09 16:58:51 +01:00
Stephan Bergmann
b6a69585b0 Fold sal_detail_log_backtrace into sal_detail_log
...the latter is LO-privately exported from sal, so it should be OK to add one
more parameter to it.

Change-Id: If6bf3458433aac2cc8b4e0cbd1602306051a777b
Reviewed-on: https://gerrit.libreoffice.org/34080
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-09 15:56:50 +00:00
Caolán McNamara
6851074c8a Resolves: tdf#66237 set layout manager the way it used to
model Frame::setLayoutManager after the Frame::impl_setPropertyValue handler
for FRAME_PROPHANDLE_LAYOUTMANAGER which used to be used before

commit b248624126c271c88381d3dad6e04fc954f65779
Date:   Fri Mar 22 09:24:15 2013 +0200

    fdo#46808, Convert frame::Frame to new style

i.e.

- Reference< XPropertySet > xFrameProps( m_xFrame, UNO_QUERY_THROW );
- xFrameProps->setPropertyValue( OUString( "LayoutManager" ), makeAny(Reference< XLayoutManager >()) );
+ m_xFrame->setLayoutManager( Reference< XLayoutManager >() );

Change-Id: I00f1a2cb8e4fafc6d484634619cbeaf58c603d87
2017-02-09 15:28:43 +00:00
Mike Kaganski
d48b805794 tdf#105852: don't merge cells if there were no merge continuation
In RTF, it's possible to start a cells merge using \clmgf, and simply
omit following cells in the row - they must merge automatically.
This makes HorizontallyMergedCell::m_nLastCol/Row uninitialized.
Previously, the uninitialized values arrived as 0,0 - thus the first
range's cell got merged with cell 0,0.

This change prevents the merge; in scenario above, absence of additional
cells in row will create merged cell automatically.

Change-Id: I68b84b7ec70d9512c541a077689369fa4a8dc0c5
Reviewed-on: https://gerrit.libreoffice.org/34079
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-02-09 15:23:32 +00:00
Caolán McNamara
60933220b2 replace localresource of strings and keys with StringArray
Change-Id: I369de4213c4cb38013b984d1c2784ad68e25793c
2017-02-09 14:18:04 +00:00
Kohei Yoshida
99d35740a1 tdf#103890: Add unit test for this.
Change-Id: I93a17f90b7e6ff9aa5133401b2630d4b4e0cced5
Reviewed-on: https://gerrit.libreoffice.org/34050
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-02-09 14:05:43 +00:00
Kohei Yoshida
bf8d4fb60d tdf#103890: Fix the logic on setting 3D flag on reference.
I believe the old logic (which I had put in place) is incorrect. We
show the sheet name only when the reference address is on another
sheet, and we do evaluate on a per-reference basis.

Change-Id: Id9e51918233eda3b72b95b89a9fcced21eb9ef93
Reviewed-on: https://gerrit.libreoffice.org/34049
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-02-09 14:05:27 +00:00
Michael Stahl
c37a53315b sw: even more integers acting up
Change-Id: I55f6d49ca831ca421e7615c096cd7ac7147caf62
2017-02-09 14:38:05 +01:00
Michael Stahl
31a04e09cd sw: fix even more integer madness
Change-Id: Id785992300de7f8ae714b7fdcf822b42d11353b1
2017-02-09 13:54:18 +01:00
Michael Stahl
816a61c935 sd: argh fix the C++ integer madness again
Change-Id: I47bf134a7ef0ebcd45ec3cc2c7cf805387ecadb9
2017-02-09 13:54:18 +01:00
Stephan Bergmann
3f46caf7af Dummy implementations of backtrace/backtrace_symbols on Android, too
Change-Id: Ibbab23a9332c3475ab6ce5654999f040e936acfb
2017-02-09 13:44:00 +01:00
Michael Stahl
6b19839909 xmloff: remove onDemandRescueUsefulDataFromTemporary
This workaround, which is both complex and quite incomplete,
should no longer be necessary because the fixes for tdf#103567
should also fix i#124143, see unit test in previous commit.

Change-Id: I038f238d5e3cf5cadfc666196380b7b351543982
2017-02-09 13:17:42 +01:00
Michael Stahl
dbc3119053 i#124243 sd: add unit test for ODF import of glue points on SVG shape
Change-Id: Ib6434063f4dfebb5f3e180c7136b411dbf0d94d0
2017-02-09 13:17:10 +01:00
Michael Stahl
ae00898f12 tdf#103567 xmloff: ODF import: fix more lossage on Writer frames
There's another context that reads draw:frame, and it has the same
problem as the one used for Impress shapes.  This causes SVG images
in Writer to lose contour polygons and image maps.

Fix this the same way as the other context.

(likely regression from 44cfc7cb6533d827fd2d6e586d92c61d7d7f7a70)

Change-Id: I16cf55e68829b4e1b0841f2015d0729be0ce3725
2017-02-09 13:17:10 +01:00
Michael Stahl
3ce68a2a7c xmloff: fix this CreateChildContext to be properly ignorant
Change-Id: I0b5cc271768ba29d039abb05408ccbd686c18544
2017-02-09 13:17:09 +01:00
Noel Grandin
858bd8b8be convert ResultType to scoped enum
and drop unused enumerators

Change-Id: I429e586967ef46e2657e296a369cdeb3b75bfc02
Reviewed-on: https://gerrit.libreoffice.org/34064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 11:11:38 +00:00
Jochen Nitschke
d2f4700331 expat moved to github
see https://sourceforge.net/p/expat/code_git/ci/master/tree/MIGRATED_TO_GITHUB.txt

Change-Id: I9f0351debb69f7aae2b066ad90e983cb6259bff5
Reviewed-on: https://gerrit.libreoffice.org/34041
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-02-09 11:08:01 +00:00
Miklos Vajna
91af0067c9 xmlsecurity: remove unused EncryptorImpl
No longer necessary since commit
50669de68785d61534c4c3fe101fd8e1d12fae65 (xmlsecurity: remove unused
xsec_fw_component_getFactory(), 2017-02-02).

Change-Id: Ibbc78888abcd1cb6d7f242c93f28cdaf836cca14
2017-02-09 11:50:12 +01:00
Tor Lillqvist
b21ba53be7 loplugin:staticmethods
Change-Id: I46d24d74e48806368f1726688747f0872100c438
2017-02-09 12:44:14 +02:00
Caolán McNamara
f67dc04cfd Resolves: tdf#101972 skip invalidating labels on alt if autoaccel is disabled
so no Invalidate will be called if auto accelerators are not enabled
so there should be no blinking under windows

Change-Id: Iccc5dad7af41f39ac02d3be93e935f2d926a82a6
2017-02-09 10:28:44 +00:00
Stephan Bergmann
b52948a77d Proper -Werror,-Wunused-parameter fix for C code
Change-Id: I2ebd350c3c39f848f5a39fa120154dc449173434
2017-02-09 11:22:26 +01:00
Noel Grandin
76cf4c3656 convert PDFVersion to scoped enum
Change-Id: I9920f4c9783eb23a41d135e5eacd12805c1b9c2b
Reviewed-on: https://gerrit.libreoffice.org/34060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 10:13:58 +00:00
Stephan Bergmann
de3b0afd73 -Werror,-Wunused-parameter
Change-Id: I1a52e05994d6a31aa5e65bc3357f48258fb6f049
2017-02-09 11:12:07 +01:00
Noel Grandin
3e33fbd269 restore constant to VerticalOrientation
Removed in commit f4826959c1a5b0e6d2849d4240668b2087582848
"new loplugin:unusedenumconstants".
And add a comment.

Change-Id: I63d6f46aa92e31db08e51e47a62104dc7d3d3359
Reviewed-on: https://gerrit.libreoffice.org/34057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 10:09:08 +00:00
Noel Grandin
76e0f23171 convert DestAreaType to scoped enum
and drop read-only enumerators

Change-Id: Ibc4c2a99448a83fc179e2779f8f3e5c8f034ae7b
Reviewed-on: https://gerrit.libreoffice.org/34059
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 10:03:52 +00:00
Yousuf Philips
a25b1ff25a tdf#91820 - Toggle sheet grid is per sheet option
Change-Id: I7ba75517dc68f5fd977f140b6a7e37fbfe1fcf7f
Reviewed-on: https://gerrit.libreoffice.org/33914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-02-09 09:52:03 +00:00
Noel Grandin
bca47d830e remove ConnectionIdentifierType enum
since we only use the AsciiCString enumerator.
Consequently simplify the GetConnectionIdentifier method

Change-Id: I9e1a1318d2f12bfd18edeb8479e0e7171b22d0f1
Reviewed-on: https://gerrit.libreoffice.org/34026
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 09:51:05 +00:00
Noel Grandin
4ccdf7932e convert PDFWriter::PageTransition to scoped enum
and drop some read-only enumerators

Change-Id: I96380efec90abe02fa02c3f766f2b6180723da0d
Reviewed-on: https://gerrit.libreoffice.org/34058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 09:47:37 +00:00
Stephan Bergmann
c71f4dc97b Implement SAL_DEBUG_BACKTRACE for Linux
...by using glibc's backtrace_symbols(3).  If this is ever implemented for other
platforms, backtrace_symbols' interface may turn out to be awkward; but just use
it directly for now.  Also, the output from backtrace_symbols isn't too useful
in itself, as for non-exported symbols it only prints soname+offset, but some
addr2line postprocessing can turn that into something half-way decent.

Change-Id: I58cc7912aa7d8031729fc116a82a409c1c16977a
2017-02-09 10:37:25 +01:00
Stephan Bergmann
8458ec8c9c Fix SAL_DEBUG_BACKTRACE
...after 56d071c10ca8016848f1f059aa3eb197fe928844 "rename SAL_DEBUG_TRACE to
SAL_DEBUG_BACKTRACE" (looks like this doesn't get used much...)
2017-02-09 10:35:20 +01:00
Caolán McNamara
cff6cdb2ee Resolves: ofz#576 unexpected exception with invalid fraction
Change-Id: I1d653775e88e9fa2ba7b62fce39d52fc21ffe363
2017-02-09 09:22:31 +00:00
Caolán McNamara
e2b1e755e2 drop unused RSC_BYNAME define
Change-Id: If26e39fedc1687ceb08d3e8663f95f4d84b5c488
2017-02-09 09:22:31 +00:00
Caolán McNamara
49c007b394 split getApplicationBasicManager into get and getOrCreate
Change-Id: I8e35594104ba85470eda387bc227e88bf77ccffd
2017-02-09 09:22:31 +00:00
Henry Castro
f5e330abbf sc lok: Limit number of row with LOK to 1000 rows.
Change-Id: Ic7fe2dec012efb8ba180feb4d3df6f4bfbf6c38a
2017-02-09 09:56:50 +01:00
Jochen Nitschke
5b19a738ed replace pointers with objects in std::vectors
Change-Id: Id5577ae0b3bdf31b6d5e409cd2c0033d9f2591a2
Reviewed-on: https://gerrit.libreoffice.org/34046
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 08:46:13 +00:00
Noel Grandin
0bf5254b00 convert PaintMode to scoped enum
and drop unused INVERT enumerator

Change-Id: I6db12ff76a5515bcb4691403b8fb380f9d74c1c9
Reviewed-on: https://gerrit.libreoffice.org/34055
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 08:42:27 +00:00