403714 Commits

Author SHA1 Message Date
Noel Grandin
b5699cd01b convert BmpConversion to scoped enum
and drop unused 4BIT_TRANS and 1BIT_MATRIX enumerators

Also fix a bug in x11::convertBitmapDepth where we were incorrectly
passing BmpConversion enumeratirs to ReduceColors

Change-Id: I903c6866750e46ee752e10a17c05fcaaf6b11242
Reviewed-on: https://gerrit.libreoffice.org/34062
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 08:42:06 +00:00
brainbreaker
f1c844fed0 Explorer File View option in Settings working now
Explorer file view option in Settings is working now.
To listen to the preference updates in the app
a custom class SettingsListernerModel has been added.
SettingsListenerModel.java file contains the methods
to instantiate and set OnSettingPreferenceChangedListener
in the implementing class.
LibreOfficeUIActivity implements this listener
and it is triggered by onSharedPreferenceChanged() method
in SettingsActivity.
This class can also be used to listen to other preference changes
in Settings.

Change-Id: I063024df01cf183d2a6211648e32805795af20a9
Reviewed-on: https://gerrit.libreoffice.org/34012
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-09 08:33:02 +00:00
Noel Grandin
eecf39c6e4 convert FontType to scoped enum
Change-Id: Ieb8f90be8effde5f25bc872784c3ea2177b14bf9
Reviewed-on: https://gerrit.libreoffice.org/34056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 08:09:12 +00:00
Andras Timar
0e9fbe1db2 drop ooo2gd (Google Docs) extension from license files, too
Change-Id: Ie5642709b0befe49f8d31fe73867b541a0ea11a9
Reviewed-on: https://gerrit.libreoffice.org/34032
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-02-09 07:08:43 +00:00
Jochen Nitschke
67cf45f54c move member to stack
ScRTFColTwips is a vector with some extra logic

Change-Id: I1ef08152d57f73404d08a566e311fdbe8934f68c
Reviewed-on: https://gerrit.libreoffice.org/34047
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 05:57:24 +00:00
Jochen Nitschke
14c8ed764c use std::unique_ptr and reorder members
use unique_ptr for ScEEParser.

mpParser needs mpEngine to initialise.
declare, construct and destruct in right order.
make use of virtual dtor of mpParser.

let dtor default for ScRTFImport and ScHTMLImport (they have
no own members).

Change-Id: Ic6f830df121d687084ea394e68a37797e53f7108
Reviewed-on: https://gerrit.libreoffice.org/34044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 05:53:19 +00:00
Jochen Nitschke
e70048ebbf use std::unique_ptr<>
Change-Id: Iaad3a9784d2ad30f2c04f18e9987446238425c6b
Reviewed-on: https://gerrit.libreoffice.org/34043
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 05:51:34 +00:00
Jochen Nitschke
1955e5361c remove obsolete noop call
Change-Id: Iac60817702f7691adbabdea8a59efc4f56f249da
Reviewed-on: https://gerrit.libreoffice.org/34042
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 05:48:45 +00:00
Noel Grandin
bcad173faa Reapply "create ErrorHandlerFlags scoped enum for error handling flags""
This effectively reverts commit 32cae6a2eaa41568888df9c8fc5605debd8d704a.

Change-Id: I15bb0a5c4acaeee6d47dd93a71601d9687d701bc
Reviewed-on: https://gerrit.libreoffice.org/34028
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 05:47:36 +00:00
Noel Grandin
afc755fa61 loplugin:unusedenumconstants read-only constants in vcl (2)
Change-Id: Ia3da23e0ef2fa710403745bd11255ed001516da4
Reviewed-on: https://gerrit.libreoffice.org/34020
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 05:46:03 +00:00
Khaled Hosny
026345eeb2 Don’t look for bundled fonts relative to executable path on Windows
Just do like other platforms, so that the fonts are avialble to unit tests
since cppunittester is not run from instdir.

Change-Id: Ib209473f5b6b07a154fecb430dca45b32e8fa556
Reviewed-on: https://gerrit.libreoffice.org/34048
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-02-09 03:16:35 +00:00
Bartosz Kosiorek
0e0fef1000 tdf#50916 Allow proper updating, deleting and inserting tabs
Change-Id: Ib318c3ff14970483fdcda1fdd6de9969f47ccbe8
Reviewed-on: https://gerrit.libreoffice.org/33647
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-02-08 23:13:07 +00:00
Bartosz Kosiorek
b78c6d8efd tdf#50916 Introduce new column validation function
Change-Id: Ib8f7b3793732a113e764c4345c07803eb8bcbc3f
Reviewed-on: https://gerrit.libreoffice.org/33196
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-02-08 20:06:42 +00:00
Miklos Vajna
b668b90dee pdfium: work around macOS 10.9 build
I assume this is a compiler bug, the patch can be dropped when we don't
build on this baseline anymore.

Change-Id: Ic65f830b888864db075efefd5b2e5d2520d9213e
Reviewed-on: https://gerrit.libreoffice.org/34033
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-08 18:23:15 +00:00
Khaled Hosny
b27324d219 Outdated comment, we are returning a reference!
Change-Id: I4061f9f421666064f918d8a46375f7f770626ab6
2017-02-08 20:04:03 +02:00
Khaled Hosny
25912929cf This is only used within vcl
Change-Id: I64d7e39506495e9fcc78bb670b897338a01a9ae1
2017-02-08 20:04:03 +02:00
Khaled Hosny
c419d2f1b0 Move the typedef where it is used
Change-Id: I275e96ce3761b61b62748a1e75f1a7a88640e7cf
2017-02-08 20:04:03 +02:00
Michael Stahl
791431d7e2 tdf#103567 xmloff: ODF import: fix loss of events on SVG multi-image
For SVG there are 2 draw:image children in the draw:frame, and the
SdXMLEventContext::EndElement() applies the content of
office:event-listeners to the shape created from the last draw:image
and then MultiImageImportHelper::solveMultipleImages() throws
it away because it's the bitmap fallback of the SVG.

Avoid that problem by calling solveMultipleImages earlier:
The ODF schema ensures that all the draw:image elements occur before
the optional property-bearing child elements of draw:frame,
so we just call solveMultipleImages on the first such optional
element, so that all subsequent properties get applied to the one
surviving shape.

(likely regression from 44cfc7cb6533d827fd2d6e586d92c61d7d7f7a70)

Change-Id: I2be5f6f424dbfd90ca2179ce6f9057929540e762
2017-02-08 18:49:45 +01:00
Caolán McNamara
725c81613c ResId::SetAutoRelease now unused
Change-Id: Ieaee60607200973f8d725d19a9c63bdc2f230850
2017-02-08 16:30:56 +00:00
Stephan Bergmann
0eed6c98ca loplugin:unreffun
Change-Id: I7cd699632b05ac8de6c5e3a6dbc66b8de7d88054
2017-02-08 17:27:02 +01:00
Caolán McNamara
2e30b18c9a replace localresource of strings and keys with StringArray
Change-Id: I4abce924a89f611c28d0441ae097b310193b5dae
2017-02-08 15:38:13 +00:00
Caolán McNamara
e5b23d924d clarify we're not setting a pal index in the mask
no logic changed intended, SetPixelIndex expands
to this, just want to clarify that this is an alpha
value, not an index into a palette

Change-Id: Ie9bb188b116adf3eab4e2bb1d6da8badbaead88b
2017-02-08 13:54:24 +00:00
Caolán McNamara
2c91fc1944 replace localresource of strings and keys with StringArray
Change-Id: I402f5485af0c1e60677b8291c879bc7ca14633d3
2017-02-08 13:54:23 +00:00
Zdeněk Crhonek
41ae267529 add IMCSC test case
Change-Id: I957a8f1396425eda8530417aecfde6a70570d058
Reviewed-on: https://gerrit.libreoffice.org/33922
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:35:10 +00:00
Zdeněk Crhonek
d8a3a0e5d8 add IMLOG2 test case
Change-Id: Ic313ce3807c9b16563cc3421a84d1d28dab54670
Reviewed-on: https://gerrit.libreoffice.org/33928
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:32:42 +00:00
Zdeněk Crhonek
7348d834da add IMCOT test case
Change-Id: Ieb3065d899099804a598e0750799810195c36343
Reviewed-on: https://gerrit.libreoffice.org/33921
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:32:38 +00:00
Zdeněk Crhonek
8125dd2fc5 add IMSECH test case
Change-Id: I9eedb7056d448fa90153b08b4184914f79aec7d8
Reviewed-on: https://gerrit.libreoffice.org/33939
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:31:43 +00:00
Zdeněk Crhonek
33c6ccecf4 add IMPRODUCT test case
Change-Id: I8d8fb1305b5d35f50ec1caec962aa251d6d1654a
Reviewed-on: https://gerrit.libreoffice.org/33931
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:31:39 +00:00
Zdeněk Crhonek
931861c191 add IMSIN test case
Change-Id: I017b844484a1616a16fb08b694950fc97d68a994
Reviewed-on: https://gerrit.libreoffice.org/33940
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:31:28 +00:00
Zdeněk Crhonek
1c30ea571f add IMSEC test case
Change-Id: I08ec61f13a802715966b4def55f57a3504a57ce3
Reviewed-on: https://gerrit.libreoffice.org/33934
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:31:23 +00:00
Zdeněk Crhonek
e7ec531e2c add IMREAL test case
Change-Id: Iaae6f2d096e625357cfda1b9e441a0f5af140c06
Reviewed-on: https://gerrit.libreoffice.org/33932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:31:18 +00:00
Zdeněk Crhonek
1251ad74eb add IMEXP test case
Change-Id: I6d623e5520a0300776f8e437034db2225c7be1e9
Reviewed-on: https://gerrit.libreoffice.org/33926
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:31:11 +00:00
Zdeněk Crhonek
8875adefeb add IMLN test case
Change-Id: I37df10ca0c76c66cdc881ef81116b7fb935a450e
Reviewed-on: https://gerrit.libreoffice.org/33927
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:31:01 +00:00
Zdeněk Crhonek
e1a1cc6342 add IMDIV test case
Change-Id: I5d4e9aacf7c8843fdc980d6b25051235f97cc9a8
Reviewed-on: https://gerrit.libreoffice.org/33924
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:30:58 +00:00
Zdeněk Crhonek
9aaabf3e03 add IMLOG10 test case
Change-Id: I66fc62ba15c3fde7e1e7143a20479cb18940498d
Reviewed-on: https://gerrit.libreoffice.org/33929
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:30:49 +00:00
Zdeněk Crhonek
19a8ba4539 add IMCSCH test case
Change-Id: Ibd99d3af9e80aa506ed08da7ce16e6ea936efbff
Reviewed-on: https://gerrit.libreoffice.org/33923
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:30:46 +00:00
Zdeněk Crhonek
f675131cf9 add IMPOWER test case
Change-Id: I584338dea3e859378e5c782ce9e50954f7f914dc
Reviewed-on: https://gerrit.libreoffice.org/33930
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:30:42 +00:00
Zdeněk Crhonek
ddbd5fbf85 add IMCOSH test case
Change-Id: I3aee4ed4e03fd23614778890a0afe5b7461cca0d
Reviewed-on: https://gerrit.libreoffice.org/33920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-08 13:29:13 +00:00
Noel Grandin
65b7b6322b loplugin:unusedenumconstants read-only constants in vcl
Change-Id: I8c81444cbecdc103cc47d9a4133b0b4d9010e0c2
Reviewed-on: https://gerrit.libreoffice.org/34018
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08 12:42:52 +00:00
Noel Grandin
20915bcbf4 convert WMWindowType to scoped enum
and drop read-only ModalDialog enumerator

Change-Id: Ie295e4863381401c73bd2a4151b94ad529c261fd
Reviewed-on: https://gerrit.libreoffice.org/34023
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08 12:36:46 +00:00
Noel Grandin
eb1352bb40 drop unused enum TTCreationFlags
there is only one method using it, and all of the call sites pass 0

Change-Id: I5d71b36cf890fbcf0be9d795756da0cfd61ae309
Reviewed-on: https://gerrit.libreoffice.org/34024
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08 12:36:24 +00:00
Miklos Vajna
b6f9eeb9b5 external: bundle pdfium
Initial use case is to avoid creating a whole Draw document + a poppler
process for each and every PDF image we load in a document.

The MSVC patch is only to support MSVC 2013, as upstream already moved
to MSVC 2015.

Change-Id: I3c9dbac3e3de9f2e874ca4cfec0a9dd8a388b87c
Reviewed-on: https://gerrit.libreoffice.org/34022
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-08 12:33:11 +00:00
Stephan Bergmann
af35c02a80 Missing include
Change-Id: I312677b88982ef1ff430d8cd440f3bd7c52d51fb
2017-02-08 13:30:08 +01:00
Caolán McNamara
ff82f13b68 drop unused error strings
includes ERRCODE_SFXMSG_STYLEREPLACE

which has the knock on effect that the flags argument
can be removed from a bunch of methods

Change-Id: I72b58bc2a19376bb4609e61aa44e71f734efb333
2017-02-08 12:18:41 +00:00
Caolán McNamara
9192e85076 move the extra data of ERRCODE_SFXMSG_STYLEREPLACE out of the .src
Change-Id: I5c39d785d1f2a78e1fcfcd763deac60f047a5e4b
2017-02-08 12:18:41 +00:00
Michael Stahl
12b865c028 gbuild, python3: stop defining SOLARIS, and remove SOLARIS patch
It's faster to change our code not to rely on -DSOLARIS than to
wait for python developers to remove such nonsense from their public
headers.

Change-Id: I3ab05d41bbb51b91a2add599339ce334b5099330
2017-02-08 12:58:38 +01:00
Michael Stahl
2e0e05aa3c basic: another SOLARIS check here converted to __sun
Change-Id: Iec76b096cfcab4bd45b77bdb1438776bf5de69ca
2017-02-08 12:58:37 +01:00
Tor Lillqvist
3b94a463c5 The string "###" can be written as such, no need for a Special Const Variable
Change-Id: Ib9737acc8e0a9845fc03ed2c7de7969cef41f27c
2017-02-08 13:35:19 +02:00
Tor Lillqvist
4df2bc90cc A newline is not that special or hard to remember
Change-Id: I2960a59283a5a04c5c804a57e43bdb633c0e45cf
2017-02-08 13:35:19 +02:00
Andras Timar
21864fed06 tdf#105814 enable localization of "host" and "port" in sample addresses
Change-Id: I2e58f4757bd86393410cdc6fd77205a8ebb9b917
Reviewed-on: https://gerrit.libreoffice.org/34021
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-02-08 11:33:41 +00:00