349099 Commits

Author SHA1 Message Date
Michael Stahl
15006df5bd tools: remove unused SvStream::IsA() and associated ID_*STREAM macros
Change-Id: I6ed0991fb5bd1d5085ee1b93323b57b1afc69860
2014-03-29 02:03:07 +01:00
Michael Stahl
1258b576ae tools: support 64-bit file positions in SvStream
Bump stream positions to 64 bits on:

SvLockBytes::SetSize()
SvStream::SeekPos()
SvStream::SetSize()
SvStream::SetStreamSize()
SvStream::Seek()
SvStream::SeekRel()
SvStream::Tell()
SvStream::remainingSize()
SvStream::nActPos
SvStream::nBufFilePos

Change-Id: I0521fd60d31d1a33e5634cbf51dd42edc46ad919
TODO: adapt callers of Seek()/SeekRel()/Tell()/remainingSize()
2014-03-29 02:03:07 +01:00
Michael Stahl
19bbfc0b39 tools: allow 64-bit positions on SvLockBytes
Bump stream positions to 64 bits on:

SvLockBytes::ReadAt()
SvLockBytes::WriteAt()
SvAsyncLockBytes::m_nSize
SvOpenLockBytes::Seek()
SvOpenLockBytes::Tell()
SvOutputStreamOpenLockBytes::m_nPosition
OInputStreamHelper::m_nActPos

Change-Id: Ica3b674e0ab23a756260a51475e97a5396ecdddb
2014-03-29 02:03:07 +01:00
Michael Stahl
655a39d8c0 basic: for PutData()/GetData() actually 32bits should be enough
Change-Id: I3c605a1e5b46d262ff557dac280b15136467b906
2014-03-29 02:03:07 +01:00
Kohei Yoshida
2ec45841b9 rhbz#1080196: Delete the destination first then paste.
Deleting in-between pasting was causing the block iterators to become
invalid when the deletion took place, which resulted in a segfault.

Also cleaned up the bits about handling filtered rows.  It was using the
old row flag which is empty these days (so it never would have worked).
Plus we do bail out earlier if the destination contains a filtered row.

Change-Id: I78d3ee8bce1647c1c8685f92a3df3c38cc014811
2014-03-28 20:56:32 -04:00
Kohei Yoshida
915b7b5b90 rhbz#1080196: Write unit test for this.
Change-Id: I1c83afa40eaf8c81ca3b436c6fb7d22f7eb9f223
2014-03-28 20:56:32 -04:00
Chris Sherlock
37672f11a7 Fix another typo in a comment
Change-Id: Ic998270701d2e8d2b562ccc869bca0a8d0aac728
Reviewed-on: https://gerrit.libreoffice.org/8778
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-03-29 00:51:25 +00:00
Chris Sherlock
96b70315fc Fix comment typos in OutputDevice::DrawTransparent()
Change-Id: I52e9d505719b3f3b985cd5300ebacb5caa57873f
Reviewed-on: https://gerrit.libreoffice.org/8777
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-03-29 00:51:12 +00:00
Caolán McNamara
eacce9bf4c coverity#704303 Logically dead code
Change-Id: I3c58b83df2b8b124b777802f12b6014a16c796a7
2014-03-28 21:10:27 +00:00
Caolán McNamara
42c428b9fd clip to max
Change-Id: Ibc25262fc0e350ce2d676940f0ec7f2fb368128f
2014-03-28 19:26:24 +00:00
Jürgen Schmidt
4d145c272f Resolves: #i124468# add checks for the read numbers of column for a section
note acecfab9dde94abe733d63260777007337b9aff0 covers the same territory
and fixes mostly the same problem, but ccolM1 isn't clipped for the
other places where it gets used

(cherry picked from commit 32d9f959cf3f133b9257c066a979848a967f7081)

Conflicts:
	sw/source/filter/ww8/ww8par6.cxx

Change-Id: Idad7d95b28d38b7c52b56cab16c533565d9ecfea
2014-03-28 19:25:18 +00:00
Valentin Kettner
061130bd6d fdo#75280 Started cleaning up of sal_uIntPtr usage.
Converted wrong usage of sal_uIntPtr to appropriate other types in basic
module.

The bug is not fully fixed with this since many other occurences of sal_uIntPtr remain.

Update due to code review comments:
Fixed forgetting to change some declarations in iosys.cxx.
Cleaned up the one remaining sal_uIntPtr in iosys.cxx
Fixed adding a sal_uInt64 to a Date (uses long now instead) in methods.cxx
Fixed the VarDecFromUI4 call in sbxdec.cxx from sal_uLong to ULONG .

Conflicts:
	basic/source/runtime/iosys.cxx

Change-Id: Ia6460be04967deb68b92eb62d945da8814fae605
2014-03-28 20:08:46 +01:00
Caolán McNamara
018652591d coverity#982312 Logically dead code
Change-Id: I2b40ac902812ad27dc06bd20603414dff3358eef
2014-03-28 17:24:07 +00:00
Eike Rathke
7f074dbff7 translated German comments
Change-Id: Id893ba9e4a145856be1f091293eecbf757fb423d
2014-03-28 18:19:24 +01:00
Eike Rathke
413a134b34 and restore the intention of the original patch
Change-Id: I8187d425a12f8a96d9e29df244084f7045f448ea
2014-03-28 17:48:42 +01:00
Eike Rathke
b4bc7aabce Revert "coverity#1038286 Logically dead code"
This reverts commit f5adf08aa3a9a176bd2ed5acd638148eb8da7c85.
2014-03-28 17:46:19 +01:00
Eike Rathke
49836e6f67 handle Narrow No-Break Space the same as No-Break Space, just in case
Change-Id: I08683ea7dc48f5ac91d56ee4de6c4e52d1c6f058
2014-03-28 17:35:41 +01:00
Eike Rathke
06b4ca896f name things what they are
Change-Id: I13d0cb525f3ca22b1b9158b2ac20b8b59d645463
2014-03-28 17:35:40 +01:00
Eike Rathke
2cf4763e3c we have a constant, use it
Change-Id: I402f64fdab57508df20d4dffa7bdfdf9473d8b45
2014-03-28 17:35:36 +01:00
Stephan Bergmann
52595d98bf DbgOutTypef -> SAL_WARN
Change-Id: I837643b2c12bf70585dce128dad114cc65f7f0a1
2014-03-28 17:26:09 +01:00
Stephan Bergmann
f26b981aa2 Remove now unused DBG_CTOR etc. feature
Change-Id: Id5e3191ea1a505bd7d46af355edb99e184b5fcb1
2014-03-28 17:26:09 +01:00
Stephan Bergmann
6ef2df7b9b Remove remaining DBG_NAME* uses
...that had been used for DBG_CTOR, DBG_PROF, etc.

Change-Id: I8eac38e24b7110511feb7813aaf5a20ab82bdbe0
2014-03-28 17:26:09 +01:00
Stephan Bergmann
f31964b028 Remove remaining DBG_CTOR etc. remnants from xmloff
Change-Id: I1358b5388195240c3357e4be851a48ccbe33df9e
2014-03-28 17:26:09 +01:00
Stephan Bergmann
a6c9d0046a Remove remaining DBG_CTOR etc. remnants from unotools
Change-Id: Ife6cecde4a9e89146493737d06cd9f0d8a041610
2014-03-28 17:26:08 +01:00
Jürgen Schmidt
a9582c05f8 Resolves: #i124453# check if the resulting polygon...
has already exceeded the number of points (2^16) that can be handled by a tools
polygon

(cherry picked from commit 804e547d70552fd64e1344d538427f8898824b43)

Change-Id: I437a84493e264f7b650561599170e831da20c9aa
2014-03-28 16:25:14 +00:00
Caolán McNamara
f5adf08aa3 coverity#1038286 Logically dead code
Change-Id: Ibbfdbc4925d185852a2b64304ba0983be43a4caa
2014-03-28 16:10:59 +00:00
Miklos Vajna
831b8751fc svx: fix Writer's insert -> frame crash
(regression from 6e61ecd09679a66060f932835622821d39e92f01)

Change-Id: Ifd8d482031b7fce4341d488f7276620e52f549ed
2014-03-28 17:07:10 +01:00
Jürgen Schmidt
f7799c9317 Resolves: #i124467# add check for image data offset...
against stream length, some further checks

(cherry picked from commit 9ceda6fa56d31af717cc2c0c7572cf53cdc47af1)

Conflicts:
	vcl/source/gdi/dibtools.cxx

Change-Id: I8993b91ef4fa951e7bae702b0d056996015245ba
2014-03-28 15:58:18 +00:00
Miklos Vajna
55916fc50a sw: adapt frame/templatedialog4.ui to FillAttributes
With this, editing frame properties of an existing TextFrame and editing
frame styles work again.

(regression from 6e61ecd09679a66060f932835622821d39e92f01)

Change-Id: Ib2bbd337d3d1f648f220d585d42d8310c3486111
2014-03-28 16:56:41 +01:00
Caolán McNamara
0c8c30a95e bRefSizeChanged is always false
Change-Id: I2f27e55a11f972374e7ef0d007a69f3cfb92a7bb
2014-03-28 15:35:53 +00:00
Caolán McNamara
11676ac765 coverity#1078506 troubling Logically dead code
Change-Id: I9687ab7340e9c9ab45ff4dd27eb53e671492e7b5
2014-03-28 15:35:53 +00:00
Caolán McNamara
47bf12afa0 coverity#1078520 Logically dead code
Change-Id: I91ff819bbbca9f74236bcec725b98f8065a84a50
2014-03-28 15:35:52 +00:00
Caolán McNamara
d1d05703ac coverity#1157772 Logically dead code
Change-Id: I4eda11bdeda2e9f2e7d124d19ba051fafc846321
2014-03-28 15:35:51 +00:00
Oliver-Rainer Wittmann
f5c174ac30 Resolves: #i124451# apply correct index entry template patterns...
which are used for e.g. TOC

(cherry picked from commit 52c89c2aff23dbb875c9a86021145b30af463908)

Conflicts:
	sw/inc/tox.hxx
	sw/source/core/tox/tox.cxx
	sw/source/filter/ww8/ww8par5.cxx

Change-Id: Id14cecc07d09d3461c091a6451143cbce206e308
2014-03-28 15:33:09 +00:00
Stephan Bergmann
a5a52ba164 warning C4701: potentially uninitialized local variable used
Change-Id: I0ab3c52fa12d519c6afcbaf701dd42f69c728ff0
2014-03-28 16:14:35 +01:00
Stephan Bergmann
4f9b072072 Remove remaining DBG_CTOR etc. remnants from toolkit
Change-Id: Ia6219ebd5fb2d2644135ec20a986158b68b771fc
2014-03-28 16:12:33 +01:00
Stephan Bergmann
d205ff49be Remove remaining DBG_CTOR etc. remnants from svl
Change-Id: Ib0a4bd4f3d056c39156bfcfb0bd28c62f2f530b2
2014-03-28 16:05:19 +01:00
Tor Lillqvist
ae00e71afd Bin rest of DBG_WARNING[123]
Change-Id: Iaaf36d012e353f73f083c9c0ebbbb6d0953b16c8
2014-03-28 16:52:36 +02:00
Stephan Bergmann
b6f77d2702 Remove remaining DBG_CTOR etc. remnants from sc
Change-Id: Ica865166d6f187bbe610ed537208eab809a77e5f
2014-03-28 15:45:06 +01:00
Stephan Bergmann
b10be2e029 loplugin:literaltoboolconversion
Change-Id: I920ffc647ca92276491b720e1312314f27ab58f2
2014-03-28 15:44:34 +01:00
Stephan Bergmann
3b836710c4 Remove remaining DBG_CTOR etc. remnants from fpicker
Change-Id: I736ce8d12372b115e42319e9b3c352e36cbae346
2014-03-28 15:41:03 +01:00
Stephan Bergmann
d0542fe725 -Werror,-Wunused-variable
Change-Id: I7b9ccef3de21d657b215f5225d8ef539921cc541
2014-03-28 15:39:02 +01:00
Stephan Bergmann
47862e75de loplugin:implicitboolconversion,literaltoboolconversion
Change-Id: I28d228c0992660ca181a4c420736600ee79b3ea5
2014-03-28 15:38:05 +01:00
Stephan Bergmann
4b060ce51a Remove remaining DBG_CTOR etc. remnants from formula
Change-Id: I36740cd276d2047552298606f24b2696ed61b36b
2014-03-28 15:34:01 +01:00
Stephan Bergmann
1f90d06bbb Remove remaining DBG_CTOR etc. remnants from forms
Change-Id: I1616d7e77071caa78ffd8c7d7857f50f3afa1bb7
2014-03-28 15:32:45 +01:00
Stephan Bergmann
be89e8b8ac loplugin:saloverride
Change-Id: I0822af84c04ab70b2a202d232720aa77d8472983
2014-03-28 15:31:35 +01:00
Stephan Bergmann
efe704cc59 Dead code
Change-Id: I05ecb627119eb545d1781fa42613e940fc22aac1
2014-03-28 15:27:38 +01:00
Stephan Bergmann
5a1732eaab Remove remaining DBG_CTOR etc. remnants from connectivity
Change-Id: I9d7ca8354cef6a1474914ce290c476460f982bdd
2014-03-28 15:26:01 +01:00
Stephan Bergmann
5b5e626503 Remove remaining DBG_CTOR etc. remnants from chart2
Change-Id: Iaf07f77b4228d4debb2620625b14ce7dc41e3a98
2014-03-28 15:23:09 +01:00
Armin Le Grand
0072d03151 Resolves: #i124313# At SVG import, try to optimize used ClipRegions
(cherry picked from commit 6dc64444a42997bb4e1ab38f52e4978719e0275a)

Change-Id: I42ec8b0cbfd9367bc98510bfbd1818543ac4b5be
2014-03-28 14:20:35 +00:00