Commit Graph

349099 Commits

Author SHA1 Message Date
Caolán McNamara
dd139fa3e4 coverity#735446 Logically dead code
Change-Id: I6615145e2529193cbe72f4e5d326832a5b8864d0
2014-03-25 12:33:21 +00:00
Caolán McNamara
1cc0bdd037 coverity#735439 Logically dead code
Change-Id: Id475c10effc81386a08337128be270f715daef52
2014-03-25 12:33:21 +00:00
Caolán McNamara
6137b5f72f coverity#735432 Logically dead code
Change-Id: I6bbbe539d28aefcad04ccae48f2518e78f15b240
2014-03-25 12:33:21 +00:00
Caolán McNamara
da5ac820d7 coverity#704376 Logically dead code
Change-Id: I4ab6a73a0b24db2d07c33cd593b0898b87c90fd3
2014-03-25 12:33:21 +00:00
Caolán McNamara
a79afdaa11 coverity#736158 Dereference null return value
Change-Id: Ia3afc3989d1c9a5d9c70b167186fd81a263550fb
2014-03-25 12:33:20 +00:00
Caolán McNamara
fcdae12f36 coverity#736142 Dereference null return value
Change-Id: I89e0ac7fe236edee43f4ce12789d1ad024d7eb08
2014-03-25 12:33:20 +00:00
Caolán McNamara
d112c8e677 coverity#704953 Dereference after null check
Change-Id: I134feebf45ff83a78b1b9e691a2731990b8e3f21
2014-03-25 12:33:20 +00:00
Caolán McNamara
3f73193745 coverity#704949 Dereference after null check
Change-Id: I25fbecbe3dd0c6a9f25b7641ac93842dba66abb7
2014-03-25 12:33:20 +00:00
Caolán McNamara
145d278b22 coverity#704947 Dereference after null check
Change-Id: Iff2a146e217bb6953525ee86ddc84d8c134ab8aa
2014-03-25 12:33:20 +00:00
Caolán McNamara
5fa0e2a400 coverity#704946 Dereference after null check
Change-Id: I816b4305261e6a9971c7cbc838381982972652c2
2014-03-25 12:33:19 +00:00
Caolán McNamara
bcbef3acbf coverity#704945 Dereference after null check
Change-Id: I23606421cdae293d9021cafcc22c4a326c50d49b
2014-03-25 12:33:19 +00:00
Caolán McNamara
f02c2cbb28 coverity#704938 Dereference after null check
Change-Id: I4108ee2cf86f0cf080a7590a0b2667071418673c
2014-03-25 12:33:19 +00:00
Caolán McNamara
802b66210d coverity#982311 Dead default in switch
Change-Id: I59ab0c6883e7fc02bed2f4e286a83b6054d8ef3b
2014-03-25 12:33:19 +00:00
Caolán McNamara
0aab188892 coverity#1019315 Dead default in switch
Change-Id: Iaac33534d5035ded00115f7a75e2c8720ccc3ea5
2014-03-25 12:33:19 +00:00
Caolán McNamara
65f8ce6d94 coverity#1187652 Dead default in switch
Change-Id: Ieedec800955c0785b73caf52ff242b54246b653f
2014-03-25 12:33:18 +00:00
Noel Grandin
80ef0dfedc svtools: sal_Bool->bool
Change-Id: I42a341b5805e0b2a7d619ba552700db35815afd5
2014-03-25 14:32:57 +02:00
Noel Grandin
b5e11641a7 svtools: sal_Bool->bool
Change-Id: I90320997ed79be2556eafa4c35af6b968b378454
2014-03-25 14:32:56 +02:00
Noel Grandin
436cd90095 svtools: sal_Bool->bool
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25 14:32:56 +02:00
Noel Grandin
c849d750eb svtools: sal_Bool->bool
Change-Id: I05dd992f332ab2f3dbcc65aed6dac909872168d4
2014-03-25 14:32:55 +02:00
Noel Grandin
2d3a1d2a46 svtools: sal_Bool->bool
Change-Id: I6c57a52b4fc3ecb993af4526fefcca352ad269b5
2014-03-25 14:32:55 +02:00
Noel Grandin
bdd2df7723 svtools/svparser.hxx: sal_Bool->bool
Change-Id: I130c40227a756b396c4f858468457867d53454b1
2014-03-25 14:32:55 +02:00
Noel Grandin
b4d4ede795 svtools/svtabbax.hxx: sal_Bool->bool
Change-Id: I2441e15d2b32b897561cb404a925390299fea6d8
2014-03-25 14:32:54 +02:00
Noel Grandin
f5864e8ff4 svtools: sal_Bool->bool
Change-Id: Ia0280d3d4f2d5b8a93a37a93847951391e928028
2014-03-25 14:32:53 +02:00
Chris Sherlock
514d33fa3a fdo#74702 DrawTransformedBitmapEx simplified
Removed bPrinter check from DrawTransformedBitmapEx, also removes
meOutDevType.

Change-Id: I5fd09efc4f3467702ab9671dc45da1a9c0e3f927
Reviewed-on: https://gerrit.libreoffice.org/8723
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-03-25 12:26:16 +00:00
Chris Sherlock
03568b2e24 fdo#74702 Move GetBitCount() and GetAlphaBitCount into correct classes
GetBitCount() works differently for VirtualDevices. GetAlphaBitCount()
is really only used by VirtualDevice, so moved functionality from
OutputDevice to VirtualDevice.

Change-Id: Ic00e32f1fa385542bcce8c9475f0ea5eb9a077f9
Reviewed-on: https://gerrit.libreoffice.org/8722
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-03-25 12:25:18 +00:00
Chris Sherlock
977aae0cde fdo#74702 Moved EnableRTL() logic to specific classes where appropriate
OutputDevice::EnableRTL() is a bit of a mess. It uses a runtime
variable to see if it is using a VirtualDevice, and it uses a
dynamic_cast to see if the object is a Window or a Control!

I have made it virtual and moved the knowledge of class specific
functionality from OutputDevice to VirtualDevice, Window and Control
as needed. OutputDevice::EnableRTL() functionality is then called.

Also: small formatting change to outdev.hxx, also included a note
that WindowImpl is a pimpl in window.hxx.

Change-Id: I44b66601c4457fb2e0bbc1014fb7acf8f6942f80
Reviewed-on: https://gerrit.libreoffice.org/8721
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-03-25 12:17:01 +00:00
Andreas Mantke
b53ba68b6b More vertical space for the options dialog
The vertical space of the options dialog is to small for the new
security page in German translation. The last entry is not visible
and the button could not be reached.
Solution: I added more vertical space to ROW_3 which is the postion
of the separation line. I added the hight of a button and of the line.
This fixes the issue with missing space for the last entry in section
especially for the German translation.

Change-Id: Icacfd4587d605e56438f3d7207ce5d257f313072
Reviewed-on: https://gerrit.libreoffice.org/8735
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2014-03-25 11:35:27 +00:00
Andras Timar
fb33a0f720 fdo#76568 remove BerkeleyDB from license text
Change-Id: If269f9058bba37eca8abf4745fd30214fbdd1890
2014-03-25 12:28:26 +01:00
Luboš Luňák
71f2aff7a5 prevent KDE/Qt from interfering with the session manager
I occassionally get lockups in IceProcessMessages() called from QtCore,
I'm actually not exactly sure why, as theoretically two connections
from one app shouldn't be a problem, but since LO does its own
session handling, there's no need to the KDE/Qt code to be involved,
so prevent it from connecting to the session manager altogether.

Change-Id: Iebe20d4cb5403e5fea8bd5d8c1f69b62d1c2907b
2014-03-25 12:23:02 +01:00
Takeshi Abe
dd52330db6 Avoid possible resource leaks by boost::scoped_array
Change-Id: I14e1f7ef217eb5e8e9db9f8962af868ab0a4ab81
2014-03-25 20:08:26 +09:00
Thomas Arnhold
259ec024ba remove commented code
commented out since it came in with
835219840d
2014-03-25 11:55:15 +01:00
Mathias Supp
450cb7831f add parameter to supress dialog
With the new parameter you can now supress the dialog for document
compare in writer.

Change-Id: I984ee75552e5c006332331510df5d437b687903f
2014-03-25 11:31:20 +01:00
Luboš Luňák
26b06662eb avoid repeated table layouting (fdo#75622)
With the document from fdo#75622, this saves 3775 calls and leaves only 13.
e586fe4585 removed avoiding the call
to LayoutTable(), which made loading slow. I checked that the doc from that
bugreport still works, so if very original code was correct in avoiding
the call sometimes, this should be ok too.

Change-Id: Ia80f974d4497e5cb04612331527eb87b579ddb76
2014-03-25 11:31:36 +01:00
Caolán McNamara
0cb272bbf5 use a grid instead of a box because they shrink better
Change-Id: If271f02d99625ffa6fd418cf83307add7c09d802
2014-03-25 09:22:09 +00:00
Stephan Bergmann
b2b3dd2fe6 Remove commented-out debug code
Change-Id: I1442d57eb2f80d98370549659eece5a2cd7db3c5
2014-03-25 10:01:29 +01:00
Stephan Bergmann
93d7c75305 Adapt to sal/log.hxx
Change-Id: I96786bcab1205d212926af6c7c6afbf88bfe1453
2014-03-25 10:00:10 +01:00
Miklos Vajna
f5ae42f934 fdo#76563 DOCX import: speed up importing lots of hyperlinks
The problem was that in
writerfilter::ooxml::OOXMLStreamImpl::lcl_getTarget(), we went over the
list of all hyperlinks for each request. Instead, let's do it once, and
in the remaining cases just look up the result from a map.

Numbers before on my machine (ms, load time):

2215, 2243, 2205

After:

1362, 1358, 1358

So that causes about 39% speedup for a non-debug build.

Change-Id: Ib4718abbe834c5ba49a85469148b656e3c808041
2014-03-25 09:47:17 +01:00
David Tardon
0a9cc5ce4d Revert "avoid infinite loop when setting vert. text dir."
The problem is already fixed by
33c310b6ff and
1a67b7cc3d .

This reverts commit 363119a9f2.

Change-Id: Ieac14da9f37849cd51d14ed0035b3808b8dd77c0
2014-03-25 09:29:57 +01:00
David Tardon
1e188aa004 update test files
Change-Id: I937a85fa7bda7df13e79e704973c21bfc732ba66
2014-03-25 09:29:57 +01:00
Armin Le Grand
9ee0cf63a1 i115391 corected from isLocked to IsPasteResize which was used in modifiers for CustomShape and TextShape
(cherry picked from commit 473a118a62842270b85713d0ab0dc247b5778439)
2014-03-25 09:29:56 +01:00
Stephan Bergmann
f9cc750985 Reduce IAccessibleTabListBox to what's actually used
...the calls to getAccessibleChild(0) and getHeaderBar(BBYTE_COLUMNHEADERBAR)
ultimately all ended up at
AccessibleBrowseBox::implGetHeaderBar(BBTYPE_COLUMNHEADERBAR).

Change-Id: Ie25659e19d0d1ce2dcde2d1440ecc69b4fa265b0
2014-03-25 09:15:40 +01:00
Stephan Bergmann
d96a2f432f Remove dead code
Change-Id: Ia9035189bd01d3a3e5e3222760fc392f3f78880f
2014-03-25 09:15:39 +01:00
Stephan Bergmann
c6b2b5f34c Remove dead code
Change-Id: Id522113f1ba0c9e7b1356acc01a79e0e90a5e752
2014-03-25 09:15:39 +01:00
Stephan Bergmann
af4b38d6e7 Remove dead code
Change-Id: I59fb7843d5c9a6cf2873b6d668d0e9dccff316d2
2014-03-25 09:15:39 +01:00
Matteo Casalin
05c1c60a82 Remove stray fprintf
Change-Id: I9d85108b8c2659f1b167299840772f51f80b2e29
2014-03-25 09:08:15 +01:00
Matteo Casalin
cd8c774030 Simplify by choosing shape kind in SvXMLElementExport constructor
Change-Id: I6d8e1e3c78675b6096f354cace3ff060801cad9e
2014-03-25 09:08:14 +01:00
Matteo Casalin
794d71c4e9 Use isEmpty and endsWith
The isEmpty could be redundant, since the first test for length in
the old code seemed to be just a pre-condition for evaluating the
expressions in the second one.

Change-Id: I0d1838d5eb143196a0d7be0cbadf9f0a59cff71b
2014-03-25 09:08:14 +01:00
Kohei Yoshida
325ecb1d05 Let's be more defensive here by checking for null return objects.
Change-Id: I5164e7d82f882ea9fe296a5a2df616d396d6726f
2014-03-24 22:24:50 -04:00
Kohei Yoshida
6292dbc3ef Better to associate true for "enable" and false for "disable".
The code reads better this way, and certainly is easier on human brain
to process their logic.

Change-Id: I3150fca3385931b9fe01ad13cb11fab410331349
2014-03-24 22:24:30 -04:00
Matteo Casalin
ee84eb9678 Do not compare the same OUString twice
Change-Id: Id915a41e3cc50720d36955da9aa2c7efa6c9034c
2014-03-24 23:22:12 +01:00