mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
423,211 Commits 1 Branch 0 Tags
19c45de4cb41ac7519b601b29d58760a65de0adc
Commit Graph

423211 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Gabor Kelemen
8713c1ffd8 tdf#42949 Fix IWYU warnings in sc/inc/e* 
Found with bin/find-unneeded-includes
Only removal proposals/trivial replacements are dealt with here.

Change-Id: I0ad6772012c771e8ab3f3f42af26f9ac05615771
Reviewed-on: https://gerrit.libreoffice.org/54147
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-05-15 09:09:01 +02:00
Gabor Kelemen
1c2d8e870c tdf#42949 Fix IWYU warnings in sc/inc/columniterator.hxx 
Found with bin/find-unneeded-includes
Here IWYU suggested to remove the column.hxx, but that does not compile.
Instead IWYUs complete suggestion list is applied

Change-Id: I815bcda467ebe698ce673d055e0ff3ad8f4b2aa3
Reviewed-on: https://gerrit.libreoffice.org/53952
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-05-15 09:08:31 +02:00
Miklos Vajna
c167620444 tdf#117225 sfx2: fix leftover temp file when saving doc with embedded objects 
Regression from 27938e1bbd (sfx2 store:
create temp files next to local files (storage case), 2018-01-17), the
optimization to store temp files during save next to the destination
document (so that it can be renamed and not copied after writing the
data successfully) causes problems when we have embedded objects.

Avoid the problem by disabling this new optimization when the document
has embedded objects.

How to fix the actual root cause is not clear to me, I see that:

- the SfxMedium::GetOutputStorage() call in
  SfxObjectShell::SaveTo_Impl() create a temp file
- the SfxMedium::Commit() call in SfxObjectShell::SaveTo_Impl() tries to
  remove the file, which fails on Windows as there is an open file
  handle to that file
- SfxObjectShell::SwitchChildrenPersistance() would close the storage,
  owning that open file handle, but it's too late

So just go back to the previous behavior for now.

Change-Id: I37259100d1ddf963c1f2d3b7bd9f460bc995815c
Reviewed-on: https://gerrit.libreoffice.org/54340
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-05-15 09:06:59 +02:00
Mike Kaganski
b64ef8d113 Remove "Toggle Design Mode" from Writer's Edit menu 
... since it exists in Form menu

Change-Id: I3eaa2c6295242e776990fa3935b1346c130b1247
Reviewed-on: https://gerrit.libreoffice.org/54200
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
 2018-05-15 08:50:46 +02:00
heiko tietze
8ab79071d8 tdf#117186 - Sidebar: Shapes deck should fill the whole sidebar 
Change-Id: Ib4ddab03b3b001523f3e819e5bdac7fbefc17f24
Reviewed-on: https://gerrit.libreoffice.org/54339
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
 2018-05-15 08:45:58 +02:00
Stephan Bergmann
c074abd484 Merge in Flatpak improvements 
...from <https://github.com/flathub/org.libreoffice.LibreOffice/>:

Author: Stephan Bergmann <sbergman@redhat.com>
Date:   Mon May 14 16:51:37 2018 +0200

    Find flatpak'ed Java installation via JAVA_HOME

    ...instead of via PATH, so that a JAVA_HOME inherited from the environment
    doesn't accidentally select a different Java installation.  Fixes
    <https://github.com/flathub/org.libreoffice.LibreOffice/issues/37> "undefined
    symbol: FT_Done_MM_Var".

Change-Id: I2b4c3a55c92f0ef5c5925f0a9909b7b061eedeeb
Reviewed-on: https://gerrit.libreoffice.org/54330
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-05-15 08:39:05 +02:00
Justin Luth
d2c85c671d cleanup my asserts before branching - they served their purpose 
Change-Id: I933ac25dac8d7a20d62535af9690b17503fc159d
Reviewed-on: https://gerrit.libreoffice.org/54086
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
 2018-05-15 06:13:37 +02:00
Aron Budea
1511412793 Updated core 
Project: dictionaries  dbcea2a5cdfabea90420fa292e66cc647814b824

English dictionaries: add ref to package-description.txt

Change-Id: Ie63941f519f43a5e632816b696bd174f033c4991
Reviewed-on: https://gerrit.libreoffice.org/53953
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
 2018-05-15 00:49:14 +02:00
andreas kainz
6523c16275 Add icon option for ObjectTitleDescription 
Change-Id: Ie1a2792d8c1c6696b6ac2ee89a8cce6482d3a662
Reviewed-on: https://gerrit.libreoffice.org/54337
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
 2018-05-14 23:33:08 +02:00
andreas kainz
bc782ae7b4 Colibre icons: add ObjectTitleDescription to colibre 
Change-Id: Id39458b364d2fe74909a8ef8fd8f3969db5cac6a
Reviewed-on: https://gerrit.libreoffice.org/54336
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
 2018-05-14 23:32:41 +02:00
Caolán McNamara
90875893fb ofz#7322 lcl_MarkEqualByStart sort logic differs from that of operator== 
when it encounters a SwPosition with a SwIndex nContent whose m_pIndexReg is
null and compares to one whose m_pIndexReg is not null, where both have an
m_nIndex of 0.

operator== considers them different, while lcl_MarkEqualByStart doesn't care
and sorts them as equal

Change-Id: I29920b98c9e6f395487de1b9cafa6b1282b2b1b6
Reviewed-on: https://gerrit.libreoffice.org/54334
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 22:11:31 +02:00
Caolán McNamara
2eedf1dc71 weld ExportDialog 
Change-Id: Ie799f429d3121426b90bdd62cf0758da38b0beb4
Reviewed-on: https://gerrit.libreoffice.org/54335
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 22:10:51 +02:00
Rene Engelhard
fddc55cc89 fix typo 
the header is already ParameterSubstitution.hxx...

Change-Id: I13239681fbdee6d79aae67f7b7291fe5f7ee78ee
Reviewed-on: https://gerrit.libreoffice.org/54333
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rene Engelhard <rene@debian.org>
 2018-05-14 21:03:10 +02:00
Caolán McNamara
7b85567296 weld GalleryIdDialog 
Change-Id: I214afef7668eaf5082683f1c77b08aa0c5107619
Reviewed-on: https://gerrit.libreoffice.org/54317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 18:25:19 +02:00
Luboš Luňák
a9a0601e2a use optional ScInterpreterContext if possible 
Avoids assertion with threaded cell computations for tdf#100811/2.

Change-Id: I2dc0fd80595ccec1824c8675fc97cfc763b88659
Reviewed-on: https://gerrit.libreoffice.org/54080
Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
 2018-05-14 17:32:48 +02:00
Luboš Luňák
6154d04d90 remove page count check in a test (irrelevant and fragile) 
If I load this document in LO, either my build or distro build, it has only
one page, so the test fails for me only because of the 2-page check.
The commit causing this, b904d639a8, has been in for quite a while,
so it's apparently something special about my setup, but a) the test
doesn't actually require 2 pages for anything, b) the commit mentions that
the test is fragile, c) if I manually inspect the .rtf, there's an extra page
that I do not see even in Word2013, so the document is possibly a bit broken.
One way or another, the page check seems pointless.

Change-Id: I18bdf25f71e8eb9225acd667e60f426fca008ee4
Reviewed-on: https://gerrit.libreoffice.org/53380
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
 2018-05-14 17:31:58 +02:00
Eike Rathke
f72bd4f02b Related: tdf#116939 Disable <cols><col> overflow detection due to excess ... 
... custom column widths.

It's probably just confusing to users, even if technically
correct. Live with truncation of a "layout form" if no content is
present.

Change-Id: I43d77c3e019badd053cb21d92aacd64c7bbcf0e6
Reviewed-on: https://gerrit.libreoffice.org/54319
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-05-14 17:14:57 +02:00
Noel Grandin
7ebb57228f loplugin:useuniqueptr in FormulaTokenArray 
Change-Id: I5716295d2f0c88c6daf0570941d5dd4c5ff03a33
Reviewed-on: https://gerrit.libreoffice.org/54168
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 17:12:51 +02:00
Caolán McNamara
38fa68b90a weld TitleDialog 
Change-Id: I009da829e2b866844e67f976582e2a9d99bd22c0
Reviewed-on: https://gerrit.libreoffice.org/54316
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 16:28:38 +02:00
Tomaž Vajngerl
76f3045057 [API-CHANGE] revert reordering of Graphic properties 
This reverts the reordering of properties and adds new properties
to the end and marks them as optional so we break API as little as
possible.

Change-Id: I422d882d1d1c721dd3ff7ad289329a9df58beb42
Reviewed-on: https://gerrit.libreoffice.org/54322
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-05-14 16:21:52 +02:00
Caolán McNamara
209f95d914 weld ProfileExportedDialog 
Change-Id: Ie360699c167cbee0be6d890ad686d351d64707cd
Reviewed-on: https://gerrit.libreoffice.org/54315
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 16:05:35 +02:00
Stephan Bergmann
2bd48ad3bc loplugin:redundantfcast 
Change-Id: I412eb9530e4b10281c505c07f0c18a4220e2cba9
 2018-05-14 15:21:49 +02:00
Caolán McNamara
2cc5db6244 weld AddModelDialog 
Change-Id: Ia12069f966c93ad7700b7a068dd7660284a40130
Reviewed-on: https://gerrit.libreoffice.org/54314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 15:04:11 +02:00
Caolán McNamara
881bb00dc3 weld AddInstanceDialog 
Change-Id: I69bcb7fb9c18922a5de03e6f2dedd915a5851712
Reviewed-on: https://gerrit.libreoffice.org/54313
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 15:03:50 +02:00
Caolán McNamara
f645481d29 weld ManageNamespaceDialog 
Change-Id: Ieb5605fcab285de26e4fab64b8178d4d7818eb2d
Reviewed-on: https://gerrit.libreoffice.org/54311
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 15:03:35 +02:00
Caolán McNamara
6f2bbb3641 weld ExtrusionDepthDialog 
Change-Id: I5905fea310a7f29574d94eaf61c80b6ca09a7467
Reviewed-on: https://gerrit.libreoffice.org/54310
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 14:07:06 +02:00
Caolán McNamara
165e57d6c9 weld FmInputRecordNoDialog 
Change-Id: I87f3dc3a576e30fe50871c14a67a5b777c21d3ba
Reviewed-on: https://gerrit.libreoffice.org/54308
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 14:06:53 +02:00
Caolán McNamara
c7ac8480c9 weld CreateMonitor and PrintMonitor 
Change-Id: Icf57a0660482cf283d6f993f72f72def2ddf6181
Reviewed-on: https://gerrit.libreoffice.org/54307
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 14:05:56 +02:00
Stephan Bergmann
267240ecf7 Adapt compilerplugins to recent Clang trunk change 
Change-Id: I3013799433e7b82d6b869e9a3cf071495a12d5ae
Reviewed-on: https://gerrit.libreoffice.org/54304
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-05-14 13:54:27 +02:00
Katarina Behrens
d6d5c1c855 tdf#113688: Pattern fill can be set from sidebar now 
Change-Id: I877dd2610aadd1b0118cdb6928a8473af1dc4c73
Reviewed-on: https://gerrit.libreoffice.org/54020
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2018-05-14 13:24:52 +02:00
Ilmari Lauhakangas
d05567e04e Updated core 
Project: help  f7e5c512cda255e1811f0b155ec37aa3addf8831

Clarify text in command line startup instructions

Change-Id: I3d3d8cb2fdeb12f628f2ef4accbf947c5d97d558
 2018-05-14 12:50:49 +02:00
Caolán McNamara
1b0c6d7963 CancelableDialog mbModal is always false 
Change-Id: Ie42a96cf21eb0a7967fb4d0a6c64a221a44e1b53
Reviewed-on: https://gerrit.libreoffice.org/54303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 12:45:20 +02:00
Caolán McNamara
5224f99a40 Updated core 
Project: help  68b328faf7e2b07b8d4f8ed47933df980d191726

update helpids

Change-Id: I153fea94b7533cf3d190ddb1fbea9ef2334ea4fe
 2018-05-14 12:28:05 +02:00
Caolán McNamara
b16ad4e232 modal is always false 
Change-Id: Id6b5a9ef7820b54342e3a7132040c8d500c2e3f2
Reviewed-on: https://gerrit.libreoffice.org/54302
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 12:25:18 +02:00
Caolán McNamara
f08c5fbabf split PrintMonitor and weld SaveMonitor part 
Change-Id: I72325530027df69cabe8a0ec85b7b77d239ad453
Reviewed-on: https://gerrit.libreoffice.org/54300
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 12:25:03 +02:00
Caolán McNamara
5169a27da5 this needs pdfium 
Change-Id: I0ee2d81f2d720b16e2399cf7abdea18505274ad3
Reviewed-on: https://gerrit.libreoffice.org/54299
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-05-14 11:45:22 +02:00
Noel Grandin
6e32a6575b loplugin:useuniqueptr in SvxItemPropertySet 
Change-Id: Ie4fa2f1a9d1cea52936f978a4dcbcaf1a616df2a
Reviewed-on: https://gerrit.libreoffice.org/54179
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:19:21 +02:00
Noel Grandin
3f32388fd4 loplugin:useuniqueptr in PSWriter 
Change-Id: I31b6e216bbd603d551e25e415851b423864148d7
Reviewed-on: https://gerrit.libreoffice.org/54178
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:19:14 +02:00
Noel Grandin
d0242b1163 loplugin:useuniqueptr in EditTextObjectImpl 
Change-Id: I8c0aca098cb2453f3780ea123b35848eb417e5f1
Reviewed-on: https://gerrit.libreoffice.org/54177
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:19:04 +02:00
Noel Grandin
311c5a98b8 loplugin:useuniqueptr in MediaWindowImpl 
Change-Id: I45c9e33578f23ed368b4bff92a72b37e3c98e8e3
Reviewed-on: https://gerrit.libreoffice.org/54176
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:17:20 +02:00
Noel Grandin
89507e35e1 loplugin:useuniqueptr in MediaFloater 
Change-Id: Ibdf838b630fdd63f549b59f69ee05c2030326fa5
Reviewed-on: https://gerrit.libreoffice.org/54175
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:11:42 +02:00
Noel Grandin
5c3816cce5 loplugin:useuniqueptr in SfxTabDialog 
Change-Id: I460bf5aac44e6fd08a5bd5ab8af217dedbcc3cf8
Reviewed-on: https://gerrit.libreoffice.org/54174
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:11:33 +02:00
Noel Grandin
943e12e73d loplugin:useuniqueptr in SfxViewShell_Impl 
Change-Id: Ie9efff0d4872d5b3353b765d00e56593e151ff83
Reviewed-on: https://gerrit.libreoffice.org/54173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:10:42 +02:00
Noel Grandin
9819438373 loplugin:useuniqueptr in SfxCommonTemplateDialog_Impl 
Change-Id: I204d9ea555e35d8822c01f43172dad53b04c60fb
Reviewed-on: https://gerrit.libreoffice.org/54171
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:10:31 +02:00
Noel Grandin
0f53efefe1 loplugin:useuniqueptr in SaveDBDocPage 
Change-Id: I750e6de1cce5355281336343b1ec03596113e311
Reviewed-on: https://gerrit.libreoffice.org/54170
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:10:22 +02:00
Noel Grandin
a245e5c60f loplugin:useuniqueptr in ORowSet 
hold this by rtl::Reference since we are taking references to it
elsewhere and passing them around.

Change-Id: Iae68d7da67cf84f01deb6bb42c00e4c74d7a99d7
Reviewed-on: https://gerrit.libreoffice.org/54169
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:10:15 +02:00
Noel Grandin
858e6b2664 loplugin:useuniqueptr in SaneDlg 
Change-Id: I712b733c9c24db2e2fcdc4b6ce16e38eaf0b27f0
Reviewed-on: https://gerrit.libreoffice.org/54167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:10:09 +02:00
Noel Grandin
6a017237e0 loplugin:useuniqueptr in helpdatafileproxy::Hdf 
Change-Id: I4324a290b826d76f89319f556aededb30d921f8d
Reviewed-on: https://gerrit.libreoffice.org/54166
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-14 11:09:58 +02:00
Miklos Vajna
56195a4d0b pdfium: update to 3426 
Allows dropping the ugly freetype.patch.1.

Change-Id: Ifa8a6dac02a49a2c13572e59773261a847efad3f
Reviewed-on: https://gerrit.libreoffice.org/54294
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-05-14 10:44:35 +02:00
Miklos Vajna
b160db926b tdf#96947 vcl opengl win: fix background of menu items w/ check/radio marks 
Extract the actually used bounding box from the rendering code and reuse
that for OpenGL texture purposes, so the available and the used size
can't mismatch.

The background itself is almost invisible, but the borders were lost due
to this size difference.

Change-Id: I31b3e5aa0c0106461b90bfaab3a84d45b33afd71
Reviewed-on: https://gerrit.libreoffice.org/54298
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-05-14 10:34:25 +02:00