Formally property 'Name' was set at com.sun.star.drawing.ControlShape,
but this Shape does not (and never did) support that Property. It
should have thrown an UnknownPropertyException in the past, but did
not do that by error. It was just ignored in SvxShape::_setPropertyValue
and lost.
Solution is to just not set it anymore. This loses nothing (was never
set, see above), but avoids the (now correctly thrown) exception.
Change-Id: Id6bdc545862f91692213afe6fb706b98d3fce211
Reviewed-on: https://gerrit.libreoffice.org/54145
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
and rename m_sCurrentParaStyleId -> m_sCurrentParaStyleName
This is prep work for tdf#117504, where the value
saved in m_sCurrentParaStyleId is not accurate. Since the
actual value saved inside the paragraph properties is the
ConvertStyleName(), lets use the LO-version of the
style name, so that FindStyleSheetByConvertedStyleName()
can be used for either the paragraph's PropertyValue or
m_pImpl->m_sCurrentParaStyleName.
Change-Id: I8aed80094417ea91f2515e666dc05ecbb021a128
Reviewed-on: https://gerrit.libreoffice.org/54084
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
The rendering result on this Intel card is acceptable, but the console
is flooded with warnings saying wglMakeCurrent() failed with reason
"success", which makes it hard to see any other more important message.
I assume the root cause here is a broken driver.
Change-Id: I112279e9d669b804baeb47383b8357f1a1b7fde5
Reviewed-on: https://gerrit.libreoffice.org/54124
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Set primary keys at the end of the sql statement instead of putting it
right after the column definition. This way multiple primary keys can be
defined.
Change-Id: I7956a536b0516fd8a773d4aa64ccb930ae5c715d
Reviewed-on: https://gerrit.libreoffice.org/54204
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
The one in tools/solar.h is the only one needed.
Change-Id: I7a4e041694fb61329d16f300be4f986eb8d4ec48
Reviewed-on: https://gerrit.libreoffice.org/54202
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
and set a proper parent for it
Change-Id: Ia03e549e9fdde5925d85af3332d63253d9fbe911
Reviewed-on: https://gerrit.libreoffice.org/54199
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
The general size of the image should be the same when width/height
attributes are present. It is very wrong to assume the size of the
image is the area covered by all the primitives in the image.
Change-Id: I56f241e84dee37796f9804ce2569c4eb416e83a0
Reviewed-on: https://gerrit.libreoffice.org/54191
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Industrial and Oxygen removed because of no maintainer,
limited coverage, outdated design, and no SVG support
Legacy themes will be available as extension
Change-Id: I8f9c7bff6a180e3c151404b644a514eae4efcba8
Reviewed-on: https://gerrit.libreoffice.org/54158
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Project: help d6cf5222fb6188eed6bad6cb3e0f5ee9bdafb5d2
Grammar: subject–verb agreement
We don’t suffix “-s/-es” to verbs that refer to a subject in the
third-person plural.
Change-Id: I6fd90814bd63d618c8af4e625d38c6ee9895f919
After the gettext migration there is no point to have two
APIs for reading the same .mo file.
This patch is for sc/source/filter/ for easier review.
Change-Id: I77adc446e66623535a9d4c871ac1403e88efff78
Reviewed-on: https://gerrit.libreoffice.org/54183
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
It was asserting for me at startup on Windows.
Change-Id: I81d7b0dd58fd912c5fc255c3a7fa0878e841737e
Reviewed-on: https://gerrit.libreoffice.org/54160
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
We really don’t want anyone to subclass these classes and introduce new
text layout inconsistencies.
Change-Id: I38d046dc2fab602fd262dc43ac86b55fb0c59db2
Reviewed-on: https://gerrit.libreoffice.org/54153
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
After the gettext migration there is no point to have two
APIs for reading the same .mo file.
This patch is for sc/source/core/tool for easier review.
Change-Id: I4722c8a9ce11ae073389ec8395401f3d11ef0d5b
Reviewed-on: https://gerrit.libreoffice.org/54133
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
After the gettext migration there is no point to have two
APIs for reading the same .mo file.
This patch is for sc/source/ui/view/ for easier review.
Change-Id: Ic07f7e924236d29f3cafd69c5ee634ae92105459
Reviewed-on: https://gerrit.libreoffice.org/54137
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
After the gettext migration there is no point to have two
APIs for reading the same .mo file.
This patch is for sc/source/ui/[a-d]* for easier review.
Change-Id: If268fb87ab09ca430a5bdb5cdd53a233e9158bfe
Reviewed-on: https://gerrit.libreoffice.org/54134
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
After the gettext migration there is no point to have two
APIs for reading the same .mo file.
This patch is for sc/source/ui/[m-u]* for easier review.
Change-Id: I326902a89b8c65e32a42c3ebb55bea3609d32db6
Reviewed-on: https://gerrit.libreoffice.org/54136
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
After the gettext migration there is no point to have two
APIs for reading the same .mo file.
This patch is for sc/qa for easier review.
Change-Id: Ifd773700654565ad31424dfe854bee8486a2330b
Reviewed-on: https://gerrit.libreoffice.org/54095
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
This reverts commit fe192a7b7485379625a4d91ad6e3a9e6280add2c.
The mac-mini jenkins buildslaves get stuck on the sw_odfexporttest and
ultimately get killed by the build-timeout. Revert to not tempt people
into bypassing jenkins alltogether.
Change-Id: I6c08657a1957455161882443b88b5d581c888bcf
Reviewed-on: https://gerrit.libreoffice.org/54155
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
This adds 2 properties to GraphicDescriptor:
"Linked" - to indicate if the graphic is a linked one
"OriginURL" - the URL of the location from where the graphic was
or will be loaded (and is linked to)
Additionally GraphicProvider was extended with a "LoadAsLink"
(media)property, which can be passed using queryGraphic method.
If "LoadAsLink" is set to true, then the Graphic will be created
as a linked one.
In addition the tests for this API was added to VCL (home of this
API implementors).
Change-Id: Ibdabe5e7780d1b372d1e66c3e19b18779fee2c9a
Reviewed-on: https://gerrit.libreoffice.org/54090
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Project: help 5f14059e0d87ac3552b02436405b129c1c3257e1
Helponline: Only add extra <p> margin for main body text
Change-Id: Ia6413bbe4e16ee39dbd01ba48fa307514f517fbe
