While decoding using 'INetURLObject::DecodeMechanism::Unambiguous'
as introduced by commit 47708d533e
("tdf#109219 Allow files with spaces in name as MM data source")
makes sure that e.g. spaces in file names are properly decoded,
'INetURLObject::DecodeMechanism::WithCharset' is actually the
more correct decoding mechanism to use here, since it also decodes
some percentage encodings that 'INetURLObject::DecodeMechanism::Unambiguous'
would leave unchanged.
Using 'INetURLObject::DecodeMechanism::WithCharset' instead
e.g. makes CSV files with '%' characters in their names work
as data sources for mail merge as well.
A big thanks to Stephan Bergmann for pointing this out in
https://gerrit.libreoffice.org/#/c/82201/ .
Change-Id: Iee50584299c82d5718e3210f048ed739818bd11b
Reviewed-on: https://gerrit.libreoffice.org/82428
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The argument is meant to define semantical meaning of the array's first column,
not just define if it's sorted or not.
Change-Id: I87ff172bcc13d6471ee4025e74962be89f1b0b50
Reviewed-on: https://gerrit.libreoffice.org/82376
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Update helpcontent2 from branch 'master'
- Related: tdf#121090: Rewrite descriptions for the last argument of HLOOKUP/VLOOKUP
That parameter is not about telling the *functions* if the search column in
the array is sorted or not, but about different semantical treatment of the
array, i.e. whether it's the array of values or sorted ranges. The wording
"Sorted" and "indicates whether the first column in the array is sorted in
ascending order" is misleading, not providing the idea behind the argument,
and create an impression that all sorted array lookups must have it ser to
TRUE.
Change-Id: I795c29f3c7d5632db6f72f7906bfdacaa372832e
Reviewed-on: https://gerrit.libreoffice.org/82375
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
The changes caused several issues in the presenter console (mouse events delivered to wrong widgets).
Also it turned up that parent windows got the notification about mouse events from their children,
but the position was always relative to the top widget, so very unhelpful for the parent widgets.
Also I found out that there are XKeyHandler and XMouseClickHandler interfaces which
already do what I tried to do with the below commits (events get passed down to parent widgets, and they even can be marked as consumed).
So the original issue reported can be fixed by using XKeyHandler/XMouseClickHandler instead.
This reverts the following two commits:
* "Related tdf#122920 Treat UNO key events the same as mouse events" 9e0e97b716
* "tdf#122920 Send UNO mouse events to parent window listeners as well" 6f43902b12
Change-Id: I005d22770a7a4db9588c5bc22197dc0ae526627e
Reviewed-on: https://gerrit.libreoffice.org/82423
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Fix regressions from commit 24b04db5a6
(tdf#123703 RTF import: fix length of space character sequence).
It seems, longer space sequence is an obsolete RTF-only feature, eg.
new RTF documents created in MSO don't use it, but old RTF documents
still keep their layout (only in RTF).
- Only old-style (without \stshfdbch) or compatible (\stshfdbch31505)
RTF documents get longer space sequences using a one-time conversion;
- because Writer always exports old-style RTF documents, to avoid of
enlargement of space sequences of new-style RTF documents later, RTF
import doesn't modify the RTF documents saved in Writer (checking
\generator);
- text in monospaced font "Courier New" doesn't get longer space
sequence (despite its \prq2 (not monospaced) font setting).
Change-Id: I308ab06db57a2db5deec1d4c4573da3317cad8e9
Reviewed-on: https://gerrit.libreoffice.org/82145
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Actually the whole FILLIN handling is not that correct, because
the value can actually be formatted in any way in Word, as it's
just defined as a range of runs with formating, while Writer just
applies the character formatitng to the whole field.
But this at least allows for a round trip of the exported Writer
type input field after commit 62aaaad156 ("tdf#125103 Writer:
input fields will be exported to docx") changed this.
Change-Id: I6389b4a2ff9d2b62e1e4a00f1c1e112c199377b5
Regression-from: 62aaaad156
Reviewed-on: https://gerrit.libreoffice.org/81686
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
using "InternetLink" in hyperlink/r/rPr/rStyle instead of the actual
character style, and keep actual character formatting in
hyperlink/r/rPr/rFonts, like MSO does.
Change-Id: I13a5e1758ec5b96e647ca77736396ee2f8b22814
Reviewed-on: https://gerrit.libreoffice.org/80868
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
When copying the item to a different SwDoc, the items in the nested
SfxItemSet must be copied into the target SwDoc's item pool, or a
use-after-free is inevitable.
(regression from 5ba30f588d)
Change-Id: I7071ff6dccf2285d96f540ac556b9fa2265ddf00
Reviewed-on: https://gerrit.libreoffice.org/81911
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
...introduced with <https://gerrit.libreoffice.org/#/c/82139/> "tdf#125688
removing XWeak support from SvXMLImportContext", even if that whole commit is
likely to be redone differently again (see Gerrit comments there)
Change-Id: I5b88400181efd76a896d07676230b0e7cb75f1f0
Reviewed-on: https://gerrit.libreoffice.org/82417
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Also drop unused framework/inc/fwkdllapi.h
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I9e79266f273b778f4a8bd3330b1b0353a2e01a61
Reviewed-on: https://gerrit.libreoffice.org/81927
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Forgot to add "actionButtonTextColor" to the iOS theme definition.
Change-Id: I29207512a04068759021d4ae6a30824b56498de6
Reviewed-on: https://gerrit.libreoffice.org/82394
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
This adds new action button stylesettings to the xml def. parser
and adds the defeinitions to iOS theme.
Change-Id: If500d0a7a4633b3c7b90b14b6f62c320ef4b1c12
Reviewed-on: https://gerrit.libreoffice.org/82381
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Direct formatting was used when symbols were inserted.
However when there wasn't any direct formatting of Latin
fonts in the following runs, it didn't know how to reset
the font. Get the default font with XPropertyState and
try to reset to the default value if symbol fonts are set.
Change-Id: I83c9317ba61a96375128f1cc3ed478d958ddaa5c
Reviewed-on: https://gerrit.libreoffice.org/81956
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
