Commit Graph

352211 Commits

Author SHA1 Message Date
Thomas Arnhold
1a0cdabf1d remove some commented out lines from src files
Change-Id: If872737d2a7db5d9053a256f7e3d57007c24230e
2014-05-05 19:42:28 +02:00
Eike Rathke
571cefca47 resolved fdo#78294 default null-date for document import is 1899-12-30
Change-Id: I9dfe76d422ad732a081442b95a995d8d395a098e
2014-05-05 18:27:33 +01:00
Takeshi Abe
6726fb5ce2 Avoid possible memory leaks in case of exceptions
Change-Id: I8914e0dc253c636a1393672f7a20bcb5d39d4276
2014-05-06 02:26:22 +09:00
Tor Lillqvist
d177d16026 Document that the weirder constants are not actually keyboard keys
Change-Id: I8e163e63bfbbbaa5f7f4de2151fea41d735417d0
2014-05-05 19:38:07 +03:00
Tor Lillqvist
72ff5d4196 Add more unmapped VCL keycodes to the comment
Change-Id: If417d8091896c9f6c9650cf7d6036ffacbcc0884
2014-05-05 19:19:49 +03:00
xukai
e0dc3c8a0a add codes to Line::render()
Change-Id: I6510f486707b08ea8f611105f40cc4c7e1581a7f
2014-05-05 17:57:20 +02:00
xukai
461aa03c95 remove the codes of set camera info to render()
Change-Id: I9c2aecd5dea617e7cd69c1fc005b6a9ee237f202
2014-05-05 17:57:20 +02:00
xukai
4e8a9d669f add codes to set camera info
Change-Id: Id6bac3a8dd46d7994c9e64c9e0c16e8c7ac036ac
2014-05-05 17:57:20 +02:00
xukai
0714c0aba7 Initial size of OpenGL3DRenderer
Change-Id: Ibfed531e48848ea711be429d6e5c08094473f781
2014-05-05 17:57:19 +02:00
xukai
4b6ba1eae6 Initialization of light
Change-Id: I91220e8ebffa0090fa7e9146df853f16b6783491
2014-05-05 17:57:19 +02:00
xukai
d3832fc4e0 Introduce OpenGL3DRenderer object
Change-Id: If0454ace5ef21b9d32299f3edea115a2726aac00
2014-05-05 17:57:19 +02:00
xukai
bf293da678 To implement an abstract method:isOpenGLInitialized
Change-Id: I651c0e5830008fd08ba886ccf1be99d40868bb72
2014-05-05 17:57:19 +02:00
xukai
4493860167 Update Function Set3DSenceInfo
Change-Id: Ic117de10be2181a80e65ea48c888789456abfb0a
2014-05-05 17:57:19 +02:00
Markus Mohrhard
eb0da9b80f fix whitespace issues
Change-Id: I7a3680aa324c4242572b71c91ec5bc4f85eff9e9
2014-05-05 17:57:19 +02:00
xukai
8af5e1a9fb add vertex shader and fragment shader for 3D rendering
Change-Id: I7b1ca054006500d468da73d2d85eafaad85dda67
2014-05-05 17:57:18 +02:00
Jan Holesovsky
fc4000a9be openGL: More debug info.
Change-Id: Ia2e09c92673b97fd48c4ede7ebb9ff47da821926
2014-05-05 16:47:23 +02:00
Stephan Bergmann
0635a9c190 Missing const
Change-Id: If1e0e78e1b62c547bd0f03e727e1856227b32821
2014-05-05 16:35:44 +02:00
Markus Mohrhard
51bfb3a5af Asan: fix invalid memory access
Change-Id: I7a2acd99f3a8cb143c2ad1c978dfa4b02bf54464
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-05 14:36:28 +02:00
Miklos Vajna
315503314a oox: don't try to set Writer-specific properties on non-TextFrames...
... during DOCX import of shapes with text, so that we don't crash when
the currently always active
setServiceName("com.sun.star.text.TextFrame") call is not present.

Change-Id: I5b005583ddcee81b9683e3b34e8f0a2e5faa4f95
2014-05-05 14:20:48 +02:00
Tomofumi Yagi
7623bc3158 fix windows build(external/poppler)
Fix build error on windows with --enable-dbgutil autogen.sh option.
We need to link freetype248_D.lib,when we use --enable-dbgutil option.
(Suffix "_D" is needed.)

Change-Id: Ib2927e777d9b9bb615e1df62e428cf17cc8bc26e
Reviewed-on: https://gerrit.libreoffice.org/9248
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-05-05 11:24:17 +00:00
Noel Grandin
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
Miklos Vajna
b410741190 Revert "Move ImplInitAppFontData from Window to Application"
This reverts commit f76026a43a. This
brings back the paragraph style and font name combo boxes in Writer.

Change-Id: Idb28253797ef842d575fe10537f6e70faa34fe75
2014-05-05 12:27:51 +02:00
Thomas Arnhold
8f08def4ae Updated core
Project: help  ada56299c9e1c2d2cf36a475fc4e746bf5977354
2014-05-05 10:15:22 +00:00
Stephan Bergmann
304b3b3910 Handle GetTextBreak returning -1
I don't know what the root cause is exactly that made at least Mac OS X
--enable-dbgutil JunitTest_forms_unoapi start to fail recently, but when nWidth
is just 1 (which might be the root of the problem here, but could probably also
legitimately be the case) and GetTextWidth returns -1 (which it probably is
allowed to do), this would lead to an out-of-bounds OUString::operator[] access
at

> rtl::OUString::operator[] (this=0x118a04be0, index=-1) at ustring.hxx:421
> com::sun::i18n::BreakIterator_Unicode::getLineBreak (this=0x11986f6f8, Text=@0x118a04be0, nStartPos=-2, rLocale=@0x7fbd83821d98, nMinBreakPos=4, hOptions=@0x118a04620) at i18npool/source/breakiterator/breakiterator_unicode.cxx:429
> com::sun::i18n::BreakIteratorImpl::getLineBreak (this=0x1112d5c98, Text=@0x118a04be0, nStartPos=-1, rLocale=@0x7fbd83821d98, nMinBreakPos=4, hOptions=@0x118a04620, bOptions=@0x118a045f8) at i18npool/source/breakiterator/breakiteratorImpl.cxx:242
> OutputDevice::ImplGetTextLines (rLineInfo=@0x118a04bb0, nWidth=1, rStr=@0x118a04be0, nStyle=12560, _rLayout=@0x118a04db8) at vcl/source/outdev/text.cxx:527
> OutputDevice::ImplDrawText (this=0x7fbd8302d000, rTargetDevice=@0x7fbd8302d000, rRect=@0x118a05058, rOrigStr=@0x118a04f70, nStyle=12560, pVector=0x0, pDisplayText=0x0, _rLayout=@0x118a04db8) at vcl/source/outdev/text.cxx:1500
> OutputDevice::DrawText (this=0x7fbd8302d000, rRect=@0x118a05058, rOrigStr=@0x118a04f70, nStyle=12560, pVector=0x0, pDisplayText=0x0, _pTextLayout=0x0) at vcl/source/outdev/text.cxx:1754
> sfx2::TitledDockingWindow::Paint (this=0x7fbd8302d000, i_rArea=@0x118a051d0) at sfx2/source/dialog/titledockwin.cxx:218

Change-Id: I95c6027e86b9a608fe9eb05ffb83fb2316c175f2
2014-05-05 11:31:27 +02:00
sushil_shinde
61e8452c62 fdo#77727 PAGEBREAK In first paragraph was not rendered and exported.
Case 1: If PAGEBREAK appears in first paragraph, LO was inserting
       BreakType_PAGE_BEFORE but since it was first paragraph, PAGEBREAK
       was not rendered in LO hence not exported back to docx file properly.
  case 2: If PAGEBREAK appears after first run of any paragraph in document
       LO was rendering it in wrong paragraph.
  case 3: If COLUMNBREAK appears in first paragraph of section, LO was not
       rendering and exporting it.

Change-Id: Ic557b3e6f80cfa6dd3eb6b4204be7e6531b9ecbf
Reviewed-on: https://gerrit.libreoffice.org/9191
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-05-05 07:34:45 +00:00
Andras Timar
82a623fb08 Updated core
Project: help  400d3515694ff3857f253c8da9ea44b962161ee0
2014-05-05 06:35:59 +00:00
Julien Nabet
c19c942ccf Typo: depricated->deprecated
Change-Id: I77fe282a9dcebde5ad7684aee4597fe4cfb07e11
2014-05-04 23:14:29 +02:00
Miklos Vajna
d6c42a503f coverity#1038298 Unchecked dynamic_cast
Change-Id: Ibb2eca48edb30a88b1ab4bcc35e7e5852efbb436
2014-05-04 21:29:56 +02:00
Miklos Vajna
da47a7d239 writerfilter: fix indentation in rtfdocumentimpl
Change-Id: I5588e84a486ca751e94e097bc8bceaa35fe8b969
2014-05-04 21:29:56 +02:00
Maxim Monastirsky
40a6b4863c sc: Fix bunch of tests
Change-Id: I7ea90d4be037d9935ef23822512f48b100a446a2
2014-05-04 19:41:47 +03:00
Maxim Monastirsky
d3cb2467fa Fix CppunitTest_sc_outlineobj test
Change-Id: Iaf2747e64e486f8536c3074f247a3b85dd78bbd1
2014-05-04 18:37:27 +03:00
Maxim Monastirsky
4f4b34ab63 Fix CppunitTest_chart2_xshape test
Change-Id: I6036988fc53f00f0344623a4d28a2de5962e160a
2014-05-04 17:53:31 +03:00
Markus Mohrhard
ae1d664008 Revert "Revert "temporarily disable failing , fdo#66617
This reverts commit 9b8c33ecc5.
2014-05-04 14:41:50 +02:00
Stephan Bergmann
a34a62b32d loplugin:saloverride
Change-Id: I5c3b3c6212524430068e3fd8d9e9d259557bbea2
2014-05-04 12:52:54 +02:00
Chris Sherlock
f76026a43a Move ImplInitAppFontData from Window to Application
I have renamed ImplInitAppFontData to InitAppFontData and moved it from
Window to Application. This is because this is something that sets
*application* global variables, it just so happens it gets it from a
Window parameter. But it should be set when the application starts, so
I have moved it to Main().

Change-Id: I9d98aa5b533166f91352218af267930034648c7a
Reviewed-on: https://gerrit.libreoffice.org/9242
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-05-04 06:32:53 +00:00
Julien Nabet
e4d61b3c55 Resolves: fdo#78217 selected text should be copied in "Replace"
Change-Id: I548d46ec46ff07528bd1f8ed6be09463354826d8
2014-05-04 08:32:04 +02:00
Markus Mohrhard
20778b037c fix windows packaging
Change-Id: I97b1d2432dadf7239a8500544f7e54b667ca4dfc
2014-05-04 01:15:17 +02:00
Andrzej Hunt
74bb3cf5a9 Add clang support for boost multi_array Wshadow patch.
ba54eca181 replaces the existing -Wshadow
fixes with a GCC pragma, however we also want to be able to build with clang.

Change-Id: I522f3c549adf65b98522561ab7167258dfda48b5
2014-05-03 20:40:51 +01:00
Miklos Vajna
dbbaa85d29 writerfilter: fix indentation in rtfdocumentfactory
Change-Id: I9cf6abaf091d358670bbe71de9abe832fa139f42
2014-05-03 21:11:04 +02:00
Miklos Vajna
26946775d7 coverity#1078575 Unchecked dynamic_cast
Change-Id: Ie25c91ce0035c78629ebd8466baa717d62948503
2014-05-03 21:11:03 +02:00
Chris Sherlock
be8a675617 Rearrange outdev.cxx functions, et al.
* Rearranged outdev.cxx functions to better match outdev.hxx layout
* Moved transparency functions from outdev.cxx to transparency.cxx
* Corrected one comment typo in outdev.hxx
* Moved CreateUnoGraphicsList definition to outdev.cxx out of header
* Formatted function declarations in outdev.hxx

Change-Id: I6fda24ae8208ef5ea7b2fe8f59079d48d0af1488
2014-05-03 20:53:43 +10:00
Jeroen Nijhof
e81212315b find-german-comments -l crashed for a too long path name
In calculating how many tabs to use for the display,
when the path was more than 40 characters (like for
dbaccess/source/ui/relationdesign/RelationTableView.cxx)
it returned '1, 0' for the number of tabs --
and python didn't like that. Return 1 instead.

Change-Id: If370ffe03b4aff67ca59094dd38863986ca39519
Reviewed-on: https://gerrit.libreoffice.org/9239
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-05-03 10:42:16 +00:00
Kohei Yoshida
af7df25bcc fdo#78062: Broadcast only on non-empty cells within deleted range.
We don't want to broadcast over the whole selected range, which may be
the whole sheet which is well over 1 billion cells !

Change-Id: I7c139ce5efe09312cf824e35f0efe551184032eb
2014-05-03 00:55:41 -04:00
Michael Stahl
41062189f7 SfxDocumentMetaData: suppress some spurious warnings
These always trigger on a new document.

Change-Id: Ied60f52c4dc348b2b18f6dc8c30204ee3dc56f29
2014-05-03 00:51:39 +02:00
Michael Stahl
5f982c22ff SwUndoSplitTbl::UndoImpl(): avoid assert from ~SwIndexReg
Can be triggered by moving view cursor into new paragraph before Undo.

Change-Id: I8386611a8eabd1c3b6edfacd0226358df52cbe66
2014-05-03 00:51:38 +02:00
Michael Stahl
bc0c939270 fdo#57197: sw: fix crash on Undo of table row/column insert
The _SaveTable::CreateNew() will call _FndBox::DelFrms() but at that
point the SwTableBoxes have already been deleted; so do that earlier.

Change-Id: I868c8fffbddeb1ea6df724fb68cac732eeee2eba
2014-05-03 00:49:15 +02:00
Michael Stahl
45cb8e3d1e sw: hypothetical crashes if last node is not SwTxtNode
Change-Id: I16c476ae83d01ea23891af36fd4bcca4e8992228
2014-05-03 00:49:14 +02:00
Michael Stahl
e06131e966 SwUndoDelete::RedoImpl(): avoid assert from ~SwIndexReg
1. insert header
2. insert table in header
3. put cursor in bottom right cell
4. Ctrl+Shift+Delete
5. Undo
6. Redo

Problem is that the shell cursors never get corrected in step 6.
Replace the previous hacky after-the-fact fixup of rPam only with call
to PaMCorrAbs.  [there does not appear to be any other case than
bDelFullPara where this branch is taken, which make the next one look
kind of weird?]

Change-Id: If3583f83e66fff4d3367a1532e443aed780a5e6c
2014-05-03 00:49:10 +02:00
Michael Stahl
ba54eca181 boost: replace multi_array Wshadow patch with different one
... based on upstream feedback.

Change-Id: I846287d62d3b53f4a3d3013c9f82fd77d22a9523
2014-05-03 00:48:14 +02:00
Michael Stahl
45e7b4c18d chart::ChartController::queryGL3DChart(): crash on concurrent model close
As seen in JunitTest_chart2_unoapi
[sch.ChXChartDocument::com::sun:🫘:XPropertySet]
it is possible that one thread closes the model while the main thread
tries to paint the chart via timeout.
In  chart::ChartController::modeChanged() It's not obviously possible
to lock m_aModelMutex since that might deadlock with SolarMutex.

6  in SolarMutexGuard::SolarMutexGuard (this=0x2b742f846cc0) at /include/vcl/svapp.hxx:1579
7  in (anonymous namespace)::Frame::isActionLocked (this=0x1dbe1b0) at /framework/source/services/frame.cxx:2597
8  in (anonymous namespace)::Frame::close (this=0x1dbe1b0, bDeliverOwnership=0 '\000') at /framework/source/services/frame.cxx:1773
9  in chart::ChartController::notifyClosing (this=0x1e4ec00, rSource=...) at /chart2/source/controller/main/ChartController.cxx:877
10 in apphelper::CloseableLifeTimeManager::impl_doClose (this=0x1e03b98) at /chart2/source/tools/LifeTime.cxx:368
11 in apphelper::CloseableLifeTimeManager::g_close_endTryClose_doClose (this=0x1e03b98) at /chart2/source/tools/LifeTime.cxx:311
12 in chart::ChartModel::close (this=0x1e03ac0, bDeliverOwnership=1 '\001') at /chart2/source/model/main/ChartModel.cxx:654

main thread:

21 in chart::ChartController::TheModel::getModel (this=0x0) at /chart2/source/controller/main/ChartController.hxx:470
22 in chart::ChartController::queryGL3DChart (this=0x1e4ec00) at /chart2/source/controller/main/ChartController.cxx:1398
23 in chart::ChartController::modeChanged (this=0x1e4ec00, rEvent=...) at /chart2/source/controller/main/ChartController.cxx:486
24 in chart::ChartView::impl_notifyModeChangeListener (this=0x1e149f0, rNewMode="valid") at /chart2/source/view/main/ChartView.cxx:2823
25 in chart::ChartView::impl_updateView (this=0x1e149f0) at /chart2/source/view/main/ChartView.cxx:2730
26 in chart::ChartView::update (this=0x1e149f0) at /chart2/source/view/main/ChartView.cxx:2861
27 in chart::ChartController::execute_Paint (this=0x1e4ec00, rRect=Rectangle = {...}) at /chart2/source/controller/main/ChartController_Window.cxx:493
28 in chart::ChartWindow::Paint (this=0x201c970, rRect=Rectangle = {...}) at /chart2/source/controller/main/ChartWindow.cxx:83

Change-Id: Ib99edbb9862bc9dab76ed3e0c21eca5589fe7fdb
2014-05-03 00:48:13 +02:00