Commit Graph

422974 Commits

Author SHA1 Message Date
Noel Grandin
1b0b0f3c64 loplugin:datamembershadow in SdGenericDrawPage
Change-Id: I0c7a08206b6480ba954464be1782d4577483b15e
Reviewed-on: https://gerrit.libreoffice.org/54106
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-11 09:19:10 +02:00
Miklos Vajna
7758d6609d tdf#117245 sw layout: extend TabOverMargin compat mode
This layout compatibility flag is supposed to mimic Word behavior, but
in both cases we failed to lay out the text as Word does.

Change-Id: Ic6fb2eb16ce3670d23aeb9f17bd7043f55164883
Reviewed-on: https://gerrit.libreoffice.org/54087
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-11 09:03:19 +02:00
Noel Grandin
026077340d loplugin:datamembershadow in SvxMacroTabPage_
Change-Id: I8cd1a4fef6bd0966620692c316a40ea47dd14d7d
Reviewed-on: https://gerrit.libreoffice.org/54105
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-11 08:44:36 +02:00
Noel Grandin
19156dccf7 loplugin:datamembershadow in DXF filter
depending on which version of the DXF file format you look at, elevation
can be either group code 30 or group code 38. But since neither of these
fields is actually in use, lets just remove both until someone has an
actual use-case for them and can test against real data.

Change-Id: I4355b37c4b8513e8f9704272b269b2fe3f1c659f
Reviewed-on: https://gerrit.libreoffice.org/54104
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-11 08:44:21 +02:00
Noel Grandin
a111a7ba40 tdf#117522 Calc Column Width after Insert Columns
regression from
    commit d6fb5ca566
    dyncolcontainer: use ScCompressedArray for pColWidth

Change-Id: I65d1197c0c638216e063f74def4efb98bfbb9aad
Reviewed-on: https://gerrit.libreoffice.org/54067
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-11 08:44:04 +02:00
Samuel Mehrbrodt
29deb66577 Only write mime-type attribute if ODF version > 1.2
Change-Id: I88ae821e969a2c45161f59eb2e667f645f1afdac
Reviewed-on: https://gerrit.libreoffice.org/54075
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-11 08:24:36 +02:00
Zdeněk Crhonek
4374f8b621 uitest for bug tdf#88999
Change-Id: I442704bb54490bdb37a5c3bf7dd0c123cfb89ee6
Reviewed-on: https://gerrit.libreoffice.org/54088
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-11 07:22:15 +02:00
Tor Lillqvist
fc00041df8 Also for SDK 10.0.17134 the winsdklibsubdir needs to have a .0 tacked on
Also remove questionable old "Hack needed at least by tml".

Change-Id: I478358ea114cee2f8a181b98cb3433447b3ed560
Reviewed-on: https://gerrit.libreoffice.org/54081
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-11 00:42:13 +02:00
Khaled Hosny
a909afbc21 Fold CommonSalLayout into GenericSalLayout
Now the crazy constructors of CommonSalLayout are gone, we can merge
the two and drop one level of indirection.

Change-Id: I166e4ed2c9d22c1ce75246d486f7526c4928f652
Reviewed-on: https://gerrit.libreoffice.org/54077
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-11 00:16:39 +02:00
Rene Engelhard
e37135d413 move Java from config_features to already existing config_java
Change-Id: I085fab2bcdc5910d1386fc20768fe7063ce3e28e
Reviewed-on: https://gerrit.libreoffice.org/54071
Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>
2018-05-10 22:44:37 +02:00
Caolán McNamara
a4d35e9ed6 weld SdVectorizeDlg
Change-Id: I15469be36807bcfca9882d04dd5d55933692abf7
Reviewed-on: https://gerrit.libreoffice.org/54092
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10 21:57:53 +02:00
Caolán McNamara
8154d17893 ofz#8206 fix rework as OUStringBuffer
Change-Id: Ie9ef508c9db730c4d273d7258c052d074b6ef088
Reviewed-on: https://gerrit.libreoffice.org/54082
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10 18:06:42 +02:00
Thorsten Behrens
c4380ced32 sal: log windows traces to debugger console, take two
This reverts most of commit 4c5b475278
and just keeps the OutputDebugStringA() call unconditionally.

Change-Id: Ia838052b3147ca2d66c7d28b04eadd9700244669
Reviewed-on: https://gerrit.libreoffice.org/54029
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-05-10 17:17:01 +02:00
Zdeněk Crhonek
8f799c4565 uitest / Calc autofill
Change-Id: I91f9c5eb69059eceedc190f1578c3d08a722409a
Reviewed-on: https://gerrit.libreoffice.org/52595
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-10 16:52:42 +02:00
Zdeněk Crhonek
a9ca2cf9da uitest - Calc Text to columns
Change-Id: I89effeccc9615f4e34e3dc036f06a5e5437ec37b
Reviewed-on: https://gerrit.libreoffice.org/53052
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-10 16:51:50 +02:00
Zdeněk Crhonek
cb749eb664 uitest - Calc-Format-Rows + tdf#89140
Change-Id: Id2e9946b2bbf466c86aed6d37e592ccb2a4059d3
Reviewed-on: https://gerrit.libreoffice.org/54054
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-10 16:50:39 +02:00
Zdeněk Crhonek
8a8fa23a37 uitest - Calc-Format-Columns
Change-Id: Ie9375a9c464b658abf5a8f85ae76cc460ed4b9cf
Reviewed-on: https://gerrit.libreoffice.org/54056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-10 16:49:41 +02:00
Mike Kaganski
140e278412 Fix IntelliSense error
Change-Id: I521763230761cd408226b0e6ca08889fb6660fb0
Reviewed-on: https://gerrit.libreoffice.org/54062
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-05-10 16:48:06 +02:00
Samuel Mehrbrodt
b55ce8d777 Only write signatureline element if ODF version > 1.2
Change-Id: I28769e8e3f4d5a0daa54fa188a9aec56c31120ca
Reviewed-on: https://gerrit.libreoffice.org/54074
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
2018-05-10 16:05:39 +02:00
Caolán McNamara
23a32cf68d assert in vectorization dialog with wrong pixel type
regression from...

commit 900b1109a9
Author: Chris Sherlock <chris.sherlock79@gmail.com>
Date:   Tue Apr 17 22:06:20 2018 +1000

    vcl: move Bitmap{Ex}::ReduceColors() to BitmapColorQuantizationFilter class

    Change-Id: I32b58e8d451e7303e94788a546a5b5f9a5bb4590
    Reviewed-on: https://gerrit.libreoffice.org/53037
    Tested-by: Jenkins <ci@libreoffice.org>
    Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

where inexplicably the nBitCount related lines weren't moved

Change-Id: Ieca91d5c7c1b8a045d1019cf1b43218f8a2db508
Reviewed-on: https://gerrit.libreoffice.org/54078
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
2018-05-10 15:45:18 +02:00
Caolán McNamara
5e24544520 weld SdCustomShowDlg and SdDefineCustomShowDlg
Change-Id: I44d40a286eb5d70982284a270f340653858d38cf
Reviewed-on: https://gerrit.libreoffice.org/54076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10 15:05:19 +02:00
Caolán McNamara
476ed0aed1 weld SdStartPresentationDlg
to get duration spinbutton working need to know where the cursor
is in the spinbutton and to change the adjustment factor depending
on that, and need to additionally disable the vcl round to nearest base unit on
up/down

Change-Id: I6dd09e1639454cb4820d3aeb0c0c698fcebd417e
Reviewed-on: https://gerrit.libreoffice.org/54065
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10 14:37:06 +02:00
Gabor Kelemen
7cee480efe tdf#42949 Fix IWYU warnings in sc/inc/d*
Found with bin/find-unneeded-includes
Mostly removal proposals are dealt with here
and a few trivial substitutions in small headers

Change-Id: Ic4b2e48f1e55fc5d10e3dab16cfee1e358a8e917
Reviewed-on: https://gerrit.libreoffice.org/54005
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-10 14:18:17 +02:00
Victor Mireyev
9992338fbb tdf#79315 Fix wp:effectExtent issue when exporting inline picture to DOCX.
Change-Id: I250bb365593c6a06f1d99f28b36e8bde183b16e6
Reviewed-on: https://gerrit.libreoffice.org/53679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-10 14:14:06 +02:00
Mike Kaganski
c0965754df Set SAL_USE_VCLPLUGIN=svp on all platforms to define headless mode
... as used now in ODatabaseSource::buildLowLevelConnection; so not
having it on Windows/macOS makes it hang waiting for dialog (e.g., in
fdo84315).

Change-Id: Ia63921ae398eddcd1be7d23e75c85979109a6615
Reviewed-on: https://gerrit.libreoffice.org/54068
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-05-10 14:06:07 +02:00
Michael Meeks
447c40948e Make debugging obscure save failures slightly less awful.
Change-Id: Idf2385b08b31e1a6fddefbf61f6284763c456b18
Reviewed-on: https://gerrit.libreoffice.org/54047
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-05-10 13:59:37 +02:00
Caolán McNamara
014d31ca48 crashtesting: PageFrame may not exist
Change-Id: I5799ca4e08146688a842ff53a7eb5591504069a6
Reviewed-on: https://gerrit.libreoffice.org/54066
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10 13:05:11 +02:00
Caolán McNamara
557ca49197 refactor ImplNumericReformat
Change-Id: I92e3a5592691b99683e5c879a3a07b9f3bac7c41
Reviewed-on: https://gerrit.libreoffice.org/54064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10 12:27:52 +02:00
Rene Engelhard
c1abccec44 configure: fix gdrive,alfresco and onedrive id/secret diagnostics
e.g. GDRIVE_CLIENT_ID was checked with -z but it actually is "", so this
always was outputted as "set".

Change-Id: I9ee3e742655af721ba2b9d56e52d86b17331c65c
Reviewed-on: https://gerrit.libreoffice.org/54057
Tested-by: Rene Engelhard <rene@debian.org>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Rene Engelhard <rene@debian.org>
2018-05-10 12:12:45 +02:00
Noel Grandin
0e384e1080 loplugin:unnecessaryvirtual improvements
look for virtual methods where all of the overrides of the method are
empty

Change-Id: I87d99a0b647700a8d53498e0ab5f0437d3508553
Reviewed-on: https://gerrit.libreoffice.org/54060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-10 11:34:18 +02:00
Caolán McNamara
6ede622ab6 Related: tdf#117499 set default titles for non-gtk3 message dialogs
Change-Id: Ie2de7fe79e5861351c3fd6512bb970def9a31e4e
Reviewed-on: https://gerrit.libreoffice.org/53991
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10 11:05:10 +02:00
Miklos Vajna
7e0f06f412 writerfilter, writerperfect: various small cleanups
Change-Id: Iea26b73bd91ed178cc4f2279c23246d79f48a6be
Reviewed-on: https://gerrit.libreoffice.org/54063
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2018-05-10 10:34:04 +02:00
Noel Grandin
5c9ae702b4 store Color using boost::optional in EditCharAttribField
Change-Id: If4af5991be51cdb035c0bc0fb7668844df703073
Reviewed-on: https://gerrit.libreoffice.org/54022
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-10 08:42:37 +02:00
Khaled Hosny
c5f8a296fc tdf#117517: Fix OpenGL text rendering on Windows
Use the HDC we already selected the HFONT on instead of creating a new HDC and
selecting the font on it, apparently selecting the font the second time fails.

Change-Id: I2a26469ce70bce763562b6cd2171707e482fb1d8
Reviewed-on: https://gerrit.libreoffice.org/54046
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-10 03:44:10 +02:00
Tomaž Vajngerl
fe93b77160 Convert SwXDocumentIndex API qadevOOo tests (incomplete)
Somebody has to start converting this for Writer...

This conversion is still incomplete, but this sets the base of
for the conversion of qadevOOo to from Java.

Change-Id: I2cadeaaf58fe334a5e1f29dcb8e59c7481a4550d
Reviewed-on: https://gerrit.libreoffice.org/53989
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-10 03:42:06 +02:00
Adolfo Jayme Barrientos
6aa734cee4 Updated core
Project: help  49076d176daea11abbb789a84c8a9e32f2ee9144

Helponline: Give links a different color

It was the same color as headings, which was confusing.

Also, remove the underline until hovering, which improves readability,
particularly with Chinese, Japanese and Korean.

And add a custom selection color because… why not?

Change-Id: I3d120c7fd6cbe27d74f0c7c40b72e23cddaa0296
2018-05-10 02:37:58 +02:00
andreas kainz
f4779cdade tdf#117519 Colibre icons for merge cell dialog
Change-Id: I4e23962dc4262569e4eff73345c1cb44c590370f
Reviewed-on: https://gerrit.libreoffice.org/54040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-09 23:00:54 +02:00
Caolán McNamara
f717b7b5fb ImplNumericReformat always returns true
Change-Id: Icfb555a59d0a221bdbdcf17601440fda43680d4b
Reviewed-on: https://gerrit.libreoffice.org/54032
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-09 21:40:21 +02:00
andreas kainz
9479e5c63f Colibre icons: ALL galaxy icons are available in colibre
Change-Id: I3da8a928a14529f7ba6839a37b823b1df84b99f8
Reviewed-on: https://gerrit.libreoffice.org/54038
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-09 21:40:11 +02:00
andreas kainz
55178172d1 Colibre icons: add 96px mime icon in /res
Change-Id: I8d2f9788fe8c8e0042d8f3337413dc0c0505b8af
Reviewed-on: https://gerrit.libreoffice.org/54036
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-05-09 21:39:57 +02:00
Bjoern Michaelsen
c663523ae6 no extra heap allocs by WriterMultiListener
Change-Id: I53fbc049e8462b09a1fe7fbdd4207032ddaf5a2b
Reviewed-on: https://gerrit.libreoffice.org/53955
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-05-09 21:26:00 +02:00
Stephan Bergmann
c330f795ae Avoid division by zero
...as happens during CppunitTest_sd_export_tests:

> sd/source/filter/eppt/epptso.cxx:118:76: runtime error: division by zero
>  #0 in PPTExBulletProvider::GetId(Graphic const&, Size&) at sd/source/filter/eppt/epptso.cxx:118:76 (instdir/program/libsdfiltlo.so +0x38e7e7)
>  #1 in ParagraphObj::ImplGetNumberingLevel(PPTExBulletProvider*, short, bool, bool) at sd/source/filter/eppt/pptx-text.cxx:897:46 (instdir/program/libsdfiltlo.so +0x55464d)
>  #2 in ParagraphObj::ImplGetParagraphValues(PPTExBulletProvider*, bool) at sd/source/filter/eppt/pptx-text.cxx:1114:5 (instdir/program/libsdfiltlo.so +0x54c01d)
>  #3 in ParagraphObj::ParagraphObj(com::sun::uno::Reference<com::sun::text::XTextContent> const&, ParaFlags, FontCollection&, PPTExBulletProvider&) at sd/source/filter/eppt/pptx-text.cxx:741:9 (instdir/program/libsdfiltlo.so +0x54e373)
>  #4 in TextObj::TextObj(com::sun::uno::Reference<com::sun::text::XSimpleText> const&, int, FontCollection&, PPTExBulletProvider&) at sd/source/filter/eppt/pptx-text.cxx:1313:47 (instdir/program/libsdfiltlo.so +0x5574a4)
>  #5 in TextObjBinary::TextObjBinary(com::sun::uno::Reference<com::sun::text::XSimpleText> const&, int, FontCollection&, PPTExBulletProvider&) at sd/source/filter/eppt/eppt.hxx:141:101 (instdir/program/libsdfiltlo.so +0x4068e7)
>  #6 in PPTWriter::ImplWritePage(PHLayout const&, EscherSolverContainer&, PageType, bool, int) at sd/source/filter/eppt/epptso.cxx:2367:39 (instdir/program/libsdfiltlo.so +0x3dc5bb)
>  #7 in PPTWriter::ImplWriteSlide(unsigned int, unsigned int, unsigned short, bool, com::sun::uno::Reference<com::sun:🫘:XPropertySet> const&) at sd/source/filter/eppt/eppt.cxx:312:5 (instdir/program/libsdfiltlo.so +0x327239)
>  #8 in PPTWriterBase::CreateSlide(unsigned int) at sd/source/filter/eppt/pptx-epptbase.cxx:399:5 (instdir/program/libsdfiltlo.so +0x49896a)
>  #9 in PPTWriterBase::exportPPT(std::__debug::vector<com::sun:🫘:PropertyValue, std::allocator<com::sun:🫘:PropertyValue> > const&) at sd/source/filter/eppt/pptx-epptbase.cxx:233:15 (instdir/program/libsdfiltlo.so +0x48ff5e)
>  #10 in ExportPPT at sd/source/filter/eppt/eppt.cxx:1451:17 (instdir/program/libsdfiltlo.so +0x34dfdc)
>  #11 in SdPPTFilter::Export() at sd/source/filter/sdpptwrp.cxx:173:24 (instdir/program/libsdlo.so +0x26b070d)
>  #12 in sd::DrawDocShell::ConvertTo(SfxMedium&) at sd/source/ui/docshell/docshel4.cxx:662:29 (instdir/program/libsdlo.so +0x2c454b7)
>  #13 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1508:19 (instdir/program/libsfxlo.so +0x2baa19d)
>  #14 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&) at sfx2/source/doc/objstor.cxx:2792:39 (instdir/program/libsfxlo.so +0x2bcdc17)
>  #15 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objstor.cxx:2650:9 (instdir/program/libsfxlo.so +0x2bc86cf)
>  #16 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objserv.cxx:302:19 (instdir/program/libsfxlo.so +0x2b69519)
>  #17 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&, bool) at sfx2/source/doc/sfxbasemodel.cxx:2959:46 (instdir/program/libsfxlo.so +0x2cbd740)
>  #18 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1638:13 (instdir/program/libsfxlo.so +0x2cc26b5)
>  #19 in SdExportTest::testBulletsAsImage() at sd/qa/unit/export-tests.cxx:934:20 (workdir/LinkTarget/CppunitTest/libtest_sd_export_tests.so +0x8988c)

Change-Id: I516bb2367d6a7fae23e2d474e63ab50af925208b
Reviewed-on: https://gerrit.libreoffice.org/54034
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-09 21:00:32 +02:00
Tamás Zolnai
1c0035230c Better log about preloaded dicts.
Change-Id: I906c0082f3ac3c701f7b02e5d35b998bb7ea4d59
Reviewed-on: https://gerrit.libreoffice.org/54044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-05-09 20:44:09 +02:00
Mike Kaganski
48078ed27c Remove obsolete param documentation
obsoleted by commit 2f9d53df89

Change-Id: I3876d1fe0f28f6cde706dba8d53d7f97ab25d5ca
Reviewed-on: https://gerrit.libreoffice.org/54033
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-05-09 20:05:19 +02:00
heiko tietze
c23c770e35 Typos in change 53934
Change-Id: I7d2dd64beb70d44113c3c548ff6e13ff1d766614
Reviewed-on: https://gerrit.libreoffice.org/54017
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-09 19:59:35 +02:00
Mike Kaganski
5ed889e808 Don't throw in LdapUserProfileBe ctor on LDAP misconfiguration
Otherwise LO crashes e.g. at opening Expert Configuration dialog.
Instead, log the event, create an empty backend, and return empty values.

Change-Id: I433fc89c003e7886dfc5242a4ef8defa46d643d3
Reviewed-on: https://gerrit.libreoffice.org/53958
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2018-05-09 17:59:19 +02:00
Armin Le Grand
015dd48ce6 tdf#116977 Correctly handle copy-construct of SdrTableObj
The new central CloneSdrObject in the case of SdrTableObj
has to do some more stuff due to the UNO API TableModel in-
volved and stuff. This is done in ::operator= now and thus
will work uniformly now (multi-select and copy).
At the same time there is functionality to clone/copy only
a partial Table in Draw/Impress when e.g some Cells are
selected. To reflect this code is needed to 'crop' the
just cloned SdrTableObj to the current selection. This again
was pretty hard due to side-effects in the implementation
using a mix of UNO API and SdrModel-stuff.

Change-Id: I9816e1caf34e29021d46d6dd9bb935c634f5ba2e
Reviewed-on: https://gerrit.libreoffice.org/53975
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-09 17:41:12 +02:00
Zdeněk Crhonek
1887806c40 uitest for bug tdf#91305
Change-Id: Icf4956214ddbad16fa39922267e3336fe621fbf6
Reviewed-on: https://gerrit.libreoffice.org/53289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-09 17:40:42 +02:00
Winfried Donkers
1a8febcaa4 tdf#117433 count empty cells properly with COUNTIF.
All empty columns after the first column of the range were skipped.
When the query contains an 'cell is empty' expression, skipping is omitted.

Change-Id: I0d5b0d24c2d08bad88479cd5b356529a0a709156
Reviewed-on: https://gerrit.libreoffice.org/54021
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-09 17:04:10 +02:00
Stephan Bergmann
64293a2725 Merge in Flatpak improvements
...from <https://github.com/flathub/org.libreoffice.LibreOffice/>:

commit 945f6caad87658b1df1e8918bd5f64939058ab7f (origin/desktop-integration)
Author: Robert McQueen <rob@endlessm.com>
Date:   Fri Apr 27 16:54:30 2018 +0100

    clean up desktop integration

     - don't register MIME handler for text/plain (Flatpak appears first in
       XDG_DATA_DIRS so otherwise we "steal" the default text editor association)
     - copy the icons app into the theme with both their original libreoffice-*
       name as well as the org.libreoffice name needed by Flatpak, which fixes the
       window icons
     - append the appdata for the separate apps (Base, Draw, etc) to the appdata
       XML we export for Flatpak, so they are visible in software centers etc

Change-Id: Ia086071671b9ff5a8b07c55a822240f9e8fbb8d3
Reviewed-on: https://gerrit.libreoffice.org/54030
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-09 16:38:42 +02:00