mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
403,347 Commits 1 Branch 0 Tags
1ba76fa81eb64c56c31379f678345a6667c47aa5
Commit Graph

403347 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Stephan Bergmann
1ba76fa81e Use OUStringLiteral 
Change-Id: I76b83140222cfd7e313736936b2803997c43836d
 2017-02-08 10:14:21 +01:00
Stephan Bergmann
fc51789ad0 Solaris C++ 5.2 compiler is no longer relevant 
Change-Id: I520a58438e156661d3e01a899e97ee33d9f19102
 2017-02-08 10:14:21 +01:00
Stephan Bergmann
07b51bc283 Use OUStringLiteral 
Change-Id: I6fd5f86288b303c8e3ce1cd072368df578e5e6a9
 2017-02-08 10:14:21 +01:00
Stephan Bergmann
d7a2e94e65 Use OUStringLiteral 
Change-Id: I720f70f81db92d75cdd83aa20a1cbf5a311b092b
 2017-02-08 10:14:21 +01:00
Stephan Bergmann
3c5c11bf63 Use OUStringLiteral 
Change-Id: I20685c733b12ef2a7efc894091a6e40d1347ac84
 2017-02-08 10:14:21 +01:00
Stephan Bergmann
3783df2027 rtl_str_shortenedCompare_WithLength -> OString::startsWith 
Change-Id: I3eabdeba10d8d1064f00b817b04f03aad8a6b352
 2017-02-08 10:14:20 +01:00
Stephan Bergmann
dd1cdac272 Clean up curious by-4/by-2 loop indices 
...that had been like that ever since ff09f8d6ef,
"MWS_SRX644: migrate branch mws_srx644 -> HEAD" at least, for no apparent
reason.

Change-Id: I6f8bd44179b232b7b39e493d443a443a60522a5c
 2017-02-08 10:14:20 +01:00
Stephan Bergmann
9123dda5c4 Use OUStringLiteral 
Change-Id: I905fe6553f0ad7f0d2dd1ac1bc771b2d42f35fe2
 2017-02-08 10:14:20 +01:00
Stephan Bergmann
ccc2b4ec0e Use OUStringLiteral 
Change-Id: I15580bd0395145f9554cd3a155c4825ba95005b3
 2017-02-08 10:14:20 +01:00
Stephan Bergmann
40035bbbbc Drop bogus check for escaped $ 
This apparently wanted to check whether the $ starting a potential pattern
occurrence was escaped by a preceding $.  However:

* The check itself was broken, erratically looking into sPattern instead of
  _inout_rFileURL for the $.

* The check was bogus, as it would have misinterpreted e.g. "$$$(loggername)".

* The resulting string is documented (in
  officecfg/registry/schema/org/openoffice/Office/Logging.xcs) to be passed
  through css.util.PathSubstitution.  However, neither the PathSubstitution
  service's documentation (in offapi/com/sun/star/util/PathSubstitution.idl) nor
  its implementation (SubstitutePathVariables::impl_substituteVariable in
  framework/source/services/substitutepathvars.cxx) appear to support esacping
  $ with a preceding $.  So it looks more reasonable to remove the check
  completely here.

Change-Id: I445493d444904cd54f166adcbf870a918d1f9982
 2017-02-08 10:14:20 +01:00
Stephan Bergmann
55717b14e0 Remove newly-unnecessary #includes from cppumaker-generated files 
...after e57ca02849 "Remove dynamic exception
specifications" dropped uses of UNO exception types from those generated files.
This needed first adapting client code that implicitly depended on those
#includes in the generated files it included ("Add missing #includes":
6dce9c6757,
a34d9150b4,
fed3783e77).

Change-Id: Ia1defda2d586b69092f53feef3644875192cbea4
Reviewed-on: https://gerrit.libreoffice.org/34014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-02-08 08:39:24 +00:00
Miklos Vajna
ad24a7c7f4 oox, sfx2: can use std::move() here 
Change-Id: I0add196f79045e8cb7280b2b7d1d8620e4ec669e
Reviewed-on: https://gerrit.libreoffice.org/34013
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-02-08 08:19:34 +00:00
Noel Grandin
f5245bf483 loplugin:unusedenumconstants read-only constants in xmloff 
Change-Id: I88afb3b4b3aa7d823c46062ead894561a66ac275
Reviewed-on: https://gerrit.libreoffice.org/33995
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-08 08:17:46 +00:00
Noel Grandin
37e9eae8ac remove unused constants from RES_MSG 
Change-Id: I3eaa1f051440a91c8c5b4996e28dea4e0d3933e5
Reviewed-on: https://gerrit.libreoffice.org/33994
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-08 08:17:27 +00:00
Noel Grandin
a3190d7201 remove unused SCHATTR_DIAGRAM_STYLE 
and associated SvxChartStyleItem and SvxChartStyle

Change-Id: I1564a4583125dd32af71e4eff338dfcefc6517c4
Reviewed-on: https://gerrit.libreoffice.org/33988
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-08 08:12:56 +00:00
Stephan Bergmann
7c62784314 loplugin:useuniqueptr (clang-cl) 
Change-Id: I9b9a6af2a7ff2dd64c474ec7f2dd084d4feb76f0
 2017-02-08 08:41:17 +01:00
Stephan Bergmann
c0d7a40be2 loplugin:useuniqueptr (clang-cl) 
Change-Id: Ic774c9ad174ea522da85585cd1d36f89ca6b1d64
 2017-02-08 08:41:00 +01:00
Stephan Bergmann
fed3783e77 Add missing #includes 
...like 6dce9c6757, for Windows-only code

Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
 2017-02-08 08:40:06 +01:00
Michael Stahl
653e181fb8 Revert "remove ugly operator* in DynamicErrorInfo" 
This reverts commit b5e3f8a5fa.

The problem is this:

==24217== Conditional jump or move depends on uninitialised value(s)
==24217==    at 0x29A25FCE: SfxObjectShell::SetError(unsigned int, rtl::OUString const&) (objmisc.cxx:220)
==24217==    by 0x29A35E6E: SfxObjectShell::ImportFrom(SfxMedium&, com::sun:⭐:uno::Reference<com::sun:⭐:text::XTextRange> const&) (objstor.cxx:2300)
==24217==    by 0x29A3705C: SfxObjectShell::DoLoad(SfxMedium*) (objstor.cxx:765)
==24217==    by 0x29A6BC48:
SfxBaseModel::load(com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) (sfxbasemodel.cxx:1802)

The commit is bogus because it introduces a
DynamicErrorInfo::GetErrorCode(), which overloads
ErrorInfo::GetErrorCode(), which is used at least in
DynamicErrorInfo_Impl::RegisterEDcr() and used to return a constructor
argument of DynamicErrorInfo but now returns pImpl->lErrId,
which is what this statement is trying to initialize.

Ultimately this causes my clang+ASAN build to fail because the
uninitialized error code happens to be detected as a mere Warning:

Test name: testMathMalformedXml::Import
assertion failed
- Expression: !xComponent.is()
- loading succeeded: sw/qa/extras/ooxmlimport/data/math-malformed_xml.docx

Change-Id: I9141144e0bc356ee54279948f2fce036d1831a86
 2017-02-07 23:02:57 +01:00
Michael Stahl
32cae6a2ea Revert "create ErrorHandlerFlags scoped enum for error handling flags" 
This reverts commit 05e78bde26.

Depends on the other commit that needs reverting
 2017-02-07 23:02:28 +01:00
Michael Stahl
178f530697 sfx2: if the exception thrown by filter isn't known... 
... then don't silently ignore it but just abort.  Evidently this cannot
happen, because if it were a real possibility the author of this
exception handler would have at least called SetError here.

Change-Id: Iaa5f1f1d4cac388ae08214f6031a8bc279e6fceb
 2017-02-07 23:02:18 +01:00
Caolán McNamara
54380811ac ofz: get the font info early inside leak disabled code 
cause we don't have a tear-down to release it

Change-Id: I86a72288a1ed03bf5fc5b6a00d9067f3f1063580
 2017-02-07 20:42:29 +00:00
Stephan Bergmann
8c2f9bb5b8 Remove duplicate documentation comment 
Change-Id: I5215f4a27a5fde9e34ba1dce0a6f68f8dfbf0f97
 2017-02-07 21:10:12 +01:00
Maxim Monastirsky
4d4d25ee6f Always use split button for .uno:CharBackColor 
Change-Id: I4dd01ec8692fff77a94d6fa698e438581f6dbf37
 2017-02-07 21:34:58 +02:00
Maxim Monastirsky
5350dfca60 tdf#105631 Notebookbar doesn't use wide buttons 
So we want non-split behavior only in SidebarToolBox,
not in the derived NotebookbarToolBox.

Change-Id: I064bbe59b97da301a13889ad78a31227cfd693ee
 2017-02-07 21:34:58 +02:00
Stephan Bergmann
afe76d1a4e SDK, just stop tampering with my term's title 
Change-Id: If053466ed5f2e74ea4b73719f6e07789c055998d
 2017-02-07 20:34:13 +01:00
Stephan Bergmann
ccc827a593 Blind fix for build 
Change-Id: I0e992eb2e10c71de1e04b9283a012c8e8f229612
 2017-02-07 20:25:38 +01:00
Stephan Bergmann
da147a4e64 Clean up C-style interface nonsense 
Change-Id: Ie9a1e106f5270fd307d211fa334449c698acf25d
Reviewed-on: https://gerrit.libreoffice.org/34010
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-02-07 19:23:01 +00:00
Jochen Nitschke
bddc774795 remove CREATE_OSTRING macro 
Change-Id: I7d5e1570918adc3b0cf2063d9735414233011a81
Reviewed-on: https://gerrit.libreoffice.org/34009
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-07 19:06:16 +00:00
Michael Meeks
58d4a3122c tdf#104870 - keep reference on the TitleBar while setting title. 
Unlikely to fix the issue, but may help.

Change-Id: I3c319f550e86f2ab731b072d86d258dca12d34fa
Reviewed-on: https://gerrit.libreoffice.org/33998
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2017-02-07 18:56:16 +00:00
Caolán McNamara
555e1ff4cc bubble the original gtk surface type through rendering 
this may make scrolling a tad faster

Change-Id: I0c2cc9df85932e25dbfed88727d3b83d299671c7
 2017-02-07 16:41:51 +00:00
Xisco Fauli
f9d0f55b2e tdf#79236: Add uitest 
Change-Id: I916438d688ec24c67b581bf2e025215dda228e97
Reviewed-on: https://gerrit.libreoffice.org/34000
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
 2017-02-07 16:40:54 +00:00
Stephan Bergmann
cc33a1ccda Remove MINGW_CLIB_DIR left-over 
...after b28f25aa9e "MINGW_CLIB_DIR is unused"

Change-Id: I8395d492120455378ec001e37428a645aa879440
 2017-02-07 17:19:18 +01:00
Stephan Bergmann
95c7b3693a Remove HAVE_NON_CONST_NPP_GETMIMEDESCRIPTION left-over 
...after 4c18af27bf "tdf#96398 kill remaining
NPAPI support for plugins _inside_ LO"

Change-Id: Ide62fa142108562c191ca95ab307638178476fea
 2017-02-07 17:16:34 +01:00
Stephan Bergmann
2ff37ae383 Remove GNOMEVFS left-overs 
...afer b40b601007 "ditch gnome-vfs2 support"

Change-Id: I0a57da5f2d810e78837035c86ee1f03ae33aacd8
 2017-02-07 17:13:28 +01:00
Caolán McNamara
321d970e2f flatten ShellResource resource 
Change-Id: Ib071a21778289f4dc68273cb305d38bf260a31a7
 2017-02-07 16:10:46 +00:00
Stephan Bergmann
2ec697a77f Remove DBUSMENUGTK left-overs 
...after 4e7f9650e2 "remove ancient lo-menubar
implementation now that we have the shiny new one"

Change-Id: I49e7a5489279aaf3469d14c4e9d75245203c5937
 2017-02-07 17:06:37 +01:00
Caolán McNamara
6684945304 convert resources containing strings to stringarray resources 
Change-Id: I61e815a9545f55a3b886322e7d2c0d50040584bd
 2017-02-07 15:38:57 +00:00
Caolán McNamara
6efdd843c8 Related: tdf#105371 we can do this with a sizegroup 
Change-Id: Ie37a3d960ec244033f2b05e7a902c7a23ba9b94d
 2017-02-07 15:38:57 +00:00
Stephan Bergmann
c504923421 Replace macro with function 
Change-Id: Icb4488ea38b99a329a071063292db4001799ecc8
 2017-02-07 15:50:44 +01:00
Michael Meeks
e5b0627589 configmgr: add SAL_CONFIG_WINREG_RETAIN_TMP variable. 
Windows registry dumping behaves very strangely, and in hard to debug
ways - this should help in-the-field debugging of this in future.

Change-Id: Ia35d58a8be36d1b683db39ae7d2128a3ccfd10a5
Reviewed-on: https://gerrit.libreoffice.org/33992
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2017-02-07 13:38:47 +00:00
Stephan Bergmann
3b9073d2ba Bring back initui.hrc 
...presumably missing from 19ea3db6d3 "revert
unready stuff"

Change-Id: I74ab88dc1bd1bdd92d8bebc3120d036f032f5049
 2017-02-07 14:32:27 +01:00
gkorepanov
9f44d19815 Made lcl_DrawDashedRect() more readable and faster a bit 
Change-Id: I58e06f090248e034541e276f11cecef8b26e874a
Reviewed-on: https://gerrit.libreoffice.org/33394
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2017-02-07 13:21:49 +00:00
Caolán McNamara
19ea3db6d3 revert unready stuff 
Change-Id: I2b112a17a2bc70bfe4d5a6af7964a3c1d7eacf9b
 2017-02-07 13:09:31 +00:00
Caolán McNamara
eee0206831 interim convert to ResArray 
Change-Id: I74c8ad1242611321401f6282dfbce3205977394a
 2017-02-07 13:07:58 +00:00
Caolán McNamara
e51f247484 flatten ShellResource resource 
Change-Id: I6094f86eb7da89ba5e21be909417b23f9f375351
 2017-02-07 13:07:58 +00:00
Caolán McNamara
1c48275a28 convert resources containing strings to stringarray resources 
Change-Id: I8a306b417dcf533a148e34a6314e37589dcdda12
 2017-02-07 13:07:57 +00:00
Caolán McNamara
7863798f2a bubble the original gtk surface type through rendering 
this may make scrolling a tad faster

Change-Id: I5f11f9b3196c3d42c82ac03bc332ef84189f3737
 2017-02-07 13:07:57 +00:00
Caolán McNamara
5ddf5d8dc6 there is no cnt (chaos) resource file anymore 
Change-Id: I97f0606c6003ca12c651841ec26145728fc5c808
 2017-02-07 13:06:28 +00:00
Caolán McNamara
a44e94a453 replace calculation to get RID_SVXERRCODE with RID_SVXERRCODE 
presumably a hackaround from old deliver-headers era

Change-Id: Idbaeec7bb8523776045ce5355235a4397b2195e4
 2017-02-07 13:05:59 +00:00