437590 Commits

Author SHA1 Message Date
Muhammet Kara
1d137f07cb Add QtCreator-specific file to .gitignore
Change-Id: If00a4eed997acf2eb7783915e41c61c7651232d6
Reviewed-on: https://gerrit.libreoffice.org/73698
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-08 15:36:20 +02:00
Noel Grandin
516bdf7989 loplugin:singlevalfields
Change-Id: I7c00b7d932bf96a0725eac5482580461baea6977
Reviewed-on: https://gerrit.libreoffice.org/73697
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08 15:01:13 +02:00
Muhammet Kara
fe977ec070 Auto redaction dialog second iteration
* Add the Add handler
* Add SfxAddTargetDialog dialog
* Add the Delete handler

Change-Id: I9c466754f6b593ffe3c8a1cc8034bbe47674f591
Reviewed-on: https://gerrit.libreoffice.org/73285
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-08 12:12:41 +02:00
Muhammet Kara
82bba7e4c0 Auto redaction dialog first iteration
* Add the uno command .uno:AutoRedact with the name 'Auto-Redact'
* Add the dialog SfxAutoRedactDialog
* Implement the basic functionality to show up when clicked on the
  menu/toolbar item.
* Add the class TargetsTable to control the weld::TreeView
  which is used to list the targets
* Add the struct RedactionTarget to keep info for individual targets

Change-Id: Ic02dfb009590c0928a2ea7b0f8b19b4febca221a
Reviewed-on: https://gerrit.libreoffice.org/72254
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-08 11:10:14 +02:00
Julien Nabet
4195323c05 Typos
Change-Id: If8a5aaba35afb270ce30d49b55a0106e020dfbe0
Reviewed-on: https://gerrit.libreoffice.org/73695
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 10:19:32 +02:00
Noel Grandin
aed5ce3547 loplugin:unusedfields
Change-Id: I9758fd606c7d4c251a3ac06661d642a47260b5fc
Reviewed-on: https://gerrit.libreoffice.org/73674
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08 09:35:54 +02:00
Andrea Gelmini
1f07faf2ca Fix typo
Change-Id: I57ad3ce3595f8225ae6f52afd63dfc2477b7e5d8
Reviewed-on: https://gerrit.libreoffice.org/73689
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 09:01:06 +02:00
Andrea Gelmini
1a5ab86511 Fix typo
Change-Id: I8f6725b66ea076804e5a1966e3acb88999d2204d
Reviewed-on: https://gerrit.libreoffice.org/73685
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 08:53:05 +02:00
Andrea Gelmini
714fa1af62 Fix typo
Change-Id: Idd668a1d16ae17d4821804859d0d5eb6b92ae345
Reviewed-on: https://gerrit.libreoffice.org/73683
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 08:52:39 +02:00
Andrea Gelmini
65844edb15 Fix typo
Change-Id: I1728ab5cb25cb96e764f21e7c750ca6b91a92b15
Reviewed-on: https://gerrit.libreoffice.org/73682
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 08:51:57 +02:00
Andrea Gelmini
561e1b6aed Fix typo
Change-Id: I3c1e4697282f4ccc4ef0b0cea28b55ea20e9189b
Reviewed-on: https://gerrit.libreoffice.org/73691
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 08:50:03 +02:00
Andrea Gelmini
0c5cb20f26 Fix typo
Change-Id: I8327e8ba6be8122636d1203cefa8d33ac498c112
Reviewed-on: https://gerrit.libreoffice.org/73687
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 08:49:27 +02:00
Andrea Gelmini
6704943336 Fix typo
Change-Id: Ifc02d4d56b5068af0c6c73a9138e4ada1a8bbd5f
Reviewed-on: https://gerrit.libreoffice.org/73690
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 08:45:33 +02:00
Andrea Gelmini
de60d2ad55 Fix typo
Change-Id: I1d1b0a678e4d21367349178467d18eef00a98621
Reviewed-on: https://gerrit.libreoffice.org/73688
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 08:44:26 +02:00
Andrea Gelmini
8c90c9d2f8 Fix typo
Change-Id: If45e9c127027adc20edbddf31907db257c0ef8f0
Reviewed-on: https://gerrit.libreoffice.org/73686
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 08:43:18 +02:00
Jan-Marek Glogowski
3e82710d1e KDE5 merge KDE5SalGraphics into Qt5SvpGraphics
Nothing KDE specific left in there, so just merge it.

Change-Id: I11712961f2abc5e11256a158300ec6b388f9ee44
Reviewed-on: https://gerrit.libreoffice.org/73680
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-08 05:56:44 +02:00
Michael Weghorn
92c03d9bf6 qtcreator: Take over '-std=...' from CXXFLAGS
If the '-std=' compiler flag is set in CXXFLAGS,
take that over into the .pro files used by
Qt Creator.

This makes ClangCodeModel use the correct std version,
and e.g. know about 'std::string_view' if '-std=gnu++2a'
(or anything else indicating C++17 or higher is supported)
is used and thus avoids unnecessary errors/warnings from
being displayed.

Use a list, so other flags can easily be added later.
(It currently doesn't seem reasonable to me to just pass all
cxxflags though, since .pro files are currently only generated
per top-level module, while C++ flags can differ between
different targets in the same module).

Change-Id: Id3f3e2b9ba77e5220a17fd4796937c816979959a
Reviewed-on: https://gerrit.libreoffice.org/73677
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-06-08 03:58:00 +02:00
Mike Kaganski
5fca7ba2fd Drop SwAttrHandler::SwAttrStack; use std::vector instead
Change-Id: I3e6257cc34782ca32fb2a7c87c9976494b36907b
Reviewed-on: https://gerrit.libreoffice.org/73660
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-08 03:50:29 +02:00
Jan-Marek Glogowski
2cb6a591b6 tdf#125673 KDE5 implement a KDE5SalVirtualDevice
We just need AcquireGraphics() to return a KDE5Graphics.
Otherwise the BufferDevice's SVP will use a SvpSalGraphics
instead of the KDE5Graphics, which knows about Qt's theming.

Change-Id: I0ea646df260f2067d61c753f03dee01a003f382a
Reviewed-on: https://gerrit.libreoffice.org/73673
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-08 03:30:45 +02:00
Miklos Vajna
9870ff897f Related: tdf#111522 svx: fix crash with view1 doing textedit and resize/rotate
The two actually affected functions are SdrEditView::RotateMarkedObj()
and SdrDragObjOwn::EndSdrDrag(), but it looks like the other functions
in SdrEditView are safe to be changed the same way.

I expect IsUndoEnabled() can't be changed, though: that would mean there
would be no undo for the text edit itself, either.

If other actions still crash, the pattern is the same: put a breakpoint
on the SdrUndoAction constructor and see the backtrace to find the
function that calls IsUndoEnabled() without calling CanDoSdrUndo() at
the same time.

Change-Id: If9324e311ec6e9f68a951559e903e14bb72ea31c
Reviewed-on: https://gerrit.libreoffice.org/73669
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2019-06-07 23:46:25 +02:00
Grzegorz Araminowicz
8aae7e4bc8 tdf#125551 PPTX export: correct position and size of diagrams
Save position and size of diagram background instead of whole group shape.
Some diagrams contain shapes that are outside these boundaries. That caused
diagram to grow and move.

Change-Id: I909c13a5dc268f77832234b3884b91292922823c
Reviewed-on: https://gerrit.libreoffice.org/73663
Tested-by: Jenkins
Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-06-07 23:12:45 +02:00
andreas kainz
42223dc757 notebookbar_compact update
Change-Id: I256c2ec3934d728b5b68fbca8b7ba99a50a840ff
Reviewed-on: https://gerrit.libreoffice.org/73661
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-07 22:10:54 +02:00
Regina Henschel
95b61f7da4 tdf#125563 Adapt adjustment values to binary shape geometry
All presetTextWarp shapes are mapped to MS binary WordArt geometry in
current implementation. But they use different reference systems for
coordinates and different unit for angles. So _all_ adjustment values
have to be adapted. Error was, that only angles were treated.
Correct test file to actually contain the claimed 213.25 degree.
Other bugs than adjustment values will be addressed in separate issues.

Change-Id: I719b364af23887e50f003cf9878665755b8989ae
Reviewed-on: https://gerrit.libreoffice.org/73624
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-06-07 21:52:53 +02:00
Stephan Bergmann
74a088d577 Don't reset PYTHON_VERSION if it was explicitly passed in
...along with PYTHON, PYTHON_CFLAGS, and PYTHON_LIBS.  (PYTHON_VERSION is
apparently set by AM_PATH_PYTHON.  When explicitly passing in PYTHON_CFLAGS and
PYTHON_LIBS under --enable-python=system, AM_PATH_PYTHON does not get called,
but PYTHON_VERSION needs to be set, so needs to be passed in explicitly.)

Change-Id: Ia8c3877fffd8dcc179a56be04627c61a667d8cb0
Reviewed-on: https://gerrit.libreoffice.org/73662
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-07 21:29:42 +02:00
Caolán McNamara
cb0fd00eb3 Resolves: tdf#125761 there is no page called 'labelTP_BACKGROUND'
Change-Id: Ia6558039da010b0f6d8385e9791c0abc2ef75eba
Reviewed-on: https://gerrit.libreoffice.org/73665
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-07 20:47:44 +02:00
Mike Kaganski
2d5821ceac tdf#125624: this bugdoc overflows sal_uInt16
Change-Id: I8ecc08d3ef42b9f7cc501017e0e169bde2196317
Reviewed-on: https://gerrit.libreoffice.org/73654
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-07 16:28:55 +02:00
Noel Grandin
e51aa80ea3 fix assert in make screenshot
after
    commit a46a257794f1f53b294735fc876c394be23a3811
    Date:   Wed Jun 5 15:24:04 2019 +0200
    improve empty tools::Rectangle (width)

Change-Id: I496d92712aa7627f7d6932d7d01f70a68a1ee781
Reviewed-on: https://gerrit.libreoffice.org/73657
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07 16:23:00 +02:00
Michael Meeks
03d33ba941 lok: re-factor getTextSelection.
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e
Reviewed-on: https://gerrit.libreoffice.org/73626
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-07 15:42:05 +02:00
Miklos Vajna
00dfa6dc89 tdf#117347 sw form controls: fix disappearing FixedText when editing TextField
This is nominally a regression from commit
af11abf3626e12d2b4b7dd9d255c6c71bf84cd4b (SwViewShell::ImplEndAction:
still paint directly when non-double-buffering, 2015-09-01), but that
just uncovered an already existing problem introduced earlier in commit
2b26c1796d0a05f47cfb01d79ee4f69344efbbb2 (tdf#92577 sw rendercontext:
paint transparent from controls conditionally, 2015-07-06).

Given that the first commit (as a side-effect) solved the problem the
second commit tried to solve, it's safe to just revert this.

(Sadly we have no way to test incremental paints with a reasonable
amount of effort, so no testcase.)

Change-Id: Ia59efbf45a0cd5af3580914e1dcee74d89068f03
Reviewed-on: https://gerrit.libreoffice.org/73647
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2019-06-07 14:17:10 +02:00
Jan Holesovsky
e9660591f8 android: Fix build after welding AboutDialog.
Without this, the vcl's AboutDialog conflicts with the AboutDialog from
cui during linking of liblo-native-code.so.

Change-Id: Ie6e5ddd52bb7bdee1c7d53c37ea566d7ce6c9385
Reviewed-on: https://gerrit.libreoffice.org/73613
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-07 13:41:05 +02:00
Caolán McNamara
b1ffd72e32 drop some unneeded includes
Change-Id: Ifdafc97c8616da5d844a1ade7694265a833e8f53
Reviewed-on: https://gerrit.libreoffice.org/73598
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-07 12:40:41 +02:00
Michael Weghorn
6b911ae9eb Drop support for gstreamer-0.10
Drop all GStreamer 0.10 support according to
ESC decision of 2019-06-06.

GStreamer 0.10 is obsolete and no longer needed,
superseded by GStreamer 1.0 which is available in
baseline (RHEL 7 or CentOS 7) and all relevant distros.

Change-Id: Ic317eba04d2c17e141acc983f37fbfa4301c9f3f
Reviewed-on: https://gerrit.libreoffice.org/73619
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-06-07 11:07:42 +02:00
Noel Grandin
a46a257794 improve empty tools::Rectangle (width)
This is the width part, the height part will come next.

Instead of storing "empty" as a special value (which is easy to get
wrong, eg. some image filters pass in that special value, expecting it
to be a valid width), just use separate boolean values for width and
height empty.

Also lots of code was calling GetBottom() or GetRight() on an
empty rectangle, getting back that magic value and doing calculations
on it, resulting in completely bogus data.

So
(1) make the various Rectangle methods do something reasonable
    when the empty flags are set
(2) fix various other code to handle empty better
(3) assert when code accesses Bottom or Right and the empty flag
    is set.

Change-Id: I1163378cd2773dd8b386210f83400bb6b4701069
Reviewed-on: https://gerrit.libreoffice.org/73564
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07 11:01:37 +02:00
Gabor Kelemen
43ddddb703 tdf#42949 Fix IWYU warnings in svl/
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Except source/svdde/* which is WIN-specific

Also recheck include/svl

Change-Id: I32d3bcb6b14665c56c07a2f10526329b08c64cbe
Reviewed-on: https://gerrit.libreoffice.org/73630
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-07 09:06:14 +02:00
Miklos Vajna
9c945cdbe1 sw btlr writing mode: DOCX drawingML import for fly frames
By using the now working btlr direction of the underlying fly frame,
instead of the character-level workaround.

Change-Id: I3024e3348a30c72f461032b03b88c210f25eb75a
Reviewed-on: https://gerrit.libreoffice.org/73628
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-07 09:05:08 +02:00
Tor Lillqvist
8d16f406e6 Bin the much too verbose SAL_INFO() calls for the "vcl.cg" tag
Quikee agreed that they aren't really useful. Doing even the simplest
things causes such a huge amount of logging that it is questionable
whether anybody could have any use of it.

Parts of it might be useful to restore later, if need arises. Like the
mnContextStackDepth logging in vcl/inc/quartz/CGHelpers.hxx.

Change-Id: If635e6492a50e5955c56c54fa310e7c0ab2986ae
Reviewed-on: https://gerrit.libreoffice.org/73639
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-06-07 08:44:05 +02:00
Andrea Gelmini
548f30f21b Fix typo
Change-Id: I0037cf0a59189862ad502bfbdb00580ed7378fe4
Reviewed-on: https://gerrit.libreoffice.org/70393
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07 07:09:10 +02:00
Andrea Gelmini
dafb3bda09 Fix typo
Change-Id: I4b4f0d6c96d85d050110ff39db2cc06bb1d666c2
Reviewed-on: https://gerrit.libreoffice.org/70690
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07 07:08:53 +02:00
Andrea Gelmini
94be791d32 Fix typos
Change-Id: Iec0824418063fa4d146d9d48f3c74561fc0c5a67
Reviewed-on: https://gerrit.libreoffice.org/73631
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07 07:07:55 +02:00
Andrea Gelmini
a9d67bbb4b Fix typos
Change-Id: If9d52bd769d96865a3fbfdda1f339bbd0f8c3ca3
Reviewed-on: https://gerrit.libreoffice.org/73633
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07 07:07:36 +02:00
Andrea Gelmini
93bc4fe035 Fix typo
Change-Id: Ie9174d46b3936ee19a7d1e70f85af6fed2c0c6d4
Reviewed-on: https://gerrit.libreoffice.org/73637
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07 07:07:16 +02:00
Andrea Gelmini
0cb40b6f02 Fix typo
Change-Id: I577cecc9b5c73a999b0e38478adf71c527210619
Reviewed-on: https://gerrit.libreoffice.org/73635
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07 07:06:20 +02:00
Andrea Gelmini
f158398de8 Fix typo
Change-Id: Icbfc9276e09f2d50647c4e800b6d688d978b875b
Reviewed-on: https://gerrit.libreoffice.org/73632
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07 06:53:49 +02:00
Andrea Gelmini
08a42f9ccd Fix typo
Change-Id: I1ed7280266fc2612ca1286c129a614c51aba3571
Reviewed-on: https://gerrit.libreoffice.org/73636
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07 06:53:05 +02:00
Andrea Gelmini
87481b9173 Fix typo
Change-Id: I4cfc98ab3be0c789274978ec6b26f981ad627494
Reviewed-on: https://gerrit.libreoffice.org/73634
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07 06:51:32 +02:00
Jens Carl
daba09df24 Remove .uno:ToolsMacroEdit command
A search with git grep ".uno:ToolsMacroEdit" showed that the entry isn't
used anywhere (also .uno:BasicIDEAppear provides a similar functionality).

Change-Id: Ib97f4ebd6707d82f9077dd2f4e6c05e537f8154d
Reviewed-on: https://gerrit.libreoffice.org/73582
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-07 06:50:54 +02:00
László Németh
1b63fa32bb sanitize LibreLogo calls
Change-Id: Ie4d9858e5b4b3e55ab08416fb9338d2df34ee5e1
Reviewed-on: https://gerrit.libreoffice.org/73627
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2019-06-07 06:29:13 +02:00
Tomaž Vajngerl
b170256fb6 tabbar: make ImplFormat more readable
Change-Id: Id9a188fc46d800212ff583a233f06553bf1b4596
Reviewed-on: https://gerrit.libreoffice.org/73591
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-07 03:11:55 +02:00
rizmut
c74d7ff0b4 Sifr: Add missing large icons
Change-Id: Iadd17df97f374752097c8cad4b82735a4c77f923
Reviewed-on: https://gerrit.libreoffice.org/73343
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-06 23:57:20 +02:00
Michael Meeks
326f281715 lok: remove ext text event re-entrancy hazard.
Change-Id: I7566c158330bab77589d422c61c64210727ab835
Reviewed-on: https://gerrit.libreoffice.org/73625
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-06 23:21:51 +02:00