mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
383,463 Commits 1 Branch 0 Tags
1d2a407d90c140e2edab6390c7d46814993b988f
Commit Graph

217 Commits

Author SHA1 Message Date
Stephan Bergmann
51b45df6bb loplugin:nullptr (automatic rewrite) 
Change-Id: I8690de2cb68dcfedc9f2239ce66cea06fd94bc16
 2015-11-10 10:32:01 +01:00
Noel Grandin
6c80a8fe89 new loplugin: oncevar 
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-09 08:34:40 +00:00
Stephan Bergmann
41a000b742 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: Ibb9372bc45a0bc0b9083ad0e405440bbbe5ef678
 2015-11-06 09:38:44 +01:00
Noel Grandin
e209d115d4 remove old standalone Sun bug numbers 
Sun bug numbers without any accompanying text are completely useless.

Fixed with
   git grep -lP '//\s*#\d+#\s*$'
       | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.

Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-01 06:57:19 +00:00
Caolán McNamara
31ebd9f475 boost->std 
Change-Id: Ic18be8b86727dd1179a7e39c70493d088ed00557
 2015-09-16 15:34:23 +01:00
Stephan Bergmann
b71b5c85f1 Clean up sEmptyURL 
Change-Id: I63e2f5055a87593708f672341b5849554b4db6fb
 2015-08-27 08:00:33 +02:00
Stephan Bergmann
a6050c32f3 Clean up aEmpty 
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
 2015-08-27 08:00:32 +02:00
Caolán McNamara
7ae8e767b9 cppcheck: variableScope 
Change-Id: If24e86a0bdc0c5bdce02bed9981232070b38393c
 2015-08-12 09:23:13 +01:00
Noel Grandin
05457f3bf8 loplugin: defaultparams 
Change-Id: I7989a91d8d67a15d3fef13391c5dbf06233f75e9
 2015-08-11 09:48:18 +02:00
Noel Grandin
9c1f700aff improve refcounting loplugin to check SvRef-based classes 
Change-Id: I2b3c8eedabeaecd8dcae9fe69c951353a5686883
Reviewed-on: https://gerrit.libreoffice.org/17521
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-05 11:26:04 +00:00
Stephan Bergmann
5897e103b6 loplugin:stringconstant: handle OUString+=OUString(literal) 
Change-Id: I44c30ef19661d3274a4131dd05a5c786263fae59
 2015-06-26 13:55:36 +02:00
Caolán McNamara
e50698c0ce cppcheck: noExplicitConstructor 
Change-Id: I8c9e970d5c5931de1a7526cbff3de626ef30bd74
 2015-05-24 20:58:24 +01:00
Markus Mohrhard
6acc6c011d text:p is not allowed as child element of draw:frame 
Regression from #i118485#.

Change-Id: Ib242ca1417f46b731d62d117132cbed6c02448fb
Reviewed-on: https://gerrit.libreoffice.org/15173
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2015-04-08 13:40:11 +00:00
Markus Mohrhard
204d1093d4 only try to export text:p for elements that really support it 
Change-Id: Ie2c072c67ecaa0c0ec45c804ebbd4b3bcd631a13
Reviewed-on: https://gerrit.libreoffice.org/15172
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2015-04-08 13:39:50 +00:00
Noel Grandin
4906c24387 convert SvtModuleOptions::EFactory to enum class 
and fix issues in iterating through o3tl::enumarray

Change-Id: Ia59ef9be44d8c92c2e406fa71aa92269578e26e3
 2015-04-07 13:05:34 +02:00
Stephan Bergmann
44b9b27b1a Clean up C-style casts from pointers to void 
Change-Id: I962bd44f2ef6204ed2ea51f79b752bd948f67209
 2015-03-28 19:09:29 +01:00
Caolán McNamara
5a308b1239 V801: Decreased performance 
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
 2015-03-09 12:41:09 +00:00
Michael Weghorn
bfe79b50bc fdo#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: If7ad3584b3124ed0b337836071af1a5bd0451d85
Reviewed-on: https://gerrit.libreoffice.org/13972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-01-19 08:39:32 +00:00
David Tardon
5672dab6b5 Revert "Don't assume that the ZOrder property of shapes is an enumeration" 
This reverts commit 66c7dbbf7d.

See https://gerrit.libreoffice.org/#/c/13554/ .

Conflicts:
	include/xmloff/shapeexport.hxx
	reportdesign/source/filter/xml/xmlExport.cxx
	sc/source/filter/xml/xmlexprt.cxx
	xmloff/source/draw/shapeexport.cxx

Change-Id: I14fed9ad043a756a9e2d390c76fa907c349c3a2e
 2015-01-08 16:08:11 +01:00
Noel Grandin
64cccf36f2 fdo#84938: convert SEF_EXPORT_ #defines to 'enum class' 
Change-Id: I7165d0f1b6b4af4de5e5b39a21f36d726a1b0e30
 2015-01-06 10:59:42 +02:00
Noel Grandin
c29657e0d6 fdo#84938: convert EXPORT_ #defines to 'enum class' 
Change-Id: I2ed239fa073b5fa8fb56c1af9d4b0bac89acfacf
 2015-01-06 10:59:42 +02:00
Lionel Elie Mamane
aeeff83595 fix build 
Change-Id: Ia528bd301e2f2ee1f7f3b009e3b9c3f395a4dcdb
 2014-12-20 00:20:58 +01:00
Lionel Elie Mamane
be2aa71a2c survive "TextBox" having no value 
Change-Id: Iebed41cfcc5899387e3defb8d8a0792276349098
 2014-12-19 23:35:17 +01:00
Lionel Elie Mamane
66c7dbbf7d Don't assume that the ZOrder property of shapes is an enumeration 
...at least when we can easily not assume it.

shapes = shapes of the same XShapes
an enumeration = it is the sequence 0, 1, 2, 3, ..., XShapes->getCount()-1

We replace the ZOrder property by the index of the XShape in the
XShapes (the same XShapes that is passed to seekShapes()... when that
is easy to find. Else, use ZOrder and hope for the best.

ZOrders are not always an enumeration. For example, in documents
(forms) created by the Base forms wizard, it is not the case.

The wrong assumptions was leading to the following bugs in the Base
form wizard:

 - Only the first two controls in the form were successfully saved. The
   others were just dropped.

 - Whereas the labels had the proper style (background and text
   colour) applied while creating the document, these were not saved
   successfully

Change-Id: I15b9a3ef3b16eafa9698332e35d82d51d51627f8
 2014-12-19 23:33:33 +01:00
Lionel Elie Mamane
3d4e1beacb two references having same content 
Change-Id: I2db8842411e39d7d100d0627f8c930bb3f633d77
 2014-12-19 23:33:31 +01:00
Lionel Elie Mamane
f0471ea755 this is purely informative, SAL_WARN is overkill 
Change-Id: Iccb98e50a678e5c53b69fb1052e3dac83cdcf5f5
 2014-12-19 23:33:30 +01:00
Stephan Bergmann
513108bd57 xmloff: Use appropriate OUString functions on string constants 
Change-Id: Idbe6ac27a4125bd9d9acb01ac42b60396abf0c81
 2014-12-12 12:25:35 +01:00
Markus Mohrhard
95d27f465f the xlink:type attribute is mandatory, related fdo#79449 
Change-Id: I03c4217f786bc10aa915780dc10ea52d94019b6e
 2014-12-06 08:21:50 +01:00
Stephan Bergmann
e97edb6e85 simplify 
Change-Id: I6cb7c66a8dbac1a887d4f218f5de9d73310c809b
 2014-11-26 22:21:22 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Miklos Vajna
9835a5823e sw textboxes: reimplement ODF import/export 
Turns out that for normal TextFrames and rectangular drawinglayer
shapes, the engine is written in ODF implicitly. Use the same trick to
describe if the shape content should be rendered by SW or editeng.

This reverts 9d310ecfce (sw textboxes:
implement ODF import/export, 2014-06-02).

Change-Id: Id8afa6368bedcd293e578244abb58e18949bec8d
 2014-10-04 20:18:01 +02:00
Noel Grandin
c190577f75 loplugin: cstylecast 
Change-Id: I25b82a96aace448a8debe90c181b22976ea95414
 2014-10-01 13:08:43 +02:00
Noel Grandin
c9d4a2887c fdo#82577: Handle PolyPolygon 
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows
PolyPolygon typedef.

Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
 2014-09-30 11:47:41 +02:00
Stephan Bergmann
edffb444c0 loplugin:stringconcat 
Change-Id: Iaa5df366118b8766b47e7bd4e9875c44c0e5d8d9
 2014-07-29 14:59:33 +02:00
Joren De Cuyper
ccdd9a2c54 Further OUString cleanup in xmloff/ 
Change-Id: Ic749119931db569bf26c8d8a58da7d468811f927
Reviewed-on: https://gerrit.libreoffice.org/10598
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2014-07-29 12:44:23 +00:00
Oliver-Rainer Wittmann
fd641c7b23 Resolves: #i125289# do apply possible changed <GraphicStreamURL>... 
only for embedded images which already have its stream inside the package

fixes also issue 125290

(cherry picked from commit 9602a121b458e7456fc533dad86f434f846a72ba)

Conflicts:
	xmloff/source/draw/shapeexport2.cxx

Change-Id: I5af0093b20f2f291d3a94c690bfbdb59a59320c3
 2014-07-23 11:26:34 +01:00
Noel Grandin
4ff115b3e7 drop UniReference in favour of rtl::Reference 
since they're doing the same thing.

Change-Id: I76134b6b848db8628f315fe5bd9eb972a6bf0cb6
 2014-07-02 15:23:52 +02:00
Zolnai Tamás
04b7b2c72f Fix gltf export: close plugin element before export fallback 
Change-Id: I2e1f27e535ee45259f7bdf783ea5224b2ad559ef
 2014-06-16 13:55:40 +02:00
Zolnai Tamás
4d8c4e7fe3 glTF import/export: fallback must be the second one inside the frame 
The previous solution was good because older LO versions
import the fallback image without changing their code, but
it came out it does not fit to ODF standard so export
fallback image as the second object after the glTF model.

Change-Id: Ib9b2044b1f36b32d980cb79f6dac8dcf94d6209b
 2014-06-16 12:59:19 +02:00
Zolnai Tamás
9ee69cbd6f glTF export: Use plural folder names 
Change-Id: If17628395ede512c00b666efc5511d9711edfb5a
 2014-06-16 12:58:52 +02:00
Stephan Bergmann
c21979a327 loplugin:staticcall 
Change-Id: I7691a6d267ea572e3fdd028c1cfae7b721a76da7
 2014-06-13 17:54:37 +02:00
Zolnai Tamás
e8fcf1153f Change glTF mime type: {application -> model}/vnd.gltf+json 
There is no an accepted mime type for glTF models yet, so
follow collada's mime type: model/vnd.collada+xml.

Change-Id: I1e23a95dbb0caea781dade819f8e08235cb5c1dc
 2014-06-12 21:43:36 +02:00
Zolnai Tamás
fe70101856 Introduce HAVE_FEATURE_GLTF to enable/disable gltf related code 
When it is a release build then enable it only on Windows and
Linux.

Change-Id: I7c462aeb75e6ab60eeaa0fa42ca7853a6369b742
 2014-06-12 21:43:35 +02:00
Oliver-Rainer Wittmann
192abfb36b Resolves: #i114361# provide and accept changed URL... 
of embedded graphic file during save (ODF export)

(cherry picked from commit a90c007908eb3f66e28a9ea525729065db652b6f)

Conflicts:
	sw/inc/ndgrf.hxx
	sw/source/core/graphic/ndgrf.cxx
	sw/source/core/unocore/unoframe.cxx
	sw/source/filter/xml/xmltexte.cxx
	xmloff/source/draw/shapeexport2.cxx

Change-Id: I9d4a02af2561467fe1a66f036b55d6dcf2429986
 2014-05-23 20:38:13 +01:00
Zolnai Tamás
b862a216f7 ODF filters: fallback glTF model to bitmap for older versions 
Change-Id: I33161401a29f511e61429355dd2905d4643fe8ff
 2014-05-16 16:24:10 +02:00
Noel Grandin
8a81f542a6 xmloff: sal_Bool->bool 
Change-Id: I873c80baec8e70e3e8f642644563b92137571a30
 2014-04-15 09:02:31 +02:00
Norbert Thiebaud
0586bdc748 coverity#704111: Unchecked return value 
Change-Id: Ida3a1b2804f655b39378f79e10872dcac4e70cf1
 2014-04-06 13:11:30 -05:00
Zolnai Tamás
d14f701bba glTF ODF export: use mimetype to decide about file type 
Change-Id: Ib1837bdc7468fb19f55a38f6875e026eea8d3b24
 2014-04-04 19:06:12 +02:00
Zolnai Tamás
8416261a8b Use stored mime type for stream creation 
Change-Id: Iecc50f7964fa63ae028e2fb21d022de1f060c7a7
 2014-04-04 19:06:11 +02:00
Zolnai Tamás
f470f3c72e Introduce a new media shape property to handle mime type 
Default mime-type for all media objects:
"application/vnd.sun.star.media"
The problem of missing mime-type detection
still exists. For now only glTF model has
a concrete type.

Change-Id: I4dca26c1c47a564579bbed926bffa3aa5eda6c04
 2014-04-04 19:06:11 +02:00