Floating tables in table-only headers are imported
as non-floating ones after a SAX parser error. Now
we import them as non-floating ones from the beginning
to avoid of the parser error.
Change-Id: I0a816a7af642f402a25ed53d9766b1e8b82db789
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87874
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
inherits from DragSourceHelper and DropTargetHelper but doesn't do anything
and it doesn't override some default dnd to explicitly disable it.
AFAICS this doesn't do anything
Change-Id: I428385af32e49f26c8c24e40208fe9b1ab373de9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87925
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
The bugdoc has a transparent PDF image, and we currently put a white
background behind that in Impress, given that vcl::RenderPDFBitmaps()
works with Bitmap instances, not BitmapEx ones.
This means that in case we preserve transparency during PDF export, the
content that was rendered OK now becomes unreadable.
Adapt the PDF export to do the same as rendering by putting a white
background behind the PDF image.
Change-Id: I4edcb12fab71bb305d97a50d20fbfbf86d9aab85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87910
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
In general, the term "mobile," when used in APIs related to Online and
the mobile apps, means "mobile phone but not tablet". Which is sad,
but it is too late to change that convention now.
Thus comphelper::LibreOfficeKit::isMobile() returns false on iPad,
apparently intentionally. But surely we want to use the "double tap"
term instead of "click" also on iPad.
Change-Id: I8f7186ea6590f2a21b885549751346edad09eb8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87858
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 4098608ea21d4737fdd640fd57c2417e56426fbb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87931
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Seen this happening in custom sidebars (from extensions).
When the text is too long for the button, it will get cut off
and there is no way to view the button text.
Change-Id: I86ce72154e0371bdf24480be41517855dc3ce050
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87692
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
It's quite a usless macro actually. It is forced that every class
implements this method anyway. This gets rid of usages in the
drawinglayer module first.
Change-Id: Ic2b2e7d5b72a8e0f7ea0748d0ea44cd38cf8c1ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87905
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
...because of ControlLayoutData::m_pParent member and implicitly defined copy/
move functions of VCL_DLLPUBLIC ControlLayoutData
Change-Id: I2328bd5128ac778f54fcaec204c92d28c505f040
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87897
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This patch resolves:
1) content not shown when Navigator is docked from a floating zoomed-in
("List Box" item unchecked) state
2) "List Box" item is visible when the Navigator is in
docked state on document open.
Change-Id: Id1fcaf0b581e26aabd4fd897ff142a60d6761e1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87758
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
...(vcl/win/app/salinst.cxx) in case the
#if HAVE_FEATURE_SKIA
#if SKIA_USE_BITMAP32
...
block it contains is excluded (when building with clang-cl on Windows)
Change-Id: I60910106bbd6a4c2cb3f393945a5417eb02407c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87898
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...as seen at
> In file included from desktop/win32/source/QuickStart/QuickStart.cxx:29:
> In file included from include\systools/win32/uwinapi.h:25:
> include\prewin.h(38,9): error: duplicate defines [loplugin:duplicatedefines]
> #define WIN32_LEAN_AND_MEAN
> ^
> desktop/win32/source/QuickStart/QuickStart.cxx(24,9): note: previous define [loplugin:duplicatedefines]
> #define WIN32_LEAN_AND_MEAN
> ^
(An alternative fix could be to replace all those defines of WIN32_LEAN_AND_MEAN
prior to including windows.h with includes of prewin.h and postwin.h?)
Change-Id: I0271b5629af8f4ecfb3c90f1455bad399174f6ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87880
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The bugdoc had 2 tables: both using the TableGrid table style, but one
had a direct formatting to disable all borders. The second was in the A1
cell of the first, and given that the table style config state was not
separated for nested tables, the border settings of the inner table
affected the settings of the later cells of the outer table.
Change-Id: Ie7897bc661d9f47ca9f5c1b3ed1c439ef0406037
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87899
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
It used to be set both in AppSearch action (using RegLocator table),
and in MigrateInstallPath custom action. This would overwrite value
of INSTALLLOCATION taken from user, and read on the previous step,
with values taken on the next step.
Only migrating the install location in one single place - in custom
action MigrateInstallPath - makes the process controllable. Also it
allows to easily see all the various places in registry we read.
Change-Id: Ib7e04c26e71ba92c6a62a0511971bfb3bdb7db72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87867
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
...found with 2db9a6813a "flush out unused
MapModes" in code that had not used the variable ever since it got introduced
with dd2f230139 "INTEGRATION: CWS graphicapi"
Change-Id: I7412a3badeec546ed1dff8dcf905036f06287e70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87892
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
when its selected right to left with cursor flashing at the start
format->paragraph->area->color->pick, cursor into hex# edit, end to
cursor at the end, shift + home to select all, right to left, ctrl+c,
ctrl+v, assert
Change-Id: I8e29108ddff94487c298bd5e6607b98f5f841afd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87883
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
