Causes subtle and surprising differences, and it was only needed for the
Core Text-based layout engine, which is not the default now. We want to
use floats for our text layout everywhere at some point, though, so lets
keep the code around.
Change-Id: Iac4d0f58992646b9357a9f32c5eea8ff2729a5c0
Honor the padding value even if the border is not visible.
Previously the padding information was just thrown out, and
the image scaled to fill the entire image size.
The unit test for tdf#77454 needed to be tweaked because surprisingly
it has border padding of 1 - which this patch turns into a negative crop.
Change-Id: I866d26e00f27221239d3291404f70fb57ac0896d
Reviewed-on: https://gerrit.libreoffice.org/30578
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Project: help 1678d9035beaf714860804462f03501393291c56
Honor width and height in images for help3
Modern browsers renders width and height expressed in inches and
centimeters, as well as pixels.
Change-Id: I337de791e7e894b0c84f1bd9848e15edc861707f
Reviewed-on: https://gerrit.libreoffice.org/30616
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
If we didn’t find any known good position, not inserting Kashida at all
is better than inserting it randomly.
Change-Id: I075f8414b7f0a0aeb4d27d372c7eae51f4b5c37b
This code seems to follow the algorithm described in:
https://www.microsoft.com/middleeast/msdn/JustifyingText-CSS.aspx
But there seem to be a confusion due to the transliteration used there,
Haa can be the standard Arabic name for U+0647 ARABIC LETTER HEH or
U+062D ARABIC LETTER HAH. The code is using the later, but I’m pretty
sure it is the former given that the other character in this priority is
Teh Marbuta, which is a Heh-like character. Also before final Hah is a
bad place for kashida.
Change-Id: I9ad3fc432ac58f0e45c562a6b44ac5cbe751c3bf
The current logic is swapped. MenuAttributes::aImageId can be
only handled by SvFileInformationManager, while the menu item
command is what might be (in case of .uno command) handled
by CommandInfoProvider.
This gone wrong in tdf#96059 which wrongly assumed that
GetImageFromURL is equivalent to what's provided by
CommandInfoProvider (so other places should be checked too).
Change-Id: Ia487c602753dde3fb0d0462ef4b3d63209398b36
This is set just locally for OGLTrans, because I have no idea what the
other places that use glm expect...
Change-Id: I83675ef2463ab945cb3d6885f803dcbae60a5558
Project: help 8494b1d545c68fd4eeb75d78c692a3ce71ed3caf
tdf#103622 do not use arrow as separator of menu commands
Change-Id: I761c3845939ee95fb151a196587b359c3b6d965d
Reviewed-on: https://gerrit.libreoffice.org/30572
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
It saves lots of extra code: no separately checking if a line exists,
and then getting the width. Closely matches the existing CalcLineSpace.
sc/source/ui/view/printfun.cxx is another place that could use this
heavily to replace their lcl_LineTotal function. Perhaps something
good for an easyHack. (Wait until LO5.4, since much of the logic
should use CalcLineSpace(,true) instead, and that function probably
will have the default bEvenIfNoLine changed to true. Compiler doesn't
like providing "true" when the default value is also "true".)
Change-Id: I298d057b2bf04959434736f6ab2666d2de4222f9
Reviewed-on: https://gerrit.libreoffice.org/30589
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Revert "SvxShadowTabPage::Construct was removed"
f9a2c1c12e.
Revert "replace OColorPopup with SvxColorWindow"
f300754bb1.
Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID"
347c2c3345.
Revert "replace last ColorLB use with a listbox of colors"
604b35bf55.
Revert "simplify, its just a vector of colors"
351a97ce6b.
Revert "replace user draw with an Image of the color"
df738e0f8c.
Revert "strip down to the used pieces"
commit 08d6cd788f.
Revert "move now combined ColorLB to location of last user"
a19b18ad7c.
Revert "fold ColorListBox and ColorLB together"
a989a0b1f2.
Revert "move ColorListBox beside sole thing that uses it"
760a198e69.
Revert "extensions leaks out details of Color Selector, patch it up"
8bea644d61.
Revert "inherit FillAttrLB from ListBox not ColorListBox"
d2ce812f1d.
Revert "unify color selectors"
43bc303148.
regression from commit e598ab0447
very aggressively forced a new frame size via compat setting
CLIPPED_PICTURES on any fly - not just images.
This only affects MS-format documents, EXCEPT that it is a document
property, so if the file every spent any part of it's life in MS-format,
it will always retain that compatibility setting. That explains
why the problem was intermittent for me - and was hard to reproduce
in a clean document, even though I'd seen it in .ODTs.
bIgnoreLine (ignore the fact that there is no visible line)
was a confusing word choice for "if there is no line,
then return a spacing size of zero". bEvenIfNoLine=false is better.
Change-Id: I50a3bdef3a67339ae517ee6319920651bc56f9be
Reviewed-on: https://gerrit.libreoffice.org/30585
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
The OpenGL transitions are optional, so the respective config. file
should only be listed in the ogltrans module.
This reverts commit dafcb2844b.
Change-Id: Ie785db07d04a0baf3dc9fd385f1d8a34837dc38b
Since we enable Graphite by default, this code was effectively setting
nMaxContext to 8 on macOS and 10 everywhere else. Does not look like a
huge difference, and an unnecessary one even since we use the same
layout engine everywhere now.
Change-Id: I6d2cc3a89ed2942c09e62f7637cec5b6db753a24
