Commit Graph

399342 Commits

Author SHA1 Message Date
Tamás Zolnai
18f5d68d68 Fix these comments
Change-Id: Ie5c7876ce258a75f5507a862a320c4197a1e1f79
2016-11-05 11:45:11 +00:00
Tamás Zolnai
5ef66db91e tdf#103664: FILEOPEN: DOCX: Wingdings symbols are imported as rectangles
Change-Id: Ifd9ff26f2460e5570ec1b736308d48acdb3e56a8
Reviewed-on: https://gerrit.libreoffice.org/30575
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-11-05 10:37:35 +00:00
Jean-Pierre Ledure
385fa53636 Access2Base - Spanish translation
Provided by Iñigo Zuluaga

Change-Id: I6ba436e29f7aff35e30a8e614e0c3c3d2c3ac1b4
2016-11-05 11:27:46 +01:00
Julien Nabet
6fe0706f67 [loplugin:simplifybool]
Change-Id: I20177b47fd756558430420710c0f497be49c8948
Reviewed-on: https://gerrit.libreoffice.org/30584
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-05 07:08:03 +00:00
Justin Luth
67e385ac8d tdf#41542 MSWordExport: accommodate page's borderless padding
Honor the padding value even if the border is not visible. This is
needed both for ODT->DOC(X) (starting in LO5.4), authoring documents
DOC(X) files from within LO (starting in LO5.3), or round-tripping
current documents created in some other WordProcessor that produces
valid ODT documents with borderless padding.

Change-Id: I2d653f2c8d3ad22f86384ad17d3a0b8c89738f60
Reviewed-on: https://gerrit.libreoffice.org/30512
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
2016-11-05 04:23:29 +00:00
Justin Luth
570e8488b5 ooxmlexport*: cleanup - remove unnecessary "crop" lines
Change-Id: I2bf5b6c0d68ea8fbe57d9d1240564631e4a2da12
Reviewed-on: https://gerrit.libreoffice.org/30577
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
2016-11-05 04:17:11 +00:00
Khaled Hosny
d9ea614a1e Validate Kashida positions with font fallback
MultiSalLayout did not implement IsKashidaPosValid() which meant that
whenever there is a font fallback no Kashida validation was performed.

Change-Id: I30e498c356c49b0c06dd6b45187105f6bd758a24
2016-11-05 05:23:32 +02:00
Takeshi Abe
6984fd5a75 tdf#102008 Drop whitespace between "fact" and brace
for consistency with "abs{<?>}", "sqrt{<?>}", etc.

Change-Id: I53106d6daf99f72f1a064bc6f5e0fe4dab55cc02
Reviewed-on: https://gerrit.libreoffice.org/30556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-05 02:00:09 +00:00
Takeshi Abe
239b662753 tdf#102007 Surround widebslash's placeholders with braces
like wideslash's.

Change-Id: Icddd563ee64510c0df8bfa8d4a5274a00f60162a
Reviewed-on: https://gerrit.libreoffice.org/30555
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-05 01:59:40 +00:00
Jan Holesovsky
32bdc50970 We have exactly the same file as include/unotools/ZipPackageHelper.hxx.
Change-Id: I2cc545c50a8ae936e73ff23a200f350809ab8335
2016-11-05 00:11:57 +01:00
Szymon Kłos
19fa8aae97 tdf#93520 : Mirrored page margin tooltip
Change-Id: I5cf0c7eeba204d4493ae1f4229718faf870a5528
Reviewed-on: https://gerrit.libreoffice.org/30570
Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
Tested-by: Szymon Kłos <eszkadev@gmail.com>
2016-11-04 22:35:12 +00:00
Khaled Hosny
5b389c32eb tdf#100936: Add Tangut to vertical scripts
Change-Id: I0ac8be9f129636fae2be03f60a4e9b8a65a195e9
2016-11-04 23:46:22 +02:00
Khaled Hosny
4e59168ef0 tdf#103710: rotate all glyphs in vertical runs
So that we base the rotation or not based on the resolved script,
instead of using the outdated and hard-coded ranges in GetVerticalFlags.

Change-Id: I52ee38c4151f30d98287e64f852b4d2df143c719
2016-11-04 23:39:38 +02:00
Caolán McNamara
f9a2c1c12e SvxShadowTabPage::Construct was removed
Change-Id: Iaaa303dac79556d43cda78363abbcdd03e977e8a
2016-11-04 17:24:36 +00:00
Caolán McNamara
f300754bb1 replace OColorPopup with SvxColorWindow
Change-Id: I1aa06f70016b935bb13a0f6e93234eea10ba8b84
2016-11-04 17:14:32 +00:00
Caolán McNamara
347c2c3345 drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID
it doesn't appear to exist/be implemented and makes
the reportdesigner font dialog from conditional
formatting crash

Change-Id: Iad929fec8aedfa31f6e8f9dfaa0055d61a9ff6f3
2016-11-04 17:14:30 +00:00
Caolán McNamara
604b35bf55 replace last ColorLB use with a listbox of colors
Change-Id: Ia0058939faa63507b50c5ca70527850e59c0ba5d
2016-11-04 17:14:29 +00:00
Caolán McNamara
351a97ce6b simplify, its just a vector of colors
Change-Id: I7d388739225d371090872a33d30aa3178b20ca6e
2016-11-04 17:14:29 +00:00
Caolán McNamara
df738e0f8c replace user draw with an Image of the color
Change-Id: I0d301ba4082a45e7030c6956c18aa76e52bce216
2016-11-04 17:14:27 +00:00
Caolán McNamara
08d6cd788f strip down to the used pieces
Change-Id: I1d9eed2345f3d8a78f467d0fb5f7b7cd0211a160
2016-11-04 17:14:27 +00:00
Caolán McNamara
a19b18ad7c move now combined ColorLB to location of last user
Change-Id: I5dc1204c28b65d5dca993bf38aea217bbb49e913
2016-11-04 17:14:27 +00:00
Caolán McNamara
a989a0b1f2 fold ColorListBox and ColorLB together
Change-Id: I485109acd7cd4d6c2dc53e29f4b01bfc202a38f3
2016-11-04 17:14:26 +00:00
Caolán McNamara
760a198e69 move ColorListBox beside sole thing that uses it
Change-Id: Ia458ded8881c415badd5d75bddad0daca57a1a25
2016-11-04 17:14:26 +00:00
Caolán McNamara
8bea644d61 extensions leaks out details of Color Selector, patch it up
and rebase it on SvxColorListBox

Change-Id: I3afef689ab0dc3c34e465810d82bf21797907558
2016-11-04 17:14:26 +00:00
Caolán McNamara
d2ce812f1d inherit FillAttrLB from ListBox not ColorListBox
Change-Id: Icd6f51b61ec0d006c10c6a75da649cc83057b9f1
2016-11-04 17:14:26 +00:00
Caolán McNamara
43bc303148 unify color selectors
Note: this removes the use of auto-color from writer's asian text grid, because
its always invisible as far as I can see in practice.

Change-Id: Ie850790d740a4d56c43015e493e093678cef3b4e
2016-11-04 17:14:26 +00:00
Eike Rathke
44523738f0 bail out early in ScColumn::UpdateSelectionFunction() if nothing is marked
... which happens if there are multi-marks in non-adjacent columns.

Change-Id: Ic8cf0fb0071f793fa91c506a56b01f2833fe5cec
2016-11-04 17:45:25 +01:00
Caolán McNamara
54dc3dd96b use default copy and assignment operators
Change-Id: Ic784b3951fcf2f614b62d93d925eec134feb7364
Reviewed-on: https://gerrit.libreoffice.org/30567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-04 16:01:15 +00:00
Tomaž Vajngerl
dec5931ede opengl: move shaders to its own directory
Change-Id: I9ca5a97ae3ed2472257f468f6751903b458529a7
Reviewed-on: https://gerrit.libreoffice.org/30502
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-11-04 15:54:18 +00:00
Tomaž Vajngerl
6b571ae460 opengl: change from BGRA to RGBA color arrangement on Windows
BGRA is native color arrangement on Windows however some intel
drivers have problems with large textures if they read from a
BGRA buffer. So with this commit we switch to RGBA color
arrangement. This shouldn't cause much performance differences,
but we need to convert from RGBA to BGRA when printing.

Change-Id: Ic112dc6a6c5d8b70e96041d0de15a03bbbdc406f
Reviewed-on: https://gerrit.libreoffice.org/30544
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-11-04 15:53:48 +00:00
David Tardon
c52d1403c3 add test case for rhbz#1390776
Disabled, because the file fails to load for some reason...

Change-Id: Ida79b9de4ff53d76fed86e0495f9479addc228f8
2016-11-04 16:24:55 +01:00
David Tardon
6287b17ce7 fix build of postgresql with bundled zlib
Change-Id: I8a1a8b8e1437d79d4c262cb8521a1239c250699e
2016-11-04 16:22:23 +01:00
David Tardon
b5c566fd10 fix external def for graphite
Change-Id: I474a7852647fc17597ec3d5a44e1e8dfdc78c0c3
2016-11-04 16:22:23 +01:00
David Tardon
b2c16b3563 fix build of bundled python3 with bundled zlib
Change-Id: I383a04ea926187263b1d7e11c548817fa9ca3fb6
2016-11-04 16:22:23 +01:00
David Tardon
c9fdaa1d21 fix external deps for cairo
Change-Id: Iba03576ee9a114ea8dc20d8ff70a953e11c6d3e7
2016-11-04 16:22:23 +01:00
Eike Rathke
029bd007b9 unit test for tdf#103684, calculate status bar function across sheets
Change-Id: I8205cf56628b6b4d4b5d655386df994a9c02a1ad
2016-11-04 15:43:06 +01:00
Eike Rathke
334a03d801 use ScMarkData::GetMarkedRangesForTab(nTab) in SingleColumnSpanSet::scan()
That always worked only by chance only on the first selected sheet, luckily
with ScMarkData it seems to be used only in ScColumn::GetOptimalColWidth()
which usually operates on the visible sheet.

So now setting optimal column width actually works on all selected sheets for
the selected columns.

Change-Id: I5944b943824a67d77b549b6cdfc0b2550b8d77b8
2016-11-04 14:55:01 +01:00
Katarina Behrens
d082936c7a Allow including/packaging help-specific images
from other than icon-themes folder

Change-Id: Iba1808e642fde8d0370b59550c7bdac1a3e4ac79
Reviewed-on: https://gerrit.libreoffice.org/28513
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-11-04 13:42:09 +00:00
Katarina Behrens
cae6864374 Updated core
Project: help  98d298e4ef2bc9ad9f4e2d2bb83c3183e3ee0977

Create a new image list for 'make postprocess'

with screenshot images

corrected path as indicated

Change-Id: I3d81c88a4ae002f12247ec4a5587e50f9927a005
Reviewed-on: https://gerrit.libreoffice.org/28499
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-11-04 13:41:33 +00:00
Michael Meeks
5946cc2f70 tdf#91260 - ReplaceAll should use a columnar direction.
MDDS is columnular, so this shrinks the working set very
significantly, and should improve performance.

Change-Id: I2aff92b31bfc459e85291059d977541aa65155cf
Reviewed-on: https://gerrit.libreoffice.org/30562
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-04 13:26:53 +00:00
Eike Rathke
2ba62a7815 sc-perf: eliminate unnecessary loops in ScTable::UpdateSelectionFunction()
That looped unconditionally over all columns of a sheet just to let
ScColumn::UpdateSelectionFunction() costly (by creating empty spans) decide
that it doesn't have to do anything. This for *every* cell cursor movement or
switching sheets et al. Instead, use the ScMarkData area to narrow down the
range beforehand, which when travelling with the cell cursor is just one
column.

Change-Id: Ic60928d07bc6cec4f6d8491ab30b99d7b20b8490
2016-11-04 14:20:54 +01:00
Noel Grandin
c1805c48ae loplugin:oncevar in dbaccess
Change-Id: I956063bb354fbbd002e922bb06d0b3863a2750fc
Reviewed-on: https://gerrit.libreoffice.org/30565
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04 13:15:41 +00:00
Noel Grandin
2dfc4c0845 loplugin:oncevar in desktop..filter
Change-Id: I21c47cacbcd68f06eea7ccbbfa6d04fc65e2b7ee
Reviewed-on: https://gerrit.libreoffice.org/30564
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04 13:15:29 +00:00
Caolán McNamara
859204a523 customize dialog crashes, since...
commit 164d8e3b1a
Date:   Thu Nov 3 02:35:00 2016 +0200

    tdf#91222 VclBuilder constructor cleanup

so revert problematic bit of that.

The impl is called SfxAccCfgTabListBox_Impl, but the
widget name is SfxAccCfgTabListBox

Change-Id: I8e800b376afa48090fde1074350c1c8ce39a27bf
2016-11-04 11:42:22 +00:00
Miklos Vajna
d0edff60c7 xmlsecurity PDF NSS verify: handle SHA1_WITH_RSA
SHA1_WITH_RSA is a signing algorithm, not a digest one, but let's
accept it, so LO on Linux can verify a signature generated by LO on
Windows.

It's annoying that equivalent mapping in NSS is not part of their public
API.

Change-Id: I97186fcc1d118f922e5ee3cb472aa5b52bc4b5ca
2016-11-04 12:32:40 +01:00
Eike Rathke
8e38964c32 move loplugin:defaultparams to store/
As per IRC 2016-11-04 12:21

Change-Id: Ic4cc7f67fb31be80a966c652cb30bb859f874a8b
2016-11-04 12:28:57 +01:00
Samuel Mehrbrodt
6375c36702 Fix dialog name and title
Change-Id: I55d628d6e61d4035155d42fa45270418a3e10387
Reviewed-on: https://gerrit.libreoffice.org/30563
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-04 10:12:51 +00:00
Stephan Bergmann
99f7aacd5b external/harfbuzz: -fsanitize=function
Change-Id: Ie72eec98f1337e895b81c4ebebeefa4861a5a6a1
2016-11-04 10:25:14 +01:00
Stephan Bergmann
6694ce6b54 external/harfbuzz: Work around ASan out of bounds warning
CppunitTest_sccomp_lpsolver failed with the below error.  struct _mtx
(hb-ot-hmtx-table.hh) has two "variable-sized" array members (each of size
VAR=1) longMetric and leadingBearingX, where the latter isn't used anywhere in
the code; so removing it would make ASan's variable-sized array member heuristic
kick in here and suppress the warning, but who knows whether there's some
requirement on the exact sizeof(_mtx).

> hb-ot-font.cc:128:12: runtime error: index 3 out of bounds for type 'OT::LongMetric const[1]'
>  hb_ot_face_metrics_accelerator_t::get_advance(unsigned int) const workdir/UnpackedTarball/harfbuzz/src/hb-ot-font.cc:128:43
>  hb_ot_get_glyph_h_advance(hb_font_t*, void*, unsigned int, void*) workdir/UnpackedTarball/harfbuzz/src/hb-ot-font.cc:439:47
>  hb_font_t::get_glyph_h_advance(unsigned int) workdir/UnpackedTarball/harfbuzz/src/./hb-font-private.hh:207:12
>  hb_ot_position_default(hb_ot_shape_context_t*) workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:613:35
>  hb_ot_position(hb_ot_shape_context_t*) workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:719:3
>  hb_ot_shape_internal(hb_ot_shape_context_t*) workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:768:3
>  _hb_ot_shape workdir/UnpackedTarball/harfbuzz/src/hb-ot-shape.cc:792:3
>  hb_shape_plan_execute workdir/UnpackedTarball/harfbuzz/src/./hb-shaper-list.hh:43:1
>  CommonSalLayout::LayoutText(ImplLayoutArgs&) vcl/source/gdi/CommonSalLayout.cxx:485:23
>  OutputDevice::ImplLayout(rtl::OUString const&, int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache const*) const vcl/source/outdev/text.cxx:1400:36
>  OutputDevice::GetTextArray(rtl::OUString const&, long*, int, int, vcl::TextLayoutCache const*) const vcl/source/outdev/text.cxx:999:35
>  OutputDevice::GetTextWidth(rtl::OUString const&, int, int, vcl::TextLayoutCache const*) const vcl/source/outdev/text.cxx:915:19
>  ImplFontMetricData::ImplInitTextLineSize(OutputDevice const*) vcl/source/font/fontmetric.cxx:372:30
>  OutputDevice::ImplNewFont() const vcl/source/outdev/font.cxx:1100:42
>  OutputDevice::GetTextHeight() const vcl/source/outdev/text.cxx:924:14
>  vcl::Window::ImplInitAppFontData(vcl::Window*) vcl/source/window/window.cxx:1177:33
>  vcl::Window::ImplInit(vcl::Window*, long, SystemParentData*) vcl/source/window/window.cxx:1168:9
>  ImplBorderWindow::ImplInit(vcl::Window*, long, BorderWindowStyle, SystemParentData*) vcl/source/window/brdwin.cxx:1758:13
>  ImplBorderWindow::ImplBorderWindow(vcl::Window*, SystemParentData*, long, BorderWindowStyle) vcl/source/window/brdwin.cxx:1790:5
>  VclPtrInstance<ImplBorderWindow>::VclPtrInstance<vcl::Window*&, SystemParentData*&, long&, BorderWindowStyle&>(vcl::Window*&, SystemParentData*&, long&, BorderWindowStyle&) include/vcl/vclptr.hxx:281:39
>  WorkWindow::ImplInit(vcl::Window*, long, SystemParentData*) vcl/source/window/wrkwin.cxx:52:38
>  WorkWindow::WorkWindow(vcl::Window*, long) vcl/source/window/wrkwin.cxx:95:5
>  VclPtr<WorkWindow> VclPtr<WorkWindow>::Create<vcl::Window*&, long&>(vcl::Window*&, long&) include/vcl/vclptr.hxx:131:46
>  (anonymous namespace)::VCLXToolkit::ImplCreateWindow(VCLXWindow**, com::sun::awt::WindowDescriptor const&, vcl::Window*, long) toolkit/source/awt/vclxtoolkit.cxx:1195:42
>  (anonymous namespace)::VCLXToolkit::ImplCreateWindow(com::sun::awt::WindowDescriptor const&, long) toolkit/source/awt/vclxtoolkit.cxx:1306:22
>  (anonymous namespace)::VCLXToolkit::createWindow(com::sun::awt::WindowDescriptor const&) toolkit/source/awt/vclxtoolkit.cxx:799:12
>  non-virtual thunk to (anonymous namespace)::VCLXToolkit::createWindow(com::sun::awt::WindowDescriptor const&) toolkit/source/awt/vclxtoolkit.cxx:797:59
>  (anonymous namespace)::TaskCreatorService::implts_createContainerWindow(com::sun::uno::Reference<com::sun::awt::XWindow> const&, com::sun::awt::Rectangle const&, bool) framework/source/services/taskcreatorsrv.cxx:268:73
>  (anonymous namespace)::TaskCreatorService::createInstanceWithArguments(com::sun::uno::Sequence<com::sun::uno::Any> const&) framework/source/services/taskcreatorsrv.cxx:165:28
>  non-virtual thunk to (anonymous namespace)::TaskCreatorService::createInstanceWithArguments(com::sun::uno::Sequence<com::sun::uno::Any> const&) framework/source/services/taskcreatorsrv.cxx:133:74
>  framework::TaskCreator::createTask(rtl::OUString const&) framework/source/classes/taskcreator.cxx:112:63
>  framework::Desktop::findFrame(rtl::OUString const&, int) framework/source/services/desktop.cxx:951:28
>  non-virtual thunk to framework::Desktop::findFrame(rtl::OUString const&, int) framework/source/services/desktop.cxx:920:61
>  framework::LoadEnv::impl_loadContent() framework/source/loadenv/loadenv.cxx:1017:50
>  framework::LoadEnv::startLoading() framework/source/loadenv/loadenv.cxx:379:20
>  framework::LoadEnv::loadComponentFromURL(com::sun::uno::Reference<com::sun::frame::XComponentLoader> const&, com::sun::uno::Reference<com::sun::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&) framework/source/loadenv/loadenv.cxx:165:14
>  framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&) framework/source/services/desktop.cxx:597:12
>  non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&) framework/source/services/desktop.cxx:583:64
>  (anonymous namespace)::LpSolverTest::setUp() sccomp/qa/unit/lpsolver.cxx:45:67
...

Change-Id: If46d9b82225a70caa9ad2f17fbeb99c6adc63990
2016-11-04 10:25:14 +01:00
Justin Luth
9130627e21 tdf#41542 globally allow padding without borders: layout
Styles with borders do not have a requirement for visible borders
in order to apply padding in the ODF specs. This was only an
implementation design, so remove that layout restriction.
So, padding will be allowed now for any border (not just textframes/cells)
and it will be allowed for any format (not only those marked
with the compatibility setting AllowPaddingWithoutBorders - which
is now redefined to indicate whether the UI allows
creating borderless padding).

The global UI implementation to allow creating these types of documents
will come in 5.4.  Allow the layout already in 5.3 to enhance
compatibility between supported versions.

Change-Id: I75bab7cbfff23bf70406123f8531e2fea352ddda
Reviewed-on: https://gerrit.libreoffice.org/30434
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-04 09:20:47 +00:00