Commit Graph

413327 Commits

Author SHA1 Message Date
Noel Grandin
26c82bd286 loplugin:unusedfields improve finding callee
which makes absolutely no difference to the results, but anyhow, would
be a shame to waste the work

Change-Id: I4576528f30986a5ce522c76fdf21873f0ce23f0a
2017-09-29 09:10:36 +02:00
Noel Grandin
2149bbfd27 rename SvxTabStop::IsEqual to operator==
Change-Id: I98f8db6e80d6a5dc30826ec755deb9432f809e92
Reviewed-on: https://gerrit.libreoffice.org/42907
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-29 08:53:20 +02:00
Noel Grandin
8a8864aeb7 convert IsEqual/etc methods on ESelection to operators
Change-Id: Ia8424e701b6f22d0536ee7f3bdb0ecaaed94a3b9
Reviewed-on: https://gerrit.libreoffice.org/42904
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-29 08:53:03 +02:00
Noel Grandin
ce301dadcb convert GfxLink::IsEqual to operator==
exactly one use site

Change-Id: Id0a75d46c459be213e81b47aa6c1194c87aec848
Reviewed-on: https://gerrit.libreoffice.org/42891
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-29 08:52:34 +02:00
Noel Grandin
1ffba0e356 loplugin:flatten check for throw in then clause
also make the plugin ignore the case where we have var decl's in the
clause we want to flatten, which could lead to problematic extension of
variable lifetime

Change-Id: I3061f7104e8c6a460bf74f5eac325a516ec50c59
Reviewed-on: https://gerrit.libreoffice.org/42889
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-29 08:51:48 +02:00
Stephan Bergmann
ce9a41dc38 Adapt loplugin:reservedid to Windows
Change-Id: I41ccccd7ad77bc4ecf2ff7fcd9496af656ad952e
2017-09-29 08:32:36 +02:00
Serge Krot
25cd067a82 writerfilter: convert loops to range-based-for
Change-Id: I424fd1bf8eef7112a8cff54ab46a07bb41596ca5
Reviewed-on: https://gerrit.libreoffice.org/42901
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-28 23:14:35 +02:00
Andrea Gelmini
5501c18e6b Fix typo
Change-Id: I81e3c3dcc850e0dc0774228e609da3f94f14f422
Reviewed-on: https://gerrit.libreoffice.org/42917
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-28 22:37:40 +02:00
Patrick Jaap
3b1db9b7a9 tdf#112012 EMF+ dashed lines: correct dash length
Since the first guess of the right transformation seemed to be wrong,
here is the next try. The pure float value is multiplied with the pen width.
This is way more intuitive for me and renders the EMF files from the
bugtracker exactly like in MSO.

See 588c5b0cff for the previous patch.

Change-Id: I74e82a0f9800d950e0d989184765a53e520b48e6
Reviewed-on: https://gerrit.libreoffice.org/42810
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-28 22:36:18 +02:00
Caolán McNamara
69c8865488 Resolves: tdf#42873 videos in presenter console misplaced
Change-Id: Ib7559246f6f3173acea72268db0489b79df38ae3
Reviewed-on: https://gerrit.libreoffice.org/42892
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-28 21:21:10 +02:00
Caolán McNamara
6ddd8fcf5c Resolves: tdf#112680 start color picker with currently selected color
Change-Id: I939a0b88646b4654337505e985cceff883f09343
Reviewed-on: https://gerrit.libreoffice.org/42899
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-28 21:20:30 +02:00
Stephan Bergmann
9e0be8a76e Remove dead code behind Calc "Live Data Streams" dialog's "scriptdata" button
...that has been disabled and hidden ever since
4c90ed782a "Actually hide these two radio buttons
(since there is no choice now)."

This removes the sole user of SvScriptStream.  (Unfortunately, removing the no
longer needed

  #include <osl/process.h>

from include/tools/stream.hxx triggered an avalanche of missing includes
elsewhere.)

Change-Id: I7b0e683b14c0eaf7f4737f62adc9d691826380c0
Reviewed-on: https://gerrit.libreoffice.org/42916
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-09-28 19:13:29 +02:00
Jan-Marek Glogowski
49564323e2 Fix SalUserEventList usage on Android
Change-Id: I598446c6f14e9df798bf37cb64c8b7bcbb04dd91
2017-09-28 19:01:19 +02:00
Markus Mohrhard
1047b426ed updater: make sure the target dir exists while writing update info
Change-Id: I6cafdb28468d0023a0a1ea8cc2c051e9b84a1c6c
2017-09-28 18:40:01 +02:00
Stephan Bergmann
812ee8c53f Look through derived-to-base ImpliciCast
...as happens on Windows when looking at

  maControlToPropertyMap.clear();

in PrintDialog::dispose (vcl/source/window/printdlg.cxx), where std::map's clear
happens to be declared at some base class std::_Tree.

Change-Id: I41810514bca59af8b4f2812d9412ce6a8d43576c
2017-09-28 18:31:53 +02:00
Stephan Bergmann
8457b50ffd loplugin:simplifybool (clang-cl)
Change-Id: I230c37482cfce85534f860ecf3426254be8981ab
2017-09-28 18:10:26 +02:00
Stephan Bergmann
f702d752a7 Missing includes (--disable-pch)
Change-Id: Iaa87663255f815e4f837df25d5338439d79c70dd
2017-09-28 18:09:45 +02:00
Jan-Marek Glogowski
e310c00709 Unify SalUserEvent handling
Merges the various SalUserEvent structs and their handling into
a single class. This includes a common SalFrame* hash map, as all
backends use such a map to verify alive SalFrames.

It also reverts the "FIXME: lousy workaround" for i#90083, which
was part of commit d6f7c94e5c.

At least on my current OSX box application based window switching
"just works" "out of the box", even without the code.

Change-Id: I188b567e44fd79c162b2d9cabbd771d1f66c7dc4
Reviewed-on: https://gerrit.libreoffice.org/42845
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-28 17:48:37 +02:00
jan Iversen
dea1b64976 iOS, WIP build static library loKit
WIP on the road to prelink all LO libraries into a single
static library for each arm64, arm64-debug, simulator

Change-Id: I5e7aaefa46c9d234252ba3b6848f173647215795
2017-09-28 17:22:32 +02:00
Samuel Mehrbrodt
7757a30a6b Python 2.6 compatibility for pack_images.py
Change-Id: I61b315bc644763749acf82d2dd7e4a3140d8f8b1
Reviewed-on: https://gerrit.libreoffice.org/42911
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-28 17:00:10 +02:00
Jan-Marek Glogowski
4a15820fec tdf#112288 set timestamp for otherEventWithType
In otherEventWithType we have to set the timestamp manually to the
current uptime, and can't default to 0.

Change-Id: I3e96dff38ea81b0e6744fa175fc3a169e160b982
2017-09-28 15:34:18 +02:00
Markus Mohrhard
d239ac8e4b fix the command line argument limit problem for incremental build generation
Change-Id: I934c8196e260573cd0bc4f74066ea6082ab3c6c3
2017-09-28 15:06:00 +02:00
Stephan Bergmann
8706178823 Warn about missing text converter
(probably because the encoding is RTL_TEXTENCODING_DONTKNOW; that may
still happen in various places, so can't use anything stronger than
SAL_WARN here)

Change-Id: I75993c9ad629104055c171389ed7708649747d9b
2017-09-28 14:41:23 +02:00
Miklos Vajna
4b88f3545c RTF export: various minor cleanups
Change-Id: I6bdbe246bf65dcfa193289210f7c464769d5e2ad
Reviewed-on: https://gerrit.libreoffice.org/42887
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-09-28 14:08:13 +02:00
jan Iversen
a7e4417c63 iOS, xcodebuild corrections.
Changed target of builds.

Change-Id: Ieb1da70f0ec2e636e571c3ad69243b26bb726487
2017-09-28 13:50:39 +02:00
Tor Lillqvist
d2cf510af2 The OpenCL XIRR test fails randomly on some machines so bin it
We don't even use OpenCL for XIRR normally anyway.

Change-Id: I4bd76e9c5a0ad2222bef47d801f956fda1da568c
2017-09-28 14:19:15 +03:00
Julien Nabet
19910c4612 tdf#112658: fix leak when calling TextEngine::SetAttrib
TextCharAttribList::RemoveAttrib lets a dangling pointer
when release unique_ptr obj maAttribs[n]
So retrieve a unique_ptr from the different layers until
SentenceEditWindow_Impl::ChangeMarkedWord (SpellDialog.cxx).

Change-Id: I734909dce86ec28d69c09b2a8c0fc4a6941f422a
Reviewed-on: https://gerrit.libreoffice.org/42881
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-28 13:10:58 +02:00
Julien Nabet
4fca2ef76a Use sal_Int32 to stick with other SetAttrib methods
+ use size_t GetUndoActionCount like other existing ones

Change-Id: Ibfae20e7fd75df980f395e055063f0bdba1047f7
Reviewed-on: https://gerrit.libreoffice.org/42873
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-28 13:06:57 +02:00
Caolán McNamara
6266e83d30 Related: tdf#109385 make automatically after: <spinbutton> width narrower
Change-Id: I51d4c0606a5c6317c3f87fd71c61a0dbcdbc3b09
Reviewed-on: https://gerrit.libreoffice.org/42903
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-28 13:05:11 +02:00
Caolán McNamara
e302ade40e Related: tdf#109385 make default panel width wider
Change-Id: Ia1c5fc96ccb8b91a3091ef925526a277f25662c6
Reviewed-on: https://gerrit.libreoffice.org/42900
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-28 13:03:59 +02:00
Eike Rathke
0f6b9eca20 i18n-perf: cache map of breakiterators, tdf#108703
See source code comment.

Change-Id: I75015f3492a24f5f69a163dca165dcf57d6f0e28
Reviewed-on: https://gerrit.libreoffice.org/42866
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-09-28 12:53:16 +02:00
jan Iversen
e67f6acc30 iOS, WIP setup to build static lib and app.
Cleaned up custom targets.

Change-Id: I11ef1cb6d129722ac206b298c6ad15c00da5c433
2017-09-28 12:50:10 +02:00
Stephan Bergmann
dbb5a5a2f4 Replace fancy Unicode in exception message
...with something more prosaic and ASCII

Change-Id: I4a927cec15abb7c00f39a6a298a13f192f34c631
2017-09-28 11:29:09 +02:00
jan Iversen
4b2d0e511d iOS, cleaned add resources
Simpler setup makefile, that will generate the 2 xcconfig files
as well as create the resources directory.

The generated directory is on purpose created in the core/ios, because
the output of the different builds are needed for the app build.

Change-Id: I402604ebf947f962552b069bf24ff3794b2ade9d
2017-09-28 11:04:42 +02:00
Andrea Gelmini
b195f901ec Fix typos
Change-Id: I22b1c5575dcd38b9cfac2068ba3960026e44ad1e
Reviewed-on: https://gerrit.libreoffice.org/42888
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-28 10:51:32 +02:00
Gabor Kelemen
0b20137bad tdf#112555 Mark default area pattern names for translation
These need to be kept in sync with the contents of
extras/source/palettes/standard.sop:Contents.xml

Change-Id: I424919cacafd19dc456b4975b13f1c7333d14fa4
Reviewed-on: https://gerrit.libreoffice.org/42671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-28 09:25:32 +02:00
Jens Carl
6a313ab973 tdf#106894: Rewrite packimages.pl in Python (pack_images.py)
Change-Id: I2e9054775941b38392ba3ee38575891b5339249e
Reviewed-on: https://gerrit.libreoffice.org/42790
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-28 09:14:23 +02:00
Mike Kaganski
e80aef4e03 shell: use Unicode on Windows
Change-Id: I9f7962db320f8832879ba327108425a7592b4b77
Reviewed-on: https://gerrit.libreoffice.org/42885
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-28 08:55:04 +02:00
Noel Grandin
09917566b6 simplify Bitmap operator==/IsEqual (stage2)
Now that we've sorted out which bits are rightfully internal (see commit
7a4064cf87d23bffac987b3e39bf87d9b4d158fc), and which bits need a
comparison operator, rename IsEqual to operator==.

Change-Id: Iec229a7571d76ee18fbc0a4fe672cc2e50a44948
Reviewed-on: https://gerrit.libreoffice.org/42851
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-28 08:53:56 +02:00
Stephan Bergmann
851c9f8f4b Blind fix for Clang 3.8 "must explicitly initialize the const member" error
...as seen at <https://ci.libreoffice.org/job/lo_ubsan/681/console>

Change-Id: I428b6e2fe55023fde5b77f7ff0bd1dba16bae2ed
2017-09-28 08:46:08 +02:00
Stephan Bergmann
c9f3277ea7 loplugin:stringconstant: Simplify construction of non-ASCII OUString
Change-Id: If80c53978106789824e6154db396baeecc1969dd
Reviewed-on: https://gerrit.libreoffice.org/42876
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-28 08:27:11 +02:00
Mike Kaganski
0fa2133642 setup_native: use more Unicode in MSI custom actions
Change-Id: Id47ea566c9cf508116216625fe00013e8326b165
Reviewed-on: https://gerrit.libreoffice.org/42839
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-28 05:32:50 +02:00
Tor Lillqvist
8d2a287da3 Avoid warning: 'inflateValidate' is only available on macOS 10.13 or newer
Change-Id: I0f828239ed5aff164ba1f4e486017db0e6c93a4a
2017-09-27 23:44:02 +03:00
Caolán McNamara
bf565ecf45 ofz#3504 Null-dereference READ
Change-Id: I2e2ad8e9fbbcdb8bc3d60da8b5ddde71b935805e
Reviewed-on: https://gerrit.libreoffice.org/42875
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-27 22:22:02 +02:00
Caolán McNamara
5a0f4d00d2 ofz#3499 oom in tiff reader
Change-Id: I2b9e98ed3a6749e2ee83a566ec857c1080e452f3
Reviewed-on: https://gerrit.libreoffice.org/42861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-27 21:28:58 +02:00
Tor Lillqvist
05b3614cac If we are going to avoid repeated calls to pDocument->GetRecursionHelper(),
do it from the start of the function then.

Change-Id: I4699fbd9c70f6ec0110d202062631e8861095aa0
2017-09-27 21:14:12 +03:00
Eike Rathke
86910087fa Resolves: tdf#112523 do not use anything Ascii in UI context
Change-Id: I0854f7b1e6e0bf51d8b4c7d846fad9b0ff25e763
2017-09-27 18:59:02 +02:00
Caolán McNamara
0d45001d01 dynamic_cast followed by static_cast
Change-Id: I9c208cfedd87f04489c6bab4399c438e6aee1cbe
Reviewed-on: https://gerrit.libreoffice.org/42862
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-27 18:07:33 +02:00
Stephan Bergmann
7e76b98330 Silence --disable-assert-always-abort warnings
Change-Id: I34fbba0253d307021a5b090143eb357809c144ec
2017-09-27 17:18:16 +02:00
Stephan Bergmann
14e2a82002 loplugin:constparams
Change-Id: I14673c52584214bef157f2db2e1fdd57c4667d4a
2017-09-27 17:13:10 +02:00