* support of string arrays in the VBA AutoFilter
* tests:
- reading string arrays
- skip Criteria2 when Criteria1 is an array
- use only last element of Criteria2 array
Change-Id: I8faf6af8c4fbf9b654885b31210ef77bae3a39af
Reviewed-on: https://gerrit.libreoffice.org/37515
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
and
coverity#1406100 Dereference null return value
coverity#1406099 Dereference null return value
coverity#1406098 Dereference null return value
coverity#1406097 Dereference null return value
Change-Id: I26d5c0f2e69dc049a87a607ca28586dc575a8ca3
Also
- rename SetOfByte to SdrLayerIDSet
- add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't
allocate overlapping SdrLayerID values
- add a new constant SDRLAYERPOS_NOTFOUND to be returned from
SdrLayerAdmin::GetLayerPos
Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8
Reviewed-on: https://gerrit.libreoffice.org/37467
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
- Solves issue described in the bug where the legend calculation
was not correct if using custom legend placing and the buttons
were added to the legend (like in a pivot chart).
- Place the legend buttons horizontally if the legend is placed
at the top or bottom (wide legend expansion), so the space is
used more efficiently.
- Fix automatic placing of the legend when we have buttons at the
bottom of the chart so that we don't cover them with the legend.
- It can happen that the button click is triggered when we resize
the legend, so make sure we trigger only when mouse-down and
mouse-up are on button.
Change-Id: I6a60e7885f7a2ddd6424b1cdfc22e8b046c89dd4
Reviewed-on: https://gerrit.libreoffice.org/37518
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
See commit 8fe8bd6c3b (Related: fdo#61594
SwWW8ImplReader::StartApo: don't always start a frame, 2013-05-13) for
the context, this is one more case where having a multi-page floattable
as a multi-page one is a better option.
The additional condition is that in case there is a break right after
the table, then always import the table as a non-floating one, as there
won't be any wrapping anyway (due to the break).
Change-Id: I3dd4174226cfc1e825c00607221feeed51b7133f
Reviewed-on: https://gerrit.libreoffice.org/37513
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
have another guess as fixing
emit.cpp:1472: assertion failure: emit-ast.cpp:1123: assertion failed: Ran out of fields in aggregate initializer
Change-Id: I814c12c350cd1dbd58c25ada3a376477b5809c06
Problem:
Start/open a document in CS Writer, and enable track changes.
- Type a few characters.
- Delete a couple of them with backspace or delete.
=> The deleted characters are still shown in the document (but not in
the tracking comment).
Findings:
In SwViewShell::ImplEndAction pRegion is 0, so no call to
SwRootFrame::Paint->vcl::Window::Invalidate occurs.
That is due to the fact that the call to SwLayAction::Action() does
not lead to populating *pRegion with rectangles
(SwViewShellImp::AddPaintRect).
In fact we stop at SwLayAction::TurboAction_ since pCnt->IsValid()
returns true and so SwLayAction::PaintContent() is never invoked.
SwFrame::IsValid() returns: mbValidPos && mbValidSize &&
mbValidPrtArea.
Here SwFrame::mbValidSize is the one that makes the difference: it is
true in Online and false in Desktop. (In our case the other 2 data
members are always true).
The reason is that the computation of the text range
(SwShellCursor::FillRects) in SwRedlineTable::LOKRedlineNotification,
which occurs just before collecting paint rectangles, leads to invoke
SwContentFrame::MakeAll which in turns set SwFrame::mbValidSize to
true.
Solution:
Call SwFrame::InvalidateSize() on any frame on which MakeAll is
invoked soon after we finish to compute the text range in
SwRedlineTable::LOKRedlineNotification.
Change-Id: Id5e29b06c044f14207722e67d6f5facbf786ffa6
Reviewed-on: https://gerrit.libreoffice.org/37508
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Created new show/hide all comments button for calc by
ShowAnnotations command. Unifyied writer, calc and impress's
ShowAnnotations slot.
Change-Id: I27149d09ee1763b84258c5e0c890a9628c8874c0
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/36697
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
In a formula like ='ExtRef1' & 'ExtRef2', or ='LocalValue' & 'ExtRef1'
empty string became an operand in concat operation if the referenced
external cell was a non-string one.
Change-Id: I7b0ac5de68349eae85afe48f377e30cab76e3fbf
Reviewed-on: https://gerrit.libreoffice.org/37469
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
otherwise the query will call make_unique to make this a unique
copy of the underlying shared font which is a waste if the
contents are going to be the same and the if branch contents
are skipped.
I was tempted to call the Font accessors like GetLanguage, etc.
but a bunch of the accessors have two versions, a const and non-const
one which behave differently so that looks like another rats nest
This relates to the changes of
commit 188439aac2
Date: Fri Apr 22 23:43:52 2016 +0200
tdf#62525 vcl: use cow_wrapper for font
Change-Id: Ic0661fccb414b3636308975e265fe5751476e1b8
Reviewed-on: https://gerrit.libreoffice.org/37502
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
