so that loplugin:useuniqueptr can trigger on it
Change-Id: I04d68278f870ec137b3a78491e83e8adc7374fa4
Reviewed-on: https://gerrit.libreoffice.org/56618
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Also make m_nProxyType a scoped enum so the code is a little easier to
follow.
Change-Id: Ic2862a1de8fe1005c4fb25147b3effc49b95140c
Reviewed-on: https://gerrit.libreoffice.org/56599
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
in every app there is in view as last subgroup zoom
ordinary you have fullscreen and zoom with the submenu
as in draw there fuulscreen isn't available panning was shown
and the submenu was updated to show also the draw specific zoom items
Change-Id: I390ac40815aa28c7df883cf63dcd214b181785ed
Reviewed-on: https://gerrit.libreoffice.org/56586
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
Insert section in writer is very long and when move InsertDoc
into the Object Subgroup it will be on the same level than
in calc
Change-Id: Ie34b5853dd462ed17df02f645a1e6953beaf3f13
Reviewed-on: https://gerrit.libreoffice.org/56584
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
If a number string has leading spaces and/or minus, then calculating
index into the aBuf as the difference between p and pStart gives
wrong (too big) number. This asserts in debug builds, when e.g. an
assignment is made in a BASIC macro:
Dim f As Double
f = " -12.20"
"include/rtl/ustrbuf.hxx:490:
sal_Unicode &rtl::OUStringBuffer::operator[](sal_Int32):
Assertion `index >= 0 && index < pData->length' failed."
This affects, e.g., https://gerrit.libreoffice.org/56610 (see
https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/9527/consoleFull#1820989527d893063f-7f3d-4b7e-b56f-4e0f225817cd)
Change-Id: I14654166be721907e2a26ea6f4091f203a9437d7
Reviewed-on: https://gerrit.libreoffice.org/56611
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Lines and Groups often are exceptions.
Normally, the import code swaps vertical rotations also. In the case
of lines (from the tests that I observed) lines don't have a rotation
value at that point during import, so no correction is made.
Grouping always messes things up.
Change-Id: I344c5a29f887294b751ffc87c01b30e472cfb4c2
Reviewed-on: https://gerrit.libreoffice.org/56595
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
But we need to have it behind the scenes, otherwise the Online's ruler
does not get notifications.
Change-Id: I72bef28cb15c462572b511449d538b067f7cb141
Reviewed-on: https://gerrit.libreoffice.org/56598
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit ee6e6bd5b853aa68c9721f53b5892384e7403eec)
Reviewed-on: https://gerrit.libreoffice.org/56601
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
...where the implicitly-defined copy ctor will copy the bAuto member while the
user-provided copy assignment op does not. The code is like that ever since at
least c779feb1dfa340d61902dcd9d0b754046ffd8e5b "INTEGRATION: CWS
hedaburemove01".
The bAuto member is only used in Put/QueryValue with MID_AUTO, but MID_AUTO
appears to be effectively unused? So lets assume that the user-provided copy
assignment op is like that due to a (presumably harmless?) accident, and make it
implicit, too. (Avoids -Wdeprecated-copy with GCC trunk towards GCC 9.)
Change-Id: I4e3156305e2b9862d337074105edc4317538af1f
Reviewed-on: https://gerrit.libreoffice.org/56592
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
editorial changes:
* maintain alphabetical sorting (by moving some of the new named patterns)
* consistent indentation
substantive changes:
* manifest schema: for no apparent reason, the QName pattern lost its +
* OFFICE-2118: Fatal: reference to the undefined pattern "table-data-pilot-groups"
* OFFICE-3857: Fatal: more than one attribute accepts the same name "scale-to"
* OFFICE-3933: the removal part of the diff was not applied
* OFFICE-3883: applied one line off, with missing rng: namespace prefix
* OFFICE-3928:
- removed combine=interleave attribute (was in 1.1 but no longer used in 1.2 schema)
- added missing rng: prefix to <empty>
Change-Id: I80871dec69b1dbc7b1438366d895c443a44fb72c
Reviewed-on: https://gerrit.libreoffice.org/56398
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Eventually MotionPathTag::Notify() and CustomAnimationPane::
updatePathFromMotionPathTag will be called to update the
motion path of the effect.
Change-Id: I1cd0756ea24d9b56ad3c44c99ef015c584c74dc7
Reviewed-on: https://gerrit.libreoffice.org/56353
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
Import custom document property _MarkAsFinal as LoadReadonly
setting, export LoadReadonly as _MarkAsFinal in DOCX, XLSX
and PPTX documents.
Before this fix, LibreOffice opened read-only OOXML documents
as editable, also saved and exported _MarkAsFinal=true silently,
resulting unintented read-only warning info bar in MSO.
This commit improves interoperability a lot, because this is a
basic document protection of MSO, recommended on its UI.
Note: LoadReadonly (on File->Properties...->Security, property
"Open file read-only") doesn't show "Edit read-only" info bar
from commit 630186ff4e0eba7317e542f8c3eca39ebd068721,
but it's still possible to switch on editing by Edit->Edit Mode.
MSO shows info bar for _MarkAsFinal. (There is an advantage to
hide the info bar in LibreOffice in a mixed environment,
to avoid overwriting of press-ready MSO files by LibreOffice.)
Note 2: Other differences of LoadReadonly in LO and _MarkAsFinal
in MSO: (1) Switching on editing doesn't remove the LoadReadonly
property automatically in LO. (2) Saving with LoadReadonly doesn't
switch off editing of the actual (still opened) document in LO.
Change-Id: Ie279c0670090d075103384cfa44ff1c2a2898216
Reviewed-on: https://gerrit.libreoffice.org/56180
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Jenkins for 'NativeNumberParams' unfortunately only on 6-1 bailed out with
/home/tdf/lode/jenkins/workspace/gerrit_windows@2/offapi/com/sun/star/i18n/XNativeNumberSupplier2.idl:57: warning: The following parameters of com::sun:⭐:i18n::XNativeNumberSupplier2::getNativeNumberStringParams([in] string NumberString, [in] ::com::sun:⭐:lang::Locale Locale, [in] short NativeNumberMode, [in] string NativeNumberParameters) are not documented:
parameter 'NativeNumberParameters'
Change-Id: I3379e1bba5b79196c86410e0115d04eba49dc2a2
new statusbar element property mandatory=true/false to determine
if this element can be hidden if total statusbar width is not
enough to fit all elements.
marked some calc and draw statusbar elements as not mandatory.
Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f
Reviewed-on: https://gerrit.libreoffice.org/56443
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
The case when the thread is re-scheduled exactly after checking for
m_bExecute but before taking the solar mutex.
Change-Id: I494c123a6225da60407391771622208c055ae49b
Reviewed-on: https://gerrit.libreoffice.org/56585
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
GCC trunk towards GCC 9 emits -Wdeprecated-copy because SalVisual has implicit
copy functions but a user-declared dtor. The implicitly-defined copy functions
are actually used (so cannot be deleted), but in fragile interaction with the
semantics of the user-provided dtor in the SalColormap(sal_uInt16) ctor.
Changing SalVisual into a move-only class (moving the "this instance must delete
its visual member" information) doesn't work well, as SalDisplay::ScreenData is
used as a supply of SalVisual instances (but which will never be of the "this
instance must delete its visual member" variety) that are then copied into
SalColormap::m_aVisual.
As only SalColormap creates SalVisual instances of the "this instance must
delete its visual member" variety, what actually works is to track that
information in SalColormap instead of directly in SalVisual, and make
SalColormap a move-only class.
Change-Id: Ib968a38c40b660ce91981b3c7b281f4add6ece6b
Reviewed-on: https://gerrit.libreoffice.org/56579
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
When subsets are non-contiguous, we need to include the parts between
subsets.
Change-Id: I28214dccc75e6a6af5c65397b2126049a65bf79f
Reviewed-on: https://gerrit.libreoffice.org/56571
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ib2301526d7aa6982af6c8c79ed7e9a4c34b7bbf7
Reviewed-on: https://gerrit.libreoffice.org/56491
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
