Follow logical consequences of the always-NULL.
And, depressingly, big slabs of the IA2 caption code
in writer doesn't actually do anything.
Change-Id: I35f7ffac19db683010b656b3c88f81b65233b080
In Writer shapes had no cropping property so far. With this
commit this is introduced as a FillProperty and has the same
type as the cropping used for pictures
(Picture context menu > Picture > Crop).
Layout and UI will be an other step. On the UI it would be placed
on the Shape context menu -> Area, when Bitmap is selected as fill type.
Note: In case of picture/graphic, cropping property is imported from
and exported to a:srcRect instead of a:fillRect.
Change-Id: Idc1ed2d40cb20b6992e94f14e7e4d853e1f55d02
git grep found nowhere in the codebase that this define is being
set.
Change-Id: I63e18e8f47b5e58ff96b075ddb4bc9a36e1dc80e
Reviewed-on: https://gerrit.libreoffice.org/8002
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This will load icons for the relevant sidebar buttons (in
paragraph panel, used with a drawing object).
Change-Id: I5426a873db3b8b9f5d7a17c99c35529aceaf381d
Reviewed-on: https://gerrit.libreoffice.org/7992
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Avoid code duplication, and make some actions to not depend
on args.
Change-Id: Ie2b32864f567f636843fb552bb0763e527322551
Reviewed-on: https://gerrit.libreoffice.org/7991
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
When copying an image from e.g. Firefox or Chromium the clipboard
will contain both the image itself, and the url of the image --
presumably it makes more sense to store the image data itself if
it is available -- the order of the items in the *_FREE_AREA_Copy
defines the order of preference for which data in the clipboard
should be used.
Change-Id: Id8b862a9f2fce3a34adbb16509e9b7372500a239
Reviewed-on: https://gerrit.libreoffice.org/7928
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Namely: Estonian has several sets of correct quote mark glyphs for double
quotes („”, „“, «» are all common), however the Institute of Estonian
Language [1] recommends using the first of these, i.e. „” (99 low, 99
high) [2]. As for single quotes, Estonian texts rarely use them, except in
a few fields such as linguistics and biology -- and both ‘’ (9-9) and ’’
(6-9) are considered correct [2, 3]. However, apostrophe in the beginning
of a word (which is effectively the same as a starting single quote) can
also be used to indicate omitted character(s) -- but there, only ’ (9) is
correct [3].
[1] Eesti Keele Instituut, the main official body which maintains and
studies the usage of Estonian language; http://en.eki.ee/index.php
[2] The last page of
https://docs.google.com/viewer?url=http://keeleabi.eki.ee/pdf/164.pdf (in
Estonian)
[3] Handbook of Estonian Language,
http://www.eki.ee/books/ekk09/index.php?p=2&p1=11&id=86 (in Estonian)
Change-Id: If88e6e03e3e4aa1919a25dbe2fa2ffc8c9a04f4a
The z-order can be any number, Word uses kind of random 32bit integers,
we count from 0. It turns out 0 and 1 may have some special meaning, as
counting from 2 (instead of 0) fixes the visibility the problems in the
bugdoc.
Change-Id: I695a625fc0ab8206cc09896bcf02ff7689f1defc
If you start a mail merge jobs via UNO, there is no way to cancel
it. But the functionality is already implemented and used by the
LO internal mail merge dialogs.
This patch adds an optional XCancellable interface to the MailMerge
service and implements it in the SwXMailMerge class.
As the XJob::execute function already uses the SolarMutex to
prevent parallel runs, XCancellable::cancel can be implemented by
storing the SwNewDBMgr in the private variable m_pMgr, protected by
a mutex.
The bCancel member has to be converted from a bitfield value to a
real boolean, because otherwise all bitfield values would have to
be protected by a mutex. Bitfield assignments aren't atomic as you
always have to replace at least a byte.
Change-Id: I007cc23fdf04ccfca7d3cd6180b0e17e99f53061
Reviewed-on: https://gerrit.libreoffice.org/7190
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
Added unit-tests to make sure that 'table cell redlines'
(e.g. - table cell was inserted \ removed) are being round
tripped correctly from a DOCX file.
Change-Id: I773cb51a39654d2640200489d5199361b56396c7
Reviewed-on: https://gerrit.libreoffice.org/7878
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
This patch adds support in the DOCX exporter for exporting the
'table cell redlines', such as 'inserted a table cell',
or 'removed a table cell'.
Change-Id: Ic37d2550691f1090a580dae57d597c8fd09c7ad9
Reviewed-on: https://gerrit.libreoffice.org/7877
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
This patch adds support in the DOCX importer for the 'table cell redline'
to be sent from the DOCX importer, using UNO (as a property of the
table cell) to the SW core. Once it reaches the 'table cell' - the
'set property' detects this property - and creates an
'SwTableCellRedline' object for it, and adds it to the
'SwExtraRedlineTbl' object.
Change-Id: Iba038f4109d5505b94cea548e73c614b5cc1b637
Reviewed-on: https://gerrit.libreoffice.org/7875
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
This patch adds support for 'Table Cell Redlines' (such as 'table cell inserted'
or 'table cell deleted' in SW core).
It adds the 'SwTableCellRedline' object, and adds a function for adding
objects of that type to the 'SwExtraRedlineTbl', which is the object
that holds all the redlines which are not 'Ranged' redlines.
Change-Id: Ic2e410be58683f171ea07d430b7544600780711e
Reviewed-on: https://gerrit.libreoffice.org/7873
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Added unit-tests to make sure that 'table row redlines'
(e.g. - table row was inserted \ removed) are being round
tripped correctly from a DOCX file.
Change-Id: I369dd32e7372d0cf0add19197f07d0ad604e9ef0
Reviewed-on: https://gerrit.libreoffice.org/7849
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
