Problem Description:
- In document.xml, outerShdw dist contains the negative value after roundtrip.
- Due to negative value file get corrupted.
XML difference:
Roundtrip: Before fix
<a:outerShdw dist="-1363652116480" dir="2700000">
Roundtrip: After fix
<a:outerShdw dist="57811035" dir="2700000">
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
https://gerrit.libreoffice.org/7880
Change-Id: Ied752672244d5768dee554e907f2f4d7a9d077d5
this code dates back to the first commit, if the null check was
valid the dereference should have triggered a bug by now.
Change-Id: If074f68bde6a63083921f687e700321488842364
this code dates back to the first commit, if the null check was
valid the dereference should have triggered a bug by now.
Change-Id: I7746bd26b6760dec4db522938e40a323be9ae4d8
Commit d738b063134e97c780205f8baf138f291016ded4 (fdo#74431 : Captions'
are preserved but remove a space, 2014-02-03) unconditionally removed
quotes around SEQ field names, because the DOCX and RTF import leaves
those quotes around during import time. However, the DOC import strips
them away.
So till all this is unified, at least make sure that on export DOC still
quotes the field names, as it did since the initial import.
Change-Id: I3478f736c2e17824f268f92580767b90d9fdd006
For the below captions :
ALPHABETIC
alphabetic
ROMAN
roman
ARABIC
in document.xml, captions were added as
<w:instrText xml:space="preserve"> SEQ "scientific" *ROMAN </w:instrText>
-no space after *
-Double quotes added for scientific
-For Caption ARABIC, it was comming as
<w:instrText xml:space="preserve"> SEQ scientific *Arabic </w:instrText>
it should be
<w:instrText xml:space="preserve"> SEQ scientific * ARABIC </w:instrText>
- After adding the above code, anchor value for a hyperlink tag was getting
corrupted. So aaded a fix for that.
UT which was failing due to above code changes :testBnc834035
"equality assertion failed
- Expected: _Toc363553908
- Actual : Figure!1|sequence"
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
https://gerrit.libreoffice.org/7839
Change-Id: I9124eefa0ae63baf7ee3eaa2148f3c739d6fa699
When calling on GtkSalFrame::GetGraphics(), if all graphics are in
use then it will return NULL. We don't currently check for this,
but we still try to use the graphics object even if none are
available.
I have added a warning when this occurs and just return immediately,
as there's nothing more we can do.
Change-Id: I24dfbb6f37f41527078a60a7577cb3b20de3fcca
Reviewed-on: https://gerrit.libreoffice.org/8031
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
The old code before the calc core refactoring took advantage of the old
calc storage which did not store empty cells at all. The new storage does
"store" empty cell blocks, and it did negatively affect the binary search
used for VLOOKUP. The revised binary search code properly skips empty cell
blocks so that it will work more like the old algorithm in 4.1.
This change also fixes fdo#72348, which was caused by the same root cause.
Change-Id: Ic20cc54d8dae26b62f5e9193cd21dad06ad10a3e
