In LOK we use one language identifier for both - UI language and
the locale used. This is a problem when we determine that we a
language for UI is not available and fall-back to the default
"en-US" langauge, which also changes the locale. This introduces
a separate variable that stores the language tag for the locale
independently to the language.
Another problem is that in some cases we don't reset the staticly
initialized data, when the new document is loaded, which is on
the other hand used to define which currency symbol is used as
SYSTEM locale. That can in some cases select the wrong currency
symbol even when we changed the locale to something else. This fix
introduces a reset function, which is triggered on every document
load.
Change-Id: I55c7f467600a832895f94346f8bf11a6ef6a1e49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89320
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89343
Tested-by: Jenkins
We already have code that detects this in the simple fly frame case,
extend that to cover the "paired fly frame + draw shape" case as well.
Change-Id: I4b3c1d600407436b239fee311ae6bfe837804241
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89381
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
getting --enable-pch=normal working with clang
means that the plugins now have a better view on some
stuff, so trigger more warnings
Change-Id: I83ca010c0ef07c8106068362bb50a354e3cf7dae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89312
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
there was "#ifdef POSTGRE_TRACE", but it was nowhere to be seen
except in the following purged files.
Change-Id: Id77aef0869d112cb1a5282d8db79da4bc78a56e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89378
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
vcl/unx/generic/gdi/salbmp.cxx:727:32: error: ‘pixmapHandle’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
vcl/unx/gtk3/gtk3gtkinst.cxx:7336:16: error: ‘eRet’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
etc.
One looks like it might occur in practice.
Change-Id: I09af7d36b134b31cb7bd8047b5c73f4a49c9d9b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89351
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
vcl/source/gdi/metaact.cxx:104:26: error: ‘%u’ directive writing between 1 and 10 bytes into a region of size 6 [-Werror=format-overflow=]
104 | sprintf(buffer, "%u", static_cast<unsigned int>(nMetaAction));
Change-Id: Iec295a5a2477b2a13d771c392e0de6c3920a2eac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89350
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
This warning is notorious for false positives so let's disable it here.
from sal/cppunittester/cppunittester.cxx:61:
workdir/UnpackedTarball/boost/boost/function/function_template.hpp: In function ‘SequenceSequenceT& boost::algorithm::iter_split(SequenceSequenceT&, RangeT&&, FinderT) [with SequenceSequenceT = std::__debug::vector<std::__cxx11::basic_string<char> >; RangeT = const char*&; FinderT = boost::algorithm::detail::token_finderF<boost::algorithm::detail::is_any_ofF<char> >]’:
workdir/UnpackedTarball/boost/boost/function/function_template.hpp:904:22: error: ‘*((void*)&<anonymous> +8)’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
904 | std::memcpy(this->functor.data, f.functor.data, sizeof(boost::detail::function::function_buffer));
Change-Id: Id3cf9fae8db190337b6a3eb0c847c019394088ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89349
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
* Update helpcontent2 from branch 'master'
to 03e9a3022cc686013fbadfe16aef8685800ac625
- Update help page for Navigator for Master
- put Move Up and Move Down in same order as Navigator
- Delete now needs a right click, also explain that file is not deleted.
- add Related Topics sections (and move link down to there)
Change-Id: I92c5ff4a5ef98f568a36e0a1edb8c20474110821
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89284
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 81d34863f3a8d919639341bbb15b1bc28bb68dec
- update help page about working with Master documents
- correct command for adding files
- generalize command about exporting to text documents, and
correct the command instructions.
- add link in Related topics to Master documents
Change-Id: Ifc7c0ed4893d837e3af98bdac751de60d0971080
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89283
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 9040e3925e3f217b3b681a2dc931c177c26cc420
- update control and command labels in Font effects help page
- "Effects" -> "Case" heading
- update "case" labels in Writer
- add "Text Decoration" heading
- correct heading levels of controls
- align order of control presentation with dialog box
- adjust module-conditional display of controls
- corrected menuitem name for showing Hidden characters
Change-Id: I3d8a0bdcb1b6c8442ba662a751116ee3f2c2252b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87807
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
DOC can have black with transparency set to 0xff, and that is meant to
be just black. Allow COL_AUTO, though; the rendering will not consider
that as transparent anyway.
Other than that, DOC does not support text with transparency, it's a
DOCX-only feature.
Change-Id: I33f61b54b8ebd7958845063ae61900182d6f5e80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89321
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
This patch removes toolbar menu item 'Dock Toolbar' enable state and
shows 'Undock Toolbar' menu item when toolbar is docked and 'Dock
Toolbar' menu item when toolbar is undocked. It also sets the
accelerator key displayed for these items to Shift+Ctrl+F10
Change-Id: I0e4673529438c42452026602785857066ea7874a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85673
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Here is effort to implement this request and improve code understanding/
readability in the areas touched.
A choice of one of three modes of outline tracking is avaliable through
the outline/heading content context menu. They are:
Default - does not collapse expanded outline entries
Focus - collapses all outline entries other than tracked
Off
The need for persistance of this setting is uncertain so has been left
for future implementation.
Change-Id: I9cb6420537d7ff9f584e94029a0c053f21f1ef8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89287
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
