This is the only variable in LogicalFontInstance with m_ as the
prefix, so changing to mpFontCache for consistency.
Also small tab cleanup in fontmanager.hxx
Change-Id: Id79392337795259568fbe71efb5200f1e31219a8
On second thoughts, FindFontFamilyByName is not a good name at all. I'm
changing it back to FindFontFamily. The parameter tells you how it's
being found.
Change-Id: Ie8278e1727075a49331135a149361a484aba91e5
There is a TODO in the code that suggests to do this, when I looked at the
collaboration diagram on Doxygen things made a LOT more sense.
Change-Id: If335498bb70872ffa5738cc5c17660faec84c35e
Reviewed-on: https://gerrit.libreoffice.org/21257
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Did a small change to ImplSVEvent * Window::PostUserEvent( const Link<void*,void>& rLink, ... ) in event.cxx file. Patch No. 5
Change-Id: I9e7fd099aec6d5d2060bdf4761f4cff4fbe31544
Reviewed-on: https://gerrit.libreoffice.org/21219
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
7c3c3006deaaaf1bb3f2f4eeeaf11da3bcebe53c is apparently worse than it
appeared at first glance since there are numerous assumptions about
bookmarks, such as that if they were inserted successfully they may be
copied successfully, which isn't the case for duplicate cross reference
bookmarks.
So fix this differently, by eliminating the duplicates and mapping all
reference fields to refer to the surviving bookmark.
It was not possible to do this in SwXBookmark by checking the makeMark()
return as that would raise interesting problems such as it's currently
guaranteed to have 1:1 SwXBoomarks to core Marks so we can't just
connect 2 SwXBookmarks to the same core Mark, and we also can't leave
the SwXBookmark unconnected after attach.
Another alternative would be to temporarily allow inserting the
duplicate bookmarks and then eliminate them after the import, but what
is implemented now is to check from xmloff for duplicates, which is
reasonably simple.
Change-Id: I7ee4854d1c9d8bf74201089cbb7287b1bd8ee3b9
Current behavior:
The direction of the sheet is set to default from left to right
Expected behavior:
The action of changing the direction from left to right to become from right to left
Solution:
Added export for text writting direction.
Now <alignment readingorder="2"> export properly
Change-Id: I0a49ba0e458cbd6a7feae8e205ae583b7da30d0b
The size of the last page will change in a bit in Hide Whitespace mode,
the intention of the test is to check the behavior of the normal
(non-last) pages.
Change-Id: I69b9072c59b6ca4dc5d93062c21726a0f5c03c05
Did a small change to to void Window::RemoveUserEvent( ImplSVEvent * nUserEvent ) and to void Window::ImplNotifyKeyMouseCommandEventListeners( NotifyEvent& rNEvt ) in event.cxx file. Patch No. 6
Change-Id: I75bc321d2a257df00f51d7e71aed2bc26500e58e
Reviewed-on: https://gerrit.libreoffice.org/21220
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Did some changes to syswin.cxx file. Patch No. 18
Change-Id: I79d3ea2110ae72762681ae494ee44ba7fc61e112
Reviewed-on: https://gerrit.libreoffice.org/21235
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Did a small change in winproc.cxx file. Patch No. 9
Change-Id: I71e3876c0512e2696d61962f2427384354130bb3
Reviewed-on: https://gerrit.libreoffice.org/21224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
...the implicitly-private derivation was presumably introduced by accident in
23fd991fda81668b3998b21b0131dda77965e405 "separate the sane from the less sane
in SwClient"
Change-Id: I30ec84b6a30c029cfbeb848ad37c9a532fec0a96
Did a small change to void Window::CallEventListeners( sal_uLong nEvent, void* pData ) in event.cxx file. Patch No. 4
Change-Id: I6dff8f0611833d1514552afad163cdb55f693980
Reviewed-on: https://gerrit.libreoffice.org/21216
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
The wget download apparently uses the time stamp of the file on the
server by default, which breaks incremental builds.
If wget downloads the file and it does not get the current timestamp at
the time of download but the one the file happens to have on the server,
then if you built from the previous version of the tarball at a later
time than the timestamp of the new tarball, make won't detect that it
has to unpack the new tarball.
The curl download should not be affected since curl requires an explicit
-R to use the server side time stamp.
Change-Id: I6bab51d20b8ab5e485fe68d3f27c31aaddc99f68
Did a small change to dndevis.cxx file. Patch No. 1
Change-Id: I9240d97a9b0dd76a2df43e01f0d1e71de9015c48
Reviewed-on: https://gerrit.libreoffice.org/21211
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Did a small change to bool Dialog::Close() in dialog.cxx file. Patch No. 2
Change-Id: I5268e77bef2225308e9d01831c7b09de19c3ded9
Reviewed-on: https://gerrit.libreoffice.org/21212
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I79610ab5c9eb3812035d9d2c5f8ce1508451cd60
Reviewed-on: https://gerrit.libreoffice.org/21251
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
Discussed on IRC - overwhelming consensus is to keep the headers
where they were before. The main reason to keep them in the same
directory is to keep headers as local as possible to the source
files, unless something else needs to access it.
The only thing that uses the headers is vc/workben/fftester.cxx
I will work out how to get Doxygen to pick up these headers another way.
This reverts commit 5d7772fc0464c867c5ad2f1e10ccabd7331f7efa.
Change-Id: I45ee970722e27748ab8af8909ac49579dc47ef56
Reviewed-on: https://gerrit.libreoffice.org/21250
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
Use binary search to find ImpBitmap BitCount in constant time.
Change-Id: Ica13d41d1473e01c9198c985d34206267d7910d1
Reviewed-on: https://gerrit.libreoffice.org/19759
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
...because they are asked for and stored in a successive user
interaction.
Change-Id: I09a3a1e59fe3819a28d7565e83b0db968dfee74b
Reviewed-on: https://gerrit.libreoffice.org/21040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
Change-Id: I57a70f7f6833af5e2cf94f526e99d1353247afb9
Reviewed-on: https://gerrit.libreoffice.org/21249
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
Project: help 71a3f0e66fb6fb37f73fe3841a36ba00bec5beaa
tdf#85433 help content for WEEKNUM, ISOWEEKNUM, WEEKNUM_EXCEL2003, WEEKNUM_OOO
Change-Id: I92995b4de6fe18d981757f0d273ddce5c11b1559
Y minimum for auto scale was accidentaly set to 0.
This avoided correct calculation of Y auto log scale (tdf#96807)
But also set linear Y auto scale from 0 (tdf#85690)
This fix detects if both min and max are equal to 0, and reset them (+-inf)
Change-Id: Ifaf306831f3b5a18a86483c88e807f478b447c77
Reviewed-on: https://gerrit.libreoffice.org/21055
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
Tested-by: Jenkins <ci@libreoffice.org>
Folder WebDAV paths have the '/' at the end, this needs to be removed
in RemoteDialog logic while filling the treeview.
Change-Id: I8336de3e08ff030b27b1e48594448ff66106cff6
Reviewed-on: https://gerrit.libreoffice.org/21041
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
Fixes a problem with Save to remote server dialog.
Change-Id: I4ef2dbf12bb786f5617cb57ff021012e4d884230
Reviewed-on: https://gerrit.libreoffice.org/21010
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
In a docx section, any header/footer which is not defined in the
section is considered to be linked to the previous section.
In the Word UI this is shown as an option named "Link to Previous",
and editing the header/footer in either section affects both sections.
LO imports this by copying the header/footer contents from the previous
section, but it did not handle the case where a section had different
headers for left pages vs right pages.
Fix this, which involved changing the mechanism used to detect
whether a section has defined a certain header/footer (which unlinks
it from the previous section):
rather than trying to figure it out from the converted LO page styles,
explicitly track which headers/footers have been defined using boolean
member variables on the SectionPropertyMap instance.
Conflicts:
sw/qa/extras/ooxmlimport/ooxmlimport.cxx
Change-Id: Ic43a867356c2cd5df09d39f2a3ddefa584b6765c
The tab stop list is a paragraph property, and RTF requires to repeat it
after \s as direct formatting, otherwise the parser should be assumed
that the tab stop list is cleared as a direct formatting.
Non-buffered text handles that in getDefaultSPRM(), handle it directly
in the RTF_PARD code for buffered text.
Change-Id: I16b09bc4c177df5a74d16653b829b198aa1a800f
Did some changes to lstbox.cxx file. Patch No. 14
Change-Id: I8e559c55345fa8c72f49c94f1a94906bf03683c7
Reviewed-on: https://gerrit.libreoffice.org/21231
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Did some changes to menufloatingwindow.cxx file. Patch No. 17
Change-Id: I3b7c9beb5f3e55930f66c463d4341b5a78d51bc1
Reviewed-on: https://gerrit.libreoffice.org/21234
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Did some changes to dockwin.cxx file. Patch No. 15
Change-Id: Iec42df460be350ffbb5aa11a801c7dea2df7c9cd
Reviewed-on: https://gerrit.libreoffice.org/21232
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Did some changes to winproc.cxx file. Patch No. 12
Change-Id: I32551d527a2d45b694418bfee19be5e8704ce60e
Reviewed-on: https://gerrit.libreoffice.org/21228
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Did a small change to static bool ImplCallCommand( vcl::Window* pChild, ...) in winproc.cxx file. Patch No. 7
Change-Id: Ib2929ff2fe98487461f2d8ec768fab8d4cd45c22
Reviewed-on: https://gerrit.libreoffice.org/21221
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Did a small change to short Dialog::Execute() in dialog.cxx file. Patch No. 3
Change-Id: I0ce2f62caea2d0aad4ced48df30d924f87de3c40
Reviewed-on: https://gerrit.libreoffice.org/21215
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
'fill', 'stroke' and 'stop-color' might depend on them
Change-Id: I8b709dafe0ad0423a87911af7f2c83fa81e61cbd
Reviewed-on: https://gerrit.libreoffice.org/20653
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
add support for font-size keywords.
My previous commit fa17cfd7e006c73f1360a5a974f38d9875f347c5
was wrong as doubles like '-10.0' or '5e1' were ignored.
Change logic to parse the whole string but the units ( 'cm',
'mm', etc, etc)
Then, value.toDouble() will try to convert it to double, and
if it's not possible it will return 0.0.
Besides, add support for font-size keywords described here:
http://www.w3.org/TR/REC-CSS2/fonts.html#font-size-props
Working on a parse test for this section.
Change-Id: I2b9c89225fcf63f1a0564abf7187097373cbc9a1
Reviewed-on: https://gerrit.libreoffice.org/20379
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
Support for text documents and presentations.
Added a command line option for gtktiledviewer:
--hide-page-shadow.
Reviewed on:
https://gerrit.libreoffice.org/21210
Change-Id: I1e427693d7af40cb5731d1730ac5b7c486d45c29
