I.e., don't try to create auto-layout for clipboard pages which
don't contain one; don't resize objects to text.
Also, don't invalidate items that are equal to defaults,
because explicitly set items are not the same as absent items:
pasting an object without an item makes the property to inherit
new target's default, while when the item is present, the default
doesn't apply.
Also, don't consider selected state of the page while stringifying
- this makes selected page string to differ from not-selected
clipboard page.
Change-Id: I172e03e1a8c428e5fcae3a116cc9ad8de79f1a87
Reviewed-on: https://gerrit.libreoffice.org/20871
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
The testcase for tdf#69640 includes links (relations) to external
pptx files. It demonstrates two non-fatal reasons for failure
opening OLE stream:
1. it fails OStorageHelper::IsValidZipEntryFileName check, because
the file path contains ":\";
2. even if that were not the case, the required file can be absent
from user's system.
I suppose that intercepting the failure at the level of
OOXMLOLEHandler::attribute() is the best option, because at the
lower level it's unknown if this failure is fatal or not.
I suppose that it could be also useful to intercept specifically
failures in OStorageHelper::IsValidZipEntryFileName, checking if
the file exist externally, and asking users if they want to update
external links (as MSO does). Possibly it should be discussed
with UX team if that should be done, and if so, do it in separate
commit.
Change-Id: I240a6f69abe236eb790bb406c79f3b761fb4638a
Reviewed-on: https://gerrit.libreoffice.org/19963
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
I currently assume that this is responsible for some of our heisenbugs
on windows. I think the windows file locking is causing issues when two
test try to access the same file in parallel. This is more likely to
happen on the fast windows ci boxes.
Change-Id: I423f6c723c2ec558026867a118972e98279bd2c2
Duplicate <include layout="@layout/toolbar"/> statement found.
Problem could be caused by either
1) a differing xml reading mechanism across android versions
2) toolbar being accessed in a different way across android versions
Duplicate element removed, and linearlayout shifted below first toolbar.
Change-Id: I084b6498745bc72988f3a8eed12f7a72d261e267
Reviewed-on: https://gerrit.libreoffice.org/20422
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Slight misinterpretation of the
{Sunday, Monday, Monday, Tuesday, ..., Sunday}
sequence defined in ODFF.
Change-Id: I09ac711adf8a52db1c9efbb1c67dc908b8e06618
The filters map between a common subset of Word smart tags and Writer
RDF annotations, and when doing so, they need to know what path to use
for a smart tag namespace and also the other way around: what RDF types
are interesting for smart tag purposes.
It turns out there is BAILS specification at
<http://www.tscp.org/wp-content/uploads/2013/08/TSCP_BAILSv1.pdf> that
describes how to refer to BAF objects, so use that instead of our custom
RDF statement / document metadata key names.
Change-Id: Iac569608b05aa61547f664f2a5df7d46fe46da76
... which now has exactly 1 parameter; removed the now non-matching
required flag of a not existing second parameter. Luckily the resource
manager treats this as a separate record block and this 0 didn't harm
the subsequent 0, accidentally..
Change-Id: I0994ed75643245c1bdebc9a92ade77abdd1c61d8
...that had inadvertently been removed as part of a larger code removal in
6948c546fd "tdf#75637: Resolve help images via a
vnd.libreoffice.image UCP"
Change-Id: Ic2d5e1a5fa5a10b240bb9e511e6dcb8097e58081
Avoid hundreds of presumably pointless warning messages in some unit
tests at least. The code explicitly checks and handles the asserted
condition not being true right after the DBG_ASSERTs.
Change-Id: I5482c56aeeadb8f85dfdd03e12960abd7e769c56
The Test currently tries to test the OpenCL and the SW interpreter and
assumes that it will show different results. However if we succeed in
generating an OpenCL interpreter we will never generate a SW interpreter.
There are a number of problems with the approach taken in this test.
1.) Assuming that we are able to execute OpenCL is an invalid
assumption.
2.) Changing the configuration inside of a test needs to be exeption
save as we are otherwise left with a strange config for the remaining
test cases.
3.) Changing the configuration does not change the formula group
interpreter. This needs to be done explicitly.
Change-Id: I679985ee7551b21aaa52038e107324980e7e1bb6
This may sound crazy, but literally vcl::FontInfo serves no purpose
that I can see. The inheritance chain is like this:
┌────────────────────────┐
│ │
│ vcl::Font │
│ │
└────────────────────────┘
^
╱ ╲
│
│
┌────────────────────────┐
│ │
│ vcl::FontInfo │
│ │
└────────────────────────┘
^
╱ ╲
│
│
┌────────────────────────┐
│ │
│ FontMetric │
│ │
└────────────────────────┘
vcl::FontInfo (which, incidentally, needs to be put into the vcl
namespace due to collisions with poppler!) literally does nothing
and is acting as a bridge between FontMetric and vcl::Font. Unlike
a bridge though, this bridge doesn't actually *do* anything.
So I'm removing it, which means one less class to deal with in the
vcl fonts world.
Change-Id: I32725669c9bca7fbb0846b6a062135464046e4f6
Reviewed-on: https://gerrit.libreoffice.org/21058
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
