Commit Graph

399660 Commits

Author SHA1 Message Date
Caolán McNamara
1ef8ab3ed7 coverity#1394295 Unchecked return value
Change-Id: Ie4edbe91ab4f9b9910fc895e47ea8b9fdfc00b7e
2016-11-12 12:23:08 +00:00
Caolán McNamara
20043e3fa2 coverity#1394296 Dereference before null check
Change-Id: I143b7439b33695aa5bc4e32fd9386692eac37697
2016-11-12 12:21:59 +00:00
Caolán McNamara
c0081fe0f4 coverity#1371239 Missing move assignment operator
but if _MSC_VER need >= 2015

Change-Id: I730319702ddc589c4fc1d72b20fd200eacfa53e4
Reviewed-on: https://gerrit.libreoffice.org/30785
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-12 12:15:27 +00:00
Mike Kaganski
737d324c90 Aviod memory leak in ScInterpreter::ScIntersect()
When one argument is a reference list, and another is a reference,
that reference is converted to temporary list. That list used to
leak because of missing release.

Change-Id: Ic76c9b8769b3a50980cf4d4e3468763b65f21e07
Reviewed-on: https://gerrit.libreoffice.org/30792
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-11-12 11:13:30 +00:00
Tor Lillqvist
afca1634c9 cid#1394298: This field was uninitialized and unused
Probably cid#1394297 was a fallout from that?

Change-Id: I98134ccbbbe8bc0b7d3c172ffddcdc3666f436f6
2016-11-12 11:58:25 +02:00
Tamás Zolnai
0415e4a914 Sd test: use binary mode to dump shapes to avoid Windows line endings
Otherwise on Windows we can't regenerate reference files.

Change-Id: Ia293fb62651ff981b127893e26ef1d19172d2a2b
Reviewed-on: https://gerrit.libreoffice.org/30788
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-11-12 09:43:50 +00:00
Tor Lillqvist
abe9f41277 More EncapsulatedX509Certificate work
Change-Id: I64239dfcfbc2383c2bf53c0cb86196d3f2c79330
2016-11-12 11:22:33 +02:00
Julien Nabet
a2c6112a47 Related tdf#70433: Use subtype to distinguish BLOB/CLOB for Firebird
See http://www.firebirdfaq.org/faq48/

Change-Id: If233919daeb02b67d0b3bc42547fbd3030864c37
Reviewed-on: https://gerrit.libreoffice.org/30789
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-12 09:15:49 +00:00
Zdeněk Crhonek
045dee9c5e add MAXIFS testcase
Change-Id: I6946fc6a6503c8e2b3b95d0d0a13d0e356f0993f
Reviewed-on: https://gerrit.libreoffice.org/30728
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-12 09:04:09 +00:00
Zdeněk Crhonek
86f9020c8e add LEFTB test case
Change-Id: I7370b60f417d4f1460a959c506e5ebc75d95fa61
Reviewed-on: https://gerrit.libreoffice.org/30366
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-12 09:03:40 +00:00
Zdeněk Crhonek
0108a967d7 add MEDIAN test case
Change-Id: I5d823f33b4cbd4a3e3b7317bcdf6d39c6210a9a0
Reviewed-on: https://gerrit.libreoffice.org/30729
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-12 09:03:17 +00:00
Julien Nabet
73679ee0a3 Copycat SvtSysLocale_Impl for SvtSysLocaleOptions_Impl
and so avoid warn:unotools.config:6728:1:unotools/source/config/configmgr.cxx:167:
ConfigManager not empty when exiting LO

See http://nabble.documentfoundation.org/OSL-ASSERT-items-empty-because-of-Setup-L10N-td4199284.html

Thank you Eike for the hint!

Change-Id: I4b374a075ad8f1ef10a71f3a9424986154613aef
Reviewed-on: https://gerrit.libreoffice.org/30787
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-12 06:38:34 +00:00
Kohei Yoshida
545f5f8abd Guarantee that InterpretFormulaGroup() is always called first.
This makes it easier to profile group calculations via formula log.
You can always bail out of that function when unfavorable condition
hits.

Change-Id: I49664c3e34b9efc98f39845379631649f76769de
Reviewed-on: https://gerrit.libreoffice.org/30790
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-12 04:33:53 +00:00
Takeshi Abe
18629fbb91 starmath: Prefix member of SmBlankNode
Change-Id: I20b9fa14d42549a3c5be8a7d4f52c85fcef52cf5
2016-11-12 12:34:25 +09:00
Mark Hung
4ffb2ae4bb svx: prevent customshape handles go far away when adjusting.
Change-Id: I4d1efd52320093a8edf4a5b7b1032a0754275f39
Reviewed-on: https://gerrit.libreoffice.org/30604
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-11-12 03:20:58 +00:00
Mark Hung
a39a2d28ac tdf#100733 svx: use RefR and RefAngle for polar handles.
Shapes imports from ooxml use RefR and RefAngle that refers
to adjustment to be updated. Though the properties exist
but the functions weren't implemented before.

Change-Id: Ib45c2e8b16c9a7b41387a3e8c356b803eaf74b77
Reviewed-on: https://gerrit.libreoffice.org/30603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-11-12 03:19:18 +00:00
Mark Hung
a241009fea tdf#100733 oox: update preset shape definition for polar handles.
RefR and RefAngle of polar handles of custom shapes can be handled
now. Their values in oox-drawingml-cs-presets and the loader of
preset shapes are updated accordingly.

Change-Id: Icacb19fbd1f4c202950b0a19afce01ad1cafc82a
Reviewed-on: https://gerrit.libreoffice.org/30602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-11-12 03:18:47 +00:00
Mark Hung
4c742c4726 tdf#100733 oox: imports RefR and RefAngle of polar handles.
RefR and RefAngle was ignored when importing polar
handles for customshapes.

Change-Id: I2d2aa1b0e54cf4946417c6dc81ecdbe58f6b50e9
Reviewed-on: https://gerrit.libreoffice.org/30601
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-11-12 03:18:12 +00:00
Adolfo Jayme Barrientos
1a31df1225 Updated core
Project: help  106850a265b62c6a85d713c20afe131844013f0a

tdf#82997 Update CSS for fonts used in systems of this decade

Draw inspiration from Medium.com’s use of system fonts. Drop the ones that were
only shipped in the proprietary StarOffice, and we have never bundled — nobody
has those installed, and by today’s standards they had poor glyph coverage.

Change-Id: I61ba65601027b35c492a379bd6ed78cd97100654
2016-11-12 02:01:01 +00:00
Zdeněk Crhonek
0d75c63a30 add REPLACE test case
Change-Id: Ic9e812abd1bc0d47fe30e810f71bca97811439bc
Reviewed-on: https://gerrit.libreoffice.org/30730
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-12 00:00:29 +00:00
Eike Rathke
0d6f974b97 Resolves: tdf#93415 use proper sheet separator in ADDRESS A1 notation
So that it matches what INDIRECT can digest in the current
configuration, as that is the primary use case.

The actual separator used depends on "Reference syntax for string
reference" and "Formula syntax" configured in Tools Options.

Change-Id: Iff91be7afdb9601a87b547dd3a7d3f4d994caf5d
2016-11-12 00:55:54 +01:00
Kohei Yoshida
0af3095298 Dump the formula string here which is also useful.
Change-Id: I604fbb41fc41319bbb17a5aef0994c8e0adc838a
2016-11-11 18:01:05 -05:00
Julien Nabet
ba8a41bac3 tdf#71251: VARCHAR max length is 32765 for Firebird
At least for Firebird 2.5 (see http://www.firebirdsql.org/en/firebird-technical-specifications/)
Let's put the same for CHAR

Change-Id: I4ab232689093b0418a7c1a9751685f41f2dabbf7
Reviewed-on: https://gerrit.libreoffice.org/30783
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-11 21:54:50 +00:00
tagezi
a615d93fa5 Updated core
Project: help  3856203084068752c3f5868e1f75ca4feb1f45d8

small refinements and cosmetic changes

corrected mistakes in the examples
pushed back signs of equality from numbers
made refinements  warning of error

Change-Id: I07194c563cf22d5b1b8254f77579f12461362a15
Reviewed-on: https://gerrit.libreoffice.org/30782
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-11-11 21:07:52 +00:00
Caolán McNamara
fe7671f144 Revert "coverity#1371239 Missing move assignment operator"
This reverts commit 8909cbeb31.
2016-11-11 20:44:14 +00:00
Michael Stahl
8eec78d3fb xmloff: print a warning if we drop a style on the floor
Turns out we do not support section styles.

Change-Id: I2858c639c1c9743f53836548b4c73645fa32d87b
2016-11-11 21:35:19 +01:00
Michael Stahl
33a32bb1e1 sc: OUString cleanup
Change-Id: I2fcd14adaa20d2692beb12ffd0b40b1a47538fbc
2016-11-11 21:35:19 +01:00
Olivier Hallot
78d1567437 Updated core
Project: help  383f9c4105ba03f86aa722b4881e7f690e017baa

Cleanups and debug info for online help

Add display of help page filename on top right
Normalize media files (part)

Change-Id: Ib6123efde1113adeb1470565a036e605a9d82b7e
Reviewed-on: https://gerrit.libreoffice.org/30765
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-11-11 19:49:00 +00:00
Abhilash Singh
453de3473c tdf#46200 Use the Scroll Lock key as a toggling lock key like Excel
Change-Id: I153522a90674f3f3c4db4ff300ef5cf4075704e3
Reviewed-on: https://gerrit.libreoffice.org/30117
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-11-11 19:35:45 +00:00
Khaled Hosny
553cfda502 tdf#103871: Set Kashida flag per glyph
When we are shaping mixed script text, the Kashida flag would be set
based on which script come last, which makes no sense of course.

I just left an XXX note yesterday, and I hit the bug today already
in a friend’s document!

Change-Id: Ic996fd886f30f4385185eccd214b5648f7248262
2016-11-11 19:43:09 +02:00
Khaled Hosny
8d8f31d38f FALLBACK_MASK flag is unused
Use also sensible values for the rest.

Change-Id: Ia772746cffe8c1e6d9d4aa4051b7b9df6d2e7ac8
2016-11-11 19:43:09 +02:00
Caolán McNamara
8909cbeb31 coverity#1371239 Missing move assignment operator
Change-Id: Ie5cddac8b4b0c8eefee82a14c845982600df0455
2016-11-11 17:03:11 +00:00
Caolán McNamara
5abd8d2eee coverity#1371263 Missing move assignment operator
Change-Id: Ifb4117afac4aa86893e674a581e1a7bb80925ee3
2016-11-11 17:03:11 +00:00
Caolán McNamara
f731296e0c check for self-assignment
Change-Id: I74eb934d19c0b511870e5a675917ca4baaf768cc
2016-11-11 17:03:11 +00:00
Caolán McNamara
4a862a6a01 make it more typical copy ctor
Change-Id: I0367e24b966a5bcc0d4838022ae12054e097270e
2016-11-11 17:03:10 +00:00
Caolán McNamara
d5233a94fd seems dubious to copy the state, but drop the load again bit
if the assigned-to item had loaded its original content, but the assigned-from
item hadn't, then surely the assigned-to item will never load the new content.

if the assigned-to item hadn't loaded its original content, but the
assigned-from had, then why load it again

Change-Id: I68c2cf2682a517e7e630ab6cbc637b35a2b9c7aa
Reviewed-on: https://gerrit.libreoffice.org/30781
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11 17:02:38 +00:00
Khaled Hosny
c49d5dea16 tdf#103765: Minimize the effect of rounding to int
Instead of scaling the relative coordinates and accumulating rounding
errors, scale the absolute coordinates. Also round to int instead of
truncating.

Change-Id: Ida0b4092685e898b7c5b5c07e923e386ffde8bcd
2016-11-11 18:26:20 +02:00
Caolán McNamara
d34572d39d these are going to get overwritten immediately
Change-Id: I065ae2aa2dead0679d05f080124ed54c27f0d68f
2016-11-11 16:21:48 +00:00
Caolán McNamara
763c47724d make this operator= a little less crazy
if SetGraphicPos was called with GPOS_NONE then
xGraphicObject, maStrLink and maStrFilter are
in a suitable state to copy to get the same
results as explicitly forced here

Change-Id: Id072590e92e0c083a3cbc443db0e85d9dbfa73f0
Reviewed-on: https://gerrit.libreoffice.org/30780
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11 16:13:31 +00:00
Andras Timar
0220020a62 new release of Graphite lib: 1.3.9
Change-Id: I4e9a7ebf323848a03e02da3e9ed39377d1df6715
Reviewed-on: https://gerrit.libreoffice.org/30771
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-11 16:11:03 +00:00
Samuel Mehrbrodt
f908ec9c22 tdf#98059 Don't replace existing objects when inserting media
Change-Id: I849e6801a20fcd3fb10482854e56923f99060f04
Reviewed-on: https://gerrit.libreoffice.org/30776
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-11 15:42:02 +00:00
Michael Meeks
99316fc0c8 tdf#103632 - sc: OOB sort fields unit test.
Change-Id: I6734d51c8f9c4ca5a01c3e54a71f83ba15db508d
Reviewed-on: https://gerrit.libreoffice.org/30761
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-11 15:41:33 +00:00
Michael Meeks
b8fa4d1b2d tdf#103632 - sc: tolerate OOB sort fields from UNO API.
Change-Id: Ie04b4281947a05572672838b3b4b5c6173d8fa0b
Reviewed-on: https://gerrit.libreoffice.org/30576
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-11 15:41:24 +00:00
Caolán McNamara
7c0bc67279 why have a pimpl with somethings in it and somethings not
Change-Id: I6151defcd9dddf4582ecf8d5952f6f8a825c545a
2016-11-11 15:19:51 +00:00
Caolán McNamara
bc09385ce2 the pStream member makes no sense at all
maybe the PurgeMedia call in sw was meant to be a PurgeGraphic
call originally

(PurgeGraphic since removed by...
commit a22ac2c218
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Thu Jul 14 22:06:29 2011 +0100

    callcatcher: remove unused methods)

PurgeMedia releasing the stream makes no difference to the only place its used
which is SvxBrushItem::GetGraphicObject which makes a new one every time
anyway.

the SvxBrushItem assignment operator doesn't change the stream
member of the pImpl which looks utterly nuts, so its a good thing
the stream is not reused

Change-Id: Ie0dee22a6640a6916908fcddbc3541ba85034217
2016-11-11 14:47:40 +00:00
Caolán McNamara
af92221020 this looks like a leak to me
Change-Id: Id72d770ec55d6e627a81cc9590cb59f6c84f27b9
2016-11-11 14:47:16 +00:00
Caolán McNamara
edff2837c3 use std::unique_ptr
Change-Id: I03e2fb2d3ad1b0b7e64f93dbee172b119ef7bf40
2016-11-11 14:47:16 +00:00
Dennis Francis
efecee353f tdf#101299 : do not show merge cells context menu for the trivial case
Change-Id: I4e5726009ac5ef60ffa74f3bbbe01683c3658e95
Reviewed-on: https://gerrit.libreoffice.org/29583
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-11-11 14:33:00 +00:00
Stephan Bergmann
fa194e7dfc loplugin:vclwidgets
Change-Id: I518db241a76bccbe060242eeeafd58135b2ac560
2016-11-11 14:09:50 +01:00
Caolán McNamara
b8b05986e7 default dtor is sufficient
Change-Id: Ia32b31489eb67f24987852dbadbcc2d3a81a0312
2016-11-11 13:08:21 +00:00