Commit Graph

399660 Commits

Author SHA1 Message Date
Noel Grandin
69581b948d warning C4701: potentially uninitialized local variable 'pPV' used
Change-Id: Icaba0cbeff8edf4bf389cf001462f157830b7afd
2016-11-14 12:01:22 +02:00
Caolán McNamara
40f8c14be2 minor opt tweaks
Change-Id: I418d0e04f8d4373c0d9f1f106ac0cc7779029802
2016-11-14 09:49:27 +00:00
Noel Grandin
fdf56e4b50 loplugin:unusedmethods
Checked a couple of them:

StandardCheckVisisbilityRedirector is unused since
    commit b1f8cf3782
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Wed Nov 2 10:57:21 2016 +0200
    loplugin:singlevalfields

SfxQueryStatus is unused since
    commit 64a708cba9
    Author: Caolán McNamara <caolanm@redhat.com>
    Date:   Sat Nov 5 20:28:27 2016 +0000
    Revert "Reverts a commit series that cripple windows ci."

Change-Id: If1c9fe26c3ebc573d8c53c8f060b05c27f2711e5
Reviewed-on: https://gerrit.libreoffice.org/30840
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14 09:48:46 +00:00
Aron Budea
2cee32bd4f tdf#94262: fix performance of MakeTree_Impl(...) in templdlg.cxx
1. replace 2nd level for-loop with a helper unordered_map that
 maps style name to its pointer

2. replace 3rd level for-loop with std::lower_bound, since the
 children are inserted sorted (based on natural sort)

...and a few related, minor changes.

Change-Id: I48f59f2e1ca416de1e2957e0d1d3708ed6e67112
Reviewed-on: https://gerrit.libreoffice.org/30744
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-14 09:48:06 +00:00
Noel Grandin
a24b62dc02 warning C4701: potentially uninitialized local variable
Change-Id: Ic3377b51faa2a83cd78bce43a56f323dc3a70085
2016-11-14 11:31:06 +02:00
Miklos Vajna
640c6745b0 sw: prefix members of CellSaveStruct
Change-Id: I94cd8c0d8f58ec2cfe00c9468e38f7129cd490f1
2016-11-14 10:18:10 +01:00
Eike Rathke
fcb1445ace ScFormulaCell::Notify: bail out early in doc dtor
Closing a document we don't even need to check a hint ID here.

Change-Id: I8cbfe50d46d6fd204a4b9ba2230e873eb5a8065e
2016-11-14 10:15:39 +01:00
Mike Kaganski
97eaf7bbb6 related: if we're empty, we're back to initial 'sorted' state
commit ae922863c4 followup

Change-Id: Ia9b8749880cc8c2b83dd59b4d7325cd666881c46
Reviewed-on: https://gerrit.libreoffice.org/30837
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-14 08:59:28 +00:00
Mike Kaganski
450762b224 tdf#68118: Pass current document frame to SvxScriptSelectorDialog
... through MacroChooser
Without this, current document's macros library is unavailable in
"Assign" dialog

Change-Id: I83baa3b98858260eab61e8f4fefde3f9979c6d83
Reviewed-on: https://gerrit.libreoffice.org/30600
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-14 08:56:42 +00:00
Caolán McNamara
6b35488c72 coverity#1371279 Missing move assignment operator
Change-Id: Ic1c1017184bff54360b0ea3b6f57e53d61cbe1d5
2016-11-14 08:53:11 +00:00
Caolán McNamara
aa3f954222 coverity#703927 Unchecked return value
make these less odd and simply return the thing they selected, rather than a
bool that indicates that the rpObj arg was successfully set to non-null, so
there's one flag to check not two which both mean the same thing.

Change-Id: If70e412f98dea8b7114fb77f26a9c59aab93be50
Reviewed-on: https://gerrit.libreoffice.org/30794
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-14 08:52:21 +00:00
Miklos Vajna
90a77e9c13 oox, xmlsecurity: fix recently introduced style problems
These files had a consistent style previously, keep them that way.

Change-Id: I6347efd4a301ddd758f4661778c0dfb68585940d
2016-11-14 09:25:28 +01:00
Adolfo Jayme Barrientos
2559ab66fd Tango icon update
Change-Id: Id8f14eb9a2b38e35d1147cea49413953f752472b
2016-11-14 00:32:36 -06:00
melikeyurtoglu
c5f5b3e533 tdf#91222 VclBuilder constructor cleanup
Change-Id: I29a8ca55d1d9f319cd57e5e30fa7e58e4d91dc5c
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/30810
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14 06:22:40 +00:00
Caolán McNamara
fef32a42c8 loplugin:unnecessaryoverride
Change-Id: Ifcdbf71a2added62b325e1a6a848973320154435
2016-11-13 20:52:41 +00:00
Caolán McNamara
fd90e40588 coverity#1371441 Uninitialized pointer field
Change-Id: Icabed9a27be9e34552531997818afd202f31114c
2016-11-13 20:47:48 +00:00
Olivier Hallot
69a3d753bb Updated core
Project: help  e852c87f0bef8b19c4d733460bb10910a880e769

New <object> element in online help + cleanups

* Implementation of <object> element in XHP files, with corresponding
  transformation in XSLT. Video objects maps to HTML5 <video> and
  audio objects into <audio> elements. Generic <object> maps to
  HTML5 <object> (WIP)

* CSS file with some cleanup and branding colors, includes the option
  to show debug info in .debug class. CSS fonts with recent changes.

* Index.html file with new <div> and better font rendering

* help.js with info on top right about the page displayed

* Cleanup of getbookmark.sh * New README with instructions

Change-Id: I856b99308ee008d8607dd0ba60a446224cc26e58
Reviewed-on: https://gerrit.libreoffice.org/30812
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-11-13 20:18:16 +00:00
David Tardon
3838475c2f drop extra semicolons
Change-Id: Ie6713d1bdf0010e5bc0bb70ca995c4dd36408673
2016-11-13 19:13:36 +01:00
David Tardon
27a165cfc9 drop useless semicolons
Change-Id: I039f8ff491b42ea9c3936bf13922df8095434228
2016-11-13 19:08:22 +01:00
David Tardon
a21d24ca72 revert unintentionally committed lines
Change-Id: I5cb355af20f18e63fdfe45e5946a9281fd1fa084
2016-11-13 19:02:31 +01:00
Khaled Hosny
ebfe8bb2b2 tdf#103895: Another fix too macOS glyph bounding
Apply font rotation when calculating glyph bounding rectangle.

Change-Id: I9c533ec3b33a5858d46b60d1700a50d3b6f915a4
2016-11-13 19:06:21 +02:00
Khaled Hosny
e760de7db5 The nAngle is set but never used
Change-Id: I7c8493e06ab3d7bab60f5af14100b1e25dd68fba
2016-11-13 19:06:21 +02:00
Khaled Hosny
3a64e01a7e Simplify vertical text drawing on macOS
Rotate only the rotated glyphs instead of rotating everything, then
unrotating the upright glyphs. No need for a rotated font either,
rotating the graphics is fine.

Change-Id: I1fce2c9c6a29abb1353a5fc8485a9c0d34edfbf1
2016-11-13 19:06:21 +02:00
Miklos Vajna
c622982a7a sot: fix loplugin:cppunitassertequals warnings
Change-Id: Ib4ec7d5c3dc89c80cc46bbbe8a14f6b1393ffa76
Reviewed-on: https://gerrit.libreoffice.org/30767
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-13 16:26:04 +00:00
Caolán McNamara
bf5eef2415 coverity#1371152 Missing move assignment operator
Change-Id: I7cf3ed2c1cd392b149d21ee884aac695d5d01be2
Reviewed-on: https://gerrit.libreoffice.org/30796
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-13 16:22:34 +00:00
Caolán McNamara
ae922863c4 if we're empty, we're back to initial 'sorted' state
Change-Id: Id85c670ab40d9d0e9848f91f4f2d14212f52c1a1
Reviewed-on: https://gerrit.libreoffice.org/30795
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-13 16:22:09 +00:00
Gulsah Kose
c3c08a16f8 tdf#103268 Activate editing object name function for writer images.
Change-Id: Idfe88a3f5b7492dc6ac71fa3791839a000a7483b
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/30759
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-11-13 16:15:06 +00:00
David Tardon
33ae095d92 add missing dependency
Change-Id: I72696c82d9a96709746060ae18bd497da8715d35
2016-11-13 16:29:31 +01:00
David Tardon
a64958ab63 move all tests for DLP libs to one place
Change-Id: Icbce7f5512c0c205f44db520f337ce9520d228d5
2016-11-13 16:29:31 +01:00
Khaled Hosny
24707c7b8d Fix build
Change-Id: I55db5ba855b8d72e9be0298a68b094c7b01d9f54
2016-11-13 14:25:00 +02:00
Korrawit Pruegsanusak
25638e2419 Change remaining sal_Int32 to ContinuationFlags ...
from 7f97b5e72c

Change-Id: I064e35f879ecba61d7ef71a0a177e760c3d263c4
Reviewed-on: https://gerrit.libreoffice.org/30793
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-13 05:28:57 +00:00
Khaled Hosny
069fc2a6a3 The bigendian parameter is always set to one
Change-Id: I91cc9ba6fac9318547a0321fa0668294db79559c
2016-11-13 07:15:49 +02:00
Khaled Hosny
7bd2eba766 Unused code
Change-Id: Ief0942e7e3dfb7a550bcd1de99e4630831438c86
2016-11-13 07:15:49 +02:00
Kohei Yoshida
892ad530b8 Actually this should be MAXROWCOUNT.
Since the end value is non-inclusive in flat_segment_tree.

Change-Id: I5f1febe378ab5c815d420ae77e38286fec8835b6
2016-11-12 21:36:25 -05:00
Kohei Yoshida
c000b8144e Address warning from the MSVC compiler.
warning C4701: potentially uninitialized local variable 'aRange' used

Change-Id: I06753a17f9b7efa35395f943f8a2ecccdd194be9
2016-11-12 21:36:25 -05:00
Kohei Yoshida
61228277fd loplugin:staticmethods
Change-Id: I674afe58964c27c349012de1117db3e362e72e5f
2016-11-12 21:36:25 -05:00
Kohei Yoshida
cc46bcc68b loplugin:stringconstant
Change-Id: Ia32a99530b8b32dc82dbca79d8c8ca1f2e090a96
2016-11-12 21:36:25 -05:00
Kohei Yoshida
8ce6e2e8bc Dump the state of the "save" data as well.
The "save" data is basically a section of the pivot table data that
needs to be saved to the file.

Change-Id: I2589c0fcd6df2458d35397b358064645fd97687f
2016-11-12 21:36:25 -05:00
Kohei Yoshida
b090a7c9a8 Let's just dump the result tree in dbgutil build.
Change-Id: I491a36152bb2106a7917a0fd548bd5b34d7021c6
2016-11-12 21:36:25 -05:00
Kohei Yoshida
e8ccf9a2e3 Let's hook up the pivot table dumper code to Ctrl-Shift-F8 as well.
It dumps the pivot data if the cursor is over a pivot table output,
else it dumps the column storage info.

Change-Id: I403e381be3f64d139f8bfaca7e477742a65dde9c
2016-11-12 21:36:25 -05:00
Takeshi Abe
73e21792ef Remove empty file
Change-Id: I7a6a9c6aa0720b9ba482b8ffa902452c3fac69fe
Reviewed-on: https://gerrit.libreoffice.org/30779
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-13 00:35:45 +00:00
Kohei Yoshida
79258677f0 Renaming due to the fact that it now dumps non-formula blocks too.
Change-Id: I9d06786a93bab2f0ed0d179df8edf9b5d8128bf6
2016-11-12 18:23:08 -05:00
Kohei Yoshida
f20df23ad9 Keep loplugin:staticmethods happy.
Change-Id: I2cdf67490d61b2868910e615bfc44d126d207bcb
2016-11-12 17:44:23 -05:00
Kohei Yoshida
633b9f30d0 Dump the other block types as well.
Change-Id: Iff41d4c2065a03865f884b2a8a260ffd83835dc1
2016-11-12 17:21:53 -05:00
Kohei Yoshida
4b57b76b6e Let's not dump formula results.
It could be too verbose.

Change-Id: I5f2da92e78bb069f3bb0c9c07bb3eae6d990f810
2016-11-12 17:21:53 -05:00
Kohei Yoshida
5a8fce7c56 Ctrl-Shift-F8 to dump the column storage where the cursor is.
Enabled only in dbgutil build.

Change-Id: I0cd095fb56893122a26b2da6882fca15e516d193
2016-11-12 17:21:53 -05:00
Eike Rathke
d38459355e accidentally kept always scroll test enabled.. tdf#46200 follow-up
When ironing out the nitpicks and committing
453de3473c the stupid reviewer forgot to
revert the bScrollLock=true so now the scrollock mode was always on.

Change-Id: I16b00266044a9ec9c839ad05e688801a7f3c7158
2016-11-12 15:47:57 +01:00
Tamás Gulácsi
96175a4bc6 tdf#69981 - sc: blank empty cells in TextToColumns
If the string is empty, we must delete the destination cell.
This is done, iff we don't return early (rStr.isEmpty() check).
Instead, add a fast path for the empty string.

Change-Id: I950db5012e7e9337f2efd576e58198b1b49eaa0c
Reviewed-on: https://gerrit.libreoffice.org/30778
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-11-12 14:43:22 +00:00
Jean-Pierre Ledure
f57502e75c Access2Base - 3 typos
Change-Id: Ie501bc7190a8eccc2810ccac2dddaec52813f1a2
2016-11-12 15:05:49 +01:00
Jean-Pierre Ledure
feed5f8a4b Access2Base - OutputTo method accepts input from array
in addition to tables and queries.
(only for internal use - arguments not published in documentation)

Change-Id: I4c7aff878a4ff1a03dcc32baae740559d034d3ca
2016-11-12 14:55:51 +01:00