mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
425,170 Commits 1 Branch 0 Tags
3c01b8cc4f15df16b4373855b8797d5dcff59327
Commit Graph

425170 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Miklos Vajna
3c01b8cc4f tdf#106854 svl windows: enable CNG by default 
But keep the environment variable to disable it for testing purposes.
This means that signing with ECDSA keys works out of the box on Windows.

Change-Id: I2820deb45377c54b59cdbd27a490af9beaf62851
Reviewed-on: https://gerrit.libreoffice.org/56901
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-07-04 09:06:35 +02:00
Stephan Bergmann
0bff0f77c2 There should be no need for a private SwSubFont copy assignment op 
...given that its (implicitly defined) copy ctor is public.  Before
ad355e2b24 "New: Proportional font width" the
class's members were all private, and then were gradually changed to public,
that's probably the reason why the copy assignment op still is.  Making it
public and implicitly declared avoids -Werror=deprecated-copy with GCC trunk
towards GCC 9.

Change-Id: I940c04041b0447f2129aaaa48f19fec40352311e
Reviewed-on: https://gerrit.libreoffice.org/56920
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-07-04 09:00:55 +02:00
Andrea Gelmini
5dadfe9f90 Fix typo 
Change-Id: I851237e46ddf83035453ae4f6c43a53e74b3aca7
Reviewed-on: https://gerrit.libreoffice.org/56882
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2018-07-04 08:48:42 +02:00
Noel Grandin
fa1028a0cd loplugin:useuniqueptr in ScCellsEnumeration 
Change-Id: I2ab494c977e6c877064ba6561d850b62bef2b438
Reviewed-on: https://gerrit.libreoffice.org/56911
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-04 08:37:07 +02:00
Noel Grandin
7b6411d016 loplugin:useuniqueptr in ScCellRangesBase 
Change-Id: I4416b012f20c71885211350e605e7ad856642fea
Reviewed-on: https://gerrit.libreoffice.org/56909
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-04 08:36:41 +02:00
Noel Grandin
13eb18a387 loplugin:useuniqueptr in ScOutputData 
Change-Id: Ic3b8802262910502cc2f7b638e41e0e865c03f6c
Reviewed-on: https://gerrit.libreoffice.org/56908
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-04 08:36:21 +02:00
Noel Grandin
a618f06d1f loplugin:useuniqueptr in ScPreview 
Change-Id: I081066d34ed6b134b5354f8df7f9801356ef181c
Reviewed-on: https://gerrit.libreoffice.org/56907
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-04 08:36:07 +02:00
Noel Grandin
2720dbe9f7 loplugin:useuniqueptr in ScDrawView 
Change-Id: Idbc47bdb3ff16d29a93365654b36b047c564de70
Reviewed-on: https://gerrit.libreoffice.org/56906
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-04 08:35:52 +02:00
Noel Grandin
ac49eb6ef9 loplugin:useuniqueptr in ScNoteMarker 
Change-Id: I4880f23a6c5879807430b60e812c6c697cf69268
Reviewed-on: https://gerrit.libreoffice.org/56905
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-04 08:35:34 +02:00
Noel Grandin
38733c7daa loplugin:useuniqueptr in ScSimpleEditSourceHelper 
Change-Id: Iebe62753d9e6f83f985e4c55fb938d5861613898
Reviewed-on: https://gerrit.libreoffice.org/56903
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-04 08:35:22 +02:00
Noel Grandin
2ddddc46fd Make ThreadPool::pushTask take param by std::unique_ptr 
And fix leak in XclExpRowBuffer::Finalize, was not freeing the
synchronous task it creates

Change-Id: Id1e9ddb5d968e6b95d9d2b5ca0c9e50774580182
Reviewed-on: https://gerrit.libreoffice.org/56874
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-04 08:35:13 +02:00
Stephan Bergmann
b0b4649690 solenv/bin/pack_images.py no longer needs executable bit 
...after 906a2e4fa4 "Always execute pack_images.py
with the right Python interpreter" removed its shebang line

Change-Id: I39dfa9c57699594caad85e183d3ef90b9ecaa59b
Reviewed-on: https://gerrit.libreoffice.org/56872
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-07-04 08:21:05 +02:00
andreas kainz
6a81ed1f3d Menubar Calc: move document compare features to track changes group 
same layout than in writer

Change-Id: I9fd0e745b6376c3047c4fa8408543fe11a4852ce
Reviewed-on: https://gerrit.libreoffice.org/56899
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
 2018-07-04 07:22:04 +02:00
andreas kainz
073d1907ef Calc Menubar: add icons to some menubar entries 
Change-Id: Iad8334c3e0f27c39cdab54a06ca8e54de263d26b
Reviewed-on: https://gerrit.libreoffice.org/56885
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
 2018-07-04 07:21:01 +02:00
Andrea Gelmini
4cf0bd4bc4 Fix typo 
Change-Id: I28a12befa0df6dcfcec7bad39c8691425b5b5d9d
Reviewed-on: https://gerrit.libreoffice.org/56852
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
 2018-07-04 07:09:30 +02:00
Alex McMurchy1917
585415df64 tdf#115718 Fix Watch Window EditBox 
For KDE4 only: this change reintroduces QStyle::PE_PanelLineEdit for
the EditBox/LineEdit widget. This allows the contents of the
Watch Window EditBox to be amended as one would expect.

Change-Id: Iffd7498d5f553ac0c9c612bf36b9f23d9eb8f86d
Reviewed-on: https://gerrit.libreoffice.org/56447
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-07-04 02:50:08 +02:00
Vasily Melenchuk
48e14cbb13 tdf#86612: impress: mark several statusbar elements as optional 
support for "mandatory" property was introduced in
d77f8eef16 but implementation was
made only for Calc and Draw.

decrease minimal width for "size" element: it is using too much
horizontal space in small window.

Change-Id: I184ac3a03ffa0a018f012d0f5da3c2da54f6c365
Reviewed-on: https://gerrit.libreoffice.org/56719
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-07-04 01:54:46 +02:00
Stephan Bergmann
f47b3f63b3 Adapt compilerplugins/clang/store/deletedspecial.cxx 
...to 322083e0cf "ScFormEditData copy functions
can be deleted"

Change-Id: Ic62c83b79e70a79d1d236b79140009a4212b6a43
Reviewed-on: https://gerrit.libreoffice.org/56878
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-07-03 23:36:35 +02:00
Tomaž Vajngerl
4dcfaad008 vcl: fontfeature test, decalre fonts the same was as in sw tests 
Change-Id: If1b3e658c30d1ae0e254ed7d8035d107bd2892f7
Reviewed-on: https://gerrit.libreoffice.org/56900
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2018-07-03 23:30:45 +02:00
andreas kainz
fdfa511eda NB writer: add media section to tabbed_compact 
Change-Id: Icbe25a95319806d8d45deb9d3d8a68ce8afc3721
Reviewed-on: https://gerrit.libreoffice.org/56895
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
 2018-07-03 22:50:48 +02:00
andreas kainz
1de7a60388 NB writer: add media section to groupedbar_compact 
Change-Id: I65aa3bbabeb0bbff05ac9257539135c67b9bcf2e
Reviewed-on: https://gerrit.libreoffice.org/56890
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
 2018-07-03 21:13:50 +02:00
andreas kainz
a74fe1b6f9 NB writer: add media section to groupedbar_full 
Change-Id: I2b306813720205649a394f3a9bcb7b38f72eea94
Reviewed-on: https://gerrit.libreoffice.org/56889
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
 2018-07-03 20:49:04 +02:00
Miklos Vajna
d4b4984109 tdf#115671 vcl opengl: fix drawing of polylines with duplicate points 
The bugdoc had a custom shape, the interesting part of it was a triangle
with miter line join, where the last segment was missing. In that case
RenderList::addDrawPolyLine() mishandled the polyline, as it does not
expect duplicate points in it.

Change-Id: I06d5c2d191bb6269a87da1f006f27a94205f5145
Reviewed-on: https://gerrit.libreoffice.org/56879
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
 2018-07-03 19:42:05 +02:00
Miklos Vajna
457acbfa30 UITest_writer_tests: split this into 4 parts 
Before: make -sr -j2 UITest_writer_tests UITest_writer_tests2 -> 5m9,863s
After: make -sr -j4 UITest_writer_tests UITest_writer_tests2 UITest_writer_tests3 UITest_writer_tests4 -> 2m21,734s

Again just assuming that each .py file means the same amount of CPU cost
(which may not be true exactly).

Change-Id: I9c4144c40eb1116d4b999bbba68e2fbef440af7b
Reviewed-on: https://gerrit.libreoffice.org/56880
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
 2018-07-03 19:34:40 +02:00
Rene Engelhard
d503b5d50b we still need a Archive::Zip test in configure.ac 
since system-hsqldb uses it for checking the hsqldb version. This partly
reverts 4e3dc8c141

Change-Id: I60d333d5807404355dd8c8fc2763e76d3a7fa350
Reviewed-on: https://gerrit.libreoffice.org/56888
Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>
 2018-07-03 19:11:41 +02:00
Michael Stahl
ed765a6087 schema: add some simple things found in ODT exported from crashtesting 
Change-Id: I425eb8595793560e35918c3b17b0c56cfd8ecaf6
Reviewed-on: https://gerrit.libreoffice.org/56867
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
 2018-07-03 18:12:05 +02:00
Stephan Bergmann
76a29148be const fixes for python3-devel-3.7.0-1.fc29.x86_64 
Change-Id: Ia16a8b828e11ce36e9bb77ecf9e8a1179bd9b90c
Reviewed-on: https://gerrit.libreoffice.org/56841
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-07-03 17:26:48 +02:00
andreas kainz
9f0bd172d0 App icon update 
Change-Id: I3ac392f903644281c6a1ccb9183fbe1c72b78311
Reviewed-on: https://gerrit.libreoffice.org/56847
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
 2018-07-03 17:24:45 +02:00
Eike Rathke
36eed54d3d Resolves: tdf#118221 whole cell kerning default is off 
So set that at OutputDevice, there is no cell attribute for
kerning, all kerning on is handled by EditEngine output.

Change-Id: I23ac2b2cf59f3a4651cc9b614df03860a9cb9146
Reviewed-on: https://gerrit.libreoffice.org/56866
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
 2018-07-03 17:12:33 +02:00
Michael Stahl
fb84f58002 schema: add README, as requested by Noel 
Change-Id: If3270ad1d20002dc39a5b4326b0cb42753112e93
Reviewed-on: https://gerrit.libreoffice.org/56868
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>
 2018-07-03 15:05:20 +02:00
Mike Kaganski
cd718dcdd2 Small cleanup of redundant assert expressions 
Change-Id: Ia529a6a9cf0ce75c612b8fc0fa1bc7dc8f1c2b5a
Reviewed-on: https://gerrit.libreoffice.org/56853
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-07-03 15:01:29 +02:00
Stephan Bergmann
11efed740e Read of uninitialized DrawViewShell::mbMouseButtonDown 
... (introduced with 6fffd09833 "tdf#109190 sd:
only MakeVisible on mouseclick-up") during CppunitTest_sd_misc_tests,
<https://ci.libreoffice.org//job/lo_ubsan/960/console>:

> /sd/source/ui/inc/DrawViewShell.hxx:117:50: runtime error: load of value 190, which is not a valid value for type 'bool'
>     #0 0x2b20592e1a9c in sd::DrawViewShell::IsMouseButtonDown() /sd/source/ui/inc/DrawViewShell.hxx:117:50
>     #1 0x2b20594e7c0c in sd::DrawViewShell::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drviewsh.cxx:61:11
>     #2 0x2b2059074b41 in sd::DrawView::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drawview.cxx:501:9
>     #3 0x2b207669a227 in SdrObjEditView::ImpMakeTextCursorAreaVisible() /svx/source/svdraw/svdedxv.cxx:1959:17
>     #4 0x2b20766e4ea4 in SdrObjEditView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdedxv.cxx:2171:13
>     #5 0x2b2076396e58 in SdrCreateView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdcrtv.cxx:868:16
>     #6 0x2b203f8d7b36 in SdrView::SetAttributes(SfxItemSet const&, bool) /include/svx/svdview.hxx:192:81
>     #7 0x2b203f8ab5a1 in SdMiscTest::testTdf99396TextEdit() /sd/qa/unit/misc-tests.cxx:215:9
>     #8 0x2b203f934ad8 in void std::_Mem_fn_base<void (SdMiscTest::*)(), true>::operator()<, void>(SdMiscTest*) const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:600:11
>     #9 0x2b203f9347e3 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1073:11
>     #10 0x2b203f9341f1 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::operator()<, void>() /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1131:11
>     #11 0x2b203f932bc9 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1871:2
>     #12 0x2b203f935550 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:2271:14
>     #13 0x2b203f931265 in CppUnit::TestCaller<SdMiscTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7
>     #14 0x2b1ff4edce7d in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
>     #15 0x2b20120c14d6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:48:14
>     #16 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #17 0x2b20048ad7a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12
>     #18 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #19 0x2b2000939e13 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16
>     #20 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #21 0x2b1ff4e172df in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
>     #22 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #23 0x2b1ff4e91b70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18
>     #24 0x2b1ff4f66ccb in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:10
>     #25 0x2b1ff4ed9efd in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5
>     #26 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
>     #27 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
>     #28 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
>     #29 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
>     #30 0x2b1ff4fa6686 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5
>     #31 0x2b1ff4f64e19 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:3
>     #32 0x2b1ff4fa7b27 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:3
>     #33 0x515d6d in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:315:13
>     #34 0x51071f in sal_main() /sal/cppunittester/cppunittester.cxx:465:14
>     #35 0x50e832 in main /sal/cppunittester/cppunittester.cxx:372:1
>     #36 0x2b1ff6bdc444 in __libc_start_main (/lib64/libc.so.6+0x22444)
>     #37 0x433494 in _start (/workdir/LinkTarget/Executable/cppunittester+0x433494)

Change-Id: Idff283298ee2fa11467ff4b8604da642e5a09a8f
Reviewed-on: https://gerrit.libreoffice.org/56854
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-07-03 14:50:48 +02:00
andreas kainz
796d60da3e NB writer: add media tab to notebookbar.ui 
Change-Id: I83a094b88c3ac31dc200a152e83ad7b8329418ad
Reviewed-on: https://gerrit.libreoffice.org/56848
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
 2018-07-03 14:49:14 +02:00
Luke Deller
9f331575ad tdf#118412: DOC incorrect bottom page margin 
Fix a silly typo when determining if the page has a bottom margin

Change-Id: I96857951725d00978c43d850d0e1bc64ab61d965
Reviewed-on: https://gerrit.libreoffice.org/56602
Tested-by: Jenkins
Reviewed-by: Luke Deller <luke@deller.id.au>
 2018-07-03 14:44:03 +02:00
Katarina Behrens
63f0dbdd61 Draw button focus so that it doesn't obscure the actual button 
Change-Id: I0df51b8dfd75dd966639d0893c379f2038c949ff
 2018-07-03 14:10:49 +02:00
Katarina Behrens
dc8f347f5f Use cairo's OVER operator to preserve transparency 
Change-Id: I1afae266a5308fa0dbf2488777ddb963e99199c7
 2018-07-03 14:10:49 +02:00
Katarina Behrens
c4a06289ca Implement native modality for modal dialogs 
instead of hack with hiding the window and showing it again (otherwise
modality change has no effect and worse yet, weird things happen)
it would be much easier to use QDialog

Change-Id: Ie7029ca66380495c4aad246d02f4b96cb55eb01e
 2018-07-03 14:10:49 +02:00
Katarina Behrens
b1a5ce7d1d Traversing dialog controls backwards (Shift-Tab) works now 
Change-Id: If0e8d7307dd37436751e524d7ed24e89d5b72db3
 2018-07-03 14:10:49 +02:00
Katarina Behrens
e3ac0b0432 Ignore closeEvent if user has vetoed closing the frame 
Change-Id: Ib86ec0d297e23c02ad50ce1044859e029eae2ba9
 2018-07-03 14:10:49 +02:00
Katarina Behrens
af74bf268f Rearrange and annotate funcs by XInterface 
Change-Id: Ie429074fdbe8fb4e28b1af47486bc70c5f8070e8
 2018-07-03 14:10:49 +02:00
Katarina Behrens
aeda1e0ff9 Implement getDirectory, signal+slot 
also factor some shared code out into separate func

Change-Id: I49d25eeb4eb647b72dae78c42301091d198eeff4
 2018-07-03 14:10:49 +02:00
Katarina Behrens
998f08ee29 Folder picker is now really a folder picker 
and not a regular file picker with wrong title

Change-Id: I849e7bb3d0cad197880fadd865f4d39f13245e97
 2018-07-03 14:10:48 +02:00
Katarina Behrens
1af4ab72e2 Fix initial switch to folder in fileopen dlg 
the argument passed is an URL, so using setDirectory wouldn't do
the trick, setDirectoryUrl would

Change-Id: I312f6e2a06b46777dc126f95f63ec0dbcb1f5799
 2018-07-03 14:10:48 +02:00
Justin Luth
e1bab58778 tdf#109190 sd: cancel selecting status on new mousedown 
It is possible to cancel a mouse-down without a mouse-up
(for example with an ESC button).
So, cancel an obsolete "MouseSelecting" on mouse-down.

Change-Id: I37d641612cf2cd8099af8f04b12fdb364c4f9e24
Reviewed-on: https://gerrit.libreoffice.org/56857
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
 2018-07-03 13:23:05 +02:00
Miklos Vajna
b8fd1a814f tdf#117757 sfx2 save-as: fix leftover temporary files for embedded objects 
This is really similar to c167620444
(tdf#117225 sfx2: fix leftover temp file when saving doc with embedded
objects, 2018-05-14), just this is save as, not save.

Change-Id: If78d91262bfbe97846287deb0794e4101ef7b4af
Reviewed-on: https://gerrit.libreoffice.org/56842
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
 2018-07-03 11:59:20 +02:00
Takeshi Abe
de7e83969b sc: Eliminate the case of MAXROWCOUNT_DEFINE <= 65536 
It is 1024*1024 since b3579d71c6.

Change-Id: I7f523f21229de8f4fa378aa85f124863a67b21c8
Reviewed-on: https://gerrit.libreoffice.org/56843
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-07-03 11:51:30 +02:00
Takeshi Abe
e46df81b67 sc: A micro optimization of PERCENTILE() for interpolation cases 
As the leading std::nth_element() already partitions the vector,
all we have to do is to pick the minimum in its latter part.

Change-Id: I7767edc538819251c8fe9d26441ae57b06b2f865
Reviewed-on: https://gerrit.libreoffice.org/55575
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-07-03 11:50:08 +02:00
Stephan Bergmann
322083e0cf ScFormEditData copy functions can be deleted 
Change-Id: Id6aad74198da68aa6475bcd3b17c993a51ccabe9
Reviewed-on: https://gerrit.libreoffice.org/56846
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-07-03 11:28:32 +02:00
Stephan Bergmann
75b3f109f6 ScAsciiOptions copy assignment op can be left implicitly defined 
...which removes a -Wdeprecated-copy (because the copy ctor is already not user-
declared) with GCC trunk towards GCC 9 (and makes SetColInfo unused).

Curiously, the user-provided copy assignment op didn't copy the eLang member,
but assume that was by accident rather than on purpose.

Change-Id: I3116500b748f0625acf1368d0106ade94f0dfa26
Reviewed-on: https://gerrit.libreoffice.org/56845
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-07-03 11:27:37 +02:00
Noel Grandin
79cb267812 no need to switch models in the SvTreeListBox 
since we're replacing it completely anyhow.

which means we can remove DisconnectFromModel

Change-Id: I2f31d93eb95a641f3364d715111e70817c7e5087
Reviewed-on: https://gerrit.libreoffice.org/56849
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-03 11:19:00 +02:00