(In VisitVarDecl, filtering out AbstractConditionalOperator avoids an unhelpful
> ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:63:32: error: replace single use of literal 'rtl::OString' variable with a literal [loplugin:elidestringvar]
> aXmlWriter.content(sPdfConformance);
> ^~~~~~~~~~~~~~~
> ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:52:21: note: literal 'rtl::OString' variable defined here [loplugin:elidestringvar]
> OString sPdfConformance = (mnPDF_A == 1) ? "A" : "B";
> ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
)
Change-Id: I7d0410f04827d79b4b526752917c37d33cad2671
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104911
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
... at the start if the section nodes were at the start.
m_bBackSp and m_bJoinNext can't both be true.
(regression from 740f179650)
Change-Id: I999ed3809ca8f527bc3e754b229df02da4576825
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104891
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Prevent us from crash in online using mobile phone
when leaving chart edit mode with chart type modified.
Change-Id: I8da70612786141a2c92b55a45822ef8ff5713e5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104606
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
If this crashes LO too often, we can revert it. It helped me to
debug tdf#137804. Then we might need to work with exceptions or
some other way to notifiy the creator of the Qt5Painter, that
the constructor has failed. Much more work to handle all sites
using Qt5Painter...
Change-Id: I81cd18770dc93d8dd1542972cd4fc220dd0dce09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104894
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
because this pivot table dialog is going to disappear on response and the error
dialog is not run in its own event loop but instead async so will end up as a
parent of a dialog that doesn't exist
Change-Id: I78302428a246612e3107d2907ffffb97a2d25ea2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104895
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
For a test I added a SAL_WARN, but that created many more debug
messages then expected, just when opening the print dialog. So
this just handles the crash like the CairoTextRender variant of
DrawTextLayout does, by returning early.
Change-Id: Ie5b58ebbba02dace0e777b60fcbc3b9f46ea9d66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104893
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* Update helpcontent2 from branch 'master'
to 4d260d542ebddf6540285885c7750b5663c3862a
- Add related topic to View - Status Bar about Status Bar
( /shared/01/03060000.xhp ) View - Status bar
- add <relatedtopics> section (with appl-switch)
- add appl - switch to show module specific help for Status bar
- update to: <h1>
- remove "taskleiste" section id
( /smath/main0103.xhp )
- update to: <h1>,<h2>,<menuitem>
- change select ID to status_bar, which was already in 03060000.xhp
Change-Id: I841be8750fa8dff526e0a9ea8fa20ff351163805
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104844
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tested-by: Jenkins
a) give it a default implementation based on the current one
b) re-use code introduced for WeldEditView::DeleteSurroundingText
for the EditView containing vcl::Window in impress/draw and
various similar Annotation windows
Change-Id: I55547c70e90ee394795b5545450cf8131538fad8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104781
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Update helpcontent2 from branch 'master'
to 1b7505a4af439d85a6db1d1a8364aa1c347717dd
- update help page for Status Bar and some of its linked pages
(swriter/main0208.xhp) Status bar
- embed missing "Word count"control
- add more explanation about Digital Signature, because no link.
- use <ul> to display menu options for Language,
and add <menuitem> to controls.
- specify that More option in Language context menu opens
character formatting dialog.
- change level of Language to <h2>
- update to <h1>,<h2>
(swriter/01/06040000.xhp) Word Count menu
update to <h1>,<menuitem>
( shared/02/20030000.xhp ) Zoom on status bar
- change "double-click" to "click" to open Zoom dialog
- specify "right-click" to open context menu
- update to: <h1>
( shared/01/03010000.xhp ) Zoom and View Layout
update to: <h1>,<h2>
(shared/00/00000403.xhp) View menu
- corrections to:
- Access to Zoom on Status Bar
- menu sequence Zoom Layout
- remove empty colspan and rowspan from <tablecell>
- change all image height/width to 1cm
- <h1>,<menuitem>,<keycodes>
Change-Id: I9db21aea66c67ebd699d7ed90877cb8c6e2f0c06
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104838
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tested-by: Jenkins
To keep compatibility with OOXML format, it should be allowed
to use Scientific Format in Custom Properties.
The solution is backward compatible with standard numbers
(it is still possible to write integer numbers and fractions).
With that fix it is also possible to store very small and very big
numbers in scientific notation.
Change-Id: Ic788a6e3f4f748b905828f3d6c8c40dc7e46ba52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104569
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
* Update translations from branch 'master'
to 21ea3a68e438396c58be1e282e1dfc8f6d7b5fd2
- update translations for master
and force-fix errors using pocheck
Change-Id: Idacdc23e832352386c34c211e4bea478f2f5dcc0
in Page and Paragraph
For all places in UI where "register-true" appears, change
to "Page line-spacing".
-For Paragraph dialog, remove section heading and rename checkbox to
"Activate page line-spacing"
-For Page Style dialog, change label to: "Use page line-spacing"
-Add tooltip and extended tooltip in Paragraph dialog;
-Shorten tooltip in Page dialog, and add extended tooltip
Bonus:
-Add tooltip to "Automatic" in Paragraph dialog
-Remove contraction in control label (in accordance with UI guidelines)
Change-Id: I826ce35051b1d2c04f0e52d4e9fe4e6cfd1d7cf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104331
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Update translations from branch 'master'
to 9e37d57a9ccfcba5925a14f5e29397b2fbf0e261
- update translations for master / 7.1.0.0 alpha1
and force-fix errors using pocheck
Change-Id: Ic49ef021112516a473dac6df957ca8e4c27d2369
The MirroredY property is set (in the CustomShapeGeometry property), but
it is not supported for the LineShape by UNO, so we have to make the
mirroring during importing.
Change-Id: Iaa7e3a352598ad12c5e0d40b4fcd43fd197c4df9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104662
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Without this patch if a shape anchored to a paragraph and containing
a text box was moved upwards beyond the vertical position of its anchor,
the text box failed to keep its position in sync with the shape.
This is fixed by telling the text box the absolute vertical position of
the corresponding shape after the latter is moved.
Note: Other fix is associated to the shortcut keys
Shift-Arrow Up/Shift-Arrow Down for moving text frames with
bigger steps vertically. Now it's not possible to use these
keys, but that was bad with text boxes, because it moved only
the text content of the text box.
Note: this patch fixes the vertical position of the text box
of textbox-wps-only.docx of the unit test textboxWpsOnly.
Change-Id: Ib66b13cae455462c616fed6bbd088433c83e61a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104520
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
* Update helpcontent2 from branch 'master'
to 934cd73d20322b68c830c78ac596eeddcdf85051
- Improve "Enable regular expressions in formulas" section
Add a link to regular expressions list; add LOOKUP to affected functions
Change-Id: Ic753552b916bdccfcb13335ff32490babe0d840a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104836
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Commit d75c5b3891 (tdf#136836 emfio: speed
up import of EMF import when the orig PDF is available, 2020-09-17)
improved both performance and correctness of the EMF import, in case it
had a PDF fallback.
It turns out that PDF fallback can be nominally non-transparent, and
still the EMF equivalent supports transparency.
Fix the problem by enabling transparency in the PDF-in-EMF case.
Change-Id: I4d1585a5db6f28bd9c9cb380b5f193f4d5edcc8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104849
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
The default background color of the frame is APPBACKGROUND, which
is matched to GetWorkspaceColor(). That color is visible in Writer
as the default document workspace background.
Originally I just saw the dark background of the button box in the
start center, and thought the workspace color in Qt is wrong and
changed it in the reverted commit, missing the change of the color
around the Writer document.
Now that the button boxes's background color isn't fixed via the
"branding" setting, we also must react to changed style settings,
so we override the DataChanged function.
This also reverts commit e0c72e31c1.
Regressed-by: a927e0964b
Change-Id: I62396355054523baef1197a8a8af61c2f0d29ef3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104740
Tested-by: Jenkins
Reviewed-by: Thorsten Wagner <thorsten.wagner.4@gmail.com>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
...see a9266c39cc "loplugin:toolslong
(--enable-online-update)" arguing that "the third argument to
curl_easy_getinfo(..., CURLINFO_RESPONSE_CODE, ...)
must be a pointer to long".
Change-Id: I7c542595219d2387cf869953fe40faef2b41b44f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104857
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Seems kind of pointless to unmark flys that aren't deleted.
SwFEShell::SelectObj() apparently guarantees that at most 1 SwFlyFrame
is marked.
Change-Id: I061fc640512192e6e0a916020e3ac0b91c75d5c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104818
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
* Update helpcontent2 from branch 'master'
to 3286cc1b7c171cb84c8661e0c5685c5600693218
- rename German id in Tools menu
tastatur --> "keyboard" (in shared/00/00000406.xhp)
and update shared/01/06140200.xhp, which referred to it.
update (a few) to: <menuitem> and <h1> in Tools menu
Change-Id: I177bfd6894e3bdb95c407422f086fdc16d3a4d40
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104833
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 93ee2d0f1ea9432d1bae5e7f69adc61ac169fb06
- rename German ID
hinweis --> "referencehelp"
in swriter/01/04090003 and embedded in swriter/01/04090005
Change-Id: I81706d0cdf420aab69ccf4ad02a187f71faaf0ab
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104832
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to f551d6b2ddcb319c162c7789ae65de4274b8d5d1
- tdf#131206 improve explanation of Insert Document (Field) (wip)
- moved <note> about HTML export of date and time down to Format
section
- add initials for Author Type, and a sys-dependent advice about
how to update that field.
- remove table about Select items for Page Type, because it is
mentioned already in Table, plus it is part of auswahl section,
which is embedded into DocInformation (04090004.xhp), which does
not insert any "pages" in that dialog tab.
- add "select list" to the tip about double-clicking
- update <literal>,<menuitem>
- update to: <h1>,<h2> in main page for Fields
- eliminate German id: dokument-->document in 040900001.xhp
Change-Id: I72803af2a9f38d8fd1e5ef45b3751934888d8a88
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104687
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
