All tests pass now, and I've also handled all significant bugreports
from tdf#133764. This commit is mainly meant to test this more
in practice and collect feedback. Depending on how this turns out,
there may be a backwards compatibility option or something similar,
but so far I see no significant need for it.
Change-Id: I1a946f4e0b51be5acf4e25dc773e7694c2b17b48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131180
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
It should not attempt to dereference pointers when nIndex is negative.
Properly handle too large nIndex.
Also it is not necessary to parse the string when nToken is negative.
Related to commit be281db569
Author Rüdiger Timm <rt@openoffice.org>
Date Mon Sep 20 07:43:20 2004 +0000
INTEGRATION: CWS ause011 (1.18.22); FILE MERGED
2004/08/18 11:47:54 sb 1.18.22.1: #i33153# Made getToken more robust.
Change-Id: I6fc77a5b70308ccca08cb2132bd78d024bd7e3e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131221
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This extends 582fc887f1, first
check if there is any named range that could possibly conflict (which
generally should be rare).
Change-Id: Ia5e9e56cab29b459bcb489e871b4960ba215b665
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131219
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
seen in: make UITest_sort UITEST_TEST_NAME="tdf105301.tdf105301.test_tdf105301"
with the fix for tdf#147722 which resulted in the first few rows
scrolled out of view and GetDisplayText() then returning nothing
Change-Id: Id833a6b5029a490b08e730c641bf9dcdea627b5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131220
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
The user interface is loaded in the user's language
at the first use of Scriptforge during the LO session.
So far the labels were always loaded from the relevant
.po file.
Now they are loaded in memory by code when the user's
language = "en".
Objective = gain in performance.
Additionally the default language is set to
SF_Platform.OfficeLocale
i.o.
SF_Platform.SystemLocale
Internal change, no impact on documentation
Change-Id: Ia0d1235f8ca6a42141a5481fe80b5bec1d53a7e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131214
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
In some cases the widgets are in frames now so that hierarchical
relationship is captured already. In others labelled-by is a better
match and/or is already labelled by the widget.
Change-Id: Ifecd0eb96afecadbd66fcfdf843ce1590f5c5ff4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131185
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
With dynamic columns it is possible for it to be called
for unallocated columns, and those can't be merged.
Change-Id: If4a365ba175b9ea7e68704bb4db85a30e5f8a0db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131211
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
...that had been introduced with 7e8e85adbe "Add
codeSnippet debugging output when dbglevel>1" and reinforced with
6f121860d0 "tdf#130924 replace debugging printf
calls with SAL_INFO/SAL_WARN"
Change-Id: I9529bfdedd3d1a3dd623fdb28e01d6bd96c92d97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131169
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Map <w:br w:clear="..."> to the com.sun.star.text.LineBreak UNO service,
but keep the default clear=none case unchanged.
Change-Id: I145e891c1df0bbd0fdac2c62463dc801bca827fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131167
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
In some cases the widgets are in frames now so that hierarchical
relationship is captured already. In others labelled-by is a better
match and/or is already labelled by the widget.
Change-Id: I65cbeab514a443edd96c6f9353f892317ac5f775
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131155
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Just like already done for RowHidden(), avoid repeated calls
to HasAttrib() and IsVerOverlapped() that would return the same
value because it's the same underlying attribute range.
Change-Id: Ic270f5ba1333e15d46b5e54e14d9760602221ea7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131151
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
The default cell style has protection turned off. That means that
any cells that do not have a style that turns the protection on
are actually not protected. So the original code was correct,
it went beyond the cells explicitly saved in the file and the first
"default" cell was not protected, so it was ok to jump there.
Re-saving this document to xlsx and opening it in Excel has the same
result.
So revert the change. Keep the test, but edit the test file to
actually protect cells in the default cell style too, as that way
it's actually useful as a test of protected cells. And since
the test for tdf#126904 is a subset of basically the same test
for the same "bug" tdf#131455, keep only the larger test.
Change-Id: I36f21c33aaf5a31e95aa29d616c6abdec17fcf42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131126
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
The utility used to extract archives including tar.xz is chosen among
'gtar gnutar bsdtar tar' (respectively) that may be present in the
system PATH.
When compiling LibreOffice, there is a possiblity that some bad tools
that are available in the PATH are chosen incorrectly. As an example,
Anaconda on Windows provides a 'bsdtar' utility which can not handle
tar.xz files, but it is chosen as the archive extraction utility.
This patch demotes 'bsdtar' comapred to 'tar' in configure.ac to fix
the issue, which is filed as tdf#147801.
Change-Id: If6aa47b9255a54c1220bbfce6c2515dc53fb795b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130974
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
This moves the properties read during the OOXML import into the
SparlineGroup class (the document model), so a sparkline can
be connected with the properties.
Change-Id: I09ecf560f1870624cb984722bdb8ee306d839dfe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131163
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
This adds a Sparkline class and a SparklineGroup class. The
Sparkline class is added to a cell, and the SparklineGroup
is referenced by the Sparkline, so multiple Sparklines can
share the same properties.
Change-Id: Id309ded34bfa7a35c1be43f7c0543d88594e66ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131162
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Read sparklines and sparkline groups from the OOXML document and
add store it into a (temporary local) doc. model.
Change-Id: Id2d34db70300957735571875d6defb3d560fbb26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131161
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
I.e. unlike footnotes or bookmarks, this is not specific to an opened
document; while the UI only provides the matching menu item only for an
opened document.
Change-Id: I743bee4848a2da030369b9da55e0aae9bd2a86a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131148
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
It fails locally on Windows using 150% scaling with
- Expected: 9419
- Actual : 9437
The original size of page in the PDF is 267.507 x 85.627 pt.
Converting that on 96 DPI gives 356.68 x 114.17 pixels. Without
rounding, that translated to 356 x 114 in vcl::RenderPDFBitmaps.
This adds rounding when calculating bitmap size, giving smaller
error (9446 hmm wide, less than 10 hmm from ideal 9437 mm/100,
compared to almost 20 hmm error before). Also it adds tolerance
to the unit test.
Change-Id: I3cd8f6c0e1235adf2fe1c17f4c56f3667f0132bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131110
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
