mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
414,676 Commits 1 Branch 0 Tags
4eec79bb376b64a9a90de4b6540c90776d3dba32
Commit Graph

414676 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Armin Le Grand
4eec79bb37 RotateFlyFrame: Isolate SwFrame members maFrame and maPrt 
To gain more control over changes of the Writer layout,
isolated mentioned members and replaced all calls with
inline methods for read access. Moved to own class to
also identify 'private' accesses reliably. Added access
dedicated classes for write access, the only allowed
way to do changes. Adapted all usages and made test builds
on logerrit and locally

Change-Id: Ib0b7f852f5176744e860e2aad12dd13c9a906d68

RotateFlyFrame: Migrated from SwFrame::FrameWA to setFrame

Change-Id: I01f7b828fe2134411cc76639e880da46b415d767

RotateFlyFrame: Migrated from SwFrame::PrintWA to setPrint

Change-Id: Ieea3b467f296a190de5b5f47721bef148bebf60b

RotateFlyFrame: Adapted to get/setSwFrame and get/setSwPrint

Change-Id: I6cce40ec49dd5bd32d94fe06b9d2dabd368448be

RotateFlyFrame: Adapted to get methods and WriteAccess helpers

Change-Id: Ife3c1b2391ad7beae8c7f31f796b1454709ddd26

RotateFlyFrame: Moved change executers to cxx

Moved SwFrameRect::FrameWriteAccess::~FrameWriteAccess()
and SwFrameRect::PrintWriteAccess::~PrintWriteAccess() to
implementation side and added compare op's for SwRcet to
write only if needed

Change-Id: I85d0e61009116f4b17d1ce0337e3f0d2cc031159

RotateFlyFrame: Moved change executers to cxx

Moved SwFrameRect::FrameWriteAccess::~FrameWriteAccess()
and SwFrameRect::PrintWriteAccess::~PrintWriteAccess() to
implementation side and added compare op's for SwRcet to
write only if needed

Change-Id: I85d0e61009116f4b17d1ce0337e3f0d2cc031159
 2017-10-30 12:13:17 +01:00
Armin Le Grand
3444a3086c Adapted to get methods and WriteAccess helpers 
Change-Id: Ife3c1b2391ad7beae8c7f31f796b1454709ddd26
 2017-10-30 12:13:17 +01:00
Armin Le Grand
75d4e779e4 Adapted to get/setSwFrame and get/setSwPrint 
Change-Id: I6cce40ec49dd5bd32d94fe06b9d2dabd368448be
 2017-10-30 12:13:16 +01:00
Armin Le Grand
f6edddfa23 Migrated from SwFrame::PrintWA to setPrint 
Change-Id: Ieea3b467f296a190de5b5f47721bef148bebf60b
 2017-10-30 12:13:14 +01:00
Armin Le Grand
46d233c026 Migrated from SwFrame::FrameWA to setFrame 
Change-Id: I01f7b828fe2134411cc76639e880da46b415d767
 2017-10-30 12:13:14 +01:00
Armin Le Grand
94cf446564 Isolated SwFrame members maFrane and maPrt 
To gain more control over changes of the Writer layout,
isolated mentioned members and replaced all calls with
inline methods for read and/or write access. Moved to
own class to also identify 'private' accesses reliably.

Change-Id: Ib0b7f852f5176744e860e2aad12dd13c9a906d68
 2017-10-30 12:13:13 +01:00
Noel Grandin
6f45913394 loplugin:constantparam in svx 
Change-Id: Ifaad1083b1561b2bd908e798e06fbff8bbabbe60
Reviewed-on: https://gerrit.libreoffice.org/44048
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-30 11:58:48 +01:00
Furkan Ahmet Kara
c7660cc543 tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+ 
Change-Id: If0ed3929f8faab187327b90e63014720e287e501
Reviewed-on: https://gerrit.libreoffice.org/43681
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-10-30 11:37:14 +01:00
Furkan Tokac
7939e29b41 tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+ 
Change-Id: I32aab185cd0572353f4d94cfe4b16af25a665ef4
Reviewed-on: https://gerrit.libreoffice.org/43684
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-10-30 11:27:44 +01:00
Caolán McNamara
4319953570 ErrorCode can be a simple int 
Change-Id: Ia0e9cc193be6f49a5a58c2f5ea5c7a5897e8400e
Reviewed-on: https://gerrit.libreoffice.org/44035
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-30 11:18:28 +01:00
Caolán McNamara
56ff9f2082 de-sal_uLong met filter 
Change-Id: Ia9c0051f42801e8017469c77bf3d89672a748115
Reviewed-on: https://gerrit.libreoffice.org/44034
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-30 11:18:00 +01:00
Caolán McNamara
baefc8a1d7 ofz#3896 Integer-overflow 
Change-Id: Ib7d3c8bd1a5db9f6b35e928743a701a9a95403ca
Reviewed-on: https://gerrit.libreoffice.org/44031
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-30 11:17:38 +01:00
Michael Stahl
236b7e19bb git-hooks: don't complain about large .ui files 
Looks legit.

Change-Id: I73562d0a8d863868ae717cee97b6497a93df4ee4
 2017-10-30 10:51:32 +01:00
Miklos Vajna
66eaee557d sw: prefix members of SwUndoMove 
Change-Id: I2938845f3f454c085c3b159b17fb591869eaeac8
Reviewed-on: https://gerrit.libreoffice.org/44045
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2017-10-30 10:25:34 +01:00
Thorsten Behrens
480f72ef45 Revert "tdf#113197 Add MaskPrimitive (clip) to EMF/WMF if needed" 
This reverts commit bdb9cc1702.

Breaks Mac unit tests in sw_ooxmlexport4
 2017-10-30 09:07:51 +01:00
Jens Carl
620f8eb51e Remove obsolete header 
Change-Id: I77ef4bd4a253d4f0722c131f49675e12c3396178
Reviewed-on: https://gerrit.libreoffice.org/44042
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-30 08:35:44 +01:00
Jens Carl
bf50220ac0 Fix xsheetfilterable CppUnit assert 
Change to Logical NOT operator to make
clang loplugin:simplifybool happy.

Change-Id: I95af212ea6fa33be2775824322bd64f04d2ac695
Reviewed-on: https://gerrit.libreoffice.org/44039
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-30 08:34:42 +01:00
Noel Grandin
1ecdddcc32 loplugin:constantparam in vcl 
Change-Id: Ic32e4098dcdae5ca5d7fe2749badedabda86a90d
Reviewed-on: https://gerrit.libreoffice.org/44043
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-30 08:33:39 +01:00
jan Iversen
dd9c17ae21 iOS, make list of allowed file extensions 
Info.plist import/export file extensions handled by
LibreOfficeKit, looped through and created var "KnownDocumentTypes"

Change-Id: I479126a8070490e259c81d32f7dbfe437670fb28
 2017-10-30 08:30:18 +01:00
Thorsten Behrens
08a43cc97c related: tdf#103884 remove gltf/collada feature 
Change-Id: Icd26ad96c0337844ef1463dabfbe791caa00dd2d
Reviewed-on: https://gerrit.libreoffice.org/43972
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-10-30 08:21:55 +01:00
Julien Nabet
8d994f8356 Replace list by vector for m_aSubsets (vcl) 
+ use for range loops for those related to m_aSubsets

Change-Id: I2fa3e3c46394381f5d0bb042481c1884bfe52da9
Reviewed-on: https://gerrit.libreoffice.org/44033
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-10-30 07:16:11 +01:00
Julien Nabet
cf839137d6 Replace some lists by vectors in desktop 
Change-Id: Ib1cd2278d1af651b96f07c8831382bba7f51aed6
Reviewed-on: https://gerrit.libreoffice.org/44037
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-10-30 07:14:23 +01:00
Julien Nabet
f06ca1f2af Following aded98ce3d 
Change-Id: Ie3b30ac96d5a00d5326f954423e6a1096c70cbc8
Reviewed-on: https://gerrit.libreoffice.org/44036
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-10-30 07:13:37 +01:00
Julien Nabet
5b6652f360 Replace list by vector for m_aListeners in gtk3 (vcl) 
Change-Id: I97ad632be7340ae7a628026ae8e8c45d813a49e4
Reviewed-on: https://gerrit.libreoffice.org/44032
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-10-30 07:13:02 +01:00
Justin Luth
9b8a99a188 tdf#92524 ooxmlexport: recognize COL_AUTO for RES_BACKGROUND 
FormatBackground was always returning the actual color
instead of AUTO when the color was COL_AUTO because ConvertColor
is being passed Color.GetRGBColor() instead of just Color.

There are three sections here:
-XML_fillcolor: looks like it accepts values like "green" and
"teal". Unclear from documenation whether auto is allowed.
-XML_srgbClr: only accepts rgb number, not auto
-XML_fill: needs this fix - test document available.

Since the section can't globally handle "auto", I left XML_fillcolor
alone, waiting for a proof bug report.

Change-Id: Idecb6a32fba814a6fb3aeb6cc015d793ba6f8cf9
Reviewed-on: https://gerrit.libreoffice.org/43975
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
 2017-10-30 06:16:24 +01:00
Caolán McNamara
d30522e46c ofz#3895 Integer-overflow 
Change-Id: Ibc90bdad5edf2d382e358dde4a0bfce6e4276584
Reviewed-on: https://gerrit.libreoffice.org/44026
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-30 00:15:37 +01:00
Jens Carl
bbfec269bd tdf#45904: Move Java _XSheetFilterable test to C++ 
Change-Id: Ib94aeb98c9c659118800b2dcc327c44a77d5fcc6
Reviewed-on: https://gerrit.libreoffice.org/44019
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-10-29 23:45:34 +01:00
Jens Carl
ba93d6aeb7 tdf#45904: Move Java _XSheetFilterDescriptor tests to C++ 
Change-Id: If9bbef199f2c698f9ffeb3d57423b66ebd439a94
Reviewed-on: https://gerrit.libreoffice.org/43635
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-10-29 23:45:13 +01:00
Jens Carl
4200896e36 tdf#45904: Move Java _XSheetLinkable tests to C++ 
Change-Id: I0f99c3b4a74748d7f1c73ef584170ae84b08cd9a
Reviewed-on: https://gerrit.libreoffice.org/43582
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-10-29 23:44:53 +01:00
Jens Carl
a0b7cd137a tdf#45904: Move Java _XSheetOperation tests to C++ 
Change-Id: I5aaeebd074882bb05a78e6d4057162e1da61d673
Reviewed-on: https://gerrit.libreoffice.org/43539
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-10-29 23:44:31 +01:00
Julien Nabet
7ff9b44d5d cppcheck: funcArgOrderDifferent 
Change-Id: Ic29d1229a9acdc7412159eab72cb245567a76788
Reviewed-on: https://gerrit.libreoffice.org/44030
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-10-29 23:21:13 +01:00
Jens Carl
d56be38352 tdf#45904: Move Java _XSheetPageBreak tests to C++ 
Change-Id: I29111c3495fc9767d1b2c7bab38af5f89b7840f9
Reviewed-on: https://gerrit.libreoffice.org/43399
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-10-29 22:10:18 +01:00
Jens Carl
410515366c tdf#45904 Move Java _XSpreadsheet tests to C++ 
Change-Id: Idb398c87c89aa9b5613b9952bffde5929c1bc76b
Reviewed-on: https://gerrit.libreoffice.org/43398
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-10-29 22:09:38 +01:00
Jens Carl
8000383104 tdf#45904 Move _XSubTotalCalculatable Java tests to C++ 
Change-Id: I18199a9cc79e6a109c8de0026b37a67f85cf778a
Reviewed-on: https://gerrit.libreoffice.org/42265
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-10-29 22:08:44 +01:00
Jens Carl
a060947e8c tdf#45904: Move _XSubTotalDescriptor Java tests to C++ 
Change-Id: Ie1ec8879972f77c5278992aadf9324f755859d96
Reviewed-on: https://gerrit.libreoffice.org/42096
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2017-10-29 22:08:00 +01:00
Jim Raykowski
33a617aa43 tdf#94464 change text body default line spacing to 1.15 
Change-Id: Icf5dec5f57fe80febd61832b6583829ff9e24086
Reviewed-on: https://gerrit.libreoffice.org/44027
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
 2017-10-29 22:07:32 +01:00
Caolán McNamara
bcad55fcc9 ofz: Divide-by-zero 
Change-Id: I1bf3e17950bda3386514dd5956b89df89565b780
Reviewed-on: https://gerrit.libreoffice.org/44024
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-29 22:05:08 +01:00
Caolán McNamara
4ee4c599a3 ofz#3883 Integer-overflow 
Change-Id: Ie1fd6617d6e598c6e2cfa8a83a0ffe16948e1efd
Reviewed-on: https://gerrit.libreoffice.org/44022
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-29 21:24:41 +01:00
Caolán McNamara
6e4fc05089 ofz#3889 Divide-by-zero 
Change-Id: If02a4bd6d168e9b1d4574cfc730ecc24011eab62
Reviewed-on: https://gerrit.libreoffice.org/44023
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-29 21:24:07 +01:00
jan Iversen
fb88fbbe2b iOS, problem with menu control 
storyboard and code had diverted.

Change-Id: I39d3db81f2c133a355c961a24cf7ed1409630b83
 2017-10-29 19:46:30 +01:00
jan Iversen
64f9ae5510 iOS, added missing link to Info.plist 
Added Info.plist to project file, interesting that
even without a reference xCode uses the file, only
it cannot be edited

Change-Id: I16094fe8f32f79eb2ea4fe7c758745619b0eb04e
 2017-10-29 19:46:30 +01:00
jan Iversen
c8d1c4350b iOS, tested document open from 3rd party app. 
This patch allows integration of 3rd party app.
if e.g. in mail and clicking on a OO document, LibreOfficeLight will
open and present the document

Change-Id: I86c77cd3af3aac41fda441b7c5625a2063343971
 2017-10-29 19:46:29 +01:00
Jochen Nitschke
feb6cfb104 cppcheck: unusedVariable 
Change-Id: I0fcfd512b7abce38a6865c93f6147658b7dfe493
Reviewed-on: https://gerrit.libreoffice.org/44020
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-29 17:23:53 +01:00
Caolán McNamara
f0cc59c02e undo semi-revert 
Change-Id: Ifc332d34d23cdc1bb5be80f7cfe440bdc6a12d23
 2017-10-29 15:26:14 +00:00
Arkadiy Illarionov
a6750166cd tdf#94695 Replace gethostbyaddr with getnameinfo 
Change-Id: I7ac99a6f470998364e9e43b749a0914d8a3fc096
Reviewed-on: https://gerrit.libreoffice.org/42769
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-10-29 15:51:10 +01:00
Caolán McNamara
fc4f2f1b0f ofz#3868 Integer-overflow 
Change-Id: Id5de484e365567487cdeaf73f9fa88ef5a735e3e
Reviewed-on: https://gerrit.libreoffice.org/44011
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-29 14:07:44 +01:00
Ashod Nakashian
dc55f0618c TSCP: skip empty classification sections 
When the user inserts some classification text
into the editbox in the classifcation dialog then
deletes, EditEng is giving us an empty section.

This is to skip it, since it's completely superfluous.

Change-Id: I522f05d0a270cd2bd9892235ad3cb40a88b295ac
Reviewed-on: https://gerrit.libreoffice.org/43888
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-10-29 13:12:28 +01:00
jan Iversen
1f78846481 iOS, documented DocumentActions 
Documented the popover menu
Corrected to reflect the current menu entries

Change-Id: I41283fe013cc2593e07f53e0e4fc779eff845a66
 2017-10-29 13:06:42 +01:00
jan Iversen
ba73d5e72e iOS, completed doc of DocumentController 
Added "close" menu
moved popover menu class to own file
solved clang problem with C headers () is not permitted (void) is

Change-Id: Id4f5053e325e2952171e10b0ca7f995447955748
 2017-10-29 12:31:22 +01:00
jan Iversen
adff386389 iOS, added dummy calls for LO 
In order to speed up UI work, a dummy source is added.

Change-Id: Ic226b1365681ac65036729a672c97aa5579ed118
 2017-10-29 11:21:11 +01:00