Commit Graph

367962 Commits

Author SHA1 Message Date
Caolán McNamara
6acd5c45c7 Resolves: fdo#87601 specific html doc hangs on load
Change-Id: I67f472d72efe123b533d4d94be0084986c0e8349
2015-01-21 15:25:03 +00:00
Caolán McNamara
b97d9a1238 slot:5500 -> .uno:NewDoc(FromTemplate)
try and strip out the slot:5500 magic/lunacy

Change-Id: I7236c83fba6cb8264f76aca90242775a3de58645
2015-01-21 14:49:42 +00:00
Caolán McNamara
1dbc6d05de Resolves: fdo#87636 New button not clickable when Templates preselected
regression from

commit 57207cab00
Author: Ariel Constenla-Haile <arielch@apache.org>
Date:   Tue May 28 10:01:32 2013 +0000

    Add missing copy&paste of SfxAppToolBoxControl_Impl::Select

    (cherry picked from commit 47204c74d9e52f54f6983af19b66af2a96b42e61)

    Conflicts:
        framework/inc/uielement/popuptoolbarcontroller.hxx
        svtools/inc/svtools/toolboxcontroller.hxx

The menu shown in the ui is a copy of a menu. The original menu has UserData
set on it which contains the target for the command, but the copy doesn't, so
looking up the target always fails and ses the "_default" frame and not the
correct "_self" required for the template menu

Change-Id: Ic1887467bf15f081d27286bd284929c17a2b19ad
2015-01-21 14:49:41 +00:00
Stephan Bergmann
44b2fb6d0b RotateAngle of UNO type long
Change-Id: Id3aec16d17b55366c2a35810b21b0a1c73439741
2015-01-21 14:51:11 +01:00
Stephan Bergmann
ed8110e101 Avoid reinterpret_cast to same type
...as GCC 4.6 reports "error: invalid cast from type 'pthread_t {aka long
unsigned int}' to type 'long unsigned int'" despite [expr.reinterpret.cast]/2:
"An expression of integral, enumeration, pointer, or pointer-to-member type can
be explicitly converted to its own type; such a cast yields the value of its
operand."

Change-Id: I26f1a3e6df2f0e55c665ad4f49185e0ebf432e95
2015-01-21 14:28:53 +01:00
Gary Houston
921cea89da fdo#87488 Wrong text rotation inside a preset shape from docx
Preset shape text rotation values are read in a few places and stored in
moRotation. With these changes, moRotation is always read unchanged, but
multiplied by -1 when it's used.

Change-Id: I633d665c21daa69e15fa828a43300f10d2bf2054
Reviewed-on: https://gerrit.libreoffice.org/13561
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-01-21 13:22:11 +00:00
Stephan Bergmann
1ca9c116ec loplugin:cstylecast (on Mac OS X, where pthread_t is a pointer type)
Change-Id: Ie4474a1bae02de88ea0c79510f3730d2f829239c
2015-01-21 14:06:19 +01:00
Stephan Bergmann
4698eeea35 SwSection::GetFmt const-correctness
...otherwise, wouldn't make sense to have non-const/const overloads anyway.
Needs to introduce one const_cast into doctxm.cxx (which already contains quite
a handful), otherwise the required changes would turn into too much of an
avalanche.

Change-Id: I694c7a1df7089d83ee95d35ed09bb864e9703f7c
2015-01-21 14:03:43 +01:00
Stephan Bergmann
ce67bc61da Some more loplugin:cstylecast: writerperfect
Change-Id: I5bdc5f147e507d4ac1626133e653bdc9addb5571
2015-01-21 14:03:43 +01:00
Stephan Bergmann
f53972b028 Some more loplugin:cstylecast: starmath
Change-Id: I0d1c743343d8f84c0491957ad43d8b16d9490622
2015-01-21 14:03:43 +01:00
Stephan Bergmann
c4b3801c22 Some more loplugin:cstylecast: sd
Change-Id: I3562efaab55655bc758fe94090b2b6d05b548098
2015-01-21 14:03:43 +01:00
Vort
42bb1308ff Also ignore Visual Studio 2013 files
Change-Id: I21bba16d70f9f8c43b60b2bd2a5005a888d0c11d
Reviewed-on: https://gerrit.libreoffice.org/14073
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-21 12:36:30 +00:00
Caolán McNamara
f21114332b has_focus is not implemented, remove uses
Change-Id: Iebd4d28471d85696328cb7772fec0bc793493bf4
2015-01-21 11:31:26 +00:00
Caolán McNamara
4b2daa1cd5 Resolves: fdo#88562 convert filename widget from ro-edit to selectable-label
Change-Id: I56205bf5c28b6196aae10ecfa658111768f0e433
2015-01-21 11:31:26 +00:00
Caolán McNamara
eeccf1be6a Related: fdo#88562 Nothing actually sets ID_FILETP_READONLY or ID_FILETP_TITLE
so docs cannot be toggled r/o r/w from properties page or the file name
changed. Unkink the logic a bit based on that and move now static widget
settings to .ui and remove unused checkbox

Change-Id: Ic55e41be8ffd02e214a233a2eb90736c070b5418
2015-01-21 11:31:26 +00:00
Stephan Bergmann
7cb5b21174 loplugin:cstylecast
Change-Id: Ib8575109cfe0339f2d8b56741d3ad2a538ecf164
2015-01-21 12:29:36 +01:00
Michael Stahl
d76a8ba0b5 sw: make SwTxtNode::RstTxtAttr() easier to understand
Trying to figure out whether the other 2 asserts could trigger, the idea
to just delay everything that could potentially re-sort the array and
thereby invalidate the current iteration index seemed appealing.

Should be faster too: the main loop now looks at each hint only once,
but deleting a hint now requires a O(log(n)) GetStartOf() lookup.

Change-Id: I5c7b8493b35ee71c8ebdc284d2508c9812dc29cf
2015-01-21 12:00:50 +01:00
Michael Stahl
01d25c96db sw: fix bogus assert in SwTxtNode::RstTxtAttr()
The assert for case 3 is wrong and fires when importing ooo44732-2.doc
but there is also a bug here where a hint could be skipped.

Change-Id: I028d2d5df9e80cf0001d9bc11aa7fabcd01e83bb
2015-01-21 12:00:50 +01:00
Caolán McNamara
b5f607a4aa callcatcher: update unused code
Change-Id: I225cbb3a4a66a8f20bec91c4770ad78e72b663b1
2015-01-21 09:40:33 +00:00
Ariel Constenla-Haile
5ce9606a66 Resolves: #i46871# Add French translation for Space key
(cherry picked from commit 58c7172ef98515e482bc87e219e58e1e126785d8)

Conflicts:
	vcl/unx/generic/app/keysymnames.cxx

Change-Id: Id8b9aa912cd3de9d69bddb0316c73d19ffcc4769
2015-01-21 09:28:06 +00:00
Caolán McNamara
4be8eae04e Resolves: fdo#88594 crash on F1 with local help
regression from

commit 1049511c0c
Date:   Tue Jan 13 21:43:27 2015 +0900
    infobar: add buttons one by one with addButton

Change-Id: Icf758a9671191836bbe5bc7ca7d978574cb74479
2015-01-21 09:26:42 +00:00
Miklos Vajna
7fe28b2c7b Factor out SwFmtPageDesc::dumpAsXml() from docnode
Change-Id: I813804ece7507fef84c43ba8fc290b151c8063ab
2015-01-21 09:35:28 +01:00
Michael Stahl
60143f4f7b sw: add unit test for 5c363cf3f1
Change-Id: If83f4900fcecde07f75d88c7f0b7c9088974b093
2015-01-20 22:36:34 +01:00
Eike Rathke
ef9d28a360 it's unnecessary to obtain the marked object in move mode, fdo#88339 followup
... just to determine there's nothing to do in that case.

Change-Id: Ic962a5420afc5216e750b7fb578a4844ab6fc54a
2015-01-20 21:39:59 +01:00
Niklas Johansson
46f51b4659 Add documentation for AccessibleStates STALE, OFFSCREEN and COLLAPSE
Change-Id: I6bfcd180f0c1d9e63577f58685ce64c509d91326
Reviewed-on: https://gerrit.libreoffice.org/14055
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-20 20:35:48 +00:00
Caolán McNamara
24c7c11cd1 fix SwIndexReg::~SwIndexReg assert in fdo68332-2.docx
SwParaSelection sets a mark on the cursor, but there is no need to do that.
DelFullPara will delete the SwTxtNode anyway.

Change-Id: I99b8dd637bd4d2b49a555e147514a2def19fa0bf
Reviewed-on: https://gerrit.libreoffice.org/14054
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-01-20 20:32:52 +00:00
Michael Stahl
4398cc8394 vcl: remove dependency of SalShlData on GetVersionEx()
4500afcc1b was incomplete in that the
result of GetVersionEx() is actually stored and other functions do
manual checks on it.

Change-Id: I1f66a13e98e6bfc40bc35fa5382c2f6257f905d6
2015-01-20 20:31:00 +01:00
Eike Rathke
8825e95a44 change assert() to SAL_WARN_IF()
It's a valid condition in some cases.

Change-Id: I9c9bbcf0b506a88f89e4a420dd544e4bc6502e58
2015-01-20 19:47:47 +01:00
Ashod Nakashian
5c363cf3f1 Maintain the sorting in sorted_vector after modifying the elements.
Resort immediately after modifying the data to prevent invalid lookups.

Change-Id: If132af401d8164fd5973d81a8327c1fa726c908c
Reviewed-on: https://gerrit.libreoffice.org/13984
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-01-20 16:53:40 +00:00
Caolán McNamara
4345a3de0e Resolves: fdo#84943 make fodt non crashy like odt for formulas inside shapes
where odt checks for a null pTxtCrsr and skips the object and fodt
just ploughed ahead. i.e. make fodt equally useless as odt (fdo#84942)

Change-Id: I915cc1f7c065ea83377e895a932636c82698cf1f
2015-01-20 16:18:55 +00:00
Tor Lillqvist
bff635be1d Make the RAND() and RANDBETWEEN() Calc functions non-random when requested
We don't want such a mode to affect other uses of randomness, though. Thus use
a separate random number generator object for these two functions, and use a
fixed seed for it if the SC_RAND_REPEATABLE environment variable is set.

As RAND() is implemented in sc, and RANDBETWEEN() is implemented in scaddins,
it was a bit hard to figure out where to add the new functions needed, without
having to over-engineer things with UNO. (This functionality is totally
Calc-specific, but neither sc nor scaddins has any public (non-UNO) API.)
Caolan suggested the formula module, which seems like a good enough place to
me.

Change-Id: I4b0cb327392e51a18bce28478af91b0174d6b726
2015-01-20 18:12:38 +02:00
Caolán McNamara
f1cf63c223 OSL_ENSURE->SAL_WARN_IF where conditional deref follows
Change-Id: I2648b0357c13699df2693968db4e57c81028c962
2015-01-20 15:58:24 +00:00
Caolán McNamara
0f297e20d1 OSL_ENSURE->assert where unconditionally deref follows
Change-Id: I0cb2400e7ebb28cad2c98f9e69d68d312efb03ca
2015-01-20 15:57:58 +00:00
Caolán McNamara
37e4920a31 continue to implement drawChar for unpatched popplers without drawChar2 hack
Change-Id: Id4ad86f3f563d88777352722e397cd77cfad45e4
2015-01-20 15:48:05 +00:00
Caolán McNamara
26bd210ccd Related: ooo#34420-1.sxi concealed divide by zero
on this and about 30 other documents where the NaN result is cast back to a
long, giving rise to an assert in vcl/source/outdev/map.cxx:391 of

long int ImplLogicToPixel(long int, long int, long int, long int, long int):
Assertion `std::abs(n) < std::numeric_limits<long>::max() / nMapNum / nDPI'
failed.

Change-Id: Ia87e4ee6bbf0f10b7eba513e9a5ba3c42440d181
2015-01-20 15:16:29 +00:00
Caolán McNamara
ca36f09c71 textranges are always in pairs
Change-Id: I3d98c26c7902bc89ab6701dd02e266fd466c6907
2015-01-20 14:25:28 +00:00
Winfried Donkers
104a1e6415 fdo#88547 allow inline date-arrays for array functions
Change-Id: I090633944f6514964949566ffe94038b565abff4
Reviewed-on: https://gerrit.libreoffice.org/14019
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-01-20 14:21:30 +00:00
Vort
7818c73445 fdo#85174 PDF Import: fix character positions
Change-Id: I0aa75b6cb834341e47bbeeaa15d39387a8cb5240
Reviewed-on: https://gerrit.libreoffice.org/14029
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-20 13:55:04 +00:00
Tsutomu Uchino
d8915be647 Resolves: #i116863# remove the extra space before colon...
in the label for date number format

(cherry picked from commit 2c11fc40e0500da7fc217e1bc1290adfdccab82f)

Conflicts:
	officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu

Change-Id: I8e5b6a141948fbce8361b74a3f29db3cdf7d71f4
2015-01-20 13:41:00 +00:00
Juergen Funk
282baa9012 Remove unused code
- a inline function not use
- a variable will be set but not use

Change-Id: I67674a6cd05ddb058d11d46188d5c9d039ed40fb
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-01-20 14:38:37 +01:00
Caolán McNamara
6cf58a3367 accidentally ran make with VALGRIND set and walked away...
and found this bug triggered by CppunitTest_filter_eps_test when
I got back

Change-Id: I20943e5bd0fbf8aed923699dd5f1e88fada43e81
2015-01-20 13:32:33 +00:00
Caolán McNamara
40809ce469 move OutputDevice:: Clear/Refresh inside AddTempDevFont
and drop now redundant

ImplClearFontData(true);
mpFontCache->Invalidate();

which is done on entry

Change-Id: I217c203980e5fd6a54b85f1b1376ecc2b92181db
2015-01-20 13:32:33 +00:00
Caolán McNamara
20142afafc font cache gets broken on adding an embedded font
Change-Id: I665cde5d4c89443238efb283c86277dedf621197
2015-01-20 13:32:32 +00:00
László Németh
352cdc8bf8 fdo#88623 replace std::deque with std::vector in xlsx saving
Change-Id: I0b9c44b405e2c617c60e11a1a15eaeb867cba57e
2015-01-20 12:44:22 +01:00
Markus Mohrhard
33af00a9ae bail out early if there is no Display
Change-Id: I1d724ae9346a4df7207e737cf98bf0cd7293bc2b
2015-01-20 12:35:50 +01:00
Michael Meeks
b398945d08 scaddins: quick fix for conflict on ConvertData.
Also used by VCL image plugins - defer the rest to an easy-hack.
Mostly impacts mobile which uses scaddins linked without a map file.

Change-Id: I49fd40146905f4de42c9b0e7355ab89689c776bf
2015-01-20 11:27:16 +00:00
Markus Mohrhard
229891d6cb lets do that before we delete our object
Change-Id: I8c7166ba66f74f5c548bb6fb30dfc3d28880e9a2
2015-01-20 12:03:57 +01:00
Markus Mohrhard
145ad19643 some debug code for finding leaked OpenGLContexts
Change-Id: I10e8c344ae6aa2e0a4ef562154f57e2070c70e2f
2015-01-20 12:03:57 +01:00
Markus Mohrhard
99f809c7eb I was just missing the code for the ARB version
Change-Id: Id1a7eef76967a9fdc5279d3c5e7694e6c6b2b907
2015-01-20 12:03:56 +01:00
Markus Mohrhard
9becabc9bd only enable these error handlers in dbgutil builds
They might become expensive with our repeated calls to makeCurrent

Change-Id: I1d30460f2cad34c6ab676754682651422e545c90
2015-01-20 12:03:56 +01:00