364292 Commits

Author SHA1 Message Date
Caolán McNamara
6b709b27b3 coverity#735399 Logically dead code
we can only enter the bAssumeExprLParenMode controlled block once
because the block sets bAssumeExprLParenMode to false

bAssumeExprLParenMode is only true if the first token read in the
method is LPAREN

so we can only enter this block if the current token is LPAREN and
its the first token processed, so the token can't be BYVAL

Change-Id: I6e668fca4d127d7dbfe447e2d9f2231e05278a7d
2014-11-17 14:53:24 +00:00
Caolán McNamara
9d3c54c981 OSL_ENSURE->assert where guaranteed deref follows
Change-Id: I241e13cbf440c1a7e208c2646ded7bf2628ca25b
2014-11-17 14:53:24 +00:00
Caolán McNamara
43d6da691f coverity#1242523 we just need a copy here
Change-Id: I238756de13a5bd2711538cbd92e78bbae8fced22
2014-11-17 14:53:23 +00:00
Caolán McNamara
0f83c393d3 coverity#1242810 Untrusted loop bound
Change-Id: I457f0f92dc32630e52efbb2bd068208a8570c5d0
2014-11-17 14:53:23 +00:00
Caolán McNamara
357f9d22a0 give all the open-url scripts the same starting permissions
Change-Id: I35fcb2d73accf20baa96b62d99be6d0a3ebb3ba2
2014-11-17 14:53:23 +00:00
Caolán McNamara
20dab428f8 drop gnome-open-url binary
we don't really need it anymore, fallback to our own open-url
if there is nothing else to take it

Change-Id: I7a4e841a53bda30e29d48b9c34d24af085f1b4b5
Related: coverity#706194 Use of untrusted string value
2014-11-17 14:53:22 +00:00
Caolán McNamara
5208856b3b document coverity#706181 Use of untrusted string value
Change-Id: If8c80568175b3a5380ee78dda5ebd161c5dba2f6
2014-11-17 14:53:22 +00:00
Caolán McNamara
60b3d8119c third argument should be SfxFilterFlags
Change-Id: Id0a73ffbbddc7fd2b2190cc04f59769561f45dd0
2014-11-17 14:53:22 +00:00
Caolán McNamara
639f6dcb1f coverity#705177 Missing break in switch
this is the "close toolbar" button on right clicking a toolbar.
close toolbar continues to work as expected

Change-Id: I436fbe9f133442136b6e60a1f6080926f64eaef6
2014-11-17 14:53:22 +00:00
Caolán McNamara
bf5bb66fbf coverity#1251174 help coverity out here
Change-Id: I07d6d0356ee0093f7f10a7dfbbc37a620205f37a
2014-11-17 14:53:21 +00:00
Caolán McNamara
b21b723c7c coverity#738972 rework to help coverity out
Change-Id: I288eb5ba7a38844af1b517ae7480729c236ebd63
2014-11-17 14:48:00 +00:00
Caolán McNamara
10bde6bcff coverity#704257 Logically dead code
since

commit 4939fe9653430ae002056ca1481aa1716da1b368
Date:   Tue Jan 29 14:23:27 2008 +0000
    INTEGRATION: CWS dr58_SRC680 (1.32.188); FILE MERGED
    2007/10/25 10:41:26 dr 1.32.188.1: #i81396# do not hide rows with default height

Change-Id: Id185ae2ee37d1db8aaab493f7fc6a81d93424182
2014-11-17 14:48:00 +00:00
Matúš Kukan
d743004ac4 missing include
Change-Id: Iac01fc756a74cbaeebd1d9a01ddea74bbaf18f4b
2014-11-17 15:40:58 +01:00
David Tardon
06efeee90c use already existing variable
Change-Id: I3f2781e2a041845e732046ea591a15c9bb21f1a5
2014-11-17 14:50:18 +01:00
David Tardon
e164eb5c85 coverity#1251174 untrusted pointer read
Change-Id: I894fc64d6ae6881347bd1379d2934654536a01cf
2014-11-17 14:50:18 +01:00
Matúš Kukan
71fae5db27 Add internal libjpeg-turbo library to be used instead of libjpeg
Unfortunately requires nasm - the netwide assembler -
http://www.nasm.us/

Upstream libjpeg-turbo is meant to be built with CMake on Windows but
thanks to our gcc-wrappers we are able to avoid that.

jpeg is kept mostly for platforms we are cross-compiling to. For now,
it's used also for Mac OS X because jpeg-turbo does not build there,
which should be fixed later.

Change-Id: Id87b7072a8acc2578c3abf7e82cb1499e5094dbf
2014-11-17 14:47:57 +01:00
Chris Sherlock
65f41639e2 vcl: remove AnimViewList_impl typedef also
Another typedef that destroys code readibility. I've removed AnimViewList_impl
because it's just a vector of ImplAnimView pointers.

Change-Id: I97e5867e1a7aeae575e45989ba7436867da9c808
2014-11-18 00:43:23 +11:00
Chris Sherlock
725150f4ad vcl: remove AnimationBitmapList_impl typedef
Severe overuse of typedefs makes baby Torvalds sad. :-)

AnimationBitmapList_impl is just a typedef to a vector of AnimationBitmap
pointers. It's used precisely once in the code - in animate.hxx. This just
makes reading the code more difficult - too many layers of abstraction.

Change-Id: If84892dc90220c7dfe8c071d629268efa226f069
2014-11-18 00:43:23 +11:00
Stephan Bergmann
c9518656af loplugin:unreffun
Change-Id: Ifc7377fe1bb68b21e462818248706f53347b39b1
2014-11-17 13:43:56 +01:00
Tor Lillqvist
f71aa1adc8 WaE: unused variables
Change-Id: I82570a716a0dba6c466bc754ce66ac53e7c17efa
2014-11-17 14:24:16 +02:00
Tor Lillqvist
46eb0952f1 WaE: Unreferenced function definition [loplugin:unreffun]
Change-Id: I55d6d1d403622e5ec04c29dd407274cf9db20c40
2014-11-17 14:10:45 +02:00
Michael Stahl
8b50d6b176 bridges: get at least the x86 bridge to build
Change-Id: Idd2f223e0c83e0a6a19e70bd677058b6899bf766
2014-11-17 12:50:00 +01:00
Stephan Bergmann
1fc7a1d532 cid#1254675 Uncaught exception
just throw up hands in despair via std::abort instead of std::runtime_error

Change-Id: I356932ed2d76558bb4febbd2ac0a7bb6ea27bd0f
2014-11-17 11:57:43 +01:00
Stephan Bergmann
c34322b525 Missing include
Change-Id: I1dbf7a73ec60115f11d3a5455de2871041cd1605
2014-11-17 11:44:05 +01:00
Tor Lillqvist
e6a441ccc1 Insert some fairly generic fallback whitelist entries for now
Change-Id: I1887a32aeef8097e3e8297d6bddc51179dd65127
2014-11-17 12:18:54 +02:00
Stephan Bergmann
fbe3a3cf60 -Werror,-Wunused-const-variable
Change-Id: Ic6a8f6435e00c7b679c58bdfe57da4555107787d
2014-11-17 11:16:28 +01:00
Michael Stahl
e9a7ff9880 salhelper: include-what-you-use cleanup of public headers
Change-Id: Ie778e541cecadeefc5ee5f30af9577a00c870a58
2014-11-17 11:06:53 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Michael Stahl
30f3b36e07 sal: remove pointless checking for __cplusplus in public C++ headers
Change-Id: Ibbcdb4a3f46b7491396a1b1c7b4cdc1af05f30d3
2014-11-17 11:06:51 +01:00
Michael Stahl
b3e5b5941f bridges, vcl: turns out there is sal/alloca.h; replace #ifdefery
Change-Id: I2eda8dab51e66af7856b55f2d5f297620e07ccdb
2014-11-17 11:06:51 +01:00
Michael Stahl
096c7e889f add a script to generate a dummy library to "build" all headers
... to be used together --with-iwyu to track down bloat in headers,
which are not always named in the convention that include-what-you-use
expects for reporting issues.

Change-Id: Idffda7d49cca43170717004d52779b4663de19ae
2014-11-17 11:06:50 +01:00
Michael Stahl
4213b9b38b gbuild: print better file name for generated C++ source
Change-Id: I7b028ff3af6c5cd6c48b4cf6095a16b57745db8c
2014-11-17 11:06:50 +01:00
Michael Stahl
8a8dd1c7d1 bin/run: add a license header
Change-Id: I5461a0d4e372260623ebb8833d60a9dc318757dd
2014-11-17 11:06:50 +01:00
Michael Stahl
3121b8b77e "#pragma hdrstop" looks quite obsolete
Change-Id: Id4b01f02d5d90215164c07b8076498df65978fa3
2014-11-17 11:06:49 +01:00
Stephan Bergmann
1b3f795c8e suspicious cast from 'bool' to 'sal_Bool' [loplugin:salbool]
Change-Id: I28b52faa71bb198ee34ae4893e4610aa83773645
2014-11-17 11:04:56 +01:00
Stephan Bergmann
d8a8149e15 warning C4189: local variable is initialized but not referenced
Change-Id: Id87af31e9b60d548959ba735b635ff3d154fc587
2014-11-17 11:02:01 +01:00
Matthew J. Francis
e43f692ef9 fdo#85478 Avoid destroying bitmaps after VCL is shut down
Change-Id: I1ece738e7f60b6bbbdc802339f8b9deec9396e1b
Reviewed-on: https://gerrit.libreoffice.org/12469
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17 09:57:27 +00:00
Matúš Kukan
0843ade74e package: Do not bother with deflating jpeg images
It takes a lot of time and we can save ~1% of size if at all. Rather
store them uncompressed in the zip file.
With png, we can save a bit more, although it's still only about 4% - 8%?

Change-Id: I43a3e3812882e4ce85e7af9d0aaab454d98c4860
2014-11-17 10:49:24 +01:00
Matúš Kukan
d09b6209f1 package: Do not deflate small streams in a thread
Change-Id: Iae804a34f344aa793a6d5c13315f7bc1eb64c0a2
2014-11-17 10:49:24 +01:00
Matúš Kukan
062cf18702 ZipPackageStream::getRawData can be private
Change-Id: I66cbbfb2aa6abc6c8ebe34d9ea69855436c23edd
2014-11-17 10:49:24 +01:00
Matúš Kukan
7088166a67 Simplify input parameters to just take the sequence
Change-Id: Ic2538ca8b0f7261064e1dfbf3884dd452003c797
2014-11-17 10:49:23 +01:00
Matúš Kukan
a42aa52acb package: Add possibility to disable deflating in a thread
Change-Id: I4d98b6f8b3315b731206700eb65f08463299dda3
2014-11-17 10:49:23 +01:00
Matúš Kukan
fbf714b456 package: Finally implement parallel zip entries deflating
For that:
1, create ZipPackageStream::successfullyWritten to be called after
the content is written
2, Do not take mutex when reading from WrapStreamForShare - threads should
be using different streams anyway, but there is only one common mutex. :-/

Change-Id: I90303e49206b19454dd4141e24cc8be29c433045
2014-11-17 10:49:23 +01:00
Matúš Kukan
db5552631b package: Call writeLOC always after putNextEntry explicitly
Preparation step to parallel deflating.
Rename putNextEntry to setEntry and make it a static function.
We need to call setEntry before starting thread but writeLOC after.

Change-Id: I99a9ffa7dc4c18b47c621847b48bf8469bfb789a
2014-11-17 10:49:22 +01:00
Matúš Kukan
30f80f12fb package: Do not use hacky bit 1<<4 in ZipEntry::nFlag
Change-Id: I504f5c0c9aa9b655ffb53d9820a33677dad6aa08
2014-11-17 10:49:22 +01:00
Matúš Kukan
ef8e7eabe1 There is no XZipOutputEntry interface
Change-Id: Ib8fa3351ba25416a13d6c8bf63bd5fc8e43703c5
2014-11-17 10:49:22 +01:00
Matúš Kukan
3e3b8483d7 package: Use memory stream for compressing zip entries
Change-Id: Ibf81dc3cd8a9a9da3dfd6ee6e587a522c4d56a44
2014-11-17 10:49:21 +01:00
Matúš Kukan
3e7ab1ac1d ZipOutputEntry: m_pCurrentEntry is always set
Change-Id: Ib6a69a83f4a378df838b2231b9eba7fba49cd9f1
2014-11-17 10:49:21 +01:00
Matúš Kukan
4d1cb2dc5f package: Zipping STORED entry is the same as rawWrite and we don't encrypt it
Change-Id: Ie3f8ac261a70c9a2b5182fc7d36938d0a46ec045
2014-11-17 10:49:21 +01:00
Matúš Kukan
2d92a84a6a package: Move most ZipOutputEntry's methods back to ZipOutputStream
We want to use ZipOutputEntry only for deflating (and maybe rename it).
ca13a9377e4a36436e4c82bb33648d0f3b6db6f5 was not a good idea because the
data still needs to be written sequentially anyway. Otherwise it's hard
to get offset positions of individual entries right.

Since this commit rawCloseEntry needs to be called always; also when we
use write&closeEntry because we don't call writeEXT in closeEntry
anymore.
Need to rename and add comments later.

Change-Id: I03bd48ca6e108e6253a77a137746165909ca3c3d
2014-11-17 10:49:20 +01:00