725 Commits

Author SHA1 Message Date
Noel Grandin
4712396b3b loplugin: defaultparams
Change-Id: I906912f29448bfc72e8139546aa09525c959867f
2015-08-11 09:48:17 +02:00
Noel Grandin
9d307abeec new loplugin: defaultparams
find places where we do not need to be passing a parameter to a
function, because that function has a default value which matches the
value we are passing.

Change-Id: I04d1fd6275204dd4925e6563282464f461123632
2015-08-11 08:25:33 +02:00
Noel Grandin
9c1f700aff improve refcounting loplugin to check SvRef-based classes
Change-Id: I2b3c8eedabeaecd8dcae9fe69c951353a5686883
Reviewed-on: https://gerrit.libreoffice.org/17521
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 11:26:04 +00:00
Noel Grandin
403c13487c loplugin:unusedmethods
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 09:39:22 +00:00
Stephan Bergmann
1caec42837 -Werror,-Wunused-parameter
Change-Id: Iede9204bf93014e757c4fdf4a8363a90b7577dbc
2015-08-04 10:34:50 +02:00
Noel Grandin
3d5dc80b07 fix crash in refcounting plugin
introduced by commit c15b4cf39a74176cee64795129d76f411d2c0a69
"Adapt to current Clang trunk towards 3.7"

Change-Id: I00f58d3bc79e641df9bba4e9b1d5c8463b87dc42
2015-08-04 10:25:48 +02:00
Stephan Bergmann
b9d0fe1cec Workaround for libc++
Change-Id: Iee5243231d695299609ca31741f6da2d517f524f
2015-08-04 09:39:36 +02:00
Stephan Bergmann
a2052db259 Workaround for ObjCIvarDecl problem
Change-Id: I7eb0fccce4b8268e5d9559b2eb12778d0d288c6b
2015-08-04 09:38:44 +02:00
Stephan Bergmann
c15b4cf39a Adapt to current Clang trunk towards 3.7
Change-Id: Ibb2c641d49a1773be789c9259f53a040db6f605f
2015-08-04 09:36:32 +02:00
Noel Grandin
2660d24a07 new loplugin: refcounting
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03 06:37:16 +00:00
Noel Grandin
a45827b230 loplugin:unusedmethods
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30 06:23:00 +00:00
Noel Grandin
38023af6c1 loplugin:unusedmethods
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a
Reviewed-on: https://gerrit.libreoffice.org/17312
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24 10:36:20 +00:00
Noel Grandin
96d44c9b07 loplugin:unusedmethods sc
Change-Id: I7bdb1889a942d63370731764a58f4ab524dedd8a
Reviewed-on: https://gerrit.libreoffice.org/17287
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-22 13:02:57 +00:00
Noel Grandin
407731c9f4 loplugin:unusedmethods sw
Change-Id: Ied51535fa169451fc4991237122817a34a59f6fe
Reviewed-on: https://gerrit.libreoffice.org/17256
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21 13:30:13 +00:00
Noel Grandin
f3872352b3 fix my previous commit
Change-Id: I287d99a46eda90718a3c4ec2c92f7b063babeb24
2015-07-21 14:43:01 +02:00
Noel Grandin
07645b443a workaround clang-3.5 issue in unusedmethods loplugin
Change-Id: Ie67518536932e24e9cff7a8b75b42e90e9f67673
2015-07-21 14:39:35 +02:00
Noel Grandin
3d2f43438d loplugin:unusedmethods sd
Change-Id: I9b5399ace50db3259df2e619f28ae547a38e6c6d
Reviewed-on: https://gerrit.libreoffice.org/17254
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21 09:05:41 +00:00
Noel Grandin
6ea66657eb loplugin:unusedmethods writerfilter
Change-Id: I52441115e14da6c1bcd7ba4926a0f3cc0620366e
Reviewed-on: https://gerrit.libreoffice.org/17236
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21 07:58:51 +00:00
Noel Grandin
c714b43b01 loplugin:unusedmethods oox
Change-Id: I5381e0da0efc1f951e248cfcfb35fc680ace94e4
Reviewed-on: https://gerrit.libreoffice.org/17225
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21 06:50:55 +00:00
Noel Grandin
e103bf6cfd loplugin:unusedmethods dbaccess
Change-Id: Ifa16acc6d90ebd4f56c5662959010f6228228cb5
Reviewed-on: https://gerrit.libreoffice.org/17209
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20 11:56:11 +00:00
Noel Grandin
600ed089e2 loplugin:unusedmethods sfx2
Change-Id: I40be06a4859a38ef64b6267515917f625a5f176d
2015-07-20 10:57:07 +02:00
Noel Grandin
9f4f237a38 loplugin:unusedmethods svl
Change-Id: If86cc43fda4d138cf7f678d81fa2b35f68f3c03b
Reviewed-on: https://gerrit.libreoffice.org/17162
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20 06:33:44 +00:00
Noel Grandin
0f732c41bc loplugin:unusedmethods lotuswordpro
Change-Id: I17927d48a75c332f1ddc3853145b14daac17f9c0
2015-07-17 11:50:06 +02:00
Noel Grandin
89ef4dea32 loplugin:unusedmethods cui
Change-Id: I8a4cb855054c487d7a8307ad219f10b06db3248b
2015-07-17 10:36:50 +02:00
Noel Grandin
5a7bf1b32c loplugin:unusedmethods slideshow
Change-Id: I66b6cddb638a9fc1228d3ea9df5d112300a00eb3
Reviewed-on: https://gerrit.libreoffice.org/17128
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 06:49:23 +00:00
Noel Grandin
4ca2cf1b7e loplugin:unusedmethods sfx2
Change-Id: I98c455d89f76fbcacf74929a4e8775b4da697f62
Reviewed-on: https://gerrit.libreoffice.org/17069
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16 05:47:52 +00:00
Noel Grandin
82da70787a loplugin:unusedmethods connectivity
Change-Id: Ie9f3daa49b02dddc7b56d1f5fb58a229f53d4513
Reviewed-on: https://gerrit.libreoffice.org/17043
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15 07:45:23 +00:00
Noel Grandin
06ea347b93 loplugin:unusedmethods svtools
Change-Id: I04ad31055c04a247faddf4311943ca769051473c
Reviewed-on: https://gerrit.libreoffice.org/17032
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-14 10:21:55 +00:00
Noel Grandin
a04354ecb3 improve the unusedmethods plugin
to find stuff called from 2 levels+ inside template methods

Change-Id: I4ba308a992e64a091e5364b8aa89e44d6772dcb0
2015-07-14 09:43:57 +02:00
Noel Grandin
a6fed7a19b loplugin:unusedmethods vcl
Change-Id: I53c66b7898f4e0a66e6172d22c6f782dadaf6589
Reviewed-on: https://gerrit.libreoffice.org/16975
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13 09:56:16 +00:00
Noel Grandin
001e694ecd loplugin:unusedmethods vcl(part2)
Change-Id: I12356b3fdce68282a30cae2b270b02e46558860a
Reviewed-on: https://gerrit.libreoffice.org/16847
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10 08:21:20 +00:00
Noel Grandin
449d272daf loplugin:unusedmethods vcl
Change-Id: I98b88ca3369a2c888fd63796e39d42376d513002
2015-07-08 09:51:27 +02:00
Noel Grandin
e546ed01e6 loplugin:unusedmethods package
Change-Id: I19d6bbb9288d72b99d1023b4983b1c3fff7570e8
Reviewed-on: https://gerrit.libreoffice.org/16811
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-07 11:01:11 +00:00
Noel Grandin
9d7727737b loplugin:unusedmethods ucb
Change-Id: Idc0ca78da8ebbdfe8489eee92a1167eb1bd9722f
Reviewed-on: https://gerrit.libreoffice.org/16794
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-07 06:52:52 +00:00
Stephan Bergmann
e93b4d20d8 No MAP_POPULATE on Mac OS X
Change-Id: I6a0b8bbeec94fe19b609542550f9cce783daef20
2015-07-06 19:24:27 +02:00
Noel Grandin
52099a7ad3 new loplugin: unusedmethods
Change-Id: I72574e354aadf357d6d8181a514efb4783e79e28
2015-07-06 09:20:08 +02:00
Noel Grandin
e9c3583c2c improve the returnbyref loplugin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb
Reviewed-on: https://gerrit.libreoffice.org/16731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06 07:04:50 +00:00
Stephan Bergmann
5ed2014684 loplugin:stringconstant: handle OUString+=OUString(literal)
Change-Id: I85a88eaca89bb2c89a3ad374be09547f9b2ed78f
2015-06-26 13:55:36 +02:00
Stephan Bergmann
8fd802eb33 loplugin:stringconstant: OUStringLiteral1 can handle NUL literals just fine
Change-Id: I9b31b01a34a10d5bd329dccd39da83500d6fd2c7
2015-06-26 13:55:30 +02:00
Stephan Bergmann
d4ad86dac6 ...in case this ever gets used with an unsigned APSInt of bitwidth < 7
Change-Id: Ic9436529321e523edd25d0f83ac09a0e22a44013
2015-06-25 15:59:01 +02:00
Noel Grandin
f53c186b8d my previous fix triggered an assert in clang
Change-Id: I67b8dec0d49032134a1b588363e72fa88f5993f7
2015-06-25 14:00:26 +02:00
Noel Grandin
38ea4f018e error: invalid operands to binary expression ('llvm::APSInt' and 'int')
Change-Id: I1a509ce133954a31a504dcc178687427f85f4c1c
2015-06-25 13:48:11 +02:00
Stephan Bergmann
af333e8103 loplugin:stringconstant: Flag more inefficiencies
Change-Id: I47726315f12ef05714bea248d79cc503fb99b23c
2015-06-25 12:38:40 +02:00
Stephan Bergmann
a51ac4d2bb Add variadic PartialWeakComponentImplHelper, remove need for implbase_var.hxx
Change-Id: Iad3417822b2ab3afb75da09c311a0bf07af5e2e4
2015-06-22 21:48:36 +02:00
Stephan Bergmann
383cace9ee Fix for BUILDDIR != SRCDIR
Change-Id: I3ea2a0a6d8f54afcc1959b54c36f90bb849995b4
2015-06-22 17:59:26 +02:00
Stephan Bergmann
3b540819ec Remove loplugin:pointertobool
For one, intended warnings about pointers as function call arguments being
implicitly converted to bool are also covered (along with more) by
loplugin:implicitboolconversion.  For another, this code generates false
positives inside lambdas (where the check for CallExpr eventually always hits in
the PointerToBool::ignoreConversion recursion), see
762e90ffa0cd5f85dadd9bad93391d105e60e418 "vcl: loplugin:pointertobool."

Change-Id: I55eaa668c1b4a2c66a5a015b2414bf161f796f2a
2015-06-15 15:04:57 +02:00
Noel Grandin
9db80b1499 fix vclwidget plugin warning message
Change-Id: Iac6450ed3a7742022d97b0121165f992b483eea0
2015-06-15 14:10:22 +02:00
Noel Grandin
dcf6abfcdf cppcheck:unreadVariable
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15 14:06:31 +02:00
Noel Grandin
bf34b812a7 New VclPtr clang plugin to catch potential problems.
Change-Id: I2571c4384e4c2dbe411e171325e10d57a0afe5a0
Reviewed-on: https://gerrit.libreoffice.org/16235
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-12 16:22:52 +00:00
Stephan Bergmann
623359af23 loplugin:unreffun: workaround for visibility-adding redecls
Change-Id: Ic18b44942f4fe02083c0e8167e8c8d4205e66abf
2015-06-09 12:44:31 +02:00